skeptic 0.0.6 → 0.0.7

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: c134d0e254360008e27fa9cb86c40c93db1927f4
+  data.tar.gz: 4740e1bf1ad5a49988947f4271cc02670c02e8ec
+SHA512:
+  metadata.gz: 15a38c21b6827006b04201c4cb85df642e9d23d222df9ae576e6de2bd7fa22f25c65eeb263e648a75e5c47d2fb3f65ead2d0209c6cb7435f2c097468b61372b0
+  data.tar.gz: 18a09be7c9be915270ec24fea66cfe12d705083147afc6ab8984fc4749d43daf4ca7cbbefa6cf45a93702b333214fc6f7bd180a7cd61c3102f074b36173aca62

data/VERSION

@@ -1 +1 @@
-0.0.6
+0.0.7

data/lib/skeptic/rules/naming_conventions.rb

@@ -12,6 +12,7 @@ module Skeptic
         defs:      :snake_case,
         symbol:    :snake_case,
         :@ident => :snake_case,
+        :@gvar  => :snake_case,
         :@ivar  => :snake_case,
         :@cvar  => :snake_case,
         :@const => :screaming_snake_case
@@ -36,6 +37,7 @@ module Skeptic
         def:            'method',
         defs:           'method',
         :@ident      => 'local variable',
+        :@gvar       => 'global variable',
         :@ivar       => 'instance variable',
         :@cvar       => 'class variable',
         :@const      => 'constant'
@@ -86,7 +88,7 @@ module Skeptic
 
       on :assign do |target, value|
         if target.first == :var_field
-          check_name target.last.first, extract_name(target), extract_line_number(target)
+          check_ident target.last.first, target
         end
       end
 
@@ -101,7 +103,9 @@ module Skeptic
       end
 
       def check_ident(type, ident)
-        check_name(type, extract_name(ident), extract_line_number(ident))
+        if EXPECTED_CONVENTIONS.key? type
+          check_name(type, extract_name(ident), extract_line_number(ident))
+        end
       end
 
       def check_name(type, name, line)

data/lib/skeptic/rules/spaces_around_operators.rb

@@ -3,18 +3,24 @@ module Skeptic
     class SpacesAroundOperators
       DESCRIPTION = 'Check for spaces around operators'
 
-      OPERATORS_WITHOUT_SPACES_AROUND_THEM = ['**']
+      include SexpVisitor
+
+      OPERATORS_WITHOUT_SPACES_AROUND_THEM = ['**', '::', '...', '..']
+      IGNORED_TOKEN_TYPES = [:on_sp, :on_ignored_nl, :on_nl, :on_lparen, :on_symbeg]
 
       def initialize(data)
         @violations = []
+        @special_tokens_locations = []
       end
 
       def apply_to(code, tokens, sexp)
+        visit sexp
+
         @violations = tokens.each_cons(3).select do |_, token, _|
           operator_expecting_spaces? token
         end.select do |left, operator, right|
-          no_spaces_between?(operator, left) or
-          no_spaces_between?(operator, right)
+          no_spaces_on_left_of?(operator, left) or
+          no_spaces_on_right_of?(operator, right)
         end.map do |_, operator, _|
           [operator.last, operator.first[0]]
         end
@@ -38,8 +44,67 @@ module Skeptic
           not OPERATORS_WITHOUT_SPACES_AROUND_THEM.include? token.last
       end
 
-      def no_spaces_between?(operator, neighbour)
-        neighbour.first[0] == operator.first[0] and neighbour[1] != :on_sp
+      def no_spaces_on_left_of?(operator, neighbour)
+        neighbour.first[0] == operator.first[0] and neighbour[1] != :on_lparen and
+        !special_token? neighbour
+      end
+
+      def no_spaces_on_right_of?(operator, neighbour)
+        neighbour.first[0] == operator.first[0] and neighbour[1] != :on_rparen and
+        !special_token? neighbour
+      end
+
+      def whitespace_token?(token)
+        token[1] == :on_sp or token[1] == :on_ignored_nl
+      end
+
+      def mark_special_tokens(*token_locations)
+        @special_tokens_locations.concat(token_locations)
+      end
+
+      def special_token?(token)
+        IGNORED_TOKEN_TYPES.include? token[1] or
+          @special_tokens_locations.include? token.first
+      end
+
+      on :blockarg, :rest_param do |ident|
+        mark_special_tokens ident.last
+      end
+
+      on :args_add_block do |args, block|
+        visit args
+        if block
+          case block.first
+            when :symbol_literal, :dyna_symbol
+              sexp_location = block.last.last.last
+              symbol_location = [sexp_location[0], sexp_location[1] - 1]
+              mark_special_tokens symbol_location
+            when :vcall, :var_ref
+              mark_special_tokens block.last.last
+          end
+        end
+      end
+
+      on :mlhs_add_star, :args_add_star do |_, ident|
+        if ident.first == :var_ref or ident.first == :vcall
+          mark_special_tokens ident.last.last
+        else
+          mark_special_tokens ident.last
+        end
+      end
+
+      on :block_var do |params|
+        normal_params = params[1]
+        unless normal_params.empty?
+          right_param = normal_params.last
+          right_location = [right_param.last[0],
+                            right_param.last[1] ]
+          mark_special_tokens normal_params.first.last, normal_params.last.last
+        end
+      end
+
+      on :unary do |_, token|
+        mark_special_tokens token.last
       end
     end
   end

data/skeptic.gemspec

@@ -2,10 +2,11 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
+# stub: skeptic 0.0.7 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "skeptic"
-  s.version = "0.0.6"
+  s.version = "0.0.7"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Stefan Kanev"]
@@ -52,11 +53,11 @@ Gem::Specification.new do |s|
   s.homepage = "http://github.com/skanev/skeptic"
   s.licenses = ["MIT"]
   s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.23"
+  s.rubygems_version = "2.1.5"
   s.summary = "Skeptic points out annoying things in your code"
 
   if s.respond_to? :specification_version then
-    s.specification_version = 3
+    s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_runtime_dependency(%q<trollop>, [">= 1.16.2"])

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: skeptic
 version: !ruby/object:Gem::Version
-  version: 0.0.6
-  prerelease: 
+  version: 0.0.7
 platform: ruby
 authors:
 - Stefan Kanev
@@ -14,129 +13,113 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: trollop
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.16.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.16.2
 - !ruby/object:Gem::Dependency
   name: ffi-aspell
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: aruba
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: jeweler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: An experimental, half-assed, bug-ridden and highly opinionated code analyzer.
@@ -148,9 +131,9 @@ extra_rdoc_files:
 - LICENSE.txt
 - README.markdown
 files:
-- .document
-- .rspec
-- .rvmrc
+- ".document"
+- ".rspec"
+- ".rvmrc"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -181,29 +164,25 @@ files:
 homepage: http://github.com/skanev/skeptic
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -418497778918983562
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.1.5
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Skeptic points out annoying things in your code
 test_files: []