skeptic 0.0.5 → 0.0.6

data/VERSION

@@ -1 +1 @@
-0.0.5
+0.0.6

data/lib/skeptic/rules/naming_conventions.rb

@@ -63,47 +63,59 @@ module Skeptic
 
       private
 
-      on :class, :module, :def do |name, *args, body|
-        extracted_name = strip_name_suffix(extract_name(name))
-        check_name sexp_type, extracted_name, extract_line_number(name)
-        visit args.first if args.first
+      on :class, :module do |name, *, body|
+        check_ident sexp_type, name
         visit body
       end
 
-      on :defs do |target, _, name, params, body|
-        if [target, name].any? do |ident|
-            bad_name? :defs, strip_name_suffix(extract_name(ident))
-          end
-          @violations << [:defs, "#{target}.#{name}", extract_line_number(name)]
-        end
+      on :def, :defs do |*, name, params, body|
+        check_ident sexp_type, name
         visit params
         visit body
       end
 
+      on :lambda do |params, body|
+        visit params if params
+        visit body
+      end
+
+      on :do_block, :brace_block do |(_, params, _), body|
+        visit params if params
+        visit body
+      end
+
+      on :assign do |target, value|
+        if target.first == :var_field
+          check_name target.last.first, extract_name(target), extract_line_number(target)
+        end
+      end
+
+      on :params do |*params|
+        extract_param_idents(params).each do |param_ident|
+          check_ident :@ident, param_ident
+        end
+      end
+
       on :symbol do |type, text, location|
         check_name :symbol, text, location.first
       end
 
-      on :@ident, :@ivar, :@cvar, :@const do |text, location|
-        check_name sexp_type, strip_name_prefix(text), location.first
+      def check_ident(type, ident)
+        check_name(type, extract_name(ident), extract_line_number(ident))
       end
 
       def check_name(type, name, line)
-        if bad_name? type, name
+        if bad_name? type, strip_word_punctuation(name)
           @violations << [type, name, line]
         end
       end
 
       def bad_name?(type, name)
-        !CONVENTION_REGEXES[EXPECTED_CONVENTIONS[type]].match(name)
-      end
-
-      def strip_name_suffix(name)
-        name.sub(/[!?]\z/, '')
+        !name.empty? and !CONVENTION_REGEXES[EXPECTED_CONVENTIONS[type]].match(name)
       end
 
-      def strip_name_prefix(name)
-        name.sub(/\A@{1,2}/, '')
+      def strip_word_punctuation(word)
+        word.gsub(/[^[^[:ascii:]]a-zA-Z0-9_]/, '')
       end
     end
   end

data/skeptic.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "skeptic"
-  s.version = "0.0.5"
+  s.version = "0.0.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Stefan Kanev"]
-  s.date = "2013-11-15"
+  s.date = "2013-12-14"
   s.description = "An experimental, half-assed, bug-ridden and highly opinionated code analyzer."
   s.email = "stefan.kanev@gmail.com"
   s.executables = ["skeptic"]
@@ -52,7 +52,7 @@ Gem::Specification.new do |s|
   s.homepage = "http://github.com/skanev/skeptic"
   s.licenses = ["MIT"]
   s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.24"
+  s.rubygems_version = "1.8.23"
   s.summary = "Skeptic points out annoying things in your code"
 
   if s.respond_to? :specification_version then

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: skeptic
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-15 00:00:00.000000000 Z
+date: 2013-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: trollop
@@ -191,6 +191,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -418497778918983562
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -199,7 +202,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Skeptic points out annoying things in your code