sk_sdk 0.4.0 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: d8b37450434521a67d849f242b2687bfe6cee7fe
-  data.tar.gz: 9bdfed1b7b55e8e14ecdeae80caca207c4abe024
+SHA256:
+  metadata.gz: 765868dde777bcdf0be0609eedb1f4d2b2fea1941557354b781ac8c98e1caf19
+  data.tar.gz: 94868793078e884ec7b67f5b1fe08c5d6f6aeba813288d96faec0e6922011909
 SHA512:
-  metadata.gz: fd0877e811c40bb79a7cf561b4feb9c4ded9c895f4514fae8a373b32742bcc7e68829560829105e5c497aec2bf6cd2f436d4e3a1162621d286198e93a5a4c51a
-  data.tar.gz: 66efcacd645a14db318fd921d6aa589493ae8443c531d30681b55ba90d5b7ee5340cb99522578750fe05cfbef6107635ffaff23fd951c56a41be94f94e63b98e
+  metadata.gz: 1dcea467be43a510b463a75aec989a124a6a5f8fc99de2e4151d91b8a9f4b88406c5702f61634080c84a72e8c13d78facc31c936de058cf446f1abc0306c71b9
+  data.tar.gz: b3623c68a5c132bf8cbd87f32e4d71ca2ae5152a9a3903d40cbef940212dda0f362720145cc39fea12562ab072133072b0d1524007c5bd5010addd9dcadc4756

data/README.rdoc

@@ -12,8 +12,8 @@ SalesKing App's(using oAuth2) and API clients.
 Dependencies (gem's):
 
 * activesupport
-* activeresource v2.3.x, v3.1+ (v3.0.10 until sk_sdk v0.0.8)
-* curb
+* activeresource v3.1+ (v3.0.10 until sk_sdk v0.0.8)
+* httparty
 * sk_api_schema
 
 == Classes
@@ -63,8 +63,12 @@ Before running the specs, add your SalesKing credentials to /spec/settings.yml
   bundle install
   rake spec
 
-  #test with ARes 2
-  BUNDLE_GEMFILE=ci/Gemfile_ar2 bundle install
-  BUNDLE_GEMFILE=ci/Gemfile_ar2 bundle exec rake spec
+  #test with ActiveResource 3
+  BUNDLE_GEMFILE=ci/Gemfile_ar3 bundle install
+  BUNDLE_GEMFILE=ci/Gemfile_ar3 bundle exec rake spec
 
-Copyright (c) 2011 Georg Leciejewski, released under the MIT license
+  #test with ActiveResource 5
+  BUNDLE_GEMFILE=ci/Gemfile_ar5 bundle install
+  BUNDLE_GEMFILE=ci/Gemfile_ar5 bundle exec rake spec
+
+Copyright (c) 2011-2022 Georg Leciejewski, released under the MIT license

data/Rakefile

@@ -1,19 +1,9 @@
 require 'rake'
 require 'rspec'
 require 'rspec/core/rake_task'
-require 'rdoc/task'
 require 'bundler/gem_helper'
 Bundler::GemHelper.install_tasks
 
 desc "Run specs"
 RSpec::Core::RakeTask.new
 task :default => :spec
-
-desc 'Generate documentation.'
-Rake::RDocTask.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'SalesKing SDK'
-  rdoc.options << '--line-numbers' << '--inline-source'
-  rdoc.rdoc_files.include('README')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end

data/ci/Gemfile_ar3

@@ -1,4 +1,4 @@
-source :gemcutter
+source 'https://rubygems.org'
 gem "rake"
 gem "rdoc"
 gem "activesupport", "3.2"

data/ci/Gemfile_ar3.lock

@@ -1,5 +1,5 @@
 GEM
-  remote: http://rubygems.org/
+  remote: https://rubygems.org/
   specs:
     activemodel (3.2.0)
       activesupport (= 3.2.0)
@@ -11,29 +11,34 @@ GEM
       i18n (~> 0.6)
       multi_json (~> 1.0)
     builder (3.0.4)
-    curb (0.8.5)
+    curb (0.9.3)
     diff-lcs (1.2.5)
-    docile (1.1.3)
-    i18n (0.6.9)
-    json (1.8.1)
-    multi_json (1.8.4)
-    rake (10.1.1)
-    rdoc (4.1.1)
+    docile (1.1.5)
+    i18n (0.7.0)
+    json (1.8.3)
+    multi_json (1.11.3)
+    rake (11.1.2)
+    rdoc (4.2.2)
       json (~> 1.4)
-    rspec (2.14.1)
-      rspec-core (~> 2.14.0)
-      rspec-expectations (~> 2.14.0)
-      rspec-mocks (~> 2.14.0)
-    rspec-core (2.14.7)
-    rspec-expectations (2.14.5)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.5)
-    simplecov (0.8.2)
+    rspec (3.4.0)
+      rspec-core (~> 3.4.0)
+      rspec-expectations (~> 3.4.0)
+      rspec-mocks (~> 3.4.0)
+    rspec-core (3.4.4)
+      rspec-support (~> 3.4.0)
+    rspec-expectations (3.4.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.4.0)
+    rspec-mocks (3.4.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.4.0)
+    rspec-support (3.4.1)
+    simplecov (0.11.2)
       docile (~> 1.1.0)
-      multi_json
-      simplecov-html (~> 0.8.0)
-    simplecov-html (0.8.0)
-    sk_api_schema (0.9.4)
+      json (~> 1.8)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.0)
+    sk_api_schema (0.10.6)
       activesupport
 
 PLATFORMS
@@ -48,3 +53,6 @@ DEPENDENCIES
   rspec
   simplecov
   sk_api_schema
+
+BUNDLED WITH
+   1.11.2

data/ci/{Gemfile_ar2 → Gemfile_ar5}

@@ -1,8 +1,8 @@
-source :gemcutter
+source 'https://rubygems.org'
 gem "rake"
 gem "rdoc"
-gem "activesupport", "2.3.14"
-gem "activeresource", "2.3.14"
+gem "activesupport", "5.2"
+gem "activeresource", "5.0"
 gem "sk_api_schema"
 gem "curb"
 group :test do

data/ci/Gemfile_ar5.lock

@@ -0,0 +1,68 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (5.2.0)
+      activesupport (= 5.2.0)
+    activemodel-serializers-xml (1.0.2)
+      activemodel (> 5.x)
+      activesupport (> 5.x)
+      builder (~> 3.1)
+    activeresource (5.0.0)
+      activemodel (>= 5.0, < 6)
+      activemodel-serializers-xml (~> 1.0)
+      activesupport (>= 5.0, < 6)
+    activesupport (5.2.0)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    builder (3.2.3)
+    concurrent-ruby (1.0.5)
+    curb (0.9.6)
+    diff-lcs (1.3)
+    docile (1.3.1)
+    i18n (1.1.0)
+      concurrent-ruby (~> 1.0)
+    json (2.1.0)
+    minitest (5.11.3)
+    rake (12.3.1)
+    rdoc (6.0.4)
+    rspec (3.8.0)
+      rspec-core (~> 3.8.0)
+      rspec-expectations (~> 3.8.0)
+      rspec-mocks (~> 3.8.0)
+    rspec-core (3.8.0)
+      rspec-support (~> 3.8.0)
+    rspec-expectations (3.8.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.8.0)
+    rspec-mocks (3.8.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.8.0)
+    rspec-support (3.8.0)
+    simplecov (0.16.1)
+      docile (~> 1.1)
+      json (>= 1.8, < 3)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.2)
+    sk_api_schema (0.11.0)
+      activesupport
+    thread_safe (0.3.6)
+    tzinfo (1.2.5)
+      thread_safe (~> 0.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activeresource (= 5.0)
+  activesupport (= 5.2)
+  curb
+  rake
+  rdoc
+  rspec
+  simplecov
+  sk_api_schema
+
+BUNDLED WITH
+   1.16.0

data/lib/sk_sdk/base.rb

@@ -4,13 +4,10 @@ require 'active_resource'
 require 'active_resource/version'
 # patches are for specific AR version
 case ActiveResource::VERSION::MAJOR
-when 2
-  require 'sk_sdk/ar_patches/ar2/validations'
-  require 'sk_sdk/ar_patches/ar2/base'
 when 3
   require 'sk_sdk/ar_patches/ar3/base'
   require 'sk_sdk/ar_patches/ar3/validations'
-when 4
+when 4,5,6
   require 'sk_sdk/ar_patches/ar4/validations'
   require 'sk_sdk/ar_patches/ar4/base'
 end
@@ -19,7 +16,13 @@ class SK::SDK::Base < ActiveResource::Base
   self.format = :json
   # hook before init in activeresource base because json comes in nested:
   # {client={data}
-  if (ActiveResource::VERSION::MAJOR == 3 && ActiveResource::VERSION::MINOR > 0) || ActiveResource::VERSION::MAJOR > 3
+  if ActiveResource::VERSION::MAJOR == 6
+    self.include_root_in_json = true
+    def initialize(attributes = {}, persisted=false)
+      attr = attributes[self.class.element_name] || attributes
+      super(attr, persisted)
+    end
+  elsif (ActiveResource::VERSION::MAJOR == 3 && ActiveResource::VERSION::MINOR > 0) || ActiveResource::VERSION::MAJOR < 6
     self.include_root_in_json = true
     def initialize(attributes = {}, *args)
       attr = attributes[self.class.element_name] || attributes
@@ -44,7 +47,7 @@ class SK::SDK::Base < ActiveResource::Base
   # @option [String] :password if using httpBasic sk user password
   def self.set_connection(opts)
     self.site   = site_api_url(opts[:site])
-    self.format = :json # f*** xml
+    self.format = :json
     if opts[:token] #oAuth access token in header
       self.headers['Authorization'] = "Bearer #{opts[:token]}"
     else
@@ -74,7 +77,7 @@ class SK::SDK::Base < ActiveResource::Base
 
   # Unfortunately only using AR v4+ we can create additional accessors
   # to get info on collection info and links
-  if ActiveResource::VERSION::MAJOR == 4
+  if ActiveResource::VERSION::MAJOR >= 4
     class SkCollection < ActiveResource::Collection
       attr_accessor :current_page, :per_page, :total_entries, :total_pages
 

data/lib/sk_sdk/oauth.rb

@@ -1,10 +1,21 @@
 require 'cgi'
-require 'curb'
 require 'sk_sdk'
 
 module SK::SDK
   # Authenticate your SalesKing App using oAuth2. This class provides helpers
-  # to create the token & dialog url and to get an access token
+  # to create the token & dialog url and build the params to get an access token.
+  # ==Example
+  # Using httparty gem:
+  #
+  #    require 'sk_sdk/oauth'
+  #    require 'httparty'
+  #
+  #    auth = SK::SDK::Oauth.new(sk_app_settings)
+  #    resp = HTTParty.post( auth.token_url,
+  #                          body: auth.token_params(code),
+  #                          basic_auth: auth.basic_params )
+  # Of course you can use curb or any other http lib. Just make sure to read
+  # their docs about POST params, HTTP BASIC Auth and https handling
   class Oauth
 
     attr_reader :id, :secret, :redirect_url
@@ -49,30 +60,25 @@ module SK::SDK
     # URL to get the access_token, used in the second step after you have
     # requested the authorization and gotten a code
     # The token url is located at /oauth/token
-    #
-    # @param [String] code received after auth
-    # @return [String] Url with parameter
-    def token_url(code)
-      params = { :client_id     => @id,
-                 :client_secret => @secret,
-                 :redirect_uri  => @redirect_url,
-                 :code          => code }
-      "#{sk_url}/oauth/token?#{to_url_params(params)}"
+    def token_url
+      "#{sk_url}/oauth/token"
+    end
+
+    # Params used in the POST request to /token e.g see httparty example on top.
+    # Using the client_secret in the params is DEPRECATED. Instead use HTTP Basic
+    # Auth header with client_id:client_secret like provided by #basic_params
+    # @returns[Hash] params used to get the real access-token
+    # @param [String] code to exchange for the access token
+    def token_params(code)
+      { client_id: @id,
+        grant_type: 'authorization_code',
+        redirect_uri: CGI::escape(@redirect_url),
+        code: code }
     end
 
-    # Makes a GET request to the access_token endpoint in SK and receives the
-    # access token
-    # @param [String] code request token
-    # @return [Hash{String=>String}] access token
-    def get_token(code)
-      c = Curl::Easy.new( token_url( code ) )
-      if sk_url[/dev\.salesking.eu/] # as long as we are using a self signed cert
-        c.ssl_verify_host = false
-        c.ssl_verify_peer = false
-      end
-      c.http_get
-      # grab token from response body
-      ActiveSupport::JSON.decode(c.body_str)
+    # HTTP BASIC Auth Params used in the POST request to /token e.g with httparty
+    def basic_params
+      { username: @id, password: @secret }
     end
 
     # @return [String] base api url my-sub.salesking.eu/api
@@ -81,10 +87,11 @@ module SK::SDK
     end
 
     # Each company has it's own subdomain so the url must be dynamic.
-    # This is achieved by replacing the * with the subdomain in the instance
-    #
+    # This is achieved by replacing the * with the subdomain in the instance if
+    # a sub_domain was given. Else the SalesKing domain MUST include the subdomain
     # @return [String] url
     def sk_url
+      return @sk_url unless sub_domain
       @sk_url.gsub('*', sub_domain).gsub(/\/\z/, '' )
     end
 

data/lib/sk_sdk/version.rb

@@ -1,5 +1,5 @@
 module SK
   module SDK
-    VERSION = '0.4.0'
+    VERSION = '0.4.3'
   end
 end

data/sk_sdk.gemspec

@@ -4,23 +4,19 @@ require 'sk_sdk/version'
 
 Gem::Specification.new do |s|
   s.name     = 'sk_sdk'
-  s.date     = %q{2012-05-27}
   s.version  = SK::SDK::VERSION
   s.authors  = ['Georg Leciejewski', 'Mike Poltyn']
-  s.email    = ['gl@salesking.eu']
+  s.email    = 'gl@salesking.eu'
   s.homepage = 'http://github.com/salesking/sk_sdk'
   s.summary  = %q{SalesKing Ruby SDK - simplify your Business}
   s.description = %q{Connect your business with SalesKing. This gem gives ruby developers a jump-start for building SalesKing Business Apps. It provides classes to handle oAuth, make RESTfull API requests and parses JSON Schema }
-  s.extra_rdoc_files = ['README.rdoc']
-  s.rubygems_version = %q{1.6.2}
   s.license = 'MIT'
 
-  s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  s.files         = `git ls-files -z`.split("\x0").reject{|i| i[/^docs\//] }
+  s.executables   = s.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  s.test_files    = s.files.grep(%r{^(test|spec|features)/})
   s.require_paths = ['lib']
 
-  s.add_runtime_dependency 'curb'
   s.add_runtime_dependency 'activesupport'
   s.add_runtime_dependency 'activeresource'
   s.add_runtime_dependency 'sk_api_schema'
@@ -28,5 +24,4 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rake'
   s.add_development_dependency 'simplecov'
   s.add_development_dependency 'rspec'
-  s.add_development_dependency 'rdoc'
 end

data/spec/sk_sdk/base_spec.rb

@@ -31,16 +31,16 @@ describe SK::SDK::Base, "make new class" do
 
   it "should create save method" do
     c = Contact.new
-    c.respond_to?(:save).should be_true
+    c.respond_to?(:save).should be true
   end
 
   it "should have new_record?" do
     c = Contact.new
-    c.new_record?.should be_true
+    c.new_record?.should be true
     i = KingTester::Invoice.new
-    i.new_record?.should be_true
+    i.new_record?.should be true
     p = KingTester::Product.new
-    p.new_record?.should be_true
+    p.new_record?.should be true
   end
 
   it "should allow multiple parameters in initializer" do
@@ -50,7 +50,7 @@ describe SK::SDK::Base, "make new class" do
       else
         Contact.new({ :first_name => 'herbert' })
       end
-    }.should_not raise_error(ArgumentError)
+    }.to_not raise_error(ArgumentError)
   end
 
 end

data/spec/sk_sdk/oauth_spec.rb

@@ -16,7 +16,7 @@ describe SK::SDK::Oauth, "in general" do
     a.sub_domain = 'alki'
     a.sk_url.should == "http://alki.horsts-lokal.local"
   end
-  
+
   it "should get salesking api url" do
     a = SK::SDK::Oauth.new(@set)
     a.sub_domain = 'alki'
@@ -38,13 +38,19 @@ describe SK::SDK::Oauth, "in general" do
     a.sk_canvas_url.should == "http://alki.horsts-lokal.local/app/canvas-page"
   end
 
-  it "should get token_url" do
+  it "has token_url" do
     a = SK::SDK::Oauth.new(@set)
     a.sub_domain = 'alki'
-    url = a.token_url('some-code')
-    url.should include @set['id']
-    url.should include @set['secret']
-    url.should include CGI::escape @set['redirect_url']
+    a.token_url.should == "http://alki.horsts-lokal.local/oauth/token"
+  end
+
+  it "has token_params" do
+    a = SK::SDK::Oauth.new(@set)
+    res = a.token_params('123')
+    res[:code].should == '123'
+    res[:client_id].should == @set['id']
+    res[:grant_type].should == 'authorization_code'
+    res[:redirect_uri].should == CGI::escape(@set['redirect_url'])
   end
 
 end

data/spec/sk_sdk/resources/contacts_spec.rb

@@ -21,7 +21,7 @@ else
 
     it "should save" do
       c = Contact.new :organisation=>"Rack'n Roll", :type => 'Client'
-      c.save.should be_true
+      c.save.should be true
       c.id.should_not be_empty
       c.number.should_not be_empty
       c.destroy
@@ -42,7 +42,6 @@ else
 
     it "should find contacts" do
       contacts = Contact.find(:all)
-      ActiveResource::Collection
       contacts.length.should > 0
     end
   end
@@ -96,6 +95,4 @@ else
       @contact.addresses.length.should == cnt_before-1
     end
   end
-
-
 end

data/spec/sk_sdk/resources/credit_note_spec.rb

@@ -9,11 +9,11 @@ else
     before :all do
       #setup test doc to work with
       @contact = Contact.new(:type=>'Supplier', :organisation=>'Credit Note API-Tester')
-      @contact.save.should be_true
+      @contact.save.should be true
       @doc = CreditNote.new()
       @doc.title = 'A Document from the API'
       @doc.contact_id = @contact.id
-      @doc.save.should be_true
+      @doc.save.should be true
     end
 
     after :all do
@@ -23,7 +23,7 @@ else
     it "should create a doc and use default before after text" do
       @doc.errors.should be_empty
       @doc.notes_before.should_not be_empty
-      @doc.new?.should be_false
+      @doc.new?.should be false
     end
 
     it "should fail create a doc without unique number" do
@@ -52,7 +52,7 @@ else
       @doc.notes_before = 'Payment made to you bank Account'
       @doc.title = 'Changed doc title'
 
-      @doc.save.should be_true
+      @doc.save.should be true
       @doc.lock_version.should > old_lock_version # because save returns the data
     end
 
@@ -76,12 +76,12 @@ else
 
     before :all do
       @contact =Contact.new(:type=>'Supplier', :organisation=>'Credit Note API-Tester')
-      @contact.save.should be_true
+      @contact.save.should be true
       #setup test doc to work with
       @doc = CreditNote.new :contact_id => @contact.id,
                             :line_items =>[{ :position=>1, :description => 'Pork Chops',
                                               :quantity => 12, :price_single =>'10.00'}]
-      @doc.save.should be_true
+      @doc.save.should be true
     end
 
     after :all do
@@ -127,7 +127,7 @@ else
     end
 
     it "should update from draft to open and set number with date" do
-      @doc.save.should be_true
+      @doc.save.should be true
       @doc.status.should == 'draft'
 
       @doc.status = 'open'

data/spec/sk_sdk/resources/invoice_spec.rb

@@ -10,11 +10,11 @@ describe Invoice do
 
     before :all do
       @contact =  Contact.new(:type=>'Client', :organisation=>'Invoice API-Tester')
-      @contact.save.should be_true
+      @contact.save.should be true
       @doc = Invoice.new()
       @doc.title = 'A Document from the API'
       @doc.contact_id = @contact.id
-      @doc.save.should be_true
+      @doc.save.should be true
     end
 
     after :all do
@@ -31,7 +31,7 @@ describe Invoice do
 
     before :all do
       @contact =  Contact.new(:type=>'Client', :organisation=>'Invoice API-Tester')
-      @contact.save.should be_true
+      @contact.save.should be true
     end
     after :all do
       @contact.destroy
@@ -43,9 +43,9 @@ describe Invoice do
       doc.notes_before = 'Your shiny new invoice [number]'
       doc.notes_after = 'Please pay me'
       doc.contact_id = @contact.id
-      doc.save.should be_true
+      doc.save.should be true
       doc.errors.should be_empty
-      doc.new?.should be_false
+      doc.new?.should be false
       doc.notes_before.should == 'Your shiny new invoice [number]'
       doc.destroy
     end
@@ -56,7 +56,7 @@ describe Invoice do
       doc.contact_id = @contact.id
       doc.save
       doc.errors.should be_empty
-      doc.new?.should be_false
+      doc.new?.should be false
       doc.notes_before.should_not be_empty
       doc.destroy
     end
@@ -85,12 +85,12 @@ describe Invoice do
       #setup test doc to work with
       # create client
       @contact =  Contact.new(:type=>'Client', :organisation=>'Invoice API-Tester')
-      @contact.save.should be_true
+      @contact.save.should be true
       @doc = Invoice.new
       @doc.title = 'A Document from the API'
       @doc.notes_before = 'Your invoice [number]'
       @doc.contact_id = @contact.id
-      @doc.save.should be_true
+      @doc.save.should be true
     end
 
     after :all do
@@ -104,7 +104,7 @@ describe Invoice do
       @doc.notes_after = 'Payment made to you bank Account'
       @doc.title = 'Changed doc title'
 
-      @doc.save.should be_true
+      @doc.save.should be true
       @doc.lock_version.should > old_lock_version # because save returns the data
       @doc.notes_before.should == 'You will recieve the amout of:'
     end
@@ -129,12 +129,12 @@ describe Invoice do
 
     before :all do
       @contact =  Contact.new(:type=>'Client', :organisation=>'Credit Note API-Tester')
-      @contact.save.should be_true
+      @contact.save.should be true
       #setup test doc to work with
       @doc = Invoice.new(:contact_id => @contact.id,
                           :line_items => [{ :position=>1, :description => 'Pork Chops',
                                              :quantity => 12, :price_single =>'10.00' }] )
-      @doc.save.should be_true
+      @doc.save.should be true
     end
 
     after :all do
@@ -157,7 +157,7 @@ describe Invoice do
     it 'should add line item' do
       item = LineItem.new( {  :position=>2, :description => 'Goat-Pie', :price_single => 10, :quantity=>10} )
       product = Product.new(:name=>'Eis am Stiel', :price => 1.50, :tax=>19, :description => 'Mmmhh lecker Eis')
-      product.save.should be_true
+      product.save.should be true
       item1 = LineItem.new( { :position=>3, :use_product => 1, :product_id=> product.id, :quantity => 10 } )
       @doc.line_items << item
       @doc.line_items << item1
@@ -172,7 +172,7 @@ describe Invoice do
   describe 'with items of different type' do
     before :each do
       @contact = Contact.new(:type=>'Client', :organisation=>'Credit Note API-Tester')
-      @contact.save.should be_true
+      @contact.save.should be true
       @doc = Invoice.new(:contact_id => @contact.id)
     end
 
@@ -189,7 +189,7 @@ describe Invoice do
         { :position=>4, :name => 'Pork Chops',  :price_single =>0, :type=>'LineItem' },
         { :position=>5, :name => 'Pork Chops',  :price_single =>0.0, :type=>'LineItem' },
       ]
-      @doc.save.should be_true
+      @doc.save.should be true
       @doc.items.length.should == 5
       @doc.gross_total.should == 0.0
     end
@@ -201,7 +201,7 @@ describe Invoice do
         { :position=>2, :name => 'Yummi Beef', :type=>'DividerItem' },
         { :position=>3, :name => 'Beef Jerky', :description=> 'Jaw Breaker',:quantity => 1, :price_single =>'10.00', :type=>'LineItem' }
       ]
-      @doc.save.should be_true
+      @doc.save.should be true
       @doc.items.length.should == 4
       @doc.gross_total.should == 130.0
     end
@@ -214,7 +214,7 @@ describe Invoice do
         { :divider_item => { :position=>2, :name => 'Yummi Beef', :type=>'DividerItem' }},
         { :line_item => { :position=>3, :name => 'Beef Jerky', :description=> 'Jaw Breaker',:quantity => 1, :price_single =>'10.00' }}
       ]
-      @doc.save.should be_true
+      @doc.save.should be true
       @doc.items.length.should == 4
       @doc.gross_total.should == 130.0
     end
@@ -223,7 +223,7 @@ describe Invoice do
   describe 'with items and line_items' do
     before :all do
       @contact = Contact.new(:type=>'Client', :organisation=>'Credit Note API-Tester')
-      @contact.save.should be_true
+      @contact.save.should be true
       @doc = Invoice.new(:contact_id => @contact.id)
     end
 
@@ -234,7 +234,7 @@ describe Invoice do
     it 'should prefer line_items over items when both are present' do
       @doc.items = [LineItem.new( :position=>12, :name => 'dropped', :quantity => 1, :price_single =>1, :type=>'LineItem' )]
       @doc.line_items = [LineItem.new( :position=>12, :name => 'added', :quantity => 1, :price_single =>10, :type=>'LineItem' )]
-      @doc.save.should be_true
+      @doc.save.should be true
       @doc.items.length.should == 1
       @doc.gross_total.should == 10.0
     end
@@ -242,13 +242,13 @@ describe Invoice do
     it 'should manually remove line_items so items are used on update' do
       # first save so AR loads both(items/line_items) from response
       @doc.items = [ { :position=>1, :name => 'Pork Chops', :quantity => 1, :price_single =>'10.00', :type=>'LineItem' }]
-      @doc.save.should be_true
+      @doc.save.should be true
       @doc.gross_total.should == 10.0
       # edit
       @doc.items << LineItem.new( :position=>2, :name => 'Puppy Seeds', :quantity => 1, :price_single =>1, :type=>'LineItem' )
       @doc.line_items = nil # <= IMPORTANT  part
 
-      @doc.save.should be_true
+      @doc.save.should be true
       @doc.items.length.should == 2
       @doc.gross_total.should == 11.0
     end

data/spec/sk_sdk/resources/payment_spec.rb

@@ -8,11 +8,11 @@ describe Payment do
 
   before :all do
     @contact = Contact.new(:type=>'Client', :organisation=>'Payment API-Tester')
-    @contact.save.should be_true
+    @contact.save.should be true
     @doc = Invoice.new
     @doc.title = 'A Document from the API for payment testing'
     @doc.contact_id = @contact.id
-    @doc.save.should be_true
+    @doc.save.should be true
   end
 
   after :all do
@@ -67,7 +67,7 @@ describe Payment do
     it "should create" do
                                       # relation MUST be set
       p = Payment.new :amount => 12.34, :related_object_id=>@doc.id
-      p.save.should be_true
+      p.save.should be true
 
       payments = Payment.send( :instantiate_collection, @doc.get(:payments))
       payments.map(&:amount).should include 12.34
@@ -77,8 +77,4 @@ describe Payment do
 
 end
 
-  def destroy_payment
-
-  end
-
 end

data/spec/sk_sdk/resources/product_spec.rb

@@ -9,7 +9,7 @@ else
     before :all do
       #setup test product to work with
       @product = Product.new(:name=>'Eis am Stiel', :price => 1.50)
-      @product.save.should be_true
+      @product.save.should be true
     end
 
     after :all do
@@ -23,7 +23,7 @@ else
     it "should create a product" do
       @product.number.should_not be_nil
       @product.price.should == 1.50
-      @product.new?.should be_false
+      @product.new?.should be false
     end
 
     it "should fail create a product without name" do
@@ -35,7 +35,7 @@ else
 
     it "should fail create a product with empty price" do
       product = Product.new(:name => 'No brain', :price =>' ')
-      product.save.should be_false
+      product.save.should be false
       product.errors.full_messages.should ==  ["Price can't be blank", "Price is not a number"]
     end
 
@@ -44,13 +44,6 @@ else
       product.name.should == @product.name
     end
 
-    it "should edit a product" do
-      @product.name = 'A new product name'
-      @product.lock_version.should == 0
-      @product.save
-      @product.lock_version.should == 1 # because save returns the data
-    end
-
     it "should fail edit a product" do
       @product.name = ''
       @product.save.should == false

data/spec/sk_sdk/sync_spec.rb

@@ -20,12 +20,12 @@ describe SK::SDK::Sync do
   end
 
   it "should not be outdated" do
-    @sync.outdated?.should be_false # both objects are empty
+    @sync.outdated?.should be false # both objects are empty
   end
 
   it "should find outdated fields" do
     @l_obj.firstname = 'theo'
-    @sync.outdated?.should be_true
+    @sync.outdated?.should be true
     @sync.outdated.first.should == @sync.field(:firstname)
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sk_sdk
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.3
 platform: ruby
 authors:
 - Georg Leciejewski
@@ -9,22 +9,8 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-27 00:00:00.000000000 Z
+date: 2022-08-24 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: curb
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -109,44 +95,25 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rdoc
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: 'Connect your business with SalesKing. This gem gives ruby developers
   a jump-start for building SalesKing Business Apps. It provides classes to handle
   oAuth, make RESTfull API requests and parses JSON Schema '
-email:
-- gl@salesking.eu
+email: gl@salesking.eu
 executables: []
 extensions: []
-extra_rdoc_files:
-- README.rdoc
+extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".travis.yml"
 - Gemfile
 - MIT-LICENSE
 - README.rdoc
 - Rakefile
-- ci/Gemfile_ar2
-- ci/Gemfile_ar2.lock
 - ci/Gemfile_ar3
 - ci/Gemfile_ar3.lock
+- ci/Gemfile_ar5
+- ci/Gemfile_ar5.lock
 - lib/sk_sdk.rb
 - lib/sk_sdk/README.rdoc
-- lib/sk_sdk/ar_patches/ar2/base.rb
-- lib/sk_sdk/ar_patches/ar2/validations.rb
 - lib/sk_sdk/ar_patches/ar3/base.rb
 - lib/sk_sdk/ar_patches/ar3/validations.rb
 - lib/sk_sdk/ar_patches/ar4/base.rb
@@ -192,9 +159,22 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 3.0.9
 signing_key: 
 specification_version: 4
 summary: SalesKing Ruby SDK - simplify your Business
-test_files: []
+test_files:
+- spec/resources_spec_helper.rb
+- spec/settings.yml.default
+- spec/sk_sdk/base_spec.rb
+- spec/sk_sdk/oauth_spec.rb
+- spec/sk_sdk/resources/README.rdoc
+- spec/sk_sdk/resources/contacts_spec.rb
+- spec/sk_sdk/resources/credit_note_spec.rb
+- spec/sk_sdk/resources/invoice_spec.rb
+- spec/sk_sdk/resources/payment_spec.rb
+- spec/sk_sdk/resources/product_spec.rb
+- spec/sk_sdk/signed_request_spec.rb
+- spec/sk_sdk/sync_field_spec.rb
+- spec/sk_sdk/sync_spec.rb
+- spec/spec_helper.rb

data/.travis.yml

@@ -1,7 +0,0 @@
-# Sorry no travis since you need a private sk login .. too bad
-rvm:
-  - 1.8.7
-  - 1.9.2
-gemfile:
-  - Gemfile
-  - ci/Gemfile_ar2

data/ci/Gemfile_ar2.lock

@@ -1,38 +0,0 @@
-GEM
-  remote: http://rubygems.org/
-  specs:
-    activeresource (2.3.14)
-      activesupport (= 2.3.14)
-    activesupport (2.3.14)
-    curb (0.7.15)
-    diff-lcs (1.1.3)
-    multi_json (1.3.5)
-    rake (0.9.2)
-    rdoc (3.9.4)
-    rspec (2.6.0)
-      rspec-core (~> 2.6.0)
-      rspec-expectations (~> 2.6.0)
-      rspec-mocks (~> 2.6.0)
-    rspec-core (2.6.4)
-    rspec-expectations (2.6.0)
-      diff-lcs (~> 1.1.2)
-    rspec-mocks (2.6.0)
-    simplecov (0.6.4)
-      multi_json (~> 1.0)
-      simplecov-html (~> 0.5.3)
-    simplecov-html (0.5.3)
-    sk_api_schema (0.2.4)
-      activesupport
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activeresource (= 2.3.14)
-  activesupport (= 2.3.14)
-  curb
-  rake
-  rdoc
-  rspec
-  simplecov
-  sk_api_schema

data/lib/sk_sdk/ar_patches/ar2/base.rb

@@ -1,46 +0,0 @@
-#temp patch as_json on decimals introduced by rails. which collpases with ruby-yail
-class BigDecimal
-  def as_json
-    self.to_f
-  end
-end
-
-module ActiveResource
-  # Overridden methods to suit SalesKing.
-  # Some changes might be kicked when AR 3.0 is out
-  class Base
-
-    # override encode because json is also returned nested by SalesKing
-    def encode(options={})
-      case self.class.format
-        when ActiveResource::Formats[:xml]
-          self.class.format.encode(attributes, {:root => self.class.element_name}.merge(options))
-        else # json also nested
-          self.class.format.encode( {self.class.element_name => attributes}, options)
-      end
-    end
-
-    # override ARes method to parse only the object part
-    def load_attributes_from_response(response)
-      if response['Content-Length'] != "0" && response.body.strip.size > 0
-        load( self.class.format.decode(response.body)[self.class.element_name] )
-        if self.respond_to?(:items)
-          # move double nested items up
-          new_items = []
-          self.items.each { |item| new_items << item.attributes.first[1] }
-          self.items = new_items
-        end
-      end
-    end
-
-    # Overridden to grab the data(= clients-collection) from json:
-    # { 'collection'=> will_paginate infos,
-    #   'links' => prev/next links
-    #   'clients'=> [data], << what we need
-    # }
-    def self.instantiate_collection(collection, prefix_options = {})
-      collection = collection[ self.element_name.pluralize ] if collection.is_a?(Hash)
-      collection.collect! { |record| instantiate_record(record, prefix_options) }
-    end
-  end
-end

data/lib/sk_sdk/ar_patches/ar2/validations.rb

@@ -1,30 +0,0 @@
-module ActiveResource
-
-  module Validations
-    # Validate a resource and save (POST) it to the remote web service.
-    def save_with_validation
-      save_without_validation
-      true
-    rescue ResourceInvalid => error
-      case error.response['Content-Type']
-      when /xml/ #PATCH
-        errors.from_xml(error.response.body)
-      when /json/ #PATCH
-        errors.from_json(error.response.body)
-      end
-      false
-    end
-  end
-
-  class Errors
-
-    # Patched cause we dont need no attribute name magic .. and its just simpler
-    def from_array(messages)
-      clear
-      messages.each do |msg|
-        add msg[0], msg[1]
-      end
-    end
-  end #Errors
-
-end