sjain-redfin_api 0.1.2 → 0.1.3

data/Manifest

@@ -11,6 +11,10 @@ test/data/gis_id_search.json
 test/data/property_page.html
 test/data/query_location_listings.json
 test/data/query_location_pastSalesBuildings.json
+test/data/redfin/gis-id-search-empty.json
+test/data/redfin/gis-id-search-listing.json
+test/data/redfin/query-location-listing.json
+test/data/redfin/query-location-non-listing.json
 test/test_helper.rb
 test/test_redfin_api.rb
 test/test_redfin_base.rb

data/VERSION.yml

@@ -1,4 +1,4 @@
 ---
 :major: 0
 :minor: 1
-:patch: 2
+:patch: 3

data/lib/redfin_api/base.rb

@@ -5,38 +5,12 @@ require 'net/http'
 module RedfinApi
   module Base
     class << self
-      # this method is often overridden for testing purposes
-      def http_get(url)
-        Net::HTTP.get_response(URI.parse(url)).body
-      end
-      def http_get_json(url)
-        response = http_get(url)
-        response = response.strip[2..-3] # ignore the /* and */
-        #        puts "response = #{response}"
-        require 'json'
-        json_hash = JSON.parse(response)
-        # TODO symbolize_keys! here
-        json_hash
-      end
-      def fetch_address(url)
-        response = http_get(url)
-        doc = Hpricot(response)
-        address = {}
-        address[:address_line_1] = (doc/'#address_line_1')[0].to_plain_text rescue nil
-        address[:city] = (doc/'#address_line_2 .locality')[0].to_plain_text rescue nil
-        address[:state] = (doc/'#address_line_2 .region')[0].to_plain_text rescue nil
-        address[:zip] = (doc/'#address_line_2 .postal-code')[0].to_plain_text rescue nil
-        address[:pin] = extract_pin(response)
-        address
-      end
-      def extract_pin(html)
-        /Parcel Identification Number:\s*(\d{10,14})/.match(html)[1].strip
-      end
       def query_location(address)
         url = "http://www.redfin.com/stingray/do/query-location?location=#{URI.encode(address)}"
         location = http_get_json(url)
         # we either get a postSalesBuildings element or listings element
         item = location['pastSalesBuildings'].not_nil? ? location['pastSalesBuildings'][0] : location['listings'][0]
+        return nil if !item
         address =  item['address']
         hash = {
           :lat => item['point']['lat'].to_s,
@@ -75,6 +49,26 @@ module RedfinApi
           :url =>  "http://www.redfin.com#{payload['URL']}",
         }
       end
+      def extract_pin(url)
+        response = http_get(url)
+        /Parcel Identification Number:\s*(\d{10,14})/.match(response)[1].strip
+      rescue
+        puts "Failed to extract PIN from redfin url: #{$!}"
+        nil
+      end
+      # this method is often overridden for testing purposes
+      def http_get(url)
+        Net::HTTP.get_response(URI.parse(url)).body
+      end
+      def http_get_json(url)
+        response = http_get(url)
+        response = response.strip[2..-3] # ignore the /* and */
+        #        puts "response = #{response}"
+        require 'json'
+        json_hash = JSON.parse(response)
+        # TODO symbolize_keys! here
+        json_hash
+      end
     end
   end
 end

data/redfin_api.gemspec

@@ -2,15 +2,15 @@
 
 Gem::Specification.new do |s|
   s.name = %q{redfin_api}
-  s.version = "0.1.2"
+  s.version = "0.1.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Sharad Jain"]
-  s.date = %q{2009-09-16}
+  s.date = %q{2009-09-17}
   s.description = %q{Redfin.com webservice interface}
   s.email = %q{shaanjain@gmail.com}
   s.extra_rdoc_files = ["README.rdoc", "lib/object.rb", "lib/redfin_api.rb", "lib/redfin_api/base.rb", "tasks/redfin.rake"]
-  s.files = ["Manifest", "README.rdoc", "Rakefile", "VERSION.yml", "lib/object.rb", "lib/redfin_api.rb", "lib/redfin_api/base.rb", "redfin_api.gemspec", "tasks/redfin.rake", "test/data/gis_id_search.json", "test/data/property_page.html", "test/data/query_location_listings.json", "test/data/query_location_pastSalesBuildings.json", "test/test_helper.rb", "test/test_redfin_api.rb", "test/test_redfin_base.rb"]
+  s.files = ["Manifest", "README.rdoc", "Rakefile", "VERSION.yml", "lib/object.rb", "lib/redfin_api.rb", "lib/redfin_api/base.rb", "redfin_api.gemspec", "tasks/redfin.rake", "test/data/gis_id_search.json", "test/data/property_page.html", "test/data/query_location_listings.json", "test/data/query_location_pastSalesBuildings.json", "test/data/redfin/gis-id-search-empty.json", "test/data/redfin/gis-id-search-listing.json", "test/data/redfin/query-location-listing.json", "test/data/redfin/query-location-non-listing.json", "test/test_helper.rb", "test/test_redfin_api.rb", "test/test_redfin_base.rb"]
   s.has_rdoc = true
   s.homepage = %q{http://github.com/sjain/redfin_api}
   s.rdoc_options = ["--line-numbers", "--inline-source", "--title", "Redfin_api", "--main", "README.rdoc"]

data/test/data/redfin/gis-id-search-empty.json

@@ -0,0 +1 @@
+/*({"errorMessage":"No error.","resultCode":0,"payload":[],"version":10})*/

data/test/data/redfin/gis-id-search-listing.json

@@ -0,0 +1 @@
+/*({"errorMessage":"No error.","resultCode":0,"payload":[{"is_short_sale":false,"dom":5,"original_price":399900,"visibility_profile":"111111111111111111","mls_status":85,"type":"residential","date":1252998000000,"sqft":3454,"available_photos":"0:0","id":4658217,"search_status":2,"parcel":{"id":16957456,"longitude":-88.19809,"latitude":42.004822},"last_sale_date":"2006-09-27","is_new":false,"price_display":"$409,900","price_is_above_min":true,"est_redfin_direct_rebate":4748,"est_connect_rebate":1537,"URL":"/IL/Bartlett/438-Timber-Ridge-Dr-60103/home/13753708","baths":3,"address_data":{"zip":"60103","street":"Timber Ridge","state":"IL","unmapped":false,"number":"438","display":"438 Timber Ridge Ln","undisclosed":false,"type":"Ln","city":"BARTLETT"},"year_built":1989,"listing_type":1,"neighborhood":"Bartlett","property":{"id":13753708},"service_region_type":2,"open_house_time_end":1253394000000,"display_order":1,"lotsize":21344,"datasource_id":68,"securePhotoNum":0,"mlsid":"07323121","listing_broker_name":"KMS Realty, Inc.","beds":4,"price":409900,"market_id":6,"fixer":false,"open_house_time_display":"Sat, Sep 19 1 - 4 PM","listing_added":1252768338454,"open_house_time_start":1253383200000,"property_type_raw":6,"last_sale_price":518000}],"version":10})*/

data/test/data/redfin/query-location-listing.json

@@ -0,0 +1 @@
+/*{"listings":[{"id":4658217,"point":{"long":-88.19809,"lat":42.004822},"market":"chicago","address":{"zip":"60103","state":"IL","streetName":"Timber Ridge","number":"438","undisclosed":false,"streetType":"Ln","city":"BARTLETT"},"visibility_profile":"111111111111111111"}],"regions":[]}*/

data/test/data/redfin/query-location-non-listing.json

@@ -0,0 +1 @@
+/*{"pastSalesBuildings":[{"id":12562821,"point":{"long":-88.136536,"lat":42.052528},"market":"chicago","address":{"zip":"60169","unitType":"","state":"IL","streetName":"Poplar Creek","number":"1552","directionalPrefix":"","streetType":"Dr","unitValue":"","city":"Hoffman Estates","directionalSuffix":""}}],"listings":[],"regions":[]}*/

data/test/test_redfin_base.rb

@@ -7,18 +7,13 @@ class TestRedfinApiBase < Test::Unit::TestCase
       RedfinApi::Base.stubs(:http_get).with(@url).returns(File.read(File.dirname(__FILE__) + "/data/property_page.html"))
     end
     should "extract PIN information" do
-      address = RedfinApi::Base.fetch_address(@url)
-      assert_equal("07343000300000", address[:pin])
+      pin = RedfinApi::Base.extract_pin(@url)
+      assert_equal("07343000300000", pin)
     end
   end
-  should "fetch address from redfin url" do
-    url = "http://www.redfin.com/IL/Roselle/999-Main-St-60606/home/99999999"
-    RedfinApi::Base.stubs(:http_get).with(url).returns(File.read(File.dirname(__FILE__) + "/data/property_page.html"))
-    address = RedfinApi::Base.fetch_address(url)
-    assert_equal("640 WASHINGTON Ct", address[:address_line_1])
-    assert_equal("ROSELLE", address[:city])
-    assert_equal("IL", address[:state])
-    assert_equal("60172", address[:zip])
+  should "return nil when specified address could not be found" do
+    RedfinApi::Base.stubs(:http_get).returns('/*{"listings":[],"regions":[]}*/')
+    assert_equal(nil, RedfinApi::Base.query_location("some unlocatable address"))
   end
   context "with query location returning pastSalesBuildings" do
     setup do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: sjain-redfin_api
 version: !ruby/object:Gem::Version 
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors: 
 - Sharad Jain
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-09-16 00:00:00 -07:00
+date: 2009-09-17 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -39,6 +39,10 @@ files:
 - test/data/property_page.html
 - test/data/query_location_listings.json
 - test/data/query_location_pastSalesBuildings.json
+- test/data/redfin/gis-id-search-empty.json
+- test/data/redfin/gis-id-search-listing.json
+- test/data/redfin/query-location-listing.json
+- test/data/redfin/query-location-non-listing.json
 - test/test_helper.rb
 - test/test_redfin_api.rb
 - test/test_redfin_base.rb