sitemap_generator 7.1.0 → 7.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b18ba1ba719a39678730f1b1e4c76f9162725c3cf0b355510738a5586e566eff
-  data.tar.gz: 67dc99385dee6022f06a66945c75b24497bea9f9fc573c1ab866fcb583dc5c0e
+  metadata.gz: 6c259fa0f3a68d9e8595e387643000a6c7cde213ed6fcc8c66963428c945cefd
+  data.tar.gz: 8dc85d783b0018d2c13c9d0146fe59920160ebcca120d8693ef03c6d9958ddf0
 SHA512:
-  metadata.gz: 97fb528cf9d949463a89f3ded008df4516766aa978462954184aca1aae83fa6aa590d6efc9e81fb2f7d6a3f8f82b7fcbe0c07a5a855539c23ba86bd1ec7ae552
-  data.tar.gz: cba27e4d71b77be16ce19e6cd0dae400d2a86570e8e0d637b102c83c841440cf86d9e0aa5a6e7365a3a3885ef622fd26e5c581d68d25f437eff6f78a5aacdd2f
+  metadata.gz: b4fa4c6e8e0b2ef87e8d2af947719e7d902d74021e16f4a6c6bc51e5a9b8e16410858b06b0327ed7df514c270af032e3ec32342022ff252b2cf1d6da352200f3
+  data.tar.gz: d3dbfeed32002542b17695efbaebff375bdf28fb9b847910c16b033b4ed30478cbbec5f31e4f341be2416aaa3e33af16b0aef202631c22ac550538a48801cbe2

data/CHANGES.md

@@ -1,5 +1,16 @@
 # Changelog
 
+## 7.1.1
+
+* Fix: `rake sitemap:clean` (`clean_files`) now respects the configured `sitemaps_path`/`public_path` and also removes uncompressed `.xml` sitemaps, instead of only deleting hardcoded `public/sitemap*.xml.gz` files. [#474](https://github.com/kjvarga/sitemap_generator/issues/474) [#502](https://github.com/kjvarga/sitemap_generator/pull/502)
+* Fix: `SitemapGenerator::Interpreter` now respects `ActionController::Base.default_url_options`, so Rails URL helpers honor globally configured defaults (e.g. `:protocol`, `:port`) instead of ignoring them. [#355](https://github.com/kjvarga/sitemap_generator/issues/355) [#507](https://github.com/kjvarga/sitemap_generator/pull/507)
+* Fix: Non-ASCII characters in URL paths are now percent-encoded in the `<loc>` element, so generated sitemaps conform to the sitemap protocol. [#346](https://github.com/kjvarga/sitemap_generator/issues/346) [#506](https://github.com/kjvarga/sitemap_generator/pull/506)
+* Fix: Relative alternate hreflang hrefs (starting with `/`) are now expanded to absolute URLs using the configured host, producing valid sitemap XML instead of broken relative links. [#343](https://github.com/kjvarga/sitemap_generator/issues/343) [#504](https://github.com/kjvarga/sitemap_generator/pull/504)
+* Fix: `SitemapGenerator.verbose = false` is now respected by `rake sitemap:refresh` and other rake tasks, silencing output as configured. [#332](https://github.com/kjvarga/sitemap_generator/issues/332) [#503](https://github.com/kjvarga/sitemap_generator/pull/503)
+* Fix: Sitemap file `lastmod` is now captured at write time rather than read back via `File.mtime`, fixing incorrect timestamps and improving compatibility with time-freezing test helpers. [#508](https://github.com/kjvarga/sitemap_generator/pull/508)
+* Fix: URL `lastmod` now defaults to `Time.zone.now` under Rails (falling back to `Time.now` otherwise), so the configured Rails timezone and time-freezing helpers like `travel_to` are respected instead of always using system local time. [#422](https://github.com/kjvarga/sitemap_generator/issues/422) [#505](https://github.com/kjvarga/sitemap_generator/pull/505)
+* Internal: Enable RuboCop on the spec suite (previously fully excluded), fix real bugs the linting surfaced along the way (always-passing tests with no assertions, a latent `NameError`, broken path comparisons), and resolve all temporary RuboCop spec-suite exclusions. [#510](https://github.com/kjvarga/sitemap_generator/pull/510) [#511](https://github.com/kjvarga/sitemap_generator/pull/511) [#512](https://github.com/kjvarga/sitemap_generator/pull/512) [#513](https://github.com/kjvarga/sitemap_generator/pull/513) [#514](https://github.com/kjvarga/sitemap_generator/pull/514)
+
 ## 7.1.0
 
 * **Breaking:** `SitemapGenerator::FileAdapter#plain` has been removed. It was an internal helper inlined into `#write` to fix a file descriptor leak; any code calling it directly should call `#write` instead. [#492](https://github.com/kjvarga/sitemap_generator/pull/492)

data/VERSION

@@ -1 +1 @@
-7.1.0
+7.1.1

data/lib/sitemap_generator/builder/sitemap_file.rb

@@ -56,14 +56,11 @@ module SitemapGenerator
         @frozen = false      # rather than actually freeze, use this boolean
       end
 
-      # If a name has been reserved, use the last modified time from the file.
-      # Otherwise return nil.  We don't want to prematurely assign a name
-      # for this sitemap if one has not yet been reserved, because we may
-      # mess up the name-assignment sequence.
+      # Return the time the sitemap was written, or nil if it has not been written yet.
+      # Returning nil before write prevents prematurely reserving a name in the
+      # namer sequence.
       def lastmod
-        File.mtime(location.path) if location.reserved_name?
-      rescue StandardError
-        nil
+        @lastmod if location.reserved_name?
       end
 
       def empty?
@@ -149,6 +146,7 @@ module SitemapGenerator
         reserve_name
         @xml_content << @xml_wrapper_end
         @location.write(@xml_content, link_count)
+        @lastmod = SitemapGenerator::Utilities.current_time
         @xml_content = @xml_wrapper_end = ''
         @written = true
       end

data/lib/sitemap_generator/builder/sitemap_index_url.rb

@@ -8,7 +8,7 @@ module SitemapGenerator
     class SitemapIndexUrl < SitemapUrl
       def initialize(path, options = {})
         if (index = path.is_a?(SitemapGenerator::Builder::SitemapIndexFile) && path)
-          options = SitemapGenerator::Utilities.reverse_merge(options, host: index.location.host, lastmod: Time.now,
+          options = SitemapGenerator::Utilities.reverse_merge(options, host: index.location.host, lastmod: SitemapGenerator::Utilities.current_time,
                                                                        priority: 1.0)
           path = index.location.path_in_public
         end

data/lib/sitemap_generator/builder/sitemap_url.rb

@@ -52,7 +52,7 @@ module SitemapGenerator
           options,
           priority: 0.5,
           changefreq: 'weekly',
-          lastmod: Time.now,
+          lastmod: SitemapGenerator::Utilities.current_time,
           images: [],
           news: {},
           videos: [],
@@ -69,7 +69,7 @@ module SitemapGenerator
             alternate.is_a?(Array) ? options[:alternates].concat(alternate) : options[:alternates] << alternate
         end
 
-        path = path.to_s.sub(%r{^/}, '')
+        path = encode_non_ascii(path.to_s.sub(%r{^/}, ''))
         loc  = path.empty? ? options[:host] : "#{options[:host].to_s.sub(%r{/$}, '')}/#{path}"
         merge!(
           priority: options[:priority],
@@ -82,7 +82,7 @@ module SitemapGenerator
           news: prepare_news(options[:news]),
           videos: options[:videos],
           mobile: options[:mobile],
-          alternates: options[:alternates],
+          alternates: prepare_alternates(options[:alternates], options[:host]),
           pagemap: options[:pagemap]
         )
       end
@@ -221,6 +221,20 @@ module SitemapGenerator
         news
       end
 
+      # Return an Array of alternate option Hashes with relative hrefs expanded to absolute URLs.
+      def prepare_alternates(alternates, host)
+        alternates.map do |alt|
+          next alt unless alt.is_a?(Hash)
+
+          href = alt[:href].to_s
+          if href.start_with?('/')
+            alt.merge(href: URI.join(host, href).to_s)
+          else
+            alt
+          end
+        end
+      end
+
       # Return an Array of image option Hashes suitable to be parsed by SitemapGenerator::Builder::SitemapFile
       def prepare_images(images, host)
         images.delete_if { |key, _value| key[:loc].nil? }
@@ -282,6 +296,14 @@ module SitemapGenerator
       def format_float(value)
         value.is_a?(String) ? value : format('%0.1f', value)
       end
+
+      private
+
+      # Percent-encode non-ASCII bytes in a path segment, leaving already-encoded %XX sequences untouched.
+      # Applied to paths only — not the host — IDN hostnames require punycode, not percent-encoding.
+      def encode_non_ascii(str)
+        str.gsub(/[^\x00-\x7F]/) { |c| c.bytes.map { |b| format('%%%02X', b) }.join }
+      end
     end
   end
 end

data/lib/sitemap_generator/interpreter.rb

@@ -27,6 +27,12 @@ module SitemapGenerator
       eval(&block) if block_given? # rubocop:disable Security/Eval
     end
 
+    def default_url_options
+      return {} unless defined?(ActionController::Base)
+
+      ActionController::Base.default_url_options || {}
+    end
+
     def add(*args)
       @linkset.add(*args)
     end

data/lib/sitemap_generator/link_set.rb

@@ -433,7 +433,7 @@ module SitemapGenerator
     # in an instance variable.
     def add_default_links
       @added_default_links = true
-      link_options = { lastmod: Time.now, priority: 1.0 }
+      link_options = { priority: 1.0, lastmod: SitemapGenerator::Utilities.current_time }
       add('/', link_options) if include_root?
       return unless include_index?
 

data/lib/sitemap_generator/tasks.rb

@@ -18,6 +18,8 @@ namespace :sitemap do
 
   desc 'Install a default config/sitemap.rb file'
   task install: :require do
+    # Uses Rake's verbose flag intentionally — this is a file installation utility
+    # where Rake's -v/--verbose flag is the appropriate control mechanism.
     SitemapGenerator::Utilities.install_sitemap_rb(verbose)
   end
 
@@ -36,6 +38,6 @@ namespace :sitemap do
 
   desc "Generate sitemaps but don't ping search engines.  Alias for refresh:no_ping."
   task create: :require do
-    SitemapGenerator::Interpreter.run(config_file: ENV.fetch('CONFIG_FILE', nil), verbose: verbose)
+    SitemapGenerator::Interpreter.run(config_file: ENV.fetch('CONFIG_FILE', nil))
   end
 end

data/lib/sitemap_generator/utilities.rb

@@ -28,7 +28,12 @@ module SitemapGenerator
 
     # Clean sitemap files in output directory.
     def clean_files
-      FileUtils.rm(Dir[SitemapGenerator.app.root + 'public/sitemap*.xml.gz']) # rubocop:disable Style/StringConcatenation
+      location = SitemapGenerator::Sitemap.sitemap_location
+      dir = location.directory
+      base = SitemapGenerator::Sitemap.filename.to_s
+      return if base.empty?
+
+      FileUtils.rm(Dir[File.join(dir, "#{base}*.xml.gz"), File.join(dir, "#{base}*.xml")])
     end
 
     # Validate all keys in a hash match *valid keys, raising ArgumentError on a
@@ -184,6 +189,12 @@ module SitemapGenerator
       end
     end
 
+    # Return the current time, using Time.zone if available (Rails), otherwise Time.now.
+    def current_time
+      zone = defined?(Time.zone) && Time.zone
+      zone ? zone.now : Time.now
+    end
+
     # Return the bytesize length of the string.  Ruby 1.8.6 compatible.
     def bytesize(string)
       string.respond_to?(:bytesize) ? string.bytesize : string.length

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sitemap_generator
 version: !ruby/object:Gem::Version
-  version: 7.1.0
+  version: 7.1.1
 platform: ruby
 authors:
 - Karl Varga
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-07-03 00:00:00.000000000 Z
+date: 2026-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder