sitemap_generator 6.3.0 → 7.1.1

data/VERSION

@@ -1 +1 @@
-6.3.0
+7.1.1

data/lib/capistrano/sitemap_generator.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 load File.expand_path(File.join('..', 'tasks', 'sitemap_generator.cap'), __FILE__)

data/lib/sitemap_generator/adapters/active_storage_adapter.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+module SitemapGenerator
+  # Class for uploading sitemaps to ActiveStorage.
+  class ActiveStorageAdapter
+    attr_reader :key, :filename
+
+    def initialize(key: :sitemap, filename: 'sitemap.xml.gz')
+      @key = key
+      @filename = filename
+    end
+
+    def write(location, raw_data) # rubocop:disable Metrics/MethodLength
+      SitemapGenerator::FileAdapter.new.write(location, raw_data)
+
+      ActiveStorage::Blob.transaction do
+        ActiveStorage::Blob.where(key: key).destroy_all
+
+        File.open(location.path, 'rb') do |io|
+          ActiveStorage::Blob.create_and_upload!(
+            key: key,
+            io: io,
+            filename: filename,
+            content_type: 'application/gzip',
+            identify: false
+          )
+        end
+      end
+    end
+  end
+end

data/lib/sitemap_generator/adapters/aws_sdk_adapter.rb

@@ -1,6 +1,8 @@
-if !defined?(Aws::S3::Resource) or !defined?(Aws::Credentials)
-  raise LoadError, "Error: `Aws::S3::Resource` and/or `Aws::Credentials` are not defined.\n\n"\
-        "Please `require 'aws-sdk'` - or another library that defines these classes."
+# frozen_string_literal: true
+
+if !defined?(Aws::S3::Resource) || !defined?(Aws::Credentials)
+  raise LoadError, "Error: `Aws::S3::Resource` and/or `Aws::Credentials` are not defined.\n\n" \
+                   "Please `require 'aws-sdk'` - or another library that defines these classes."
 end
 
 module SitemapGenerator
@@ -22,32 +24,46 @@ module SitemapGenerator
     #   **Deprecated, use :secret_access_key instead** :aws_secret_access_key [String] Your AWS secret access key
     #   **Deprecated, use :region instead** :aws_region [String] Your AWS region
     #   :acl [String] The ACL to apply to the uploaded files.  Defaults to 'public-read'.
-    #   :cache_control [String] The cache control headder to apply to the uploaded files.  Defaults to 'private, max-age=0, no-cache'.
+    #   :cache_control [String] The cache control headder to apply to the uploaded files.
+    #                          Defaults to 'private, max-age=0, no-cache'.
     #
     #   All other options you provide are passed directly to the AWS client.
     #   See https://docs.aws.amazon.com/sdk-for-ruby/v2/api/Aws/S3/Client.html#initialize-instance_method
     #   for a full list of supported options.
-    def initialize(bucket, aws_access_key_id: nil, aws_secret_access_key: nil, aws_region: nil, aws_endpoint: nil, acl: 'public-read', cache_control: 'private, max-age=0, no-cache', **options)
+    def initialize(bucket, aws_access_key_id: nil, aws_secret_access_key: nil, aws_session_token: nil, aws_region: nil, # rubocop:disable Metrics/ParameterLists
+                   aws_endpoint: nil, acl: 'public-read', cache_control: 'private, max-age=0, no-cache', **options)
       @bucket = bucket
       @acl = acl
       @cache_control = cache_control
       @options = options
       set_option_unless_set(:access_key_id, aws_access_key_id)
       set_option_unless_set(:secret_access_key, aws_secret_access_key)
+      set_option_unless_set(:session_token, aws_session_token)
       set_option_unless_set(:region, aws_region)
       set_option_unless_set(:endpoint, aws_endpoint)
     end
 
-
     # Call with a SitemapLocation and string data
-    def write(location, raw_data)
+    def write(location, raw_data) # rubocop:disable Metrics/MethodLength
       SitemapGenerator::FileAdapter.new.write(location, raw_data)
-      s3_object = s3_resource.bucket(@bucket).object(location.path_in_public)
-      s3_object.upload_file(location.path, {
-        acl: @acl,
-        cache_control: @cache_control,
-        content_type: location[:compress] ? 'application/x-gzip' : 'application/xml'
-      }.compact)
+
+      if defined?(Aws::S3::TransferManager)
+        client = Aws::S3::Client.new(@options)
+        transfer_manager = Aws::S3::TransferManager.new(client: client)
+        transfer_manager.upload_file(location.path,
+                                     bucket: @bucket,
+                                     key: location.path_in_public,
+                                     acl: @acl,
+                                     cache_control: @cache_control,
+                                     content_type: location.content_type)
+      else
+        s3_object = s3_resource.bucket(@bucket).object(location.path_in_public)
+        s3_object.upload_file(location.path, {
+          acl: @acl,
+          cache_control: @cache_control,
+          content_type: location.content_type
+        }.compact)
+      end
     end
 
     private

data/lib/sitemap_generator/adapters/file_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SitemapGenerator
   # Class for writing out data to a file.
   class FileAdapter
@@ -8,23 +10,26 @@ module SitemapGenerator
     #    compressed prior to being written out.  Otherwise the data will be written out
     #    unchanged.
     # @param raw_data - data to write to the file.
-    def write(location, raw_data)
+    def write(location, raw_data) # rubocop:disable Metrics/MethodLength
       # Ensure that the directory exists
       dir = location.directory
       if !File.exist?(dir)
         FileUtils.mkdir_p(dir)
       elsif !File.directory?(dir)
-        raise SitemapError.new("#{dir} should be a directory!")
+        raise SitemapError, "#{dir} should be a directory!"
       end
 
-      stream = open(location.path, 'wb')
-      if location.path.to_s =~ /.gz$/
-        gzip(stream, raw_data)
-      else
-        plain(stream, raw_data)
+      File.open(location.path, 'wb') do |stream|
+        if location.gzip?
+          gzip(stream, raw_data)
+        else
+          stream.write raw_data
+        end
       end
     end
 
+    private
+
     # Write `data` to a stream, passing the data through a GzipWriter
     # to compress it.
     def gzip(stream, data)
@@ -32,11 +37,5 @@ module SitemapGenerator
       gz.write data
       gz.close
     end
-
-    # Write `data` to a stream as is.
-    def plain(stream, data)
-      stream.write data
-      stream.close
-    end
   end
 end

data/lib/sitemap_generator/adapters/fog_adapter.rb

@@ -1,6 +1,8 @@
-if !defined?(Fog::Storage)
-  raise LoadError, "Error: `Fog::Storage` is not defined.\n\n"\
-        "Please `require 'fog'` - or another library that defines this class."
+# frozen_string_literal: true
+
+unless defined?(Fog::Storage)
+  raise LoadError, "Error: `Fog::Storage` is not defined.\n\n" \
+                   "Please `require 'fog'` - or another library that defines this class."
 end
 
 module SitemapGenerator
@@ -21,11 +23,11 @@ module SitemapGenerator
       SitemapGenerator::FileAdapter.new.write(location, raw_data)
 
       storage   = Fog::Storage.new(@fog_credentials)
-      directory = storage.directories.new(:key => @fog_directory)
+      directory = storage.directories.new(key: @fog_directory)
       directory.files.create(
-        :key    => location.path_in_public,
-        :body   => File.open(location.path),
-        :public => true
+        key: location.path_in_public,
+        body: File.open(location.path),
+        public: true
       )
     end
   end

data/lib/sitemap_generator/adapters/google_storage_adapter.rb

@@ -1,6 +1,8 @@
-if !defined?(Google::Cloud::Storage)
-  raise LoadError, "Error: `Google::Cloud::Storage` is not defined.\n\n"\
-        "Please `require 'google/cloud/storage'` - or another library that defines this class."
+# frozen_string_literal: true
+
+unless defined?(Google::Cloud::Storage)
+  raise LoadError, "Error: `Google::Cloud::Storage` is not defined.\n\n" \
+                   "Please `require 'google/cloud/storage'` - or another library that defines this class."
 end
 
 module SitemapGenerator
@@ -10,7 +12,8 @@ module SitemapGenerator
     #
     # @param [Hash] opts Google::Cloud::Storage configuration options.
     # @option :bucket [String] Required. Name of Google Storage Bucket where the file is to be uploaded.
-    # @option :acl [String] Optional. Access control which is applied to the uploaded file(s).  Default value is 'public'.
+    # @option :acl [String] Optional. Access control which is applied to the uploaded file(s).
+    #                         Default value is 'public'.
     #
     # All options other than the `:bucket` and `:acl` options are passed to the `Google::Cloud::Storage.new`
     # initializer.  See https://googleapis.dev/ruby/google-cloud-storage/latest/file.AUTHENTICATION.html
@@ -23,7 +26,7 @@ module SitemapGenerator
     def initialize(opts = {})
       opts = opts.clone
       @bucket = opts.delete(:bucket)
-      @acl = opts.has_key?(:acl) ? opts.delete(:acl) : 'public'
+      @acl = opts.key?(:acl) ? opts.delete(:acl) : 'public'
       @storage_options = opts
     end
 

data/lib/sitemap_generator/adapters/s3_adapter.rb

@@ -1,6 +1,8 @@
-if !defined?(Fog::Storage)
-  raise LoadError, "Error: `Fog::Storage` is not defined.\n\n"\
-        "Please `require 'fog-aws'` - or another library that defines this class."
+# frozen_string_literal: true
+
+unless defined?(Fog::Storage)
+  raise LoadError, "Error: `Fog::Storage` is not defined.\n\n" \
+                   "Please `require 'fog-aws'` - or another library that defines this class."
 end
 
 module SitemapGenerator
@@ -20,27 +22,29 @@ module SitemapGenerator
     #
     # Alternatively you can use an environment variable to configure each option (except `fog_storage_options`).
     # The environment variables have the same name but capitalized, e.g. `FOG_PATH_STYLE`.
-    def initialize(opts = {})
-      @aws_access_key_id = opts[:aws_access_key_id] || ENV['AWS_ACCESS_KEY_ID']
-      @aws_secret_access_key = opts[:aws_secret_access_key] || ENV['AWS_SECRET_ACCESS_KEY']
-      @fog_provider = opts[:fog_provider] || ENV['FOG_PROVIDER']
-      @fog_directory = opts[:fog_directory] || ENV['FOG_DIRECTORY']
-      @fog_region = opts[:fog_region] || ENV['FOG_REGION']
-      @fog_path_style = opts[:fog_path_style] || ENV['FOG_PATH_STYLE']
+    def initialize(opts = {}) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+      @aws_access_key_id = opts[:aws_access_key_id] || ENV.fetch('AWS_ACCESS_KEY_ID', nil)
+      @aws_secret_access_key = opts[:aws_secret_access_key] || ENV.fetch('AWS_SECRET_ACCESS_KEY', nil)
+      @aws_session_token = opts[:aws_session_token] || ENV.fetch('AWS_SESSION_TOKEN', nil)
+      @fog_provider = opts[:fog_provider] || ENV.fetch('FOG_PROVIDER', nil)
+      @fog_directory = opts[:fog_directory] || ENV.fetch('FOG_DIRECTORY', nil)
+      @fog_region = opts[:fog_region] || ENV.fetch('FOG_REGION', nil)
+      @fog_path_style = opts[:fog_path_style] || ENV.fetch('FOG_PATH_STYLE', nil)
       @fog_storage_options = opts[:fog_storage_options] || {}
-      fog_public = opts[:fog_public].nil? ? ENV['FOG_PUBLIC'] : opts[:fog_public]
-      @fog_public = SitemapGenerator::Utilities.falsy?(fog_public) ? false : true
+      fog_public = opts[:fog_public].nil? ? ENV.fetch('FOG_PUBLIC', nil) : opts[:fog_public]
+      @fog_public = !SitemapGenerator::Utilities.falsy?(fog_public)
     end
 
     # Call with a SitemapLocation and string data
-    def write(location, raw_data)
+    def write(location, raw_data) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
       SitemapGenerator::FileAdapter.new.write(location, raw_data)
 
-      credentials = { :provider => @fog_provider }
+      credentials = { provider: @fog_provider }
 
       if @aws_access_key_id && @aws_secret_access_key
         credentials[:aws_access_key_id] = @aws_access_key_id
         credentials[:aws_secret_access_key] = @aws_secret_access_key
+        credentials[:aws_session_token] = @aws_session_token if @aws_session_token
       else
         credentials[:use_iam_profile] = true
       end
@@ -49,11 +53,12 @@ module SitemapGenerator
       credentials[:path_style] = @fog_path_style if @fog_path_style
 
       storage   = Fog::Storage.new(@fog_storage_options.merge(credentials))
-      directory = storage.directories.new(:key => @fog_directory)
+      directory = storage.directories.new(key: @fog_directory)
       directory.files.create(
-        :key    => location.path_in_public,
-        :body   => File.open(location.path),
-        :public => @fog_public
+        key: location.path_in_public,
+        body: File.open(location.path),
+        public: @fog_public,
+        content_type: location.content_type
       )
     end
   end

data/lib/sitemap_generator/adapters/wave_adapter.rb

@@ -1,6 +1,8 @@
-if !defined?(::CarrierWave::Uploader::Base)
-  raise LoadError, "Error: `CarrierWave::Uploader::Base` is not defined.\n\n"\
-        "Please `require 'carrierwave'` - or another library that defines this class."
+# frozen_string_literal: true
+
+unless defined?(CarrierWave::Uploader::Base)
+  raise LoadError, "Error: `CarrierWave::Uploader::Base` is not defined.\n\n" \
+                   "Please `require 'carrierwave'` - or another library that defines this class."
 end
 
 module SitemapGenerator
@@ -12,10 +14,10 @@ module SitemapGenerator
     def write(location, raw_data)
       SitemapGenerator::FileAdapter.new.write(location, raw_data)
       directory = File.dirname(location.path_in_public)
-      if directory != '.'
-        self.store_dir = directory
+      self.store_dir = directory if directory != '.'
+      File.open(location.path, 'rb') do |io|
+        store!(io)
       end
-      store!(open(location.path, 'rb'))
     end
   end
 end

data/lib/sitemap_generator/application.rb

@@ -1,17 +1,21 @@
+# frozen_string_literal: true
+
 require 'pathname'
 
 module SitemapGenerator
+  # Thin abstraction over the host application environment.
+  # Provides the app +root+ path and Rails version detection.
   class Application
-    def is_rails?
+    def is_rails? # rubocop:disable Naming/PredicatePrefix
       !!defined?(Rails::VERSION)
     end
 
     # Returns a boolean indicating whether this environment is Rails 3
     #
     # @return [Boolean]
-    def is_at_least_rails3?
+    def is_at_least_rails3? # rubocop:disable Naming/PredicatePrefix
       is_rails? && Rails.version.to_f >= 3
-    rescue
+    rescue StandardError
       false # Rails.version defined in 2.1.0
     end
 
@@ -29,6 +33,7 @@ module SitemapGenerator
     def rails_root
       return ::Rails.root.to_s if defined?(::Rails.root) && ::Rails.root
       return RAILS_ROOT.to_s if defined?(RAILS_ROOT)
+
       nil
     end
 
@@ -40,6 +45,7 @@ module SitemapGenerator
     def rails_env
       return ::Rails.env.to_s if defined?(::Rails.env)
       return RAILS_ENV.to_s if defined?(RAILS_ENV)
+
       nil
     end
   end

data/lib/sitemap_generator/builder/sitemap_file.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'zlib'
 require 'fileutils'
 require 'sitemap_generator/helpers/number_helper'
@@ -9,10 +11,12 @@ module SitemapGenerator
     #
     #   sitemap = SitemapFile.new(:location => SitemapLocation.new(...))
     #   sitemap.add('/', { ... })    <- add a link to the sitemap
-    #   sitemap.finalize!            <- write the sitemap file and freeze the object to protect it from further modification
+    #   sitemap.finalize!            <- write the sitemap file and freeze the object
+    #                                    to protect it from further modification
     #
     class SitemapFile
       include SitemapGenerator::Helpers::NumberHelper
+
       attr_reader :link_count, :filesize, :location, :news_count
 
       # === Options
@@ -20,12 +24,14 @@ module SitemapGenerator
       # * <tt>location</tt> - a SitemapGenerator::SitemapLocation instance or a Hash of options
       #   from which a SitemapLocation will be created for you.  See `SitemapGenerator::SitemapLocation` for
       #   the supported list of options.
-      def initialize(opts={})
+      def initialize(opts = {}) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
         @location = opts.is_a?(Hash) ? SitemapGenerator::SitemapLocation.new(opts) : opts
         @link_count = 0
         @news_count = 0
-        @xml_content = '' # XML urlset content
-        @xml_wrapper_start = <<-HTML
+        # The + prefix makes this string explicitly mutable. Ruby 2.x with
+        # --enable=frozen-string-literal freezes interpolated heredocs, and
+        # gsub! below requires a mutable string.
+        @xml_wrapper_start = +<<-HTML
           <?xml version="1.0" encoding="UTF-8"?>
             <urlset
               xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
@@ -41,33 +47,34 @@ module SitemapGenerator
             >
         HTML
         @xml_wrapper_start.gsub!(/\s+/, ' ').gsub!(/ *> */, '>').strip!
-        @xml_wrapper_end   = %q[</urlset>]
-        @filesize = SitemapGenerator::Utilities.bytesize(@xml_wrapper_start) + SitemapGenerator::Utilities.bytesize(@xml_wrapper_end)
+        @xml_wrapper_end = '</urlset>'
+        @filesize = SitemapGenerator::Utilities.bytesize(@xml_wrapper_start) +
+                    SitemapGenerator::Utilities.bytesize(@xml_wrapper_end)
+        @xml_content = @xml_wrapper_start
         @written = false
         @reserved_name = nil # holds the name reserved from the namer
         @frozen = false      # rather than actually freeze, use this boolean
       end
 
-      # If a name has been reserved, use the last modified time from the file.
-      # Otherwise return nil.  We don't want to prematurely assign a name
-      # for this sitemap if one has not yet been reserved, because we may
-      # mess up the name-assignment sequence.
+      # Return the time the sitemap was written, or nil if it has not been written yet.
+      # Returning nil before write prevents prematurely reserving a name in the
+      # namer sequence.
       def lastmod
-        File.mtime(location.path) if location.reserved_name?
-      rescue
-        nil
+        @lastmod if location.reserved_name?
       end
 
       def empty?
-        @link_count == 0
+        @link_count.zero?
       end
 
       # Return a boolean indicating whether the sitemap file can fit another link
       # of <tt>bytes</tt> bytes in size.  You can also pass a string and the
       # bytesize will be calculated for you.
       def file_can_fit?(bytes)
-        bytes = bytes.is_a?(String) ? SitemapGenerator::Utilities.bytesize(bytes) : bytes
-        (@filesize + bytes) < SitemapGenerator::MAX_SITEMAP_FILESIZE && @link_count < max_sitemap_links && @news_count < SitemapGenerator::MAX_SITEMAP_NEWS
+        bytes = SitemapGenerator::Utilities.bytesize(bytes) if bytes.is_a?(String)
+        (@filesize + bytes) < SitemapGenerator::MAX_SITEMAP_FILESIZE &&
+          @link_count < max_sitemap_links &&
+          @news_count < SitemapGenerator::MAX_SITEMAP_NEWS
       end
 
       # Add a link to the sitemap file.
@@ -89,22 +96,21 @@ module SitemapGenerator
       #
       # The link added to the sitemap will use the host from its location object
       # if no host has been specified.
-      def add(link, options={})
+      def add(link, options = {}) # rubocop:disable Metrics/MethodLength
         raise SitemapGenerator::SitemapFinalizedError if finalized?
 
-        sitemap_url = if link.is_a?(SitemapUrl)
-          link
-        else
-          options[:host] ||= @location.host
-          SitemapUrl.new(link, options)
-        end
+        sitemap_url =
+          if link.is_a?(SitemapUrl)
+            link
+          else
+            options[:host] ||= @location.host
+            SitemapUrl.new(link, options)
+          end
 
         xml = sitemap_url.to_xml
-        raise SitemapGenerator::SitemapFullError if !file_can_fit?(xml)
+        raise SitemapGenerator::SitemapFullError unless file_can_fit?(xml)
 
-        if sitemap_url.news?
-          @news_count += 1
-        end
+        @news_count += 1 if sitemap_url.news?
 
         # Add the XML to the sitemap
         @xml_content << xml
@@ -118,6 +124,7 @@ module SitemapGenerator
       # has already been finalized.
       def finalize!
         raise SitemapGenerator::SitemapFinalizedError if finalized?
+
         @frozen = true
       end
 
@@ -133,11 +140,14 @@ module SitemapGenerator
       # A SitemapGenerator::SitemapError exception is raised if the file has
       # already been written.
       def write
-        raise SitemapGenerator::SitemapError.new("Sitemap already written!") if written?
+        raise SitemapGenerator::SitemapError, 'Sitemap already written!' if written?
+
         finalize! unless finalized?
         reserve_name
-        @location.write(@xml_wrapper_start + @xml_content + @xml_wrapper_end, link_count)
-        @xml_content = @xml_wrapper_start = @xml_wrapper_end = ''
+        @xml_content << @xml_wrapper_end
+        @location.write(@xml_content, link_count)
+        @lastmod = SitemapGenerator::Utilities.current_time
+        @xml_content = @xml_wrapper_end = ''
         @written = true
       end
 
@@ -149,7 +159,7 @@ module SitemapGenerator
       # Reserve a name from the namer unless one has already been reserved.
       # Safe to call more than once.
       def reserve_name
-        @reserved_name ||= @location.reserve_name
+        @reserved_name ||= @location.reserve_name # rubocop:disable Naming/MemoizedInstanceVariableName
       end
 
       # Return a boolean indicating whether a name has been reserved

data/lib/sitemap_generator/builder/sitemap_index_file.rb

@@ -1,17 +1,23 @@
+# frozen_string_literal: true
+
 module SitemapGenerator
   module Builder
+    # Builds the sitemap index XML file, listing all sitemap files.
+    # Manages deferred naming (waits for a second sitemap before reserving the index name)
+    # and controls whether an index is written at all via +create_index+.
     class SitemapIndexFile < SitemapFile
-
       # === Options
       #
       # * <tt>location</tt> - a SitemapGenerator::SitemapIndexLocation instance or a Hash of options
       #   from which a SitemapLocation will be created for you.
-      def initialize(opts={})
+      def initialize(opts = {}) # rubocop:disable Lint/MissingSuper, Metrics/MethodLength
         @location = opts.is_a?(Hash) ? SitemapGenerator::SitemapIndexLocation.new(opts) : opts
         @link_count = 0
         @sitemaps_link_count = 0
-        @xml_content = '' # XML urlset content
-        @xml_wrapper_start = <<-HTML
+        # The + prefix makes this string explicitly mutable. Ruby 2.x with
+        # --enable=frozen-string-literal freezes interpolated heredocs, and
+        # gsub! below requires a mutable string.
+        @xml_wrapper_start = +<<-HTML
           <?xml version="1.0" encoding="UTF-8"?>
             <sitemapindex
               xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
@@ -21,8 +27,9 @@ module SitemapGenerator
             >
         HTML
         @xml_wrapper_start.gsub!(/\s+/, ' ').gsub!(/ *> */, '>').strip!
-        @xml_wrapper_end   = %q[</sitemapindex>]
+        @xml_wrapper_end = '</sitemapindex>'
         @filesize = SitemapGenerator::Utilities.bytesize(@xml_wrapper_start) + SitemapGenerator::Utilities.bytesize(@xml_wrapper_end)
+        @xml_content = @xml_wrapper_start
         @written = false
         @reserved_name = nil # holds the name reserved from the namer
         @frozen = false      # rather than actually freeze, use this boolean
@@ -44,9 +51,9 @@ module SitemapGenerator
       # If a link is being added to the index manually as a string, then we
       # can assume that the index is required (unless create_index is false of course).
       # This seems like the logical thing to do.
-      alias_method :super_add, :add
-      def add(link, options={})
-        if file = link.is_a?(SitemapFile) && link
+      alias super_add add
+      def add(link, options = {}) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
+        if (file = link.is_a?(SitemapFile) && link)
           @sitemaps_link_count += file.link_count
           file.finalize! unless file.finalized?
 
@@ -57,9 +64,9 @@ module SitemapGenerator
           # first name (the index, or the sitemap).  If the item is not a SitemapFile,
           # then it has been manually added and we can be sure that the user intends
           # for there to be an index.
-          if @link_count == 0
+          if @link_count.zero?
             @first_sitemap = SitemapGenerator::Builder::LinkHolder.new(file, options)
-            @link_count += 1     # pretend it's added, but don't add it yet
+            @link_count += 1 # pretend it's added, but don't add it yet
           else
             # need an index so make sure name is reserved and first sitemap is written out
             reserve_name unless @location.create_index == false
@@ -85,7 +92,7 @@ module SitemapGenerator
       # of <tt>bytes</tt> bytes in size.  You can also pass a string and the
       # bytesize will be calculated for you.
       def file_can_fit?(bytes)
-        bytes = bytes.is_a?(String) ? SitemapGenerator::Utilities.bytesize(bytes) : bytes
+        bytes = SitemapGenerator::Utilities.bytesize(bytes) if bytes.is_a?(String)
         (@filesize + bytes) < SitemapGenerator::MAX_SITEMAP_FILESIZE && @link_count < SitemapGenerator::MAX_SITEMAP_FILES
       end
 
@@ -94,13 +101,14 @@ module SitemapGenerator
         @sitemaps_link_count
       end
 
-      def stats_summary(opts={})
+      def stats_summary(opts = {})
         str = "Sitemap stats: #{number_with_delimiter(@sitemaps_link_count)} links / #{@link_count} sitemaps"
-        str += " / %dm%02ds" % opts[:time_taken].divmod(60) if opts[:time_taken]
+        str + format(' / %dm%02ds', *opts[:time_taken].divmod(60)) if opts[:time_taken] # rubocop:disable Style/FormatStringToken
       end
 
       def finalize!
         raise SitemapGenerator::SitemapFinalizedError if finalized?
+
         reserve_name if create_index?
         write_first_sitemap
         @frozen = true
@@ -116,7 +124,7 @@ module SitemapGenerator
       # If a link is added manually and create_index is not false, we force index
       # creation because they obviously intend for there to be an index.  False otherwise.
       def create_index?
-        @create_index || @location.create_index == true || @location.create_index == :auto && @link_count > 1
+        @create_index || @location.create_index == true || (@location.create_index == :auto && @link_count > 1)
       end
 
       # Return the index file URL.  If create_index is true, this is the URL
@@ -135,15 +143,15 @@ module SitemapGenerator
 
       # Make sure the first sitemap has been written out and added to the index
       def write_first_sitemap
-        if @first_sitemap
-          @first_sitemap.link.write unless @first_sitemap.link.written?
-          super_add(SitemapGenerator::Builder::SitemapIndexUrl.new(@first_sitemap.link, @first_sitemap.options))
-          @link_count -= 1   # we already counted it, don't count it twice
-          # Store the URL because if create_index is false, this is the
-          # "index" URL
-          @first_sitemap_url = @first_sitemap.link.location.url
-          @first_sitemap = nil
-        end
+        return unless @first_sitemap
+
+        @first_sitemap.link.write unless @first_sitemap.link.written?
+        super_add(SitemapGenerator::Builder::SitemapIndexUrl.new(@first_sitemap.link, @first_sitemap.options))
+        @link_count -= 1 # we already counted it, don't count it twice
+        # Store the URL because if create_index is false, this is the
+        # "index" URL
+        @first_sitemap_url = @first_sitemap.link.location.url
+        @first_sitemap = nil
       end
     end
   end