sitehub 0.5.0.alpha5 → 0.5.0.alpha6

data/spec/sitehub/cookie/rewriting_spec.rb

@@ -0,0 +1,68 @@
+require 'sitehub/cookie/rewriting'
+
+class SiteHub
+  class Cookie
+    describe Rewriting do
+      include_context :module_spec
+
+      let(:downstream_domain) { '.downstream_domain.com' }
+
+      let(:request_mapping) do
+        RequestMapping.new(source_url: 'http://example.org',
+                           mapped_url: "http://#{downstream_domain}",
+                           mapped_path: '/map')
+      end
+
+      let(:substitute_domain) { URI(request_mapping.source_url).host }
+      let(:substitute_path) { '/path' }
+      let(:downstream_response) { Rack::Response.new }
+      let(:downstream_domain_cookie_name) { 'downstream.cookie' }
+
+      before do
+        downstream_response.set_cookie(downstream_domain_cookie_name, domain: downstream_domain, value: 'value')
+        downstream_response.set_cookie('downstream.cookie2', domain: downstream_domain, value: 'value2', httponly: true)
+      end
+
+      describe '#cookies_string_as_hash' do
+        it 'returns the string as a hash' do
+          cookie_header = downstream_response.headers['Set-Cookie']
+
+          cookie_strings = cookie_header.lines
+          first_cookie = SiteHub::Cookie.new(cookie_strings[0])
+          second_cookie = SiteHub::Cookie.new(cookie_strings[1])
+          expected = {
+            first_cookie.name => first_cookie,
+            second_cookie.name => second_cookie
+          }
+          result = subject.cookies_string_as_hash(cookie_header)
+          expect(result).to eq(expected)
+        end
+      end
+
+      describe '#cookies_hash_to_string' do
+        it 'returns the hash as a correctly formatted string' do
+          cookies_hash = subject.cookies_string_as_hash(downstream_response.headers['Set-Cookie'])
+          expect(subject.cookies_hash_to_string(cookies_hash)).to eq(downstream_response.headers['Set-Cookie'])
+        end
+      end
+
+      describe '#rewrite_cookies' do
+        context 'subdomain character present' do
+          it 'substitues the domain for the mapped domain' do
+            downstream_response.set_cookie(downstream_domain_cookie_name, domain: downstream_domain, value: 'value')
+            subject.rewrite_cookies(downstream_response.headers, substitute_domain: substitute_domain)
+            expect(downstream_response.cookies[downstream_domain_cookie_name][:domain]).to eq('.example.org')
+          end
+        end
+
+        context 'subdomain not character present' do
+          it 'substitues the domain for the mapped domain' do
+            downstream_response.set_cookie(downstream_domain_cookie_name, domain: 'downstream.com', value: 'value')
+            subject.rewrite_cookies(downstream_response.headers, substitute_domain: substitute_domain)
+            expect(downstream_response.cookies[downstream_domain_cookie_name][:domain]).to eq('example.org')
+          end
+        end
+      end
+    end
+  end
+end

data/spec/sitehub/core_spec.rb

@@ -38,7 +38,7 @@ class SiteHub
           sitehub_json[:sitehub_cookie_name] = 'custom_name'
 
           expect(core.sitehub_cookie_name).to eq(expected.sitehub_cookie_name)
-          expect(core.routes['/route_1'].sitehub_cookie_name).to eq(expected.sitehub_cookie_name)
+          expect(core.mappings['/route_1'].sitehub_cookie_name).to eq(expected.sitehub_cookie_name)
         end
       end
 
@@ -78,13 +78,13 @@ class SiteHub
 
     describe '#proxy' do
       let(:expected_route) do
-        RouteBuilder.new(sitehub_cookie_name: RECORDED_ROUTES_COOKIE,
-                         mapped_path: '/app')
+        CandidateRoutes.new(sitehub_cookie_name: RECORDED_ROUTES_COOKIE,
+                            mapped_path: '/app')
       end
 
       context 'string as parameters' do
         it 'treats it as the mapped path' do
-          expect_any_instance_of(Middleware::Routes)
+          expect_any_instance_of(Middleware::CandidateRouteMappings)
             .to receive(:add_route)
             .with(url: nil, mapped_path: '/app').and_call_original
           subject.proxy('/app')
@@ -93,7 +93,7 @@ class SiteHub
 
       context 'hash as parameter' do
         it 'treats the key as the mapped path and the value as downstream url' do
-          expect_any_instance_of(Middleware::Routes)
+          expect_any_instance_of(Middleware::CandidateRouteMappings)
             .to receive(:add_route)
             .with(url: :downstream_url, mapped_path: '/app').and_call_original
           subject.proxy('/app' => :downstream_url)
@@ -104,7 +104,7 @@ class SiteHub
         it 'uses the block when creating the proxy' do
           proc = proc {}
 
-          expect_any_instance_of(Middleware::Routes).to receive(:add_route) do |*_args, &block|
+          expect_any_instance_of(Middleware::CandidateRouteMappings).to receive(:add_route) do |*_args, &block|
             expect(block).to be(proc)
           end
 
@@ -123,7 +123,7 @@ class SiteHub
 
         it 'passes the block to the route constructor' do
           expected_route.split url: :endpoint, percentage: 100, label: :label
-          expect(subject.routes['/app'].routes).to eq(expected_route.routes)
+          expect(subject.mappings['/app'].candidates).to eq(expected_route.candidates)
         end
       end
     end

data/spec/sitehub/middleware/{routes_spec.rb → candidate_route_mappings_spec.rb}

@@ -1,8 +1,8 @@
-require 'sitehub/middleware/routes'
+require 'sitehub/middleware/candidate_route_mappings'
 
 class SiteHub
   module Middleware
-    describe Routes do
+    describe CandidateRouteMappings do
       let(:base_url) { 'http://google.com' }
       let(:mapped_path) { '/app' }
       let(:mapped_path) { '/application_url' }
@@ -35,7 +35,7 @@ class SiteHub
         context 'RouteBuilder as parameter' do
           it 'sets it' do
             another_mapping = '/mapping'
-            route = RouteBuilder.new(sitehub_cookie_name: :sitehub_cookie_name, mapped_path: another_mapping)
+            route = CandidateRoutes.new(sitehub_cookie_name: :sitehub_cookie_name, mapped_path: another_mapping)
             subject.add_route route_builder: route
             expect(subject[another_mapping]).to be(route)
           end
@@ -69,7 +69,7 @@ class SiteHub
         context 'mapped_route found' do
           it 'uses the forward proxy' do
             subject
-            expect(forward_proxy_builder.routes[Identifier.new(:current)]).to receive(:call) do
+            expect(forward_proxy_builder.candidates[Identifier.new(:current)]).to receive(:call) do
               [200, {}, []]
             end
             expect(get(mapped_path).status).to eq(200)

data/spec/spec_helper.rb

@@ -3,6 +3,7 @@ require 'rack/test'
 require 'webmock/rspec'
 require 'timecop'
 $LOAD_PATH.unshift("#{__dir__}/..", "#{__dir__}/support")
+require 'async/middleware'
 
 require 'support/shared_contexts'
 require 'support/shared_examples'

data/spec/support/shared_examples/sitehub_json_context.rb

@@ -1,26 +1,62 @@
 shared_context :sitehub_json do
   let(:sitehub_json) do
     {
-      proxies: [proxy_1, proxy_2]
+      proxies: [routes_proxy, split_proxy]
     }
   end
 
-  let(:proxy_1) do
+  let(:routes_proxy) do
     {
       path: '/route_1',
       sitehub_cookie_path: 'route_1_cookie_path',
-      routes: [route_1]
+      routes: [route_1],
+      default: 'route_proxy_default_url'
     }
   end
 
-  let(:proxy_2) do
+  let(:split_proxy) do
     {
-      path: '/route_1',
-      sitehub_cookie_path: 'route_1_cookie_path',
+      path: '/route_2',
+      sitehub_cookie_path: 'route_2_cookie_path',
+      splits: [split_1, split_2],
+      default: 'split_proxy_default_url'
+    }
+  end
+
+  let(:nested_split_proxy) do
+    {
+      path: '/route_3',
+      sitehub_cookie_path: 'route_3_cookie_path',
+      splits: [nested_split],
+      default: 'route_proxy_default_url'
+    }
+  end
+
+  let(:nested_route_proxy) do
+    {
+      path: '/route_3',
+      sitehub_cookie_path: 'route_3_cookie_path',
+      splits: [nested_route],
+      default: 'route_proxy_default_url'
+    }
+  end
+
+  let(:nested_split) do
+    {
+      label: :nested_split_label,
+      percentage: 100,
       splits: [split_1, split_2]
     }
   end
 
+  let(:nested_route) do
+    {
+      label: :nested_route_label,
+      percentage: 100,
+      routes: [route_1]
+    }
+  end
+
   let(:route_1) do
     {
       label: :route_label_1,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sitehub
 version: !ruby/object:Gem::Version
-  version: 0.5.0.alpha5
+  version: 0.5.0.alpha6
 platform: ruby
 authors:
 - Ladtech
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-21 00:00:00.000000000 Z
+date: 2016-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -339,17 +339,20 @@ files:
 - circle.yml
 - lib/sitehub.rb
 - lib/sitehub/builder.rb
+- lib/sitehub/candidate_routes.rb
+- lib/sitehub/candidate_routes/class_methods.rb
 - lib/sitehub/collection.rb
 - lib/sitehub/collection/route_collection.rb
 - lib/sitehub/collection/split_route_collection.rb
 - lib/sitehub/collection/split_route_collection/split.rb
+- lib/sitehub/collection_methods.rb
 - lib/sitehub/constants.rb
 - lib/sitehub/constants/http_header_keys.rb
 - lib/sitehub/constants/rack_http_header_keys.rb
 - lib/sitehub/cookie.rb
 - lib/sitehub/cookie/attribute.rb
 - lib/sitehub/cookie/flag.rb
-- lib/sitehub/cookie_rewriting.rb
+- lib/sitehub/cookie/rewriting.rb
 - lib/sitehub/core.rb
 - lib/sitehub/downstream_client.rb
 - lib/sitehub/equality.rb
@@ -361,6 +364,7 @@ files:
 - lib/sitehub/location_rewriters.rb
 - lib/sitehub/memoize.rb
 - lib/sitehub/middleware.rb
+- lib/sitehub/middleware/candidate_route_mappings.rb
 - lib/sitehub/middleware/config_loader.rb
 - lib/sitehub/middleware/error_handling.rb
 - lib/sitehub/middleware/logging.rb
@@ -372,7 +376,6 @@ files:
 - lib/sitehub/middleware/logging/request_log.rb
 - lib/sitehub/middleware/reverse_proxy.rb
 - lib/sitehub/middleware/route.rb
-- lib/sitehub/middleware/routes.rb
 - lib/sitehub/middleware/transaction_id.rb
 - lib/sitehub/nil_location_rewriter.rb
 - lib/sitehub/nil_route.rb
@@ -380,21 +383,24 @@ files:
 - lib/sitehub/request_mapping.rb
 - lib/sitehub/resolver.rb
 - lib/sitehub/response.rb
-- lib/sitehub/route_builder.rb
 - lib/sitehub/rules.rb
 - lib/sitehub/string_utils.rb
 - lib/sitehub/version.rb
 - mem_usage.txt
 - sitehub.gemspec
 - spec/equality_spec.rb
+- spec/integration/access_logs_spec.rb
+- spec/integration/middleware_spec.rb
+- spec/integration/version_affinity_spec.rb
 - spec/sitehub/builder_spec.rb
+- spec/sitehub/candidate_routes_spec.rb
 - spec/sitehub/collection/route_collection_spec.rb
 - spec/sitehub/collection/split_route_collection/split_spec.rb
 - spec/sitehub/collection/split_route_collection_spec.rb
 - spec/sitehub/collection_spec.rb
 - spec/sitehub/cookie/attribute_spec.rb
 - spec/sitehub/cookie/flag_spec.rb
-- spec/sitehub/cookie_rewriting_spec.rb
+- spec/sitehub/cookie/rewriting_spec.rb
 - spec/sitehub/cookie_spec.rb
 - spec/sitehub/core_spec.rb
 - spec/sitehub/downstream_client_spec.rb
@@ -402,10 +408,10 @@ files:
 - spec/sitehub/forward_proxy_spec.rb
 - spec/sitehub/http_headers_spec.rb
 - spec/sitehub/identifier_spec.rb
-- spec/sitehub/integration_spec.rb
 - spec/sitehub/location_rewriter_spec.rb
 - spec/sitehub/location_rewriters_spec.rb
 - spec/sitehub/memoize_spec.rb
+- spec/sitehub/middleware/candidate_route_mappings_spec.rb
 - spec/sitehub/middleware/config_loader_spec.rb
 - spec/sitehub/middleware/error_handling_spec.rb
 - spec/sitehub/middleware/logging/access_logger_spec.rb
@@ -416,7 +422,6 @@ files:
 - spec/sitehub/middleware/logging/request_log_spec.rb
 - spec/sitehub/middleware/reverse_proxy_spec.rb
 - spec/sitehub/middleware/route_spec.rb
-- spec/sitehub/middleware/routes_spec.rb
 - spec/sitehub/middleware/transaction_id_spec.rb
 - spec/sitehub/middleware_spec.rb
 - spec/sitehub/nil_location_rewriter_spec.rb
@@ -425,7 +430,6 @@ files:
 - spec/sitehub/request_spec.rb
 - spec/sitehub/resolver_spec.rb
 - spec/sitehub/response_spec.rb
-- spec/sitehub/route_builder_spec.rb
 - spec/sitehub_spec.rb
 - spec/spec_helper.rb
 - spec/support/async.rb

data/lib/sitehub/cookie_rewriting.rb

@@ -1,40 +0,0 @@
-require 'sitehub/cookie'
-require 'sitehub/constants'
-class SiteHub
-  # TODO: - change in to object and remove .reek exclusions for UtilityFunction
-  module CookieRewriting
-    ENDING_WITH_NEWLINE = /#{NEW_LINE}$/
-
-    def rewrite_cookies(headers, substitute_domain:)
-      cookies_hash = cookies_string_as_hash(headers[Constants::HttpHeaderKeys::SET_COOKIE])
-
-      cookies_hash.values.each do |cookie|
-        domain_attribute = cookie.find(:domain) || next
-        update_domain(domain_attribute, substitute_domain)
-      end
-      headers[Constants::HttpHeaderKeys::SET_COOKIE] = cookies_hash_to_string(cookies_hash)
-    end
-
-    def update_domain(domain_attribute, substitute_domain)
-      substitute = substitute_domain.dup
-      if domain_attribute.value.start_with?(FULL_STOP)
-        domain_attribute.update(substitute.prepend(FULL_STOP))
-      else
-        domain_attribute.update(substitute)
-      end
-    end
-
-    def cookies_hash_to_string(cookies_hash)
-      cookies_hash.values.inject(EMPTY_STRING.dup) do |cookie_string, cookie|
-        cookie_string << "#{cookie}#{NEW_LINE}"
-      end.sub(ENDING_WITH_NEWLINE, EMPTY_STRING)
-    end
-
-    def cookies_string_as_hash(cookie_string)
-      cookie_string.lines.each_with_object({}) do |cookie_line, cookies|
-        cookie = SiteHub::Cookie.new(cookie_line)
-        cookies[cookie.name] = cookie
-      end
-    end
-  end
-end

data/spec/sitehub/cookie_rewriting_spec.rb

@@ -1,66 +0,0 @@
-require 'sitehub/cookie_rewriting'
-
-class SiteHub
-  describe CookieRewriting do
-    include_context :module_spec
-
-    let(:downstream_domain) { '.downstream_domain.com' }
-
-    let(:request_mapping) do
-      RequestMapping.new(source_url: 'http://example.org',
-                         mapped_url: "http://#{downstream_domain}",
-                         mapped_path: '/map')
-    end
-
-    let(:substitute_domain) { URI(request_mapping.source_url).host }
-    let(:substitute_path) { '/path' }
-    let(:downstream_response) { Rack::Response.new }
-    let(:downstream_domain_cookie_name) { 'downstream.cookie' }
-
-    before do
-      downstream_response.set_cookie(downstream_domain_cookie_name, domain: downstream_domain, value: 'value')
-      downstream_response.set_cookie('downstream.cookie2', domain: downstream_domain, value: 'value2', httponly: true)
-    end
-
-    describe '#cookies_string_as_hash' do
-      it 'returns the string as a hash' do
-        cookie_header = downstream_response.headers['Set-Cookie']
-
-        cookie_strings = cookie_header.lines
-        first_cookie = SiteHub::Cookie.new(cookie_strings[0])
-        second_cookie = SiteHub::Cookie.new(cookie_strings[1])
-        expected = {
-          first_cookie.name => first_cookie,
-          second_cookie.name => second_cookie
-        }
-        result = subject.cookies_string_as_hash(cookie_header)
-        expect(result).to eq(expected)
-      end
-    end
-
-    describe '#cookies_hash_to_string' do
-      it 'returns the hash as a correctly formatted string' do
-        cookies_hash = subject.cookies_string_as_hash(downstream_response.headers['Set-Cookie'])
-        expect(subject.cookies_hash_to_string(cookies_hash)).to eq(downstream_response.headers['Set-Cookie'])
-      end
-    end
-
-    describe '#rewrite_cookies' do
-      context 'subdomain character present' do
-        it 'substitues the domain for the mapped domain' do
-          downstream_response.set_cookie(downstream_domain_cookie_name, domain: downstream_domain, value: 'value')
-          subject.rewrite_cookies(downstream_response.headers, substitute_domain: substitute_domain)
-          expect(downstream_response.cookies[downstream_domain_cookie_name][:domain]).to eq('.example.org')
-        end
-      end
-
-      context 'subdomain not character present' do
-        it 'substitues the domain for the mapped domain' do
-          downstream_response.set_cookie(downstream_domain_cookie_name, domain: 'downstream.com', value: 'value')
-          subject.rewrite_cookies(downstream_response.headers, substitute_domain: substitute_domain)
-          expect(downstream_response.cookies[downstream_domain_cookie_name][:domain]).to eq('example.org')
-        end
-      end
-    end
-  end
-end

data/spec/sitehub/integration_spec.rb

@@ -1,197 +0,0 @@
-require 'async/middleware'
-require 'stringio'
-shared_context :site_hub do
-  let(:downstream_url) { 'http://localhost:12345' }
-  let(:experiment1_url) { "#{downstream_url}/experiment1" }
-  let(:experiment2_url) { "#{downstream_url}/experiment2" }
-
-  before do
-    WebMock.enable!
-    stub_request(:get, experiment1_url).to_return(body: 'experiment1_body')
-    stub_request(:get, experiment2_url).to_return(body: 'experiment2_body')
-  end
-
-  let(:builder) do
-    SiteHub::Builder.new.tap do |builder|
-      builder.access_logger StringIO.new
-      builder.error_logger StringIO.new
-      experiment1_url = experiment1_url()
-      experiment2_url = experiment2_url()
-
-      builder.proxy '/endpoint' do
-        split(label: :experiment1, percentage: 100) do
-          split percentage: 100, label: 'variant1', url: experiment1_url
-        end
-
-        split(label: :experiment2, percentage: 0) do
-          split percentage: 0, label: 'variant1', url: experiment2_url
-          split percentage: 100, label: 'variant2', url: experiment2_url
-        end
-      end
-    end
-  end
-
-  let(:rack_application) do
-    builder.build
-  end
-end
-
-describe 'proxying calls' do
-  include_context :site_hub
-
-  let(:app) { Async::Middleware.new(rack_application) }
-  describe 'supported HTTP verbs' do
-    %i(get post put delete).each do |verb|
-      it 'forwards the downstream' do
-        stub_request(verb, experiment1_url).to_return(body: 'hello')
-        send(verb, '/endpoint')
-        expect(app.last_response.body).to eq(['hello'])
-      end
-    end
-  end
-
-  describe 'route affinity' do
-    context 'requested route cookie not present' do
-      it 'drops a cookie to keep you on the same path' do
-        get('/endpoint')
-        expect(app.last_response.cookies[SiteHub::RECORDED_ROUTES_COOKIE][:value]).to eq('experiment1|variant1')
-      end
-    end
-
-    context 'requested route cookie present' do
-      it 'proxies to the preselected route' do
-        get('/endpoint', {}, 'HTTP_COOKIE' => "#{SiteHub::RECORDED_ROUTES_COOKIE}=experiment2|variant1")
-        expect(app.last_response.body).to eq(['experiment2_body'])
-
-        expect(app.last_response.cookies[SiteHub::RECORDED_ROUTES_COOKIE][:value]).to eq('experiment2|variant1')
-      end
-    end
-  end
-
-  # describe 'middleware' do
-  #
-  #   include_context :middleware_test
-  #
-  #   let(:app) { Async::Middleware.new(rack_application) }
-  #
-  #   def middleware name
-  #     create_middleware.tap do |clazz|
-  #       clazz.class_eval do
-  #         define_method :call do |env|
-  #
-  #           callback = env['async.callback'] || env['async.orig_callback']
-  #           env['async.orig_callback'] = env['async.callback'] = proc do |status, headers, body|
-  #             body = body.body.join if body.is_a?(Rack::BodyProxy)
-  #
-  #             callback.call(status, headers, "#{name}, #{body}")
-  #           end
-  #           @app.call(env)
-  #         end
-  #       end
-  #     end
-  #   end
-  #
-  #   before do
-  #     stub_request(:get, downstream_url).to_return(body: 'hello')
-  #   end
-  #
-  #   context 'middleware added to top level' do
-  #     let(:builder) do
-  #       middleware = middleware(:middleware1)
-  #       downstream_url = downstream_url()
-  #
-  #       SiteHub::Builder.new do
-  #         access_logger StringIO.new
-  #         use middleware
-  #         proxy '/1' => downstream_url
-  #         proxy '/2' => downstream_url
-  #       end
-  #     end
-  #
-  #     it 'adds it to each route' do
-  #       get('/1')
-  #       expect(app.last_response.body.join).to eq('middleware1, hello')
-  #       get('/2')
-  #       expect(app.last_response.body.join).to eq('middleware1, hello')
-  #     end
-  #   end
-  #
-  #   context 'middleware added to specific route' do
-  #     let(:builder) do
-  #       middleware = middleware(:middleware1)
-  #       downstream_url = downstream_url()
-  #
-  #       SiteHub::Builder.new do
-  #         access_logger StringIO.new
-  #         proxy '/1' do
-  #           use middleware
-  #           route label: :with_middleware, url: downstream_url
-  #         end
-  #         proxy '/2' => downstream_url
-  #       end
-  #     end
-  #
-  #     it 'adds it to that route only' do
-  #       get('/1')
-  #       expect(app.last_response.body.join).to eq('middleware1, hello')
-  #       get('/2')
-  #       expect(app.last_response.body.join).to eq('hello')
-  #     end
-  #   end
-  #
-  #   context 'base inherited middleware' do
-  #     let(:builder) do
-  #       middleware1 = middleware(:middleware1)
-  #       middleware2 = middleware(:middleware2)
-  #       downstream_url = downstream_url()
-  #
-  #       SiteHub::Builder.new do
-  #         access_logger StringIO.new
-  #         use middleware1
-  #         proxy '/1' do
-  #           use middleware2
-  #           route label: :with_middleware, url: downstream_url
-  #         end
-  #         proxy '/2' => downstream_url
-  #       end
-  #     end
-  #
-  #     it 'adds it to that route only' do
-  #       get('/1')
-  #       expect(app.last_response.body.join).to eq('middleware1, middleware2, hello')
-  #       get('/2')
-  #       expect(app.last_response.body.join).to eq('middleware1, hello')
-  #     end
-  #   end
-  #
-  #   context 'nested inherited middleware' do
-  #     let(:builder) do
-  #       middleware1 = middleware(:middleware1)
-  #       middleware2 = middleware(:middleware2)
-  #       downstream_url = downstream_url()
-  #
-  #       SiteHub::Builder.new do
-  #         access_logger StringIO.new
-  #
-  #         proxy '/1' do
-  #           split percentage: 100, label: :experiment1 do
-  #             use middleware1
-  #             split percentage: 100, label: :with_middleware do
-  #               use middleware2
-  #               split percentage: 100, label: :with_nested_middleware, url: downstream_url
-  #             end
-  #           end
-  #         end
-  #         proxy '/2' => downstream_url
-  #       end
-  #     end
-  #
-  #     it 'adds it to that route only' do
-  #       get('/1')
-  #       expect(app.last_response.body.join).to eq('middleware1, middleware2,  hello')
-  #       get('/2')
-  #       expect(app.last_response.body.join).to eq('middleware1, hello')
-  #     end
-  #   end
-  # end
-end