site_prism.vcr 0.0.1 → 0.1.0

data/spec/unit/dsl/adjuster_spec.rb

@@ -1,10 +1,22 @@
 require 'spec_helper'
 
 describe SPV::DSL::Adjuster do
-  let(:raw_fixtures)     { 'some fixtures' }
-  let(:fixtures)         { double }
-  let(:tmp_keeper)       { double(fixtures: raw_fixtures, clean_fixtures: true) }
-  let(:options)          { double(waiter: :wait_for_me) }
+  let(:raw_fixtures) { 'some fixtures' }
+  let(:fixtures)     { instance_double('SPV::Fixtures', exchange: true) }
+  let(:tmp_keeper)   {
+    instance_double(
+      'SPV::Fixtures::TmpKeeper',
+      {fixtures: raw_fixtures, clean_fixtures: true}
+    )
+  }
+
+  let(:options) {
+    instance_double(
+      'SPV::Options',
+      waiter:                :wait_for_me,
+      merge_waiter_options!: nil
+    )
+  }
 
   before do
     SPV::Fixtures::TmpKeeper.stub(:new).and_return(tmp_keeper)
@@ -12,55 +24,50 @@ describe SPV::DSL::Adjuster do
 
   subject { described_class.new(options, fixtures) }
 
-  describe '#replace' do
-    let(:replaced_fixtures) { 'replaced fixtures' }
+  describe '#prepare_fixtures' do
+    context 'when the replace action is defined' do
+      let(:replaced_fixtures) { 'replaced fixtures' }
 
-    before do
-      fixtures.stub(:replace).and_return(replaced_fixtures)
-    end
-
-    it 'replaces fixtures' do
-      expect(fixtures).to receive(:replace).with(raw_fixtures)
-
-      subject.replace
-    end
+      before do
+        fixtures.stub(:replace).and_return(replaced_fixtures)
 
-    it 'cleans fixtures being kept in the fixtures handler' do
-      expect(tmp_keeper).to receive(:clean_fixtures)
+        subject.replace
+      end
 
-      subject.replace
-    end
+      it 'replaces fixtures' do
+        expect(fixtures).to receive(:replace).with(raw_fixtures)
 
-    it 'returns a new container with fixtures' do
-      subject.replace
+        subject.prepare_fixtures
+      end
 
-      expect(subject.prepared_fixtures).to eq(replaced_fixtures)
+      it 'returns a new container with fixtures' do
+        expect(subject.prepare_fixtures).to eq(replaced_fixtures)
+      end
     end
-  end
-
-  describe '#union' do
-    let(:new_fixtures) { 'new fixtures' }
 
-    before do
-      fixtures.stub(:union).and_return(new_fixtures)
-    end
+    context 'when the union action is defined' do
+      let(:new_fixtures) { 'new fixtures' }
 
-    it 'replaces fixtures' do
-      expect(fixtures).to receive(:union).with(raw_fixtures)
+      before do
+        fixtures.stub(:union).and_return(new_fixtures)
+        subject.union
+      end
 
-      subject.union
-    end
+      it 'joins fixtures' do
+        expect(fixtures).to receive(:union).with(raw_fixtures)
 
-    it 'cleans fixtures being kept in the fixtures handler' do
-      expect(tmp_keeper).to receive(:clean_fixtures)
+        subject.prepare_fixtures
+      end
 
-      subject.union
+      it 'returns a new container with fixtures' do
+        expect(subject.prepare_fixtures).to eq(new_fixtures)
+      end
     end
 
-    it 'returns a new container with fixtures' do
-      subject.union
+    it 'the replace action is used as a default' do
+      expect(fixtures).to receive(:replace).with(raw_fixtures)
 
-      expect(subject.prepared_fixtures).to eq(new_fixtures)
+      subject.prepare_fixtures
     end
   end
 
@@ -84,9 +91,8 @@ describe SPV::DSL::Adjuster do
       end
     end
 
-    let(:fixtures)           { double(exchange: true) }
-    let(:fixtures_handler)   { double }
-    let(:home_path_modifier) { double(modify: true) }
+    let(:fixtures_handler)   { instance_double('SPV::Fixtures::Handler') }
+    let(:home_path_modifier) { double('home path modifier') }
 
     let(:raw_old_fixtures) { ['old fixtures'] }
     let(:raw_new_fixtures) { ['new fixtures'] }
@@ -94,11 +100,8 @@ describe SPV::DSL::Adjuster do
     let(:expected_raw_old_fixtures) { raw_old_fixtures }
     let(:expected_raw_new_fixtures) { raw_new_fixtures }
 
-    let(:old_fixture) { double }
-    let(:new_fixture) { double }
-
-    let(:handled_old_fixtures) { [old_fixture] }
-    let(:handled_new_fixtures) { [new_fixture] }
+    let(:handled_old_fixtures) { ['old fixture'] }
+    let(:handled_new_fixtures) { ['old fixture'] }
 
     before do
       SPV::Fixtures::Handler.stub(:new).and_return(fixtures_handler)
@@ -138,4 +141,12 @@ describe SPV::DSL::Adjuster do
       exchange
     end
   end
+
+  describe '#waiter_options' do
+    it 'merges default waiter options with a given' do
+      expect(options).to receive(:merge_waiter_options!).with(my: 'options')
+
+      subject.waiter_options(my: 'options')
+    end
+  end
 end

data/spec/unit/dsl/initial_adjuster_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 
 describe SPV::DSL::InitialAdjuster do
-  let(:options)          { double }
-  let(:tmp_keeper)       { double(add_fixtures: true) }
-  let(:handled_fixtures) { double }
-  let(:fixtures_handler) { double(handle_raw: handled_fixtures) }
+  let(:options)          { instance_double('SPV::Options') }
+  let(:tmp_keeper)       { instance_double('SPV::Fixtures::TmpKeeper', add_fixtures: true) }
+  let(:handled_fixtures) { 'handled fixtures' }
+  let(:fixtures_handler) { instance_double('SPV::Fixtures::Handler', handle_raw: handled_fixtures) }
 
   subject { described_class.new(options) }
 
@@ -29,7 +29,7 @@ describe SPV::DSL::InitialAdjuster do
 
   describe '#fixtures' do
     let(:raw_fixtures)       { 'some fixtures' }
-    let(:home_path_modifier) { 'some home path modifier' }
+    let(:home_path_modifier) { double('home path modifier') }
 
     before do
       SPV::Fixtures::Modifiers::HomePath.stub(:new).and_return(home_path_modifier)
@@ -73,10 +73,10 @@ describe SPV::DSL::InitialAdjuster do
     end
 
     let(:raw_fixtures)       { 'some raw fixtures' }
-    let(:options_with_path)  { double('path=' => true) }
+    let(:options_with_path)  { instance_double('SPV::OptionsWithPath', 'path=' => true) }
 
-    let(:path_modifier)       { double }
-    let(:home_path_modifier)  { double }
+    let(:path_modifier)      { double('path modifier') }
+    let(:home_path_modifier) { double('home path modifier') }
 
     before do
       SPV::OptionsWithPath.stub(:new).and_return(options_with_path)
@@ -132,7 +132,13 @@ describe SPV::DSL::InitialAdjuster do
   end
 
   describe '#waiter' do
-    let(:options) { double('waiter='.to_sym => true, 'waiter_options='.to_sym => true) }
+    let(:options) {
+      instance_double(
+        'SPV::Options',
+        'waiter='.to_sym         => true,
+        'waiter_options='.to_sym => true
+      )
+    }
 
     it 'defines a new waiter' do
       expect(options).to receive(:waiter=).with(kind_of(Proc))
@@ -147,8 +153,8 @@ describe SPV::DSL::InitialAdjuster do
     end
   end
 
-  describe '#prepared_fixtures' do
-    let(:fixtures)     { double }
+  describe '#prepare_fixtures' do
+    let(:fixtures)     { double('fixtures') }
     let(:raw_fixtures) { 'some raw fixtures' }
 
     before do
@@ -160,7 +166,7 @@ describe SPV::DSL::InitialAdjuster do
     it 'initializes the fixtures handler' do
       expect(SPV::Fixtures).to receive(:new).with(raw_fixtures).and_return(fixtures)
 
-      expect(subject.prepared_fixtures).to eq(fixtures)
+      expect(subject.prepare_fixtures).to eq(fixtures)
     end
   end
 end

data/spec/unit/element_spec.rb

@@ -1,9 +1,9 @@
 require 'spec_helper'
 
 describe SPV::Element do
-  let(:node)    { stub   }
-  let(:parent)  { double }
-  let(:applier) { double(apply: true) }
+  let(:node)    { double('node of DOM') }
+  let(:parent)  { double('parent element') }
+  let(:applier) { instance_double('SPV::Applier', apply_vcr: true) }
 
   before do
     SPV::Applier.stub(:new).and_return(applier)
@@ -26,22 +26,20 @@ describe SPV::Element do
 
     before do
       subject.stub(:click)
+      subject.stub(:shift_event).and_yield.and_return(applier)
     end
 
-    it 'applies custom fixtures' do
-      expect(applier).to receive(:apply).with(
-        kind_of(Proc)
-      )
+    it 'shifts a click event to the applier' do
+      expect(subject).to receive(:shift_event).and_yield.and_return(applier)
+      expect(subject).to receive(:click)
 
-      subject.click_and_apply_vcr() {}
+      subject.click_and_apply_vcr
     end
 
-    it 'clicks on an element' do
-      applier.stub(:apply).and_yield
-
-      expect(subject).to receive(:click)
+    it 'applies vcr' do
+      expect(applier).to receive(:apply_vcr)
 
       subject.click_and_apply_vcr
     end
   end
-end
+end

data/spec/unit/fixtures/handler_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe SPV::Fixtures::Handler do
-  let(:options)            { double }
+  let(:options)            { instance_double('SPV::Options') }
   let(:converted_fixtures) { [] }
   let(:fixtures_converter) { SPV::Fixtures::Converter }
 
@@ -19,7 +19,12 @@ describe SPV::Fixtures::Handler do
     let(:raw_fixtures)       { 'some raw fixtures' }
     let(:converted_fixture)  { 'converted fixture' }
     let(:converted_fixtures) { [converted_fixture] }
-    let(:modifier)           { double(modify: true) }
+    let(:modifier)           do
+      instance_double(
+        'SPV::Fixtures::Modifiers::HomePath',
+        modify: true
+      )
+    end
 
     it 'converts raw fixtures' do
       expect(fixtures_converter).to receive(:convert_raw).with(raw_fixtures)

data/spec/unit/fixtures/manager_spec.rb

@@ -1,12 +1,28 @@
 require 'spec_helper'
 
 describe SPV::Fixtures::Manager do
-  let(:options) { double(fixtures: ['some fixture']) }
+  let(:options) { instance_double('SPV::Options', fixtures: ['some fixture']) }
 
   describe '#inject' do
-    let(:fixture1)    { double(name: 'arya_stark', options: {erb: {testvar: true}}) }
-    let(:fixture2)    { double(name: 'jon_snow', options: {}) }
-    let(:fixtures)    { [fixture1, fixture2] }
+    let(:fixture1) do
+      instance_double(
+        'SPV::Fixture',
+        name: 'arya_stark',
+        options: {erb: {testvar: true}}
+      )
+    end
+
+    let(:fixture2) do
+      instance_double(
+        'SPV::Fixture',
+        name: 'jon_snow',
+        options: {}
+      )
+    end
+
+    let(:fixtures) do
+      [fixture1, fixture2]
+    end
 
     subject(:manager) { described_class.new(options) }
 

data/spec/unit/fixtures/modifiers/home_path_spec.rb

@@ -3,8 +3,14 @@ require 'spec_helper'
 describe SPV::Fixtures::Modifiers::HomePath do
   describe '#modify' do
     let(:path)    { 'some home path' }
-    let(:options) { double(home_path: path) }
-    let(:fixture) { double(name: 'test_with_home_path', :has_link_to_home_path? => true) }
+    let(:options) { instance_double('SPV::Options', home_path: path) }
+    let(:fixture) do
+      instance_double(
+        'SPV::Fixture',
+        name: 'test_with_home_path',
+        :has_link_to_home_path? => true
+      )
+    end
 
     subject { described_class.new(options).modify(fixture) }
 
@@ -35,7 +41,12 @@ describe SPV::Fixtures::Modifiers::HomePath do
     end
 
     context 'when a name of the fixture has no link to the home path' do
-      let(:fixture) { double(:has_link_to_home_path? => false) }
+      let(:fixture) do
+        instance_double(
+          'SPV::Fixture',
+          :has_link_to_home_path? => false
+        )
+      end
 
       it 'does not set any home path' do
         expect(fixture).to_not receive(:set_home_path)

data/spec/unit/fixtures/modifiers/path_spec.rb

@@ -3,8 +3,8 @@ require 'spec_helper'
 describe SPV::Fixtures::Modifiers::Path do
   describe '#modify' do
     let(:path)    { 'some path' }
-    let(:options) { double(path: path) }
-    let(:fixture) { double(:has_link_to_home_path? => false) }
+    let(:options) { instance_double('SPV::Options', path: path) }
+    let(:fixture) { instance_double('SPV::Fixture', :has_link_to_home_path? => false) }
 
     subject { described_class.new(options).modify(fixture) }
 
@@ -27,7 +27,13 @@ describe SPV::Fixtures::Modifiers::Path do
     end
 
     context 'when the fixture has a link to the home path' do
-      let(:fixture) { double(:has_link_to_home_path? => true, clean_name: 'Max') }
+      let(:fixture) do
+        instance_double(
+          'SPV::Fixture',
+          :has_link_to_home_path? => true,
+          clean_name: 'Max'
+        )
+      end
 
       it 'raises an error about link to the home path' do
         expect{

data/spec/unit/fixtures/tmp_keeper_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe SPV::Fixtures::TmpKeeper do
-  let(:options)    { double }
+  let(:options)    { instance_double('SPV::Options') }
   let(:tmp_keeper) { described_class.new(options) }
 
   describe '#add_fixtures' do

data/spec/unit/fixtures_spec.rb

@@ -1,11 +1,11 @@
 require 'spec_helper'
 
 describe SPV::Fixtures do
-  let(:fixture1) { double(name: 'fixture1') }
-  let(:fixture2) { double(name: 'fixture2') }
-  let(:fixture3) { double(name: 'fixture3') }
-  let(:fixture4) { double(name: 'fixture4') }
-  let(:fixture5) { double(name: 'fixture5') }
+  let(:fixture1) { instance_double('SPV::Fixture', name: 'fixture1') }
+  let(:fixture2) { instance_double('SPV::Fixture', name: 'fixture2') }
+  let(:fixture3) { instance_double('SPV::Fixture', name: 'fixture3') }
+  let(:fixture4) { instance_double('SPV::Fixture', name: 'fixture4') }
+  let(:fixture5) { instance_double('SPV::Fixture', name: 'fixture5') }
 
   subject(:fixtures) { described_class.new([fixture1, fixture2, fixture3]) }
 

data/spec/unit/options_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe SPV::Options do
-  let(:options) { described_class.new }
+  subject(:options) { described_class.new }
 
   describe '.new' do
     it 'holds the passed options' do
@@ -38,4 +38,38 @@ describe SPV::Options do
       expect(cloned_options.object_id).to_not eq(options.object_id)
     end
   end
+
+  describe '#waiter_options' do
+    context 'when options are not defined' do
+      it 'returns an empty hash' do
+        expect(options.waiter_options).to be_a(Hash)
+      end
+    end
+
+    context 'when options are defined' do
+      it 'returns it' do
+        expected = {eject_fixtures: false}
+
+        subject.waiter_options = expected
+
+        expect(subject.waiter_options).to eq(expected)
+      end
+    end
+  end
+
+  describe '#merge_waiter_options!' do
+    it 'redefines default options' do
+      subject.waiter_options = {
+        eject_fixtures:      false,
+        some_another_option: true
+      }
+
+      subject.merge_waiter_options!(eject_fixtures: true)
+
+      expect(options.waiter_options).to include(
+        eject_fixtures:      true,
+        some_another_option: true
+      )
+    end
+  end
 end

data/spec/unit/patches/element_container_spec.rb

@@ -7,38 +7,51 @@ class TestPageWithElement
     def element(*); end
   end
 
-  def el_with_options
-    'original element with options'
+  def test_el1; end
+  def test_el2
+    'original element'
   end
 
-  def test_el; end
-
-  element_with_vcr(:el_with_options, '#selector', fixtures: 'some fixtures') {}
+  link_vcr_with_element :test_el2
 end
 
 describe SitePrism::ElementContainer do
   describe '.element_with_vcr' do
+    subject do
+      TestPageWithElement.instance_eval do
+        element_with_vcr :test_el1, '#test_selector', visible: false
+      end
+    end
+
     it 'calls the original element method with given arguments' do
       expect(TestPageWithElement).to receive(:element).with(
-        :test_el,
+        :test_el1,
         '#test_selector',
         visible: false
       )
 
-      TestPageWithElement.instance_eval do
-        element_with_vcr :test_el, '#test_selector', visible: false
-      end
+      subject
+    end
+
+    it 'links vcr with an element' do
+      expect(TestPageWithElement).to receive(:link_vcr_with_element).with(
+        :test_el1
+      )
+
+      subject
     end
+  end
 
+  describe '.link_vcr_with_element' do
     context 'when a method for getting an element is called' do
       let(:page)   { TestPageWithElement.new }
       let(:vcr_el) { 'vcr element' }
 
-      subject { page.el_with_options }
+      subject { page.test_el2 }
 
-      it 'initializes a new instance of an element with empty options' do
+      it 'initializes a new instance of an element' do
         expect(SPV::Element).to receive(:new).with(
-          'original element with options', page
+          'original element', page
         ).and_return(vcr_el)
 
         expect(subject).to eq(vcr_el)

data/spec/unit/patches/page_spec.rb

@@ -3,55 +3,48 @@ require 'spec_helper'
 describe SitePrism::Page do
   subject { SitePrism::Page.new }
 
-  describe '#apply_vcr' do
-    let(:applier)      { double(apply: true) }
-    let(:action_block) { double(call: true) }
+  let(:applier) do
+    instance_double(
+      'SPV::Applier',
+      apply_vcr: true
+    )
+  end
 
-    before do
-      SitePrism::Page.vcr_options_for_load { }
+  before do
+    SitePrism::Page.vcr_options_for_load { }
+  end
 
+  describe '.new' do
+    before do
       SPV::Applier.stub(:new).and_return(applier)
     end
 
     it 'initializes the fixtures applier' do
       expect(SPV::Applier).to receive(:new).with(
-        subject
-      ).and_return(applier)
-
-      subject.apply_vcr(action_block)
-    end
-
-    it 'applies fixtures' do
-      expect(applier).to receive(:apply).with(
-        kind_of(Proc)
+        kind_of(described_class)
       )
 
-      subject.apply_vcr(action_block) { }
-    end
-
-    it 'does the action from the action block' do
-      applier.stub(:apply).and_yield
-
-      expect(action_block).to receive(:call)
-
-      subject.apply_vcr('arg1', 'arg2', action_block) { }
+      subject
     end
   end
 
   describe '#load_and_apply_vcr' do
     before do
-      subject.stub(:apply_vcr)
       subject.stub(:load)
+      subject.stub(:shift_event).and_yield.and_return(applier)
     end
 
-    it 'applies vcr fixtures and loads the page' do
-      expect(subject).to receive(:apply_vcr) do |action_block|
-        expect(subject).to receive(:load).with('arg1', 'arg2')
+    it 'shifts a load event to the applier' do
+      expect(subject).to receive(:shift_event).and_yield.and_return(applier)
+      expect(subject).to receive(:load).with('some arguments')
+
+      subject.load_and_apply_vcr('some arguments')
+    end
 
-        action_block.call
-      end
+    it 'applies vcr' do
+      expect(applier).to receive(:apply_vcr)
 
-      subject.load_and_apply_vcr('arg1', 'arg2') { }
+      subject.load_and_apply_vcr
     end
   end
 end

data/spec/unit/waiter_spec.rb

@@ -1,15 +1,27 @@
 require 'spec_helper'
 
 describe SPV::Waiter do
-  let(:node)             { double }
-  let(:options)          { double(waiter_options: nil, waiter: nil) }
-  let(:fixtures_manager) { double(eject: true) }
+  let(:node)    { double('node of DOM') }
+  let(:options) {
+    instance_double(
+      'SPV::Options',
+      waiter_options: nil,
+      waiter: nil
+    )
+  }
+
+  let(:fixtures_manager) {
+    instance_double(
+      'SPV::Fixtures::Manager',
+      eject: true
+    )
+  }
 
   subject(:waiter)       { described_class.new(node, fixtures_manager, options) }
 
   describe '#wait' do
     context 'when a waiter is defined' do
-      let(:node) { double(wait_for_content: true) }
+      let(:node) { double('node of DOM', wait_for_content: true) }
 
       before do
         options.stub(:waiter).and_return(proc { self.wait_for_content })