site_prism-all_there 3.0 → 3.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3508b03f4e5a02c0dd04ec670549bd2462b9c749de74373747ced1c10d2b1e5d
-  data.tar.gz: 198324b39aa2eb29bb622028e383446043dbd9f8352f545d78e3dd0f35dfc26f
+  metadata.gz: 14a223d06f824b7e67e41ee0bf0a8a6b31debabb74eff816c2c86fe8d3bd1fc3
+  data.tar.gz: e9dc0cccbb0acbbb5e720bfa1c2ee3326af5b0beabb8b99ccf36e0d1f55fc2bb
 SHA512:
-  metadata.gz: 1bf75250e248cb6b07c69d88bf7742e79eb31bf6a8d8565d58587dfe93994bbcb292077182035c9d233b2c8e502bf366106003263d3e835120e3ee444f5e0d93
-  data.tar.gz: 4a92b0b0d433de1717634d3dcb32ebadce9ce492dfc69cd8efa9f00cf0c65d505615555400d731a323b0a7a2df567755847ba8f5426f1de58b4604124f12d104
+  metadata.gz: ad296627b3e2d735950b457d0a5e9065f575020a6fb0059137a977be69776504e8429b30821dd96e882ee5415549fbe99db88e6550e1ad9b5d66b928a1b5a47c
+  data.tar.gz: a87debaa8ffa1cd44722f76b1a36bdc8fda68a6fd4465a7089909b050f88e443d9af2c42111ab5dc4885042dfdcd7c6157f93244fe6d52af27770fb8216b8a50

data/README.md

@@ -2,26 +2,29 @@
 - [History](#history)
 - [Enabling gem methods](#enabling-gem-methods)
 - [Usage](#usage)
-  - [In-line configuration](#in-line-configuration)
-  - [Global configuration](#global-configuration)
-- [Troubleshooting](#troubleshooting)
+  - [In-line parameter](#in-line-parameter)
+  - [Global setting](#global-setting)
 
 ## History
 
 This in the breakout gem from SitePrism to perform recursion checks for `#all_there?`
 
 This gem is a breakout of the current `SitePrism::Page#all_there?` and `SitePrism::Section#all_there?`
-methods which have already existed in the gem since version 2
+methods which have existed in site_prism since v2
 
-The gem is **now finally** version stable. It is now default functionality in `site_prism` version 4
+The gem is version stable. It is default functionality in `site_prism` v4 and above
 
 ## Enabling gem methods
 
-The gem methods are now (by default), enabled with `site_prism` version 4 and above
+The gem methods are enabled by default. No configuration is required!
 
 ## Usage
 
-### In-line configuration
+You can configure the recursion either using an in-line parameter named `recursion` or using a global setting
+
+When using both it will always look for the in-line parameter **first**
+
+### In-line parameter
 
 ```rb
 your_page = YourPage.new
@@ -31,12 +34,12 @@ your_page.all_there?(recursion: :one)      # This will do the standard `#all_the
 your_page.all_there?(recursion: :invalid)  # This will not perform any checks and just log an error
 ```
 
-### Global configuration
+### Global setting
 
 ```rb
 SitePrism.recursion_setting = :one
 your_page = YourPage.new
-your_page.all_there?(recursion: :ignore) # This will do the standard `#all_there?` check on the current page as well recursing into all `:section` or `:sections` objects and then doing the standard `#all_there?` check on those sections
+your_page.all_there? # This will do the standard `#all_there?` check on the current page as well recursive checks on all `:section` or `:sections` objects -> doing the standard `#all_there?` check on those `SitePrism::Section` instances
 
 # or...
 
@@ -45,15 +48,5 @@ SitePrism.configure do |config|
 end
 
 your_page = YourPage.new
-your_page.all_there?(recursion: :ignore) # This will do the standard `#all_there?` check on the current page as well recursing into all `:section` or `:sections` objects and then doing the standard `#all_there?` check on those `Section` instances
+your_page.all_there? # This will do the standard `#all_there?` check on the current page as well recursive checks on all `:section` or `:sections` objects -> doing the standard `#all_there?` check on those `SitePrism::Section` instances
 ```
-
-Then you can perform the above checks using the global config.
-
-## Troubleshooting
-
-**Mixing and matching the global config won't work - To come in v3!**
-
-Happy Testing / Developing!
-
-The SitePrism team

data/lib/site_prism/all_there/recursion_checker.rb

@@ -23,11 +23,11 @@ module SitePrism
 
         case setting
         when nil, :none
-          current_class_all_there?(options)
+          current_class_all_there?(**options)
         when :one
-          current_class_all_there?(options) && section_classes_all_there?(options) && sections_classes_all_there?(options)
+          current_class_all_there?(**options) && section_classes_all_there?(**options) && sections_classes_all_there?(**options)
         else
-          SitePrism.logger.debug("Invalid input value '#{recursion}'. Valid values are nil, :none or :one.")
+          SitePrism.logger.debug("Invalid input value '#{recursion}'. Valid values are 'nil', ':none' or ':one'.")
           SitePrism.logger.error('Invalid recursion setting, Will not run #all_there?.')
         end
       end
@@ -35,19 +35,19 @@ module SitePrism
       private
 
       def current_class_all_there?(**opts)
-        expected_items.array.flatten.all? { |name| there?(name, opts) }.tap do |result|
-          SitePrism.logger.info("Result of current_class_all_there?: #{result}")
+        expected_items.array.flatten.all? { |name| there?(name, **opts) }.tap do |result|
+          SitePrism.logger.debug("Result of current_class_all_there?: #{result}")
         end
       end
 
       def section_classes_all_there?(**opts)
-        section_classes_to_check.all? { |section| section.all_there?(opts) }.tap do |result|
+        section_classes_to_check.all? { |section| section.all_there?(**opts) }.tap do |result|
           SitePrism.logger.debug("Result of section_classes_all_there?: #{result}")
         end
       end
 
       def sections_classes_all_there?(**opts)
-        sections_classes_to_check.flatten.all? { |section| section.all_there?(opts) }.tap do |result|
+        sections_classes_to_check.flatten.all? { |section| section.all_there?(**opts) }.tap do |result|
           SitePrism.logger.debug("Result of sections_classes_all_there?: #{result}")
         end
       end
@@ -65,7 +65,7 @@ module SitePrism
       end
 
       def there?(name, **opts)
-        instance.send("has_#{name}?", opts)
+        instance.send("has_#{name}?", **opts)
       end
     end
   end

data/lib/site_prism/all_there/version.rb

@@ -4,6 +4,6 @@ module SitePrism
   module AllThere
     # @return [String]
     # Version of the gem
-    VERSION = '3.0'
+    VERSION = '3.0.2'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: site_prism-all_there
 version: !ruby/object:Gem::Version
-  version: '3.0'
+  version: 3.0.2
 platform: ruby
 authors:
 - Luke Hill
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-08-23 00:00:00.000000000 Z
+date: 2023-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -30,56 +30,62 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.50.2
+        version: 1.57.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.50.2
+        version: 1.57.2
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.17.1
+        version: 1.19.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.17.1
+        version: 1.19.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.20.0
+        version: 2.25.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.20.0
+        version: 2.25.0
 - !ruby/object:Gem::Dependency
   name: site_prism
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
+      - !ruby/object:Gem::Version
+        version: '4'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
+      - !ruby/object:Gem::Version
+        version: '4'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '6'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -132,8 +138,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.2.3
 signing_key: 
 specification_version: 4
-summary: An extension to allow you to recurse through your SitePrism Pages/Sections
+summary: A SitePrism extension that allows you to recurse through your SitePrism Pages
+  or Sections
 test_files: []