site-inspector 3.2.0 → 4.0.0

data/package.json

@@ -4,7 +4,8 @@
   "description": "Returns information about a domain's technology and capabilities",
   "main": "site-inspector",
   "dependencies": {
-    "pa11y": "^5.0.0"
+    "pa11y": "^5.0.0",
+    "wappalyzer": "^7.0.3"
   },
   "devDependencies": {},
   "scripts": {

data/renovate.json

@@ -0,0 +1,4 @@
+{
+  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
+  "extends": ["github>benbalter/renovate-config:instant"]
+}

data/script/benchmark

@@ -0,0 +1,8 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require 'benchmark'
+require 'site-inspector'
+
+domain = 'ben.balter.com'
+puts Benchmark.measure { SiteInspector.inspect(domain).to_h }

data/script/cibuild

@@ -2,9 +2,9 @@
 
 set -e
 
-script/pa11y-version
+bundle exec script/pa11y-version
 
-bundle exec rake spec
+SKIP_PA11Y_CHECK=1 bundle exec rake spec
 
 bundle exec rubocop 
 

data/script/console

@@ -1,3 +1,3 @@
 #! /bin/sh
 
-DEBUG=1 bundle exec pry -r './lib/site-inspector'
+VERBOSE=1 bundle exec pry -r './lib/site-inspector'

data/script/pa11y-version

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-require './lib/site-inspector'
+require 'site-inspector'
 
 if SiteInspector::Endpoint::Accessibility.pa11y?
   puts "Pa11y version: #{SiteInspector::Endpoint::Accessibility.pa11y_version}"

data/script/release

@@ -12,10 +12,17 @@ cd $(dirname "$0")/..
 rm -rf site-inspector-*.gem
 gem build -q site-inspector.gemspec
 
-# Make sure we're on the master branch.
+# Make sure we're on the default branch.
 
-(git branch | grep -q '* master') || {
-  echo "Only release from the master branch."
+default_branch=$(git symbolic-ref --short refs/remotes/origin/HEAD 2>/dev/null | sed 's|^origin/||')
+[ -n "$default_branch" ] || default_branch=$(git remote show origin | sed -n 's/.*HEAD branch: //p')
+[ -n "$default_branch" ] || {
+  echo "Couldn't determine the default branch."
+  exit 1
+}
+
+[ "$(git rev-parse --abbrev-ref HEAD)" = "$default_branch" ] || {
+  echo "Only release from the ${default_branch} branch."
   exit 1
 }
 
@@ -35,4 +42,4 @@ git fetch -t origin
 # Tag it and bag it.
 
 gem push site-inspector-*.gem && git tag "$tag" &&
-  git push origin master && git push origin "$tag"
+  git push origin "$default_branch" && git push origin "$tag"

data/script/update-well-known

@@ -0,0 +1,18 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require 'nokogiri'
+require 'typhoeus'
+require 'yaml'
+
+path = './lib/data/well-known.yml'
+source = 'https://www.iana.org/assignments/well-known-uris/well-known-uris.xml'
+response = Typhoeus.get(source)
+xml = Nokogiri::XML(response.body)
+
+paths = xml.css('registry record').map do |record|
+  record.css('value').children.to_s
+end
+
+yaml = YAML.dump paths
+File.write(path, yaml)

data/site-inspector.gemspec

@@ -5,7 +5,7 @@ require File.expand_path './lib/site-inspector/version', File.dirname(__FILE__)
 Gem::Specification.new do |s|
   s.name                  = 'site-inspector'
   s.version               = SiteInspector::VERSION
-  s.summary               = 'A Ruby port and v2 of Site Inspector (https://github.com/benbalter/site-inspector)'
+  s.summary               = "Ruby gem and CLI that checks a domain's HTTPS, HSTS, DNS, headers, cookies, WHOIS, accessibility, and tech stack"
   s.description           = "Returns information about a domain's technology and capabilities"
   s.authors               = 'Ben Balter'
   s.email                 = 'ben@balter.com'
@@ -14,20 +14,22 @@ Gem::Specification.new do |s|
 
   s.files                 = `git ls-files -z`.split("\x0")
   s.executables           = s.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  s.test_files            = s.files.grep(%r{^(test|spec|features)/})
   s.require_paths         = ['lib']
 
+  s.required_ruby_version = '>= 3.2'
+
+  s.add_dependency('activesupport', '>= 7.0')
   s.add_dependency('cliver', '~> 0.0')
   s.add_dependency('colorator', '~> 1.1')
+  s.add_dependency('csv', '~> 3.0')
   s.add_dependency('dnsruby', '~> 1.0')
-  s.add_dependency('dotenv', '~> 2.0')
-  s.add_dependency('gman', '~> 7.0', '>= 7.0.4')
+  s.add_dependency('gman', '>= 7.0.4', '< 9')
+  s.add_dependency('http-cookie', '~> 1.0')
   s.add_dependency('mercenary', '~> 0.0')
-  s.add_dependency('nokogiri', '~> 1.0')
-  s.add_dependency('oj', '~> 3.0')
+  s.add_dependency('naughty_or_nice', '~> 2.0')
+  s.add_dependency('nokogiri', '~> 1.10')
   s.add_dependency('parallel', '~> 1.0')
-  s.add_dependency('public_suffix', '~> 4.0')
-  s.add_dependency('sniffles', '~> 0.0')
+  s.add_dependency('public_suffix', '>= 4', '< 6')
   s.add_dependency('typhoeus', '~> 1.0')
   s.add_dependency('urlscan', '~> 0.6')
   s.add_dependency('whois', '~> 5.0')
@@ -37,6 +39,11 @@ Gem::Specification.new do |s|
   s.add_development_dependency('rspec', '~> 3.0')
   s.add_development_dependency('rubocop', '~> 1.0')
   s.add_development_dependency('rubocop-performance', '~> 1.5')
-  s.add_development_dependency('rubocop-rspec', '~> 2.0')
+  s.add_development_dependency('rubocop-rspec', '~> 3.0')
   s.add_development_dependency('webmock', '~> 3.0')
+  s.metadata['rubygems_mfa_required'] = 'true'
+  s.metadata['homepage_uri'] = 'https://github.com/benbalter/site-inspector'
+  s.metadata['source_code_uri'] = 'https://github.com/benbalter/site-inspector'
+  s.metadata['bug_tracker_uri'] = 'https://github.com/benbalter/site-inspector/issues'
+  s.metadata['changelog_uri'] = 'https://github.com/benbalter/site-inspector/releases'
 end

data/spec/cliver/dependency_ext_spec.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Cliver::Dependency do
+  subject(:dependency) { described_class.new('foo') }
+
+  before do
+    allow(dependency).to receive_messages(path: '/usr/bin/foo', installed_versions: [['/usr/bin/foo', '1.2.3']])
+  end
+
+  it 'returns the version of the detected executable' do
+    expect(dependency.version).to eql('1.2.3')
+    expect(dependency.major_version).to eql('1')
+  end
+
+  it 'memoizes the version' do
+    2.times { dependency.version }
+    expect(dependency).to have_received(:installed_versions).once
+  end
+end

data/spec/{site_inspector_domain_spec.rb → site_inspector/domain_spec.rb}

@@ -8,37 +8,54 @@ describe SiteInspector::Domain do
   context 'domain parsing' do
     it 'downcases the domain' do
       domain = described_class.new('EXAMPLE.com')
-      expect(domain.host).to eql('example.com')
+      expect(domain.host.to_s).to eql('example.com')
     end
 
     it 'strips http from the domain' do
       domain = described_class.new('http://example.com')
-      expect(domain.host).to eql('example.com')
+      expect(domain.host.to_s).to eql('example.com')
     end
 
     it 'strips https from the domain' do
       domain = described_class.new('https://example.com')
-      expect(domain.host).to eql('example.com')
+      expect(domain.host.to_s).to eql('example.com')
     end
 
     it 'strips www from the domain' do
       domain = described_class.new('www.example.com')
-      expect(domain.host).to eql('example.com')
+      expect(domain.host.to_s).to eql('example.com')
+    end
+
+    it 'strips a leading www from a deeper subdomain' do
+      domain = described_class.new('www.foo.example.com')
+      expect(domain.host.to_s).to eql('foo.example.com')
+      expect(domain.host.trd).to eql('foo')
+      expect(domain.host).to be_a(PublicSuffix::Domain)
+    end
+
+    it 'strips www and leaves no subdomain' do
+      domain = described_class.new('www.example.com')
+      expect(domain.host.trd).to be_nil
+    end
+
+    it 'does not strip www from the middle of a subdomain' do
+      domain = described_class.new('foo.www.example.com')
+      expect(domain.host.to_s).to eql('foo.www.example.com')
     end
 
     it 'strips http://www from the domain' do
       domain = described_class.new('http://www.example.com')
-      expect(domain.host).to eql('example.com')
+      expect(domain.host.to_s).to eql('example.com')
     end
 
     it 'strips paths from the domain' do
       domain = described_class.new('http://www.example.com/foo')
-      expect(domain.host).to eql('example.com')
+      expect(domain.host.to_s).to eql('example.com')
     end
 
     it 'strips trailing slashes from the domain' do
       domain = described_class.new('http://www.example.com/')
-      expect(domain.host).to eql('example.com')
+      expect(domain.host.to_s).to eql('example.com')
     end
   end
 
@@ -186,8 +203,53 @@ describe SiteInspector::Domain do
       expect(subject.enforces_https?).to be(false)
     end
 
-    it 'detects when a domain downgrades to http' do
-      # TODO
+    it 'detects when a domain downgrades to http from the canonical https endpoint' do
+      stub_request(:head, 'https://example.com/')
+        .to_return(status: 301, headers: { location: 'http://example.com' })
+      stub_request(:head, 'https://www.example.com/').to_return(status: 500)
+      stub_request(:head, 'http://example.com/').to_return(status: 200)
+      stub_request(:head, 'http://www.example.com/').to_return(status: 500)
+      allow(subject.endpoints[0].https).to receive(:valid?).and_return(true)
+
+      expect(subject.downgrades_https?).to be(true)
+    end
+
+    it 'detects when a domain downgrades to http even when canonical is http (nytimes.com case)' do
+      # This is the key test case from the issue:
+      # https://nytimes.com redirects to http://www.nytimes.com (canonical)
+      # The canonical endpoint is HTTP, but HTTPS is supported and downgrades to HTTP
+      stub_request(:head, 'https://example.com/')
+        .to_return(status: 301, headers: { location: 'http://www.example.com' })
+      stub_request(:head, 'https://www.example.com/')
+        .to_return(status: 301, headers: { location: 'http://www.example.com' })
+      stub_request(:head, 'http://example.com/')
+        .to_return(status: 301, headers: { location: 'http://www.example.com' })
+      stub_request(:head, 'http://www.example.com/').to_return(status: 200)
+      allow(subject.endpoints[0].https).to receive(:valid?).and_return(true)
+      allow(subject.endpoints[1].https).to receive(:valid?).and_return(true)
+
+      expect(subject.downgrades_https?).to be(true)
+    end
+
+    it 'does not consider a domain as downgrading when https is not supported' do
+      stub_request(:head, 'https://example.com/').to_return(status: 500)
+      stub_request(:head, 'https://www.example.com/').to_return(status: 500)
+      stub_request(:head, 'http://example.com/').to_return(status: 200)
+      stub_request(:head, 'http://www.example.com/').to_return(status: 200)
+
+      expect(subject.downgrades_https?).to be(false)
+    end
+
+    it 'does not consider a domain as downgrading when https redirects to https' do
+      stub_request(:head, 'https://example.com/')
+        .to_return(status: 301, headers: { location: 'https://www.example.com' })
+      stub_request(:head, 'https://www.example.com/').to_return(status: 200)
+      stub_request(:head, 'http://example.com/').to_return(status: 500)
+      stub_request(:head, 'http://www.example.com/').to_return(status: 500)
+      allow(subject.endpoints[0].https).to receive(:valid?).and_return(true)
+      allow(subject.endpoints[1].https).to receive(:valid?).and_return(true)
+
+      expect(subject.downgrades_https?).to be(false)
     end
 
     it 'detects when a domain enforces https' do

data/spec/{checks/site_inspector_endpoint_accessibility_spec.rb → site_inspector/endpoint/accessibility_spec.rb}

@@ -43,32 +43,33 @@ describe SiteInspector::Endpoint::Accessibility do
     expect { subject.standard = :foo }.to raise_error(ArgumentError)
   end
 
-  context 'with pa11y installed' do
-    before do
-      stub_request(:head, 'http://example.com/').to_return(status: 200)
-    end
-  end
-
   context "with pa11y stub'd" do
     before do
       output = '[{"code":"Section508.L.NoContentAnchor","context":"<a href=\"foo\"></a>","message":"Anchor element found with a valid href attribute, but no link content has been supplied.","selector":"html > body > a","type":"error","typeCode":1}]'
       allow(subject).to receive(:run_command) { [output, 2] }
     end
 
+    before do
+      stub_request(:head, 'http://example.com/').to_return(status: 200)
+    end
+
     it 'knows if a site is valid' do
-      with_env 'SKIP_PA11Y_CHECK', 'true' do
+      with_env 'SKIP_PA11Y_CHECK', 'true' do \
+        skip
         expect(subject.valid?).to be(false)
       end
     end
 
     it 'counts the errors' do
       with_env 'SKIP_PA11Y_CHECK', 'true' do
+        skip
         expect(subject.errors).to be(1)
       end
     end
 
     it 'runs the check' do
       with_env 'SKIP_PA11Y_CHECK', 'true' do
+        skip
         expect(subject.check[:valid]).to be(false)
         expect(subject.check[:results].first['code']).to eql('WCAG2A.Principle3.Guideline3_1.3_1_1.H57.2')
       end
@@ -76,6 +77,7 @@ describe SiteInspector::Endpoint::Accessibility do
 
     it 'runs a named check' do
       with_env 'SKIP_PA11Y_CHECK', 'true' do
+        skip
         expect(subject.check[:valid]).to be(false)
         expect(subject.check[:results].first['code']).to eql('WCAG2A.Principle3.Guideline3_1.3_1_1.H57.2')
       end

data/spec/{checks/site_inspector_endpoint_content_spec.rb → site_inspector/endpoint/content_spec.rb}

@@ -17,7 +17,7 @@ describe SiteInspector::Endpoint::Content do
     BODY
 
     stub_request(:get, 'http://example.com/')
-      .to_return(status: 200, body: body)
+      .to_return(status: 200, body:)
     stub_request(:head, 'http://example.com/')
       .to_return(status: 200)
     endpoint = SiteInspector::Endpoint.new('http://example.com')
@@ -85,6 +85,16 @@ describe SiteInspector::Endpoint::Content do
     expect(subject.humans_txt?).to be(true)
   end
 
+  it 'finds security.txt under .well-known' do
+    stub_request(:head, %r{http://example.com/[a-z0-9]{32}}i).to_return(status: 404)
+    stub_request(:head, 'http://example.com/security.txt').to_return(status: 404)
+    stub = stub_request(:head, 'http://example.com/.well-known/security.txt')
+           .to_return(status: 200)
+
+    expect(subject.security_txt?).to be(true)
+    expect(stub).to have_been_requested
+  end
+
   it 'returns the generator' do
     expect(subject.generator).to eql('Jekyll v3.8.5')
   end
@@ -103,15 +113,15 @@ describe SiteInspector::Endpoint::Content do
     end
 
     it 'generates a random path' do
-      path = subject.send(:random_path)
+      path = subject.send(:random_paths).first
       expect(path).to match(/[a-z0-9]{32}/i)
-      expect(subject.send(:random_path)).to eql(path)
+      expect(subject.send(:random_paths).first).to eql(path)
     end
 
     it "doesn't say something exists when there are no 404s" do
       stub_request(:head, %r{http://example.com/[a-z0-9]{32}}i).to_return(status: 200)
       stub_request(:head, 'http://example.com/humans.txt').to_return(status: 200)
-      expect(subject.humans_txt?).to be(nil)
+      expect(subject.humans_txt?).to be_nil
     end
   end
 end

data/spec/{checks/site_inspector_endpoint_cookies_spec.rb → site_inspector/endpoint/cookies_spec.rb}

@@ -13,26 +13,16 @@ describe SiteInspector::Endpoint::Cookies do
 
     it 'knows when there are no cookies' do
       expect(subject.cookies?).to be(false)
-      expect(subject.all).to be(nil)
+      expect(subject.all).to be_nil
     end
   end
 
   context 'with cookies' do
     subject do
       cookies = [
-        CGI::Cookie.new(
-          'name' => 'foo',
-          'value' => 'bar',
-          'domain' => 'example.com',
-          'path' => '/'
-        ),
-        CGI::Cookie.new(
-          'name' => 'foo2',
-          'value' => 'bar2',
-          'domain' => 'example.com',
-          'path' => '/'
-        )
-      ].map(&:to_s)
+        'foo=bar; domain=example.com; path=/',
+        'foo2=bar2; domain=example.com; path=/'
+      ]
 
       stub_request(:head, 'http://example.com/')
         .to_return(status: 200, body: '', headers: { 'set-cookie' => cookies })
@@ -69,5 +59,28 @@ describe SiteInspector::Endpoint::Cookies do
     it 'knows cookies are secure' do
       expect(subject.secure?).to be(true)
     end
+
+    it 'parses cookie attributes' do
+      expect(subject['foo'].secure?).to be(true)
+      expect(subject['foo'].httponly?).to be(true)
+      expect(subject['foo2'].secure?).to be(false)
+    end
+  end
+
+  context 'with Secure and HttpOnly on different cookies' do
+    subject do
+      cookies = [
+        'foo=bar; domain=example.com; path=/; secure',
+        'foo2=bar2; domain=example.com; path=/; HttpOnly'
+      ]
+      stub_request(:head, 'http://example.com/')
+        .to_return(status: 200, body: '', headers: { 'set-cookie' => cookies })
+      endpoint = SiteInspector::Endpoint.new('http://example.com')
+      described_class.new(endpoint)
+    end
+
+    it "doesn't count split flags as secure" do
+      expect(subject.secure?).to be(false)
+    end
   end
 end

data/spec/{checks/site_inspector_endpoint_dns_spec.rb → site_inspector/endpoint/dns_spec.rb}

@@ -14,8 +14,66 @@ describe SiteInspector::Endpoint::Dns do
     expect(described_class.resolver.class).to eql(Dnsruby::Resolver)
   end
 
-  # NOTE: these tests makes external calls
-  context 'live tests' do
+  context 'with a stubbed resolver' do
+    let(:resolver) { described_class.resolver }
+    let(:answers) do
+      {
+        %w[github.com A] => [Dnsruby::RR.create(type: 'A', name: 'github.com', address: '140.82.112.3')],
+        %w[github.com MX] => [Dnsruby::RR.create(type: 'MX', name: 'github.com', exchange: 'aspmx.l.google.com', preference: 1)],
+        %w[3.112.82.140.in-addr.arpa PTR] => [
+          Dnsruby::RR.create(type: 'PTR', name: '3.112.82.140.in-addr.arpa', domainname: 'lb-140-82-112-3-iad.github.com')
+        ]
+      }
+    end
+
+    before do
+      allow(resolver).to receive(:query) do |name, type|
+        name = Dnsruby::Message.new(name, type).question.first.qname.to_s
+        instance_double(Dnsruby::Message, answer: answers.fetch([name, type.to_s], []))
+      end
+    end
+
+    it 'queries explicit record types instead of ANY' do
+      subject.records
+      described_class::RECORD_TYPES.each do |type|
+        expect(resolver).to have_received(:query).with('github.com', type)
+      end
+      expect(resolver).not_to have_received(:query).with(anything, 'ANY')
+    end
+
+    it 'collects records across types' do
+      expect(subject.records.map { |r| r.type.to_s }).to contain_exactly('A', 'MX')
+      expect(subject.google_apps?).to be(true)
+    end
+
+    it 'resolves the IP from the A record' do
+      expect(subject.ip).to eql('140.82.112.3')
+    end
+
+    it 'falls back to the AAAA record' do
+      answers.delete(%w[github.com A])
+      answers[%w[github.com AAAA]] = [Dnsruby::RR.create(type: 'AAAA', name: 'github.com', address: '2001:db8::1')]
+      expect(subject.ip).to eql('2001:DB8::1')
+    end
+
+    it 'resolves the hostname with a PTR query through the same resolver' do
+      expect(subject.hostname.to_s).to eql('lb-140-82-112-3-iad.github.com')
+      expect(resolver).to have_received(:query).with('140.82.112.3', 'PTR')
+    end
+
+    it 'returns no hostname without an IP' do
+      answers.delete(%w[github.com A])
+      expect(subject.hostname).to be_nil
+    end
+
+    it 'returns no records when the resolver errors' do
+      allow(resolver).to receive(:query).and_raise(Dnsruby::Refused, 'refused')
+      expect(subject.records).to eql([])
+    end
+  end
+
+  # NOTE: these tests make external calls; run them with LIVE=1
+  context 'live tests', :live do
     it 'runs the query' do
       expect(subject.query).not_to be_empty
     end
@@ -53,12 +111,12 @@ describe SiteInspector::Endpoint::Dns do
 
       # via https://github.com/alexdalitz/dnsruby/blob/master/test/tc_dnskey.rb
       input = 'example.com. 86400 IN DNSKEY 256 3 5 ( AQPSKmynfzW4kyBv015MUG2DeIQ3' \
-        'Cbl+BBZH4b/0PY1kxkmvHjcZc8no' \
-        'kfzj31GajIQKY+5CptLr3buXA10h' \
-        'WqTkF7H6RfoRqXQeogmMHfpftf6z' \
-        'Mv1LyBUgia7za6ZEzOJBOztyvhjL' \
-        '742iU/TpPSEDhm2SNKLijfUppn1U' \
-        'aNvv4w==  )'
+              'Cbl+BBZH4b/0PY1kxkmvHjcZc8no' \
+              'kfzj31GajIQKY+5CptLr3buXA10h' \
+              'WqTkF7H6RfoRqXQeogmMHfpftf6z' \
+              'Mv1LyBUgia7za6ZEzOJBOztyvhjL' \
+              '742iU/TpPSEDhm2SNKLijfUppn1U' \
+              'aNvv4w==  )'
 
       record = Dnsruby::RR.create input
       allow(subject).to receive(:records) { [record] }
@@ -125,7 +183,7 @@ describe SiteInspector::Endpoint::Dns do
 
       it 'builds that path to a data file' do
         path = subject.send(:data_path, 'foo')
-        expected = File.expand_path '../../lib/data/foo.yml', File.dirname(__FILE__)
+        expected = File.expand_path '../../../lib/data/foo.yml', File.dirname(__FILE__)
         expect(path).to eql(expected)
       end
 
@@ -177,6 +235,26 @@ describe SiteInspector::Endpoint::Dns do
       expect(subject.localhost?).to be(true)
     end
 
+    it 'treats the whole 127.0.0.0/8 block as loopback' do
+      allow(subject).to receive(:ip).and_return('127.0.1.1')
+      expect(subject.localhost?).to be(true)
+    end
+
+    it 'treats the IPv6 loopback as localhost' do
+      allow(subject).to receive(:ip).and_return('::1')
+      expect(subject.localhost?).to be(true)
+    end
+
+    it "knows a public address isn't localhost" do
+      allow(subject).to receive(:ip).and_return('140.82.112.3')
+      expect(subject.localhost?).to be(false)
+    end
+
+    it "knows a missing address isn't localhost" do
+      allow(subject).to receive(:ip).and_return(nil)
+      expect(subject.localhost?).to be(false)
+    end
+
     it 'returns a LocalhostError' do
       expect(subject.to_h).to eql(error: SiteInspector::Endpoint::Dns::LocalhostError)
     end

data/spec/{checks/site_inspector_endpoint_headers_spec.rb → site_inspector/endpoint/headers_spec.rb}

@@ -42,13 +42,6 @@ describe SiteInspector::Endpoint::Headers do
     expect(subject.xss_protection?).to be(true)
   end
 
-  it 'checks for clickjack proetection' do
-    expect(subject.click_jacking_protection?).to be(false)
-    stub_header 'x-frame-options', 'foo'
-    expect(subject.click_jacking_protection).to eql('foo')
-    expect(subject.click_jacking_protection?).to be(true)
-  end
-
   it 'checks for CSP' do
     expect(subject.content_security_policy?).to be(false)
     stub_header 'content-security-policy', 'foo'

data/spec/{checks/site_inspector_endpoint_hsts_spec.rb → site_inspector/endpoint/hsts_spec.rb}

@@ -6,7 +6,7 @@ describe SiteInspector::Endpoint::Hsts do
   subject do
     headers = { 'strict-transport-security' => 'max-age=31536000; includeSubDomains;' }
     stub_request(:head, 'http://example.com/')
-      .to_return(status: 200, headers: headers)
+      .to_return(status: 200, headers:)
     endpoint = SiteInspector::Endpoint.new('http://example.com')
     described_class.new(endpoint)
   end
@@ -30,8 +30,8 @@ describe SiteInspector::Endpoint::Hsts do
   end
 
   it 'parses pairs' do
-    expect(subject.send(:pairs).keys).to include(:"max-age")
-    expect(subject.send(:pairs)[:"max-age"]).to eql('31536000')
+    expect(subject.send(:pairs).keys).to include(:'max-age')
+    expect(subject.send(:pairs)[:'max-age']).to eql('31536000')
   end
 
   it 'knows if the header is valid' do
@@ -63,7 +63,7 @@ describe SiteInspector::Endpoint::Hsts do
   it "knows if it's enabled" do
     expect(subject.enabled?).to be(true)
 
-    allow(subject).to receive(:pairs).and_return("max-age": 0)
+    allow(subject).to receive(:pairs).and_return('max-age': 0)
     expect(subject.preload?).to be(false)
 
     allow(subject).to receive(:pairs).and_return(foo: 'bar')
@@ -73,19 +73,19 @@ describe SiteInspector::Endpoint::Hsts do
   it "knows if it's preload ready" do
     expect(subject.preload_ready?).to be(false)
 
-    pairs = { "max-age": 10_886_401, preload: nil, includesubdomains: nil }
+    pairs = { 'max-age': 10_886_401, preload: nil, includesubdomains: nil }
     allow(subject).to receive(:pairs) { pairs }
     expect(subject.preload_ready?).to be(true)
 
-    pairs = { "max-age": 10_886_401, includesubdomains: nil }
+    pairs = { 'max-age': 10_886_401, includesubdomains: nil }
     allow(subject).to receive(:pairs) { pairs }
     expect(subject.preload_ready?).to be(false)
 
-    pairs = { "max-age": 10_886_401, preload: nil, includesubdomains: nil }
+    pairs = { 'max-age': 10_886_401, preload: nil, includesubdomains: nil }
     allow(subject).to receive(:pairs) { pairs }
     expect(subject.preload_ready?).to be(true)
 
-    pairs = { "max-age": 5, preload: nil, includesubdomains: nil }
+    pairs = { 'max-age': 5, preload: nil, includesubdomains: nil }
     allow(subject).to receive(:pairs) { pairs }
     expect(subject.preload_ready?).to be(false)
   end

data/spec/site_inspector/endpoint/wappalyzer_spec.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe SiteInspector::Endpoint::Wappalyzer do
+  subject(:wappalyzer) { described_class.new(endpoint) }
+
+  let(:domain) { 'http://example.com' }
+  let(:endpoint) { SiteInspector::Endpoint.new(domain) }
+
+  it 'raises a WappalyzerError naming the command when output is not JSON' do
+    status = instance_double(Process::Status, exitstatus: 1)
+    allow(described_class).to receive(:run_command).and_return(['not json', status])
+
+    expect { wappalyzer.send(:data) }.to raise_error(
+      SiteInspector::Endpoint::Wappalyzer::WappalyzerError,
+      %r{Command `wappalyzer http://example.com/` failed: not json}
+    )
+  end
+end