site-inspector 3.1.1 → 3.2.0

data/spec/site_inspector_cache_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe SiteInspector::Cache do

data/spec/site_inspector_disk_cache_spec.rb

@@ -1,26 +1,28 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe SiteInspector::DiskCache do
-  subject { SiteInspector::DiskCache.new(tmpdir) }
+  subject { described_class.new(tmpdir) }
 
   before do
     FileUtils.rm_rf(tmpdir)
     Dir.mkdir(tmpdir)
   end
 
-  it 'should write a value to disk' do
+  it 'writes a value to disk' do
     foo = Typhoeus::Request.new('foo')
 
     path = File.expand_path foo.cache_key, tmpdir
-    expect(File.exist?(path)).to eql(false)
+    expect(File.exist?(path)).to be(false)
 
     subject.set foo, 'bar'
 
-    expect(File.exist?(path)).to eql(true)
+    expect(File.exist?(path)).to be(true)
     expect(File.open(path).read).to eql("I\"bar:ET")
   end
 
-  it 'should read a value from disk' do
+  it 'reads a value from disk' do
     foo = Typhoeus::Request.new('foo')
 
     path = File.expand_path foo.cache_key, tmpdir
@@ -28,7 +30,7 @@ describe SiteInspector::DiskCache do
     expect(subject.get(foo)).to eql('bar')
   end
 
-  it "should calculate a file's path" do
+  it "calculates a file's path" do
     foo = Typhoeus::Request.new('foo')
 
     path = File.expand_path foo.cache_key, tmpdir

data/spec/site_inspector_domain_spec.rb

@@ -1,41 +1,43 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe SiteInspector::Domain do
-  subject { SiteInspector::Domain.new('example.com') }
+  subject { described_class.new('example.com') }
 
   context 'domain parsing' do
     it 'downcases the domain' do
-      domain = SiteInspector::Domain.new('EXAMPLE.com')
+      domain = described_class.new('EXAMPLE.com')
       expect(domain.host).to eql('example.com')
     end
 
     it 'strips http from the domain' do
-      domain = SiteInspector::Domain.new('http://example.com')
+      domain = described_class.new('http://example.com')
       expect(domain.host).to eql('example.com')
     end
 
     it 'strips https from the domain' do
-      domain = SiteInspector::Domain.new('https://example.com')
+      domain = described_class.new('https://example.com')
       expect(domain.host).to eql('example.com')
     end
 
     it 'strips www from the domain' do
-      domain = SiteInspector::Domain.new('www.example.com')
+      domain = described_class.new('www.example.com')
       expect(domain.host).to eql('example.com')
     end
 
     it 'strips http://www from the domain' do
-      domain = SiteInspector::Domain.new('http://www.example.com')
+      domain = described_class.new('http://www.example.com')
       expect(domain.host).to eql('example.com')
     end
 
     it 'strips paths from the domain' do
-      domain = SiteInspector::Domain.new('http://www.example.com/foo')
+      domain = described_class.new('http://www.example.com/foo')
       expect(domain.host).to eql('example.com')
     end
 
     it 'strips trailing slashes from the domain' do
-      domain = SiteInspector::Domain.new('http://www.example.com/')
+      domain = described_class.new('http://www.example.com/')
       expect(domain.host).to eql('example.com')
     end
   end
@@ -43,7 +45,7 @@ describe SiteInspector::Domain do
   context 'endpoints' do
     it 'generates the endpoints' do
       endpoints = subject.endpoints
-      expect(endpoints.count).to eql(4)
+      expect(endpoints.count).to be(4)
       expect(endpoints[0].to_s).to eql('https://example.com/')
       expect(endpoints[1].to_s).to eql('https://www.example.com/')
       expect(endpoints[2].to_s).to eql('http://example.com/')
@@ -60,23 +62,21 @@ describe SiteInspector::Domain do
   end
 
   it 'knows if a domain is a government domain' do
-    expect(subject.government?).to eql(false)
+    expect(subject.government?).to be(false)
 
-    domain = SiteInspector::Domain.new('whitehouse.gov')
-    expect(domain.government?).to eql(true)
+    domain = described_class.new('whitehouse.gov')
+    expect(domain.government?).to be(true)
   end
 
   context 'up' do
     it 'considers a domain up if at least one endpoint is up' do
       subject.endpoints.each do |endpoint|
-        unless endpoint.uri.to_s.start_with?('http://www')
-          allow(endpoint).to receive(:response) { Typhoeus::Response.new(code: 0) }
-        end
+        allow(endpoint).to receive(:response) { Typhoeus::Response.new(code: 0) } unless endpoint.uri.to_s.start_with?('http://www')
       end
 
       stub_request(:head, 'http://www.example.com/').to_return(status: 200)
 
-      expect(subject.up?).to eql(true)
+      expect(subject.up?).to be(true)
     end
 
     it "doesn't consider a domain up when all endpoints are down" do
@@ -84,7 +84,7 @@ describe SiteInspector::Domain do
         allow(endpoint).to receive(:response) { Typhoeus::Response.new(code: 0) }
       end
 
-      expect(subject.up?).to eql(false)
+      expect(subject.up?).to be(false)
     end
   end
 
@@ -95,7 +95,7 @@ describe SiteInspector::Domain do
       stub_request(:head, 'http://example.com/').to_return(status: 500)
       stub_request(:head, 'http://www.example.com/').to_return(status: 200)
 
-      expect(subject.up?).to eql(true)
+      expect(subject.up?).to be(true)
     end
 
     it "doesn't consider a domain up if all endpoints are down" do
@@ -104,7 +104,7 @@ describe SiteInspector::Domain do
       stub_request(:head, 'http://example.com/').to_return(status: 500)
       stub_request(:head, 'http://www.example.com/').to_return(status: 500)
 
-      expect(subject.up?).to eql(false)
+      expect(subject.up?).to be(false)
     end
   end
 
@@ -115,7 +115,7 @@ describe SiteInspector::Domain do
       stub_request(:head, 'http://example.com/').to_return(status: 500)
       stub_request(:head, 'http://www.example.com/').to_return(status: 200)
 
-      expect(subject.www?).to eql(true)
+      expect(subject.www?).to be(true)
     end
 
     it "doesn't consider a site www when no endpoint is www" do
@@ -124,7 +124,7 @@ describe SiteInspector::Domain do
       stub_request(:head, 'http://example.com/').to_return(status: 200)
       stub_request(:head, 'http://www.example.com/').to_return(status: 500)
 
-      expect(subject.www?).to eql(false)
+      expect(subject.www?).to be(false)
     end
   end
 
@@ -135,7 +135,7 @@ describe SiteInspector::Domain do
       stub_request(:head, 'http://example.com/').to_return(status: 500)
       stub_request(:head, 'http://www.example.com/').to_return(status: 500)
 
-      expect(subject.root?).to eql(true)
+      expect(subject.root?).to be(true)
     end
 
     it "doesn't call a www-only domain root" do
@@ -144,7 +144,7 @@ describe SiteInspector::Domain do
       stub_request(:head, 'http://example.com/').to_return(status: 500)
       stub_request(:head, 'http://www.example.com/').to_return(status: 200)
 
-      expect(subject.root?).to eql(false)
+      expect(subject.root?).to be(false)
     end
   end
 
@@ -154,9 +154,9 @@ describe SiteInspector::Domain do
       stub_request(:head, 'https://www.example.com/').to_return(status: 200)
       stub_request(:head, 'http://example.com/').to_return(status: 200)
       stub_request(:head, 'http://www.example.com/').to_return(status: 200)
-      allow(subject.endpoints.first.https).to receive(:valid?) { true }
+      allow(subject.endpoints.first.https).to receive(:valid?).and_return(true)
 
-      expect(subject.https?).to eql(true)
+      expect(subject.https?).to be(true)
     end
 
     it "knows when a domain doesn't support https" do
@@ -165,7 +165,7 @@ describe SiteInspector::Domain do
       stub_request(:head, 'http://example.com/').to_return(status: 200)
       stub_request(:head, 'http://www.example.com/').to_return(status: 200)
 
-      expect(subject.https?).to eql(false)
+      expect(subject.https?).to be(false)
     end
 
     it 'considers HTTPS inforced when no http endpoint responds' do
@@ -183,7 +183,7 @@ describe SiteInspector::Domain do
       stub_request(:head, 'http://example.com/').to_return(status: 500)
       stub_request(:head, 'http://www.example.com/').to_return(status: 200)
 
-      expect(subject.enforces_https?).to eql(false)
+      expect(subject.enforces_https?).to be(false)
     end
 
     it 'detects when a domain downgrades to http' do
@@ -203,7 +203,7 @@ describe SiteInspector::Domain do
         stub_request(:head, 'http://example.com/').to_return(status: 500)
         stub_request(:head, 'http://www.example.com/').to_return(status: 200)
 
-        expect(subject.canonically_www?).to eql(true)
+        expect(subject.canonically_www?).to be(true)
       end
 
       it 'detects a domain as canonically www when root redirects' do
@@ -213,7 +213,7 @@ describe SiteInspector::Domain do
           .to_return(status: 301, headers: { location: 'http://www.example.com' })
         stub_request(:head, 'http://www.example.com/').to_return(status: 200)
 
-        expect(subject.canonically_www?).to eql(true)
+        expect(subject.canonically_www?).to be(true)
       end
     end
 
@@ -223,9 +223,9 @@ describe SiteInspector::Domain do
         stub_request(:head, 'https://www.example.com/').to_return(status: 200)
         stub_request(:head, 'http://example.com/').to_return(status: 500)
         stub_request(:head, 'http://www.example.com/').to_return(status: 500)
-        allow(subject.endpoints.first.https).to receive(:valid?) { true }
+        allow(subject.endpoints.first.https).to receive(:valid?).and_return(true)
 
-        expect(subject.canonically_https?).to eql(true)
+        expect(subject.canonically_https?).to be(true)
       end
 
       it 'detects a domain as canonically https when http redirect' do
@@ -234,9 +234,9 @@ describe SiteInspector::Domain do
         stub_request(:head, 'http://example.com/')
           .to_return(status: 301, headers: { location: 'https://example.com' })
         stub_request(:head, 'http://www.example.com/').to_return(status: 500)
-        allow(subject.endpoints.first.https).to receive(:valid?) { true }
+        allow(subject.endpoints.first.https).to receive(:valid?).and_return(true)
 
-        expect(subject.canonically_https?).to eql(true)
+        expect(subject.canonically_https?).to be(true)
       end
     end
   end
@@ -250,7 +250,7 @@ describe SiteInspector::Domain do
       stub_request(:head, 'http://www.example.com/').to_return(status: 500)
       stub_request(:head, 'http://foo.example.com/').to_return(status: 200)
 
-      expect(subject.redirect?).to eql(true)
+      expect(subject.redirect?).to be(true)
     end
   end
 

data/spec/site_inspector_endpoint_spec.rb

@@ -1,16 +1,17 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe SiteInspector::Endpoint do
-  
-  subject { SiteInspector::Endpoint.new('http://example.com') }
+  subject { described_class.new('http://example.com') }
 
   it 'downcases the host' do
-    endpoint = SiteInspector::Endpoint.new('http://EXAMPLE.com')
+    endpoint = described_class.new('http://EXAMPLE.com')
     expect(endpoint.host).to eql('example.com')
   end
 
   it 'strips www from the host' do
-    endpoint = SiteInspector::Endpoint.new('http://www.example.com')
+    endpoint = described_class.new('http://www.example.com')
     expect(endpoint.host).to eql('example.com')
   end
 
@@ -19,12 +20,12 @@ describe SiteInspector::Endpoint do
   end
 
   it 'knows if an endpoint is www' do
-    expect(subject.www?).to eql(false)
-    expect(subject.root?).to eql(true)
+    expect(subject.www?).to be(false)
+    expect(subject.root?).to be(true)
 
-    endpoint = SiteInspector::Endpoint.new('http://www.example.com')
-    expect(endpoint.www?).to eql(true)
-    expect(endpoint.root?).to eql(false)
+    endpoint = described_class.new('http://www.example.com')
+    expect(endpoint.www?).to be(true)
+    expect(endpoint.root?).to be(false)
   end
 
   it 'knows if an endpoint is http' do
@@ -34,8 +35,8 @@ describe SiteInspector::Endpoint do
     stub_request(:head, 'https://example.com/')
       .to_return(status: 500, body: 'content')
 
-    expect(subject.https?).to eql(false)
-    expect(subject.http?).to eql(true)
+    expect(subject.https?).to be(false)
+    expect(subject.http?).to be(true)
   end
 
   it 'knows if an endpoint is https' do
@@ -45,15 +46,15 @@ describe SiteInspector::Endpoint do
     stub_request(:head, 'https://example.com/')
       .to_return(status: 200, body: 'content')
 
-    endpoint = SiteInspector::Endpoint.new('https://example.com')
-    expect(endpoint.https?).to eql(true)
-    expect(endpoint.http?).to eql(false)
+    endpoint = described_class.new('https://example.com')
+    expect(endpoint.https?).to be(true)
+    expect(endpoint.http?).to be(false)
   end
 
   it 'knows the scheme' do
     expect(subject.scheme).to eql('http')
 
-    endpoint = SiteInspector::Endpoint.new('https://example.com')
+    endpoint = described_class.new('https://example.com')
     expect(endpoint.scheme).to eql('https')
   end
 
@@ -79,7 +80,7 @@ describe SiteInspector::Endpoint do
         .to_return(status: 301, headers: { location: 'http://example.com/foo' })
 
       response = subject.request(followlocation: true)
-      expect(response.request.options[:followlocation]).to eql(true)
+      expect(response.request.options[:followlocation]).to be(true)
     end
 
     it 'returns the response' do
@@ -95,15 +96,15 @@ describe SiteInspector::Endpoint do
       stub_request(:head, 'http://example.com/')
         .to_return(status: 200, body: 'content')
 
-      expect(subject.responds?).to eql(true)
+      expect(subject.responds?).to be(true)
     end
 
     it "knows when there's not a response" do
       allow(subject).to receive(:response) { Typhoeus::Response.new(code: 0) }
-      expect(subject.responds?).to eql(false)
+      expect(subject.responds?).to be(false)
 
       allow(subject).to receive(:response) { Typhoeus::Response.new(return_code: :operation_timedout) }
-      expect(subject.responds?).to eql(false)
+      expect(subject.responds?).to be(false)
     end
 
     it 'knows the response code' do
@@ -115,53 +116,53 @@ describe SiteInspector::Endpoint do
 
     it 'knows if a response has timed out' do
       allow(subject).to receive(:response) { Typhoeus::Response.new(return_code: :operation_timedout) }
-      expect(subject.timed_out?).to eql(true)
+      expect(subject.timed_out?).to be(true)
     end
 
     it 'considers a 200 response code to be live and a response' do
       stub_request(:head, 'http://example.com/')
         .to_return(status: 200)
 
-      expect(subject.up?).to eql(true)
-      expect(subject.responds?).to eql(true)
+      expect(subject.up?).to be(true)
+      expect(subject.responds?).to be(true)
     end
 
     it 'considers a 301 response code to be live and a response' do
       stub_request(:head, 'http://example.com/')
         .to_return(status: 301)
 
-      expect(subject.up?).to eql(true)
-      expect(subject.responds?).to eql(true)
+      expect(subject.up?).to be(true)
+      expect(subject.responds?).to be(true)
     end
 
     it 'considers a 404 response code to be down but a response' do
       stub_request(:head, 'http://example.com/')
         .to_return(status: 404)
 
-      expect(subject.up?).to eql(false)
-      expect(subject.responds?).to eql(true)
+      expect(subject.up?).to be(false)
+      expect(subject.responds?).to be(true)
     end
 
     it 'considers a 500 response code to be down but a response' do
       stub_request(:head, 'http://example.com/')
         .to_return(status: 500)
 
-      expect(subject.up?).to eql(false)
-      expect(subject.responds?).to eql(true)
+      expect(subject.up?).to be(false)
+      expect(subject.responds?).to be(true)
     end
 
     it 'considers a 0 response code (error) to down and unresponsive' do
       allow(subject).to receive(:response) { Typhoeus::Response.new(code: 0) }
 
-      expect(subject.up?).to eql(false)
-      expect(subject.responds?).to eql(false)
+      expect(subject.up?).to be(false)
+      expect(subject.responds?).to be(false)
     end
 
     it 'considers a timeout to be down and unresponsive' do
       allow(subject).to receive(:response) { Typhoeus::Response.new(return_code: :operation_timedout) }
 
-      expect(subject.up?).to eql(false)
-      expect(subject.responds?).to eql(false)
+      expect(subject.up?).to be(false)
+      expect(subject.responds?).to be(false)
     end
   end
 
@@ -170,7 +171,7 @@ describe SiteInspector::Endpoint do
       stub_request(:head, 'http://example.com/')
         .to_return(status: 301, headers: { location: 'http://www.example.com' })
 
-      expect(subject.redirect?).to eql(true)
+      expect(subject.redirect?).to be(true)
     end
 
     it 'returns the redirect' do
@@ -187,14 +188,14 @@ describe SiteInspector::Endpoint do
       stub_request(:head, 'http://example.com/')
         .to_return(status: 301, headers: { location: '/foo' })
 
-      expect(subject.redirect?).to eql(false)
+      expect(subject.redirect?).to be(false)
     end
 
     it 'handles relative redirects without a leading slash' do
       stub_request(:head, 'http://example.com/')
         .to_return(status: 301, headers: { location: 'foo' })
 
-      expect(subject.redirect?).to eql(false)
+      expect(subject.redirect?).to be(false)
     end
 
     it 'knows what it resolves to' do
@@ -204,7 +205,7 @@ describe SiteInspector::Endpoint do
       stub_request(:head, 'http://www.example.com/')
         .to_return(status: 200)
 
-      expect(subject.redirect?).to eql(true)
+      expect(subject.redirect?).to be(true)
       expect(subject.resolves_to.uri.to_s).to eql('http://www.example.com/')
     end
 
@@ -215,8 +216,8 @@ describe SiteInspector::Endpoint do
       stub_request(:head, 'http://www.example.gov')
         .to_return(status: 200)
 
-      expect(subject.redirect?).to eql(true)
-      expect(subject.external_redirect?).to eql(true)
+      expect(subject.redirect?).to be(true)
+      expect(subject.external_redirect?).to be(true)
     end
 
     it 'knows internal redirects are not external redirects' do
@@ -226,24 +227,24 @@ describe SiteInspector::Endpoint do
       stub_request(:head, 'https://example.com/')
         .to_return(status: 200)
 
-      expect(subject.external_redirect?).to eql(false)
+      expect(subject.external_redirect?).to be(false)
     end
   end
 
   context 'checks' do
     it 'identifies checks' do
-      expected = 8
+      expected = 9
       pa11y = SiteInspector::Endpoint::Accessibility.pa11y?
       expected -= 1 unless pa11y
-      expect(SiteInspector::Endpoint.checks.count).to eql(expected)
+      expect(described_class.checks.count).to eql(expected)
     end
 
-    SiteInspector::Endpoint.checks.each do |check|
+    described_class.checks.each do |check|
       it "responds to the #{check} check" do
         stub_request(:head, 'http://example.com/')
           .to_return(status: 200)
 
-        expect(subject.send(check.name)).to_not be_nil
+        expect(subject.send(check.name)).not_to be_nil
         expect(subject.send(check.name).class).to eql(check)
       end
     end