site-inspector 3.1.0 → 3.1.1

data/spec/site_inspector_endpoint_spec.rb

@@ -1,100 +1,99 @@
 require 'spec_helper'
 
 describe SiteInspector::Endpoint do
+  
+  subject { SiteInspector::Endpoint.new('http://example.com') }
 
-  subject { SiteInspector::Endpoint.new("http://example.com") }
-
-  it "downcases the host" do
-    endpoint = SiteInspector::Endpoint.new("http://EXAMPLE.com")
-    expect(endpoint.host).to eql("example.com")
+  it 'downcases the host' do
+    endpoint = SiteInspector::Endpoint.new('http://EXAMPLE.com')
+    expect(endpoint.host).to eql('example.com')
   end
 
-  it "strips www from the host" do
-    endpoint = SiteInspector::Endpoint.new("http://www.example.com")
-    expect(endpoint.host).to eql("example.com")
+  it 'strips www from the host' do
+    endpoint = SiteInspector::Endpoint.new('http://www.example.com')
+    expect(endpoint.host).to eql('example.com')
   end
 
-  it "returns the uri" do
-    expect(subject.uri.to_s).to eql("http://example.com/")
+  it 'returns the uri' do
+    expect(subject.uri.to_s).to eql('http://example.com/')
   end
 
-  it "knows if an endpoint is www" do
+  it 'knows if an endpoint is www' do
     expect(subject.www?).to eql(false)
     expect(subject.root?).to eql(true)
 
-    endpoint = SiteInspector::Endpoint.new("http://www.example.com")
+    endpoint = SiteInspector::Endpoint.new('http://www.example.com')
     expect(endpoint.www?).to eql(true)
     expect(endpoint.root?).to eql(false)
   end
 
-  it "knows if an endpoint is http" do
-    stub_request(:head, "http://example.com/").
-      to_return(:status => 200, :body => "content")
+  it 'knows if an endpoint is http' do
+    stub_request(:head, 'http://example.com/')
+      .to_return(status: 200, body: 'content')
 
-    stub_request(:head, "https://example.com/").
-      to_return(:status => 500, :body => "content")
+    stub_request(:head, 'https://example.com/')
+      .to_return(status: 500, body: 'content')
 
     expect(subject.https?).to eql(false)
     expect(subject.http?).to eql(true)
   end
 
-  it "knows if an endpoint is https" do
-    stub_request(:head, "http://example.com/").
-      to_return(:status => 200, :body => "content")
+  it 'knows if an endpoint is https' do
+    stub_request(:head, 'http://example.com/')
+      .to_return(status: 200, body: 'content')
 
-    stub_request(:head, "https://example.com/").
-      to_return(:status => 200, :body => "content")
+    stub_request(:head, 'https://example.com/')
+      .to_return(status: 200, body: 'content')
 
-    endpoint = SiteInspector::Endpoint.new("https://example.com")
+    endpoint = SiteInspector::Endpoint.new('https://example.com')
     expect(endpoint.https?).to eql(true)
     expect(endpoint.http?).to eql(false)
   end
 
-  it "knows the scheme" do
-    expect(subject.scheme).to eql("http")
+  it 'knows the scheme' do
+    expect(subject.scheme).to eql('http')
 
-    endpoint = SiteInspector::Endpoint.new("https://example.com")
-    expect(endpoint.scheme).to eql("https")
+    endpoint = SiteInspector::Endpoint.new('https://example.com')
+    expect(endpoint.scheme).to eql('https')
   end
 
-  context "requests" do
-
-    it "requests a URL" do
-      stub = stub_request(:head, "http://example.com/").
-           to_return(:status => 200, :body => "content")
+  context 'requests' do
+    it 'requests a URL' do
+      stub = stub_request(:head, 'http://example.com/')
+             .to_return(status: 200, body: 'content')
 
-      expect(subject.request.body).to eql("content")
+      expect(subject.request.body).to eql('content')
       expect(stub).to have_been_requested
     end
 
-    it "requests a requested path" do
-      stub = stub_request(:head, "http://example.com/foo").
-           to_return(:status => 200, :body => "content")
+    it 'requests a requested path' do
+      stub = stub_request(:head, 'http://example.com/foo')
+             .to_return(status: 200, body: 'content')
 
-      expect(subject.request(:path => "foo").body).to eql("content")
+      expect(subject.request(path: 'foo').body).to eql('content')
       expect(stub).to have_been_requested
     end
 
-    it "requests with typhoeus options" do
-      stub_request(:head, "http://example.com/").
-           to_return(:status => 301, :headers => { :location => "http://example.com/foo" } )
+    it 'requests with typhoeus options' do
+      stub_request(:head, 'http://example.com/')
+        .to_return(status: 301, headers: { location: 'http://example.com/foo' })
 
-      response = subject.request(:followlocation => true)
+      response = subject.request(followlocation: true)
       expect(response.request.options[:followlocation]).to eql(true)
     end
 
-    it "returns the response" do
-      stub = stub_request(:head, "http://example.com/").
-           to_return(:status => 200, :body => "content")
+    it 'returns the response' do
+      stub = stub_request(:head, 'http://example.com/')
+             .to_return(status: 200, body: 'content')
 
-      expect(subject.response.body).to eql("content")
-      expect(subject.response.body).to eql("content")
+      expect(subject.response.body).to eql('content')
+      expect(subject.response.body).to eql('content')
       expect(stub).to have_been_requested.once
     end
 
     it "knows if there's a response" do
-      stub_request(:head, "http://example.com/").
-           to_return(:status => 200, :body => "content")
+      stub_request(:head, 'http://example.com/')
+        .to_return(status: 200, body: 'content')
 
       expect(subject.responds?).to eql(true)
     end
@@ -103,148 +102,149 @@ describe SiteInspector::Endpoint do
       allow(subject).to receive(:response) { Typhoeus::Response.new(code: 0) }
       expect(subject.responds?).to eql(false)
 
-      allow(subject).to receive(:response) { Typhoeus::Response.new(:return_code => :operation_timedout) }
+      allow(subject).to receive(:response) { Typhoeus::Response.new(return_code: :operation_timedout) }
       expect(subject.responds?).to eql(false)
     end
 
-    it "knows the response code" do
-      stub_request(:head, "http://example.com/").
-           to_return(:status => 200)
+    it 'knows the response code' do
+      stub_request(:head, 'http://example.com/')
+        .to_return(status: 200)
 
-      expect(subject.response_code).to eql("200")
+      expect(subject.response_code).to eql('200')
     end
 
-    it "knows if a response has timed out" do
-      allow(subject).to receive(:response) { Typhoeus::Response.new(:return_code => :operation_timedout) }
+    it 'knows if a response has timed out' do
+      allow(subject).to receive(:response) { Typhoeus::Response.new(return_code: :operation_timedout) }
       expect(subject.timed_out?).to eql(true)
     end
 
-    it "considers a 200 response code to be live and a response" do
-      stub_request(:head, "http://example.com/").
-           to_return(:status => 200)
+    it 'considers a 200 response code to be live and a response' do
+      stub_request(:head, 'http://example.com/')
+        .to_return(status: 200)
 
       expect(subject.up?).to eql(true)
       expect(subject.responds?).to eql(true)
     end
 
-    it "considers a 301 response code to be live and a response" do
-      stub_request(:head, "http://example.com/").
-           to_return(:status => 301)
+    it 'considers a 301 response code to be live and a response' do
+      stub_request(:head, 'http://example.com/')
+        .to_return(status: 301)
 
       expect(subject.up?).to eql(true)
       expect(subject.responds?).to eql(true)
     end
 
-    it "considers a 404 response code to be down but a response" do
-      stub_request(:head, "http://example.com/").
-           to_return(:status => 404)
+    it 'considers a 404 response code to be down but a response' do
+      stub_request(:head, 'http://example.com/')
+        .to_return(status: 404)
 
       expect(subject.up?).to eql(false)
       expect(subject.responds?).to eql(true)
     end
 
-    it "considers a 500 response code to be down but a response" do
-      stub_request(:head, "http://example.com/").
-           to_return(:status => 500)
+    it 'considers a 500 response code to be down but a response' do
+      stub_request(:head, 'http://example.com/')
+        .to_return(status: 500)
 
       expect(subject.up?).to eql(false)
       expect(subject.responds?).to eql(true)
     end
 
-    it "considers a 0 response code (error) to down and unresponsive" do
+    it 'considers a 0 response code (error) to down and unresponsive' do
       allow(subject).to receive(:response) { Typhoeus::Response.new(code: 0) }
 
       expect(subject.up?).to eql(false)
       expect(subject.responds?).to eql(false)
     end
 
-    it "considers a timeout to be down and unresponsive" do
-      allow(subject).to receive(:response) { Typhoeus::Response.new(:return_code => :operation_timedout) }
+    it 'considers a timeout to be down and unresponsive' do
+      allow(subject).to receive(:response) { Typhoeus::Response.new(return_code: :operation_timedout) }
 
       expect(subject.up?).to eql(false)
       expect(subject.responds?).to eql(false)
     end
   end
 
-  context "redirects" do
+  context 'redirects' do
     it "knows when there's a redirect" do
-      stub_request(:head, "http://example.com/").
-        to_return(:status => 301, :headers => { :location => "http://www.example.com" } )
+      stub_request(:head, 'http://example.com/')
+        .to_return(status: 301, headers: { location: 'http://www.example.com' })
 
       expect(subject.redirect?).to eql(true)
     end
 
-    it "returns the redirect" do
-      stub_request(:head, "http://example.com/").
-        to_return(:status => 301, :headers => { :location => "http://www.example.com" } )
+    it 'returns the redirect' do
+      stub_request(:head, 'http://example.com/')
+        .to_return(status: 301, headers: { location: 'http://www.example.com' })
 
-      stub_request(:head, "http://www.example.com/").
-        to_return(:status => 200)
+      stub_request(:head, 'http://www.example.com/')
+        .to_return(status: 200)
 
-      expect(subject.redirect.uri.to_s).to eql("http://www.example.com/")
+      expect(subject.redirect.uri.to_s).to eql('http://www.example.com/')
     end
 
-    it "handles relative redirects" do
-      stub_request(:head, "http://example.com/").
-           to_return(:status => 301, :headers => { :location => "/foo" } )
+    it 'handles relative redirects' do
+      stub_request(:head, 'http://example.com/')
+        .to_return(status: 301, headers: { location: '/foo' })
 
       expect(subject.redirect?).to eql(false)
     end
 
-    it "handles relative redirects without a leading slash" do
-      stub_request(:head, "http://example.com/").
-           to_return(:status => 301, :headers => { :location => "foo" } )
+    it 'handles relative redirects without a leading slash' do
+      stub_request(:head, 'http://example.com/')
+        .to_return(status: 301, headers: { location: 'foo' })
 
       expect(subject.redirect?).to eql(false)
     end
 
-    it "knows what it resolves to" do
-      stub_request(:head, "http://example.com/").
-        to_return(:status => 301, :headers => { :location => "http://www.example.com" } )
+    it 'knows what it resolves to' do
+      stub_request(:head, 'http://example.com/')
+        .to_return(status: 301, headers: { location: 'http://www.example.com' })
 
-      stub_request(:head, "http://www.example.com/").
-        to_return(:status => 200)
+      stub_request(:head, 'http://www.example.com/')
+        .to_return(status: 200)
 
       expect(subject.redirect?).to eql(true)
-      expect(subject.resolves_to.uri.to_s).to eql("http://www.example.com/")
+      expect(subject.resolves_to.uri.to_s).to eql('http://www.example.com/')
     end
 
-    it "detects external redirects" do
-      stub_request(:head, "http://example.com/").
-        to_return(:status => 301, :headers => { :location => "http://www.example.gov" } )
+    it 'detects external redirects' do
+      stub_request(:head, 'http://example.com/')
+        .to_return(status: 301, headers: { location: 'http://www.example.gov' })
 
-      stub_request(:head, "http://www.example.gov").
-        to_return(:status => 200)
+      stub_request(:head, 'http://www.example.gov')
+        .to_return(status: 200)
 
       expect(subject.redirect?).to eql(true)
       expect(subject.external_redirect?).to eql(true)
     end
 
-    it "knows internal redirects are not external redirects" do
-      stub_request(:head, "http://example.com/").
-        to_return(:status => 301, :headers => { :location => "https://example.com" } )
+    it 'knows internal redirects are not external redirects' do
+      stub_request(:head, 'http://example.com/')
+        .to_return(status: 301, headers: { location: 'https://example.com' })
 
-      stub_request(:head, "https://example.com/").
-        to_return(:status => 200)
+      stub_request(:head, 'https://example.com/')
+        .to_return(status: 200)
 
       expect(subject.external_redirect?).to eql(false)
     end
   end
 
-  context "checks" do
-    it "identifies checks" do
-      expect(SiteInspector::Endpoint.checks.count).to eql(8)
+  context 'checks' do
+    it 'identifies checks' do
+      expected = 8
+      pa11y = SiteInspector::Endpoint::Accessibility.pa11y?
+      expected -= 1 unless pa11y
+      expect(SiteInspector::Endpoint.checks.count).to eql(expected)
     end
 
     SiteInspector::Endpoint.checks.each do |check|
       it "responds to the #{check} check" do
-
-        stub_request(:head, "http://example.com/").
-          to_return(:status => 200)
+        stub_request(:head, 'http://example.com/')
+          .to_return(status: 200)
 
         expect(subject.send(check.name)).to_not be_nil
         expect(subject.send(check.name).class).to eql(check)
-
       end
     end
   end

data/spec/site_inspector_spec.rb

@@ -1,45 +1,44 @@
 require 'spec_helper'
 
 describe SiteInspector do
-
   before do
-    SiteInspector.instance_variable_set("@cache", nil)
-    SiteInspector.instance_variable_set("@timeout", nil)
+    SiteInspector.instance_variable_set('@cache', nil)
+    SiteInspector.instance_variable_set('@timeout', nil)
   end
 
-  it "defaults to ephemeral cache" do
-    with_env "CACHE", nil do
+  it 'defaults to ephemeral cache' do
+    with_env 'CACHE', nil do
       expect(SiteInspector.cache.class).to be(SiteInspector::Cache)
     end
   end
 
-  it "uses disk cache when requested" do
-    with_env "CACHE", "/tmp" do
+  it 'uses disk cache when requested' do
+    with_env 'CACHE', '/tmp' do
       expect(SiteInspector.cache.class).to be(SiteInspector::DiskCache)
     end
   end
 
-  it "returns the default timeout" do
+  it 'returns the default timeout' do
     expect(SiteInspector.timeout).to eql(10)
   end
 
-  it "honors custom timeouts" do
+  it 'honors custom timeouts' do
     SiteInspector.timeout = 20
     expect(SiteInspector.timeout).to eql(20)
   end
 
-  it "returns a domain when inspecting" do
-    expect(SiteInspector.inspect("example.com").class).to be(SiteInspector::Domain)
+  it 'returns a domain when inspecting' do
+    expect(SiteInspector.inspect('example.com').class).to be(SiteInspector::Domain)
   end
 
-  it "returns the typhoeus defaults" do
+  it 'returns the typhoeus defaults' do
     expected = {
-      :accept_encoding => "gzip",
-      :followlocation => false,
-      :method  => :head,
-      :timeout => 10,
-      :headers => {
-        "User-Agent" => "Mozilla/5.0 (compatible; SiteInspector/#{SiteInspector::VERSION}; +https://github.com/benbalter/site-inspector)"
+      accept_encoding: 'gzip',
+      followlocation:  false,
+      method:          :head,
+      timeout:         10,
+      headers:         {
+        'User-Agent' => "Mozilla/5.0 (compatible; SiteInspector/#{SiteInspector::VERSION}; +https://github.com/benbalter/site-inspector)"
       }
     }
     expect(SiteInspector.typhoeus_defaults).to eql(expected)

data/spec/spec_helper.rb

@@ -1,7 +1,7 @@
-require "bundler/setup"
+require 'bundler/setup'
 require 'webmock/rspec'
 require 'fileutils'
-require_relative "../lib/site-inspector"
+require_relative '../lib/site-inspector'
 
 WebMock.disable_net_connect!
 
@@ -13,5 +13,5 @@ def with_env(key, value)
 end
 
 def tmpdir
-  File.expand_path "../tmp", File.dirname(__FILE__)
+  File.expand_path '../tmp', File.dirname(__FILE__)
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: site-inspector
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.1
 platform: ruby
 authors:
 - Ben Balter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-10 00:00:00.000000000 Z
+date: 2016-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -234,6 +234,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.2'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.35'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.35'
 description: Returns information about a domain's technology and capabilities
 email: ben@balter.com
 executables:
@@ -242,6 +256,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".ruby-version"
 - ".travis.yml"
 - Gemfile
@@ -250,6 +265,7 @@ files:
 - README.md
 - Rakefile
 - bin/site-inspector
+- lib/cliver/dependency_ext.rb
 - lib/data/cdn.yml
 - lib/data/cloud.yml
 - lib/site-inspector.rb
@@ -272,6 +288,7 @@ files:
 - script/bootstrap
 - script/cibuild
 - script/console
+- script/pa11y-version
 - script/release
 - site-inspector.gemspec
 - spec/checks/site_inspector_endpoint_accessibility_spec.rb
@@ -309,7 +326,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: A Ruby port and v2 of Site Inspector (https://github.com/benbalter/site-inspector)
@@ -329,3 +346,4 @@ test_files:
 - spec/site_inspector_endpoint_spec.rb
 - spec/site_inspector_spec.rb
 - spec/spec_helper.rb
+has_rdoc: