sisow 0.9.5 → 0.9.9

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sisow (0.9.4)
+    sisow (0.9.5)
       hashie
       httparty
 

data/lib/sisow/api/request/transaction_request.rb

@@ -47,7 +47,7 @@ module Sisow
       private
 
         def transaction_params
-          {
+          params = {
             :payment      => payment.payment_method,
             :purchaseid   => payment.purchase_id,
             :amount       => payment.amount,
@@ -61,6 +61,25 @@ module Sisow
             :shop_id      => payment.shop_id,
             :sha1         => sha1
           }
+
+          # Only iDEAL payments need an actual issuerid
+          #
+          # In test mode, the other payment types need an issuerid
+          # that is '99' (otherwise you will always get a
+          # production payment URL, regardless of 'test=true'
+          # in the request.
+          #
+          # In production mode, the other payment types do
+          # not need an issuerid at all, so we just delete it.
+          unless payment.ideal?
+            if Sisow.configuration.test_mode_enabled?
+              params[:issuerid] = '99'
+            else
+              params.delete(:issuerid)
+            end
+          end
+
+          params
         end
 
         def payment

data/lib/sisow/payment.rb

@@ -35,6 +35,10 @@ module Sisow
       (!amount.nil? && amount != '')
     end
 
+    def ideal?
+      payment_method == 'ideal'
+    end
+
     def payment_method; raise 'Implement me in a subclass'; end
 
     private

data/lib/sisow/version.rb

@@ -1,3 +1,3 @@
 module Sisow
-  VERSION = "0.9.5"
+  VERSION = "0.9.9"
 end

data/spec/models/transaction_request_spec.rb

@@ -21,4 +21,41 @@ describe Sisow::Api::TransactionRequest do
 
   end
 
+  it "should not remove issuerid when it is an iDEAL payment" do
+    payment = Sisow::IdealPayment.new
+    request = Sisow::Api::TransactionRequest.new(payment)
+
+    request.params.keys.should include(:issuerid)
+  end
+
+  it "should remove issuerid from params for Bancontact" do
+    Sisow.configuration.stub!(:test_mode_enabled?).and_return(false)
+    payment = Sisow::BancontactPayment.new
+    request = Sisow::Api::TransactionRequest.new(payment)
+
+    request.params.keys.should_not include(:issuerid)
+  end
+
+  it "should force issuerid to '99' for Bancontact in test mode" do
+    payment = Sisow::BancontactPayment.new
+    request = Sisow::Api::TransactionRequest.new(payment)
+
+    request.params[:issuerid].should == '99'
+  end
+
+  it "should remove issuerid from params for Sofort" do
+    Sisow.configuration.stub!(:test_mode_enabled?).and_return(false)
+    payment = Sisow::SofortPayment.new
+    request = Sisow::Api::TransactionRequest.new(payment)
+
+    request.params.keys.should_not include(:issuerid)
+  end
+
+  it "should force issuerid to '99' for Sofort in test mode" do
+    payment = Sisow::SofortPayment.new
+    request = Sisow::Api::TransactionRequest.new(payment)
+
+    request.params[:issuerid].should == '99'
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sisow
 version: !ruby/object:Gem::Version
-  version: 0.9.5
+  version: 0.9.9
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-12 00:00:00.000000000 Z
+date: 2012-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty