sisow 0.9.0 → 0.9.3

data/.gitignore

@@ -2,6 +2,7 @@
 .bundle
 Gemfile.lock
 pkg/*
-lib/sisow.yml
+spec/sisow.yml
 coverage/
 spec/vcr_cassettes
+.rvmrc

data/.travis.yml

@@ -0,0 +1,7 @@
+language: ruby
+rvm:
+  - 1.8.7
+  - 1.9.3
+  - ree
+before_script: cp spec/sisow.yml.example spec/sisow.yml
+after_script: rm spec/sisow.yml

data/Gemfile

@@ -2,3 +2,7 @@ source "http://rubygems.org"
 
 # Specify your gem's dependencies in sisow.gemspec
 gemspec
+
+group :test do
+  gem 'rake'
+end

data/README.rdoc

@@ -1,4 +1,5 @@
 = Sisow
+{<img src="https://secure.travis-ci.org/marceldegraaf/sisow.png" />}[http://travis-ci.org/marceldegraaf/sisow]
 
 *NOTE* This gem is work in progress. I'm planning to have it ready somewhere in March.
 
@@ -22,7 +23,7 @@ And update your bundle with <tt>bundle install</tt>
 
 To be able to use the gem, you must first configure it. If you're on Rails, insert the following code in <tt>config/initializers/sisow.rb</tt>:
 
-  Sisow.setup do |config|
+  Sisow.configure do |config|
     config.merchant_key = 'your-merchant-key'
     config.merchant_id  = 'your-merchant-id'
 
@@ -57,7 +58,7 @@ Setting up a payment looks like this:
     :issuer_id      => '99',                    # the issuer id from the previous step
     :description    => 'Acme Inc. payment',     # description of this payment
     :amount         => 1299,                    # amount in Euro in cents
-    :entrance_code  => 'foobar-foxtrot',        # a verification code you can choose. Cannot contain spaces
+    :entrance_code  => 'foobarfoxtrot',         # internal verification code of your choice
     :return_url     => 'http://example.com',    # where the user is sent after the payment
     :cancel_url     => 'http://example.com',    # where the user is sent when he cancels the payment
     :callback_url   => 'http://example.com',    # where a failed (not cancelled) payment will be reported

data/Rakefile

@@ -1,2 +1,11 @@
 require 'bundler'
+require 'rspec/core/rake_task'
+
 Bundler::GemHelper.install_tasks
+
+desc 'Default: run specs.'
+task :default => :spec
+
+desc "Run specs"
+RSpec::Core::RakeTask.new do |t|
+end

data/lib/sisow/api/request/ping_request.rb

@@ -7,7 +7,7 @@ module Sisow
       end
 
       def params
-        default_params
+        {}
       end
 
       def clean(response)

data/lib/sisow/api/request.rb

@@ -25,7 +25,6 @@ module Sisow
       def default_params
         {
           :merchantid  => Sisow.configuration.merchant_id,
-          :merchantkey => Sisow.configuration.merchant_key,
           :test        => Sisow.configuration.test_mode_enabled?? test_mode_param : nil
         }
       end
@@ -38,7 +37,7 @@ module Sisow
       private
 
         def can_perform?
-          !Sisow.configuration.merchant_id.empty? && !Sisow.configuration.merchant_key.empty?
+          !(Sisow.configuration.merchant_id.nil? || Sisow.configuration.merchant_id.empty?) && !(Sisow.configuration.merchant_key.nil? || Sisow.configuration.merchant_key.empty?)
         end
 
         def uri

data/lib/sisow/configuration.rb

@@ -29,5 +29,13 @@ module Sisow
       @debug_mode == true
     end
 
+    def merchant_key=(merchant_key)
+      @merchant_key = merchant_key.to_s
+    end
+
+    def merchant_id=(merchant_id)
+      @merchant_id = merchant_id.to_s
+    end
+
   end
 end

data/lib/sisow/version.rb

@@ -1,3 +1,3 @@
 module Sisow
-  VERSION = "0.9.0"
+  VERSION = "0.9.3"
 end

data/spec/models/configuration_spec.rb

@@ -21,5 +21,15 @@ describe Sisow::Configuration do
     @configuration.debug_mode_enabled?.should == true
   end
 
+  it "should always save merchant_key as string" do
+    @configuration.merchant_key = 123
+    @configuration.merchant_key.should == '123'
+  end
+
+  it "should always save merchant_id as string" do
+    @configuration.merchant_id = 123
+    @configuration.merchant_id.should == '123'
+  end
+
 
 end

data/spec/sisow.yml.example

@@ -1,2 +1,5 @@
-merchant_id:  '1234567890'
-merchant_key: '1234567890abcdefg1234567890'
+#
+# These credentials belong to a testing account in Sisow
+#
+merchant_id:  '2537407799'
+merchant_key: '0f9b49d384b4836c543f76d23a923e2cd2cfaec6'

metadata

@@ -2,7 +2,7 @@
 name: sisow
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.9.0
+  version: 0.9.3
 platform: ruby
 authors: 
 - Marcel de Graaf
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-03-10 00:00:00 +01:00
+date: 2012-03-16 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -90,6 +90,7 @@ extra_rdoc_files: []
 
 files: 
 - .gitignore
+- .travis.yml
 - Gemfile
 - README.rdoc
 - Rakefile
@@ -125,7 +126,6 @@ files:
 - spec/models/sisow_spec.rb
 - spec/models/sofort_payment_spec.rb
 - spec/models/transaction_request_spec.rb
-- spec/sisow.yml
 - spec/sisow.yml.example
 - spec/spec_helper.rb
 - spec/vcr_setup.rb
@@ -171,7 +171,6 @@ test_files:
 - spec/models/sisow_spec.rb
 - spec/models/sofort_payment_spec.rb
 - spec/models/transaction_request_spec.rb
-- spec/sisow.yml
 - spec/sisow.yml.example
 - spec/spec_helper.rb
 - spec/vcr_setup.rb

data/spec/sisow.yml

@@ -1,2 +0,0 @@
-merchant_id:  '2537388949'
-merchant_key: '4553175f82004fcbf9d0582466a1e731a4357b21'