sisimai 5.4.1 → 5.5.0

data/lib/sisimai/lhost/zoho.rb

@@ -19,7 +19,7 @@ module Sisimai::Lhost
         # X-ZohoMail: Si CHF_MF_NL SS_10 UW48 UB48 FMWL UW48 UB48 SGR3_1_09124_42
         # X-Zoho-Virus-Status: 2
         # X-Mailer: Zoho Mail
-        return nil unless mhead['x-zohomail']
+        return nil if mhead['x-zohomail'].nil?
 
         dscontents = [Sisimai::Lhost.DELIVERYSTATUS]; v = nil
         emailparts = Sisimai::RFC5322.part(mbody, Boundaries)
@@ -68,7 +68,7 @@ module Sisimai::Lhost
             end
             recipients += 1
 
-          elsif e.start_with?('[Status: ')
+          elsif e.start_with?('[Status: ') && e.include?('<') && e.include?('>')
             # Expired
             # [Status: Error, Address: <kijitora@6kaku.example.co.jp>, ResponseCode 421, , Host not reachable.]
             if v["recipient"] != ""
@@ -83,17 +83,17 @@ module Sisimai::Lhost
             recipients += 1
           else
             # Continued line
-            next unless qprintable
+            next if qprintable == false
             v['diagnosis'] += e
           end
         end
-        return nil unless recipients > 0
+        return nil if recipients == 0
 
         dscontents.each do |e|
           e['diagnosis'] = Sisimai::String.sweep(e['diagnosis'].tr("\n", ' '))
           MessagesOf.each_key do |r|
             # Verify each regular expression of session errors
-            next unless MessagesOf[r].any? { |a| e['diagnosis'].include?(a) }
+            next if MessagesOf[r].none? { |a| e['diagnosis'].include?(a) }
             e['reason'] = r
             break
           end

data/lib/sisimai/lhost.rb

@@ -9,20 +9,21 @@ module Sisimai
       # @private
       def DELIVERYSTATUS
         return {
-          'spec'         => "",  # Protocl specification
-          'date'         => "",  # The value of Last-Attempt-Date header
-          'rhost'        => "",  # The value of Remote-MTA header
-          'lhost'        => "",  # The value of Received-From-MTA header
-          'alias'        => "",  # The value of alias entry(RHS)
-          'agent'        => "",  # MTA module name
-          'action'       => "",  # The value of Action header
-          'status'       => "",  # The value of Status header
-          'reason'       => "",  # Temporary reason of bounce
-          'command'      => "",  # SMTP command in the message body
-          'replycode'    => "",  # SMTP Reply code
-          'diagnosis'    => "",  # The value of Diagnostic-Code header
-          'recipient'    => "",  # The value of Final-Recipient header
-          'feedbacktype' => "",  # Feedback Type
+          'spec'         => "",     # Protocl specification
+          'date'         => "",     # The value of Last-Attempt-Date header
+          'rhost'        => "",     # The value of Remote-MTA header
+          'lhost'        => "",     # The value of Received-From-MTA header
+          'alias'        => "",     # The value of alias entry(RHS)
+          'agent'        => "",     # MTA module name
+          'action'       => "",     # The value of Action header
+          'status'       => "",     # The value of Status header
+          'reason'       => "",     # Temporary reason of bounce
+          'command'      => "",     # SMTP command in the message body
+          'replycode'    => "",     # SMTP Reply code
+          'diagnosis'    => "",     # The value of Diagnostic-Code header
+          'recipient'    => "",     # The value of Final-Recipient header
+          'feedbacktype' => "",     # Feedback Type
+          'toxic'        => false,  # EXPERIMENTAL
         }
       end
 
@@ -41,9 +42,9 @@ module Sisimai
       def index
         return %w[
           Activehunter AmazonSES ApacheJames Biglobe Courier Domino DragonFly EZweb EinsUndEins Exchange2003
-          Exchange2007 Exim FML GMX GoogleWorkspace GoogleGroups Gmail IMailServer InterScanMSS KDDI
-          MailFoundry MailMarshalSMTP MessagingServer Notes OpenSMTPD Postfix Sendmail V5sendmail
-          Verizon X1 X2 X3 X6 Zoho MFILTER Qmail
+          Exchange2007 Exim FML GMX GoogleWorkspace GoogleGroups Gmail IMailServer KDDI MailFoundry Mimecast
+          MailMarshal MessagingServer Notes OpenSMTPD Postfix Sendmail TrendMicro V5sendmail Verizon
+          X1 X2 X3 X6 Zoho MFILTER Qmail
         ]
       end
 

data/lib/sisimai/mail/maildir.rb

@@ -16,8 +16,8 @@ module Sisimai
       # @return   [Sisimai::Mail::Maildir]  Object
       #           [Nil]                     is not a directory or does not exist
       def initialize(argv1)
-        raise Errno::ENOENT  unless File.exist?(argv1)
-        raise Errno::ENOTDIR unless File.ftype(argv1) == 'directory'
+        raise Errno::ENOENT  if File.exist?(argv1) == false
+        raise Errno::ENOTDIR if File.ftype(argv1)  != 'directory'
 
         @path   = nil
         @size   = Dir.entries(argv1).size
@@ -30,7 +30,7 @@ module Sisimai
       # Maildir reader, works as an iterator.
       # @return       [String] Contents of file in Maildir/
       def read
-        return nil unless self.offset < self.size
+        return nil if self.offset >= self.size
         seekhandle = self.handle
         readbuffer = ''
 
@@ -61,7 +61,7 @@ module Sisimai
             self.file    = r
             break
           end
-          seekhandle.close unless self.offset < self.size
+          seekhandle.close if self.offset >= self.size
         end
 
         return readbuffer

data/lib/sisimai/mail/mbox.rb

@@ -16,8 +16,8 @@ module Sisimai
       # @return   [Sisimai::Mail::Mbox]   Object
       #           [Nil]                   is not specified or does not exist
       def initialize(argv1)
-        raise Errno::ENOENT   unless File.exist?(argv1)
-        raise 'is not a file' unless File.ftype(argv1) == 'file'
+        raise Errno::ENOENT   if File.exist?(argv1) == false
+        raise 'is not a file' if File.ftype(argv1)  != 'file'
 
         @path   = argv1
         @dir    = File.dirname(argv1)
@@ -30,7 +30,7 @@ module Sisimai
       # Mbox reader, works as an iterator.
       # @return   [String] Contents of mbox
       def read
-        return nil unless self.offset < self.size
+        return nil if self.offset >= self.size
 
         seekoffset = self.offset || 0
         filehandle = self.handle
@@ -53,7 +53,7 @@ module Sisimai
           seekoffset = filehandle.pos - frombuffer.bytesize
           frombuffer = ''
           self.offset = seekoffset
-          filehandle.close unless self.offset < self.size
+          filehandle.close if self.offset >= self.size
         end
 
         return readbuffer.to_s

data/lib/sisimai/mail/memory.rb

@@ -14,7 +14,7 @@ module Sisimai
       # @return   [Sisimai::Mail::Memory] Object
       #           [Nil]                   is not specified or does not exist
       def initialize(argv1)
-        raise 'is not a String' unless argv1.is_a? ::String
+        raise 'is not a String' if argv1.is_a?(::String) == false
         raise 'is empty'        if argv1.empty?
 
         @path    = '<MEMORY>'

data/lib/sisimai/mail/stdin.rb

@@ -13,7 +13,7 @@ module Sisimai
       # @param    [IO::STDIN] stdin      Standard-In
       # @return   [Sisimai::Mail::STDIN] Object
       def initialize(stdin = $stdin)
-        raise 'is not an IO object' unless stdin.is_a?(IO)
+        raise 'is not an IO object' if stdin.is_a?(IO) == false
 
         @path   = '<STDIN>'
         @size   = nil
@@ -32,7 +32,7 @@ module Sisimai
         end
 
         begin
-          readhandle = STDIN unless readhandle
+          readhandle = STDIN if readhandle.nil?
           while r = readhandle.gets
             break if readbuffer.size > 0 && r.start_with?('From ')
             readbuffer << r

data/lib/sisimai/message.rb

@@ -21,12 +21,15 @@ module Sisimai
       FieldIndex = [Fields1894.flatten, Fields5322.flatten, Fields5965.flatten].flatten.freeze
       FieldTable = FieldIndex.map { |e| [e.downcase, e] }.to_h.freeze
       Boundaries = ['Content-Type: message/rfc822', 'Content-Type: text/rfc822-headers'].freeze
-      ReplacesAs = {
-        "Content-Type" => [
-          %w[message/xdelivery-status message/delivery-status],
-          %w[message/disposition-notification message/delivery-status],
-        ]
-      }.freeze
+      MediaTypes = [
+        %w[message/xdelivery-status message/delivery-status],
+        %w[message/disposition-notification message/delivery-status],
+        %w[message/global-delivery-status message/delivery-status],
+        %w[message/global-disposition-notification  message/delivery-status],
+        %w[message/global-delivery-status message/delivery-status],
+        %w[message/global-headers text/rfc822-headers],
+        %w[message/global message/rfc822],
+      ].freeze
 
       # Read an email message and convert to structured format
       # @param         [Hash] argvs       Module to be loaded
@@ -35,7 +38,7 @@ module Sisimai
       # @return        [Sisimai::Message] Structured email data or nil if each
       #                                   value of the arguments are missing
       def rise(**argvs)
-        return nil unless argvs
+        return nil if argvs.nil?
         email = argvs[:data].scrub('?').gsub("\r\n", "\n")
         thing = {'from' => '','header' => {}, 'rfc822' => '', 'ds' => [], 'catch' => nil}
         param = {}
@@ -53,12 +56,12 @@ module Sisimai
           thing['header'] = Sisimai::Message.makemap(aftersplit[1])
 
           # 3. Decode and rewrite the "Subject:" header
-          unless thing['header']['subject'].empty?
+          if thing['header']['subject'].empty? == false
             # Decode MIME-Encoded "Subject:" header
             cv = thing['header']['subject']
             cq = Sisimai::RFC2045.is_encoded(cv) ? Sisimai::RFC2045.decodeH(cv.split(/[ ]/)) : cv
             cl = cq.downcase
-            p1 = cl.index('fwd:'); p1 = cl.index('fw:') unless p1
+            p1 = cl.index('fwd:'); p1 = cl.index('fw:') if p1.nil?
 
             # Remove "Fwd:" string from the Subject: header
             if p1
@@ -77,17 +80,16 @@ module Sisimai
             'tryonfirst' => Sisimai::Order.make(thing['header']['subject'])
           }
           break if beforefact = Sisimai::Message.sift(param)
-          break unless Boundaries.any? { |a| aftersplit[2].include?(a) }
+          break if Boundaries.none? { |a| aftersplit[2].include?(a) }
 
           # 5. Try to sift again
           #    There is a bounce message inside of mutipart/*, try to sift the first message/rfc822
           #    part as a entire message body again.
           parseagain += 1
           email = Sisimai::RFC5322.part(aftersplit[2], Boundaries, true).pop.sub(/\A\s+/, '')
-          break unless email.size > 128
+          break if email.size < 128
         end
-        return nil unless beforefact
-        return nil if beforefact.empty?
+        return nil if beforefact.nil? || beforefact.empty?
 
         # 6. Rewrite headers of the original message in the body part
         %w|ds catch rfc822|.each { |e| thing[e] = beforefact[e] }
@@ -109,8 +111,7 @@ module Sisimai
         email.gsub!(/\r\n/, "\n") if email.include?("\r\n")
 
         (parts[1], parts[2]) = email.split(/\n\n/, 2)
-        return nil unless parts[1]
-        return nil unless parts[2]
+        return nil if parts[1].nil? || parts[2].nil?
 
         if parts[1].start_with?('From ')
           # From MAILER-DAEMON Tue Feb 11 00:00:00 2014
@@ -119,7 +120,7 @@ module Sisimai
           # Set pseudo UNIX From line
           parts[0] = 'MAILER-DAEMON Tue Feb 11 00:00:00 2014'
         end
-        parts[1] += "\n" unless parts[1].end_with?("\n")
+        parts[1] += "\n" if parts[1].end_with?("\n") == false
 
         %w[image/ application/ text/html].each do |e|
           # https://github.com/sisimai/p5-sisimai/issues/492, Reduce email size
@@ -128,8 +129,8 @@ module Sisimai
           ep = e == 'text/html' ? '</html>' : "--\n"
           while true
             # Remove each part from "Content-Type: image/..." to "--\n" (the end of each boundary)
-            p0 = parts[2].index("Content-Type: #{e}", p0); break unless p0
-            p1 = parts[2].index(ep, p0 + 32);              break unless p1
+            p0 = parts[2].index("Content-Type: #{e}", p0); break if p0.nil?
+            p1 = parts[2].index(ep, p0 + 32);              break if p1.nil?
             parts[2][p0, p1 - p0] = ''
           end
         end
@@ -170,8 +171,7 @@ module Sisimai
         end
         headermaps['received'] = receivedby
 
-        return headermaps unless argv1
-        return headermaps if headermaps['subject'].empty?
+        return headermaps if argv1.nil? || headermaps['subject'].empty?
 
         # Convert MIME-Encoded subject
         if Sisimai::String.is_8bit(headermaps['subject'])
@@ -209,7 +209,7 @@ module Sisimai
           # Find and tidy up fields defined in RFC5322, RFC1894, and RFC5965
           # 1. Find a field label defined in RFC5322, RFC1894, or RFC5965 from this line
           p0 = e.index(':') || -1
-          cf = e.downcase[0, p0]
+          cf = e.downcase[0, p0].to_s.rstrip
           fn = FieldTable[cf] || ''
 
           index += 1
@@ -227,7 +227,7 @@ module Sisimai
             # Such as Diagnostic-Code, Remote-MTA, and so on
             # - Before: Diagnostic-Code: SMTP;550 User unknown
             # - After:  Diagnostic-Code: smtp; 550 User unknown
-            break unless ['Content-Type'].concat(Fields1894).any? { |a| a == fn }
+            break if ['Content-Type'].concat(Fields1894).none? { |a| a == fn }
 
             if p1
               # The field including one or more ";"
@@ -251,7 +251,8 @@ module Sisimai
                     ps = f[0, p2].downcase
                     f[0, p2] = ps
                   end
-                  f.downcase! unless ps == 'boundary'
+                  f.downcase! if ps != 'boundary'
+                  f = 'rfc822' if f == 'rfc/822'
                   break
                 end
                 ab << f
@@ -261,9 +262,9 @@ module Sisimai
                 # Diagnostic-Code: x-unix;
                 #   /var/email/kijitora/Maildir/tmp/1000000000.A000000B00000.neko22:
                 #   Disk quota exceeded
-                break unless fn == 'Diagnostic-Code'
-                break unless ab.size == 1
-                break unless lines[index + 1].start_with?(' ')
+                break if fn != 'Diagnostic-Code'
+                break if ab.size != 1
+                break if lines[index + 1].start_with?(' ') == false
 
                 ab << ''
                 break
@@ -281,9 +282,9 @@ module Sisimai
           end
 
           # 3. Tidy up a value, and a parameter of Content-Type: field
-          if ReplacesAs.has_key?(fn)
+          if fn == "Content-Type"
             # Replace the value of "Content-Type" field
-            ReplacesAs[fn].each do |f|
+            MediaTypes.each do |f|
               # - Before: Content-Type: message/xdelivery-status; ...
               # - After:  Content-Type: message/delivery-status; ...
               p1 = bf.index(f[0]) || next
@@ -296,7 +297,7 @@ module Sisimai
           email += sprintf("%s: %s\n", fn, bf)
         end
 
-        email += "\n" unless email.end_with?("\n\n")
+        email += "\n" if email.end_with?("\n\n") == false
         return email
       end
 
@@ -311,14 +312,13 @@ module Sisimai
       # @param options argvs [Array] tryonfirst  MTA module list to load on first
       # @return              [Hash]          Decoded and structured bounce mails
       def sift(argvs)
-        return nil unless argvs['mail']
-        return nil unless argvs['body']
+        return nil if argvs['mail'].nil? || argvs['body'].nil?
 
         mailheader = argvs['mail']['header']
         bodystring = argvs['body']
         hookmethod = argvs['hook'] || nil
         havecaught = nil
-        return nil unless mailheader
+        return nil if mailheader.nil?
 
         # PRECHECK_EACH_HEADER:
         # Set empty string if the value is nil
@@ -351,7 +351,7 @@ module Sisimai
           # NOT text/plain
           # In case of Content-Type: multipart/*
           p = Sisimai::RFC2045.makeflat(mailheader['content-type'], bodystring)
-          bodystring = p unless p.empty?
+          bodystring = p if p.empty? == false
         end
         bodystring = bodystring.scrub('?').delete("\r").gsub("\t", " ")
 
@@ -412,7 +412,7 @@ module Sisimai
             break # as of now, we have no sample email for coding this block
           end
         end
-        return nil unless havesifted
+        return nil if havesifted.nil?
 
         havesifted['catch'] = havecaught
         modulename = modulename.sub(/\A.+::/, '')

data/lib/sisimai/order.rb

@@ -11,7 +11,7 @@ module Sisimai
         'Sisimai::Lhost::Sendmail',
         'Sisimai::Lhost::Exchange2007',
         'Sisimai::Lhost::Exchange2003',
-        'Sisimai::Lhost::InterScanMSS',
+        'Sisimai::Lhost::TrendMicro',
         'Sisimai::Lhost::KDDI',
         'Sisimai::Lhost::FML',
         'Sisimai::Lhost::Verizon',
@@ -38,7 +38,7 @@ module Sisimai
         'Sisimai::Lhost::MFILTER',
         'Sisimai::Lhost::MailFoundry',
         'Sisimai::Lhost::GoogleGroups',
-        'Sisimai::Lhost::MailMarshalSMTP',
+        'Sisimai::Lhost::MailMarshal',
         'Sisimai::Lhost::V5sendmail',
         'Sisimai::Lhost::EZweb',
         'Sisimai::Lhost::Biglobe',
@@ -84,7 +84,7 @@ module Sisimai
           'Sisimai::Lhost::Zoho',
           'Sisimai::Lhost::EinsUndEins',
         ],
-        'mail-could'   => ['Sisimai::Lhost::InterScanMSS'],
+        'mail-could'   => ['Sisimai::Lhost::TrendMicro'],
         'mail-failure' => ['Sisimai::Lhost::Exim'],
         'mail-system'  => ['Sisimai::Lhost::EZweb'],
         'message-delivery' => ['Sisimai::Lhost::MailFoundry'],
@@ -92,6 +92,7 @@ module Sisimai
         'non-recapitabile' => ['Sisimai::Lhost::Exchange2007'],
         'non-remis' => ['Sisimai::Lhost::Exchange2007'],
         'notice'    => ['Sisimai::Lhost::Courier'],
+        'postmaster-email'   => ['Sisimai::Lhost::Mimecast'],
         'postmaster-notify'  => ['Sisimai::Lhost::Sendmail'],
         'returned-mail' => [
           'Sisimai::Lhost::Sendmail',
@@ -101,7 +102,7 @@ module Sisimai
         ],
         'there-was'          => ['Sisimai::Lhost::X6'],
         'undeliverable'      => ['Sisimai::Lhost::Exchange2007', 'Sisimai::Lhost::Exchange2003'],
-        'undeliverable-mail' => ['Sisimai::Lhost::MailMarshalSMTP', 'Sisimai::Lhost::IMailServer'],
+        'undeliverable-mail' => ['Sisimai::Lhost::MailMarshal', 'Sisimai::Lhost::IMailServer'],
         'undeliverable-message' => ['Sisimai::Lhost::Notes', 'Sisimai::Lhost::Verizon'],
         'undelivered-mail'      => ['Sisimai::Lhost::Postfix', 'Sisimai::Lhost::Zoho'],
         'warning'               => ['Sisimai::Lhost::Sendmail', 'Sisimai::Lhost::Exim'],

data/lib/sisimai/reason/authfailure.rb

@@ -38,7 +38,7 @@ module Sisimai
         # @param    [String] argv1  String to be matched with regular expressions
         # @return   [Boolean]       false: Did not match, true: Matched
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return true  if Pairs.any? { |a| Sisimai::String.aligned(argv1, a) }
           return false

data/lib/sisimai/reason/badreputation.rb

@@ -30,7 +30,7 @@ module Sisimai
         # @param    [String] argv1  String to be matched with regular expressions
         # @return   [Boolean]       false: Did not match, true: Matched
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return false
         end

data/lib/sisimai/reason/blocked.rb

@@ -41,6 +41,7 @@ module Sisimai
           'invalid ip for sending mail of domain',
           'is in a black list',
           'is not allowed to send mail from',
+          'mailfrom domain is listed in spamhaus',
           'no access from mail server',
           'no matches to nameserver query',
           'not currently accepting mail from your ip',    # Microsoft
@@ -102,7 +103,7 @@ module Sisimai
         # @param    [String] argv1  String to be matched with regular expressions
         # @return   [Boolean]       false: Did not match, true: Matched
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return true  if Pairs.any? { |a| Sisimai::String.aligned(argv1, a) }
           return false

data/lib/sisimai/reason/contenterror.rb

@@ -9,7 +9,6 @@ module Sisimai
     module ContentError
       class << self
         Index = [
-          'duplicate header',
           'header size exceeds maximum permitted',
           'improper use of 8-bit data in message header',
           'message header size, or recipient list, exceeds policy limit',
@@ -27,7 +26,7 @@ module Sisimai
         # @param    [String] argv1  String to be matched with regular expressions
         # @return   [Boolean]       false: Did not match, true: Matched
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return false
         end

data/lib/sisimai/reason/exceedlimit.rb

@@ -19,7 +19,7 @@ module Sisimai
         # @param    [String] argv1  String to be matched with regular expressions
         # @return   [Boolean]       false: Did not match, true: Matched
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return false
         end

data/lib/sisimai/reason/expired.rb

@@ -42,7 +42,7 @@ module Sisimai
         # @param    [String] argv1  String to be matched with regular expressions
         # @return   [Boolean]       false: Did not match, true: Matched
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return true  if Pairs.any? { |a| Sisimai::String.aligned(argv1, a) }
           return false

data/lib/sisimai/reason/failedstarttls.rb

@@ -17,7 +17,7 @@ module Sisimai
         # @param    [String] argv1  String to be matched with regular expressions
         # @return   [Boolean]       false: Did not match, true: Matched
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return false
         end

data/lib/sisimai/reason/filtered.rb

@@ -35,7 +35,7 @@ module Sisimai
         # @param    [String] argv1  String to be matched with regular expressions
         # @return   [Boolean]       false: Did not match, true: Matched
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return false
         end

data/lib/sisimai/reason/hasmoved.rb

@@ -17,7 +17,7 @@ module Sisimai
         # @param    [String] argv1  String to be matched with regular expressions
         # @return   [Boolean]       false: Did not match, true: Matched
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return false
         end

data/lib/sisimai/reason/hostunknown.rb

@@ -35,7 +35,7 @@ module Sisimai
         # @return   [Boolean]       false: Did not match, true: Matched
         # @since v4.0.0
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return true  if Pairs.any? { |a| Sisimai::String.aligned(argv1, a) }
           return false
@@ -55,7 +55,7 @@ module Sisimai
           if Sisimai::SMTP::Status.name(statuscode) == 'hostunknown'
             # To prevent classifying DNS errors as "HostUnknown"
             require 'sisimai/reason/networkerror'
-            return true unless Sisimai::Reason::NetworkError.match(issuedcode)
+            return true if Sisimai::Reason::NetworkError.match(issuedcode) == false
           else
             # Status: 5.1.2
             # Diagnostic-Code: SMTP; 550 Host unknown

data/lib/sisimai/reason/mailboxfull.rb

@@ -66,7 +66,7 @@ module Sisimai
         # @param    [String] argv1  String to be matched with regular expressions
         # @return   [Boolean]       false: Did not match, true: Matched
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return false
         end

data/lib/sisimai/reason/mailererror.rb

@@ -30,7 +30,7 @@ module Sisimai
         # @param    [String] argv1  String to be matched with regular expressions
         # @return   [Boolean]       false: Did not match, true: Matched
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return false
         end

data/lib/sisimai/reason/mesgtoobig.rb

@@ -29,7 +29,7 @@ module Sisimai
         # @param    [String] argv1  String to be matched with regular expressions
         # @return   [Boolean]       false: Did not match, true: Matched
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return false
         end

data/lib/sisimai/reason/networkerror.rb

@@ -36,7 +36,7 @@ module Sisimai
         # @param    [String] argv1  String to be matched with regular expressions
         # @return   [Boolean]       false: Did not match, true: Matched
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return false
         end

data/lib/sisimai/reason/norelaying.rb

@@ -28,7 +28,7 @@ module Sisimai
           'specified domain is not allowed',
           "that domain isn't in my list of allowed rcpthost",
           'this system is not configured to relay mail',
-          'unable to relay for',
+          'unable to relay ',
           "we don't handle mail for",
         ].freeze
 
@@ -39,7 +39,7 @@ module Sisimai
         # @param    [String] argv1  String to be matched with regular expressions
         # @return   [Boolean]       false: Did not match, true: Matched
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return false
         end

data/lib/sisimai/reason/notaccept.rb

@@ -11,9 +11,8 @@ module Sisimai
       class << self
         # Destination mail server does not accept any message
         Index = [
-          'does not accept mail (nullmx)',
+          'does not accept mail',             # Sendmail
           'host/domain does not accept mail', # iCloud
-          'host does not accept mail',        # Sendmail
           'mail receiving disabled',
           'name server: .: host not found',   # Sendmail
           'no mx record found for domain=',   # Oath(Yahoo!)
@@ -28,7 +27,7 @@ module Sisimai
         # @param    [String] argv1  String to be matched with regular expressions
         # @return   [Boolean]       false: Did not match, true: Matched
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return false
         end

data/lib/sisimai/reason/notcompliantrfc.rb

@@ -25,7 +25,7 @@ module Sisimai
         # @param    [String] argv1  String to be matched with regular expressions
         # @return   [Boolean]       false: Did not match, true: Matched
         def match(argv1)
-          return false unless argv1
+          return false if argv1.nil? || argv1.empty?
           return true  if Index.any? { |a| argv1.include?(a) }
           return true  if Pairs.any? { |a| Sisimai::String.aligned(argv1, a) }
           return false