sisfc 0.1.0 → 0.2.0

data/lib/sisfc/support/dsl_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # taken from Jim Freeze's excellent article "Creating DSLs with Ruby"
 # http://www.artima.com/rubycs/articles/ruby_as_dsl.html
 

data/lib/sisfc/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SISFC
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/lib/sisfc/vm.rb

@@ -1,46 +1,61 @@
-require 'sisfc/event'
+# frozen_string_literal: true
+
+require_relative './event'
+require_relative './logger'
 require 'erv'
 
+class RequestInfo < Struct.new(:request, :service_time, :arrival_time)
+  include Comparable
+  def <=> (o)
+    arrival_time <=> o.arrival_time
+  end
+end
 
 module SISFC
 
   class VM
+    include Logging
 
     # setup readable/accessible attributes
-    ATTRIBUTES = [ :vmid, :dc_id, :size ]
-
-    attr_reader *ATTRIBUTES
-
-    def initialize(vmid, opts)
-      # make sure all the required opts were provided
-      [ :dc_id, :vm_size, :service_time_distribution ].each do |k|
-        raise ArgumentError, "opts[:#{k}] missing" unless opts.has_key? k
-      end
+    attr_reader :vmid, :dc_id, :size
 
+    def initialize(vmid, dc_id, size, service_time_distribution, opts={})
       @vmid             = vmid
-      @dcid             = opts[:dc_id]
-      @size             = opts[:vm_size]
-      @service_times_rv = ERV::RandomVariable.new(opts[:service_time_distribution][@size])
+      @dcid             = dc_id
+      @size             = size
+      @service_times_rv = ERV::RandomVariable.new(service_time_distribution[@size])
 
       # initialize request queue and related tracking information
       @busy          = false
       @request_queue = []
 
+      @trace = opts[:trace] ? true : false
+      @notes = opts[:notes]
+
       # @request_queue_info          = []
       # @request_currently_servicing = nil
     end
 
     def new_request(sim, r, time)
-      # put the (request, service time, arrival time) tuple at the end of the queue
-      @request_queue << [ r, @service_times_rv.next, time ]
+      # put request w/ metadata at the end of the queue
+      @request_queue << RequestInfo.new(r, @service_times_rv.next, time)
+
+      if @trace
+        @request_queue.each_cons(2) do |x,y|
+          if y[2] < x[2]
+            raise "Inconsistent ordering in request_queue!!!!"
+          end
+        end
+      end
 
       # update queue size tracking information
-      # @request_queue_info << { :size => @request_queue.size, :time => time }
-
-      unless @busy
-        # try to allocate operator
-        try_servicing_new_request(sim, time)
+      # @request_queue_info << { size: @request_queue.size, time: time }
+      if @trace and @request_queue.size % 100 == 0
+        logger.info "VM #{@vmid} with #{@notes} has #{@request_queue.size} requests in queue at time #{time} and is " +
+           (@busy ? "busy" : "not busy")
       end
+
+      try_servicing_new_request(sim, time) unless @busy
     end
 
     def request_finished(sim, time)
@@ -64,20 +79,24 @@ module SISFC
         raise "Busy VM (vmid: #{@vmid})!" if @busy
 
         unless @request_queue.empty?
+
           # pick request and metadata from the incoming request queue
-          req, service_time, arrival_time = @request_queue.shift
+          ri = @request_queue.shift
 
-          # update the request's queuing information
-          req.queuing_completed(arrival_time, time - arrival_time)
+          if @trace
+            logger.info "VM #{@vmid} with #{@notes} fulfilling a new request at time #{time} for #{ri.service_time} seconds"
+          end
+
+          req = ri.request
 
-          # the VM is busy now
-          @busy = true
+          # update the request's queuing information
+          req.update_queuing_time(time - ri.arrival_time)
 
           # update the request's working information
-          req.step_completed(time, time + service_time)
+          req.step_completed(ri.service_time)
 
           # schedule completion of workflow step
-          sim.new_event(Event::ET_WORKFLOW_STEP_COMPLETED, req, time + service_time, self)
+          sim.new_event(Event::ET_WORKFLOW_STEP_COMPLETED, req, time + ri.service_time, self)
         end
       end
 

data/sisfc.gemspec

@@ -18,10 +18,14 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'activesupport', '~> 4.0.0'
-  spec.add_dependency 'awesome_print', '~> 1.2.0'
-  spec.add_dependency 'erv', '~> 0.0.2'
+  spec.add_dependency 'as-duration', '~> 0.1.1'
+  spec.add_dependency 'erv', '~> 0.3.5'
+  spec.add_dependency 'ice_nine', '~> 0.11.2'
 
-  spec.add_development_dependency 'bundler', '~> 1.5.3'
-  spec.add_development_dependency 'rake', '~> 10.1.1'
+  spec.add_development_dependency 'bundler', '~> 1.16'
+  spec.add_development_dependency 'dotenv', '~> 2.5'
+  spec.add_development_dependency 'rake', '~> 12.3'
+  spec.add_development_dependency 'minitest', '~> 5.11'
+  spec.add_development_dependency 'minitest-reporters', '~> 1.3'
+  spec.add_development_dependency 'minitest-spec-context', '~> 0.0.3'
 end

data/spec/minitest_helper.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+require 'sisfc'
+
+require 'minitest/spec'
+require 'minitest-spec-context'
+
+require 'minitest/autorun'

data/{test/sisfc/configuration_test.rb → spec/sisfc/configuration_spec.rb}

@@ -1,6 +1,8 @@
-require 'test_helper'
+# frozen_string_literal: true
 
-require 'sisfc/reference_configuration'
+require 'minitest_helper'
+
+require_relative './reference_configuration'
 
 
 describe SISFC::Configuration do

data/spec/sisfc/data_center_spec.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require 'minitest_helper'
+
+require_relative './reference_configuration'
+
+
+describe SISFC::DataCenter do
+  it 'should create a valid public Cloud data center' do
+    args = { maximum_vm_capacity: lambda {|vms| true } }
+    dc = SISFC::DataCenter.new(id: :dc_name, name: "Some DC", type: :public, location_id: 1, **args)
+  end
+
+  it 'should create a valid private Cloud data center' do
+    args = { maximum_vm_capacity: lambda {|vms| true } }
+    dc = SISFC::DataCenter.new(id: :dc_name, name: "Some DC", type: :private, location_id: 1, **args)
+  end
+end
+

data/{test/sisfc/evaluation_test.rb → spec/sisfc/evaluation_spec.rb}

@@ -1,10 +1,12 @@
-require 'test_helper'
+# frozen_string_literal: true
 
-require 'sisfc/reference_configuration'
+require 'minitest_helper'
+
+require_relative './reference_configuration'
 
 
 describe SISFC::Evaluator do
-  describe '.penalties' do
+  context '.penalties' do
     EXAMPLE_ALLOCATION = [
       { dc_id: 1, vm_size: :medium, vm_num: 20 },
       { dc_id: 1, vm_size:  :large, vm_num: 30 },

data/{test/sisfc/generator_test.rb → spec/sisfc/generator_spec.rb}

@@ -1,20 +1,23 @@
-require 'tempfile'
+# frozen_string_literal: true
+
+require 'minitest_helper'
 
-require 'test_helper'
+require 'tempfile'
 require 'sisfc/generator'
 
+require_relative './reference_configuration'
+
 
 describe SISFC::RequestGenerator do
 
-  GENERATION_TIMES = [ Time.now, Time.now + 1.second, Time.now + 2.seconds ].map(&:to_f)
-  DATA_CENTER_IDS  = (1..GENERATION_TIMES.size).to_a
-  ARRIVAL_TIMES    = GENERATION_TIMES.map {|x| x + 1.0 }
-  WORKFLOW_IDS     = GENERATION_TIMES.map { rand(10) }
+  GENERATION_TIMES  = [ Time.now, Time.now + 1.second, Time.now + 2.seconds ].map(&:to_f)
+  WORKFLOW_TYPE_IDS = GENERATION_TIMES.map { rand(10) }
+  CUSTOMER_IDS      = GENERATION_TIMES.map { rand(5) }
   REQUEST_GENERATION_DATA=<<-END
-    Generation Time,Data Center ID,Arrival Time,Workflow ID
-    #{GENERATION_TIMES[0]},#{DATA_CENTER_IDS[0]},#{ARRIVAL_TIMES[0]},#{WORKFLOW_IDS[0]}
-    #{GENERATION_TIMES[1]},#{DATA_CENTER_IDS[1]},#{ARRIVAL_TIMES[1]},#{WORKFLOW_IDS[1]}
-    #{GENERATION_TIMES[2]},#{DATA_CENTER_IDS[2]},#{ARRIVAL_TIMES[2]},#{WORKFLOW_IDS[2]}
+    Generation Time,Workflow Type ID,Customer ID
+    #{GENERATION_TIMES[0]},#{WORKFLOW_TYPE_IDS[0]},#{CUSTOMER_IDS[0]}
+    #{GENERATION_TIMES[1]},#{WORKFLOW_TYPE_IDS[1]},#{CUSTOMER_IDS[1]}
+    #{GENERATION_TIMES[2]},#{WORKFLOW_TYPE_IDS[2]},#{CUSTOMER_IDS[2]}
   END
 
   it 'should read from CSV file' do
@@ -27,10 +30,10 @@ describe SISFC::RequestGenerator do
       with_reference_config(request_generation: { filename: tf.path }) do |conf|
         rg = SISFC::RequestGenerator.new(conf.request_generation)
         r = rg.generate
-        r.rid.must_equal 1
-        r.generation_time.must_equal GENERATION_TIMES[0]
-        r.data_center_id.must_equal DATA_CENTER_IDS[0]
-        r.arrival_time.must_equal ARRIVAL_TIMES[0]
+        r[:rid].must_equal 1
+        r[:generation_time].must_equal GENERATION_TIMES[0]
+        r[:workflow_type_id].must_equal WORKFLOW_TYPE_IDS[0]
+        r[:customer_id].must_equal CUSTOMER_IDS[0]
       end
 
     ensure
@@ -49,10 +52,10 @@ describe SISFC::RequestGenerator do
       with_reference_config(request_generation: { command: "cat #{tf.path}" }) do |conf|
         rg = SISFC::RequestGenerator.new(conf.request_generation)
         r = rg.generate
-        r.rid.must_equal 1
-        r.generation_time.must_equal GENERATION_TIMES[0]
-        r.data_center_id.must_equal DATA_CENTER_IDS[0]
-        r.arrival_time.must_equal ARRIVAL_TIMES[0]
+        r[:rid].must_equal 1
+        r[:generation_time].must_equal GENERATION_TIMES[0]
+        r[:workflow_type_id].must_equal WORKFLOW_TYPE_IDS[0]
+        r[:customer_id].must_equal CUSTOMER_IDS[0]
       end
     ensure
       # delete temporary file

data/spec/sisfc/latency_manager_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'minitest_helper'
+require 'sisfc/latency_manager'
+
+require_relative './reference_configuration'
+
+
+describe SISFC::LatencyManager do
+  it 'should correctly work with reference configuration' do
+    SISFC::LatencyManager.new(LATENCY_MODELS)
+  end
+end

data/spec/sisfc/reference_configuration.rb

@@ -0,0 +1,534 @@
+# frozen_string_literal: true
+
+require 'sisfc/configuration'
+
+START_TIME      = Time.utc(1978, 'Aug', 12, 14, 30, 0).to_f
+DURATION        = 1.minute.to_f
+WARMUP_DURATION = 10.seconds.to_f
+SIMULATION_CHARACTERIZATION = <<END
+  # start time, duration, and warmup time for simulations
+  start_time Time.utc(1978, 'Aug', 12, 14, 30, 0)
+  duration 1.minute
+  warmup_duration 10.seconds
+END
+
+
+# characterization of data centers
+DATA_CENTERS_CHARACTERIZATION = <<END
+data_centers \
+  1 => {
+    maximum_vm_capacity: {
+      tiny:   300,
+      small:  300,
+      medium: 300,
+      large:  300,
+      huge:   300,
+    },
+    location_id: 0,
+  },
+  2 => {
+    maximum_vm_capacity: {
+      tiny:   300,
+      small:  300,
+      medium: 300,
+      large:  300,
+      huge:   300,
+    },
+    location_id: 1,
+  },
+  3 => {
+    maximum_vm_capacity: {
+      tiny:   300,
+      small:  300,
+      medium: 300,
+      large:  300,
+      huge:   300,
+    },
+    location_id: 2,
+  },
+  4 => {
+    maximum_vm_capacity: {
+      tiny:   300,
+      small:  300,
+      medium: 300,
+      large:  300,
+      huge:   300,
+    },
+    location_id: 3,
+  },
+  5 => {
+    maximum_vm_capacity: {
+      tiny:   300,
+      small:  300,
+      medium: 300,
+      large:  300,
+      huge:   300,
+    },
+    location_id: 4,
+  }
+END
+
+
+LATENCY_MODELS_CHARACTERIZATION = <<END
+latency_models \
+  [
+    # location 0
+    [
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+    ],
+    # location 1
+    [
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+    ],
+    # location 2
+    [
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+    ],
+    # location 3
+    [
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+    ],
+    # location 4
+    [
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+    ],
+    # location 5
+    [
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+    ],
+    # location 6
+    [
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+    ],
+    # location 7
+    [
+      {
+        distribution: :gaussian,
+        args: {
+          mean: 0.009,
+          sd:   0.001,
+        },
+      },
+    ],
+  ]
+END
+
+
+CUSTOMER_CHARACTERIZATION = <<END
+customers \
+  [
+    # first customer (id: 0) is in location with id=5 (?)
+    { location_id: 5 },
+    # second customer (id: 1) is in location with id=6 (?)
+    { location_id: 6 },
+    # third customer (id: 2) is in location with id=7 (?)
+    { location_id: 7 },
+    # fourth customer (id: 3) is in location with id=8 (?)
+    { location_id: 8 },
+  ]
+END
+
+
+# characterization of component types
+SERVICE_COMPONENT_TYPES_CHARACTERIZATION = <<END
+service_component_types \
+  'Web Server' => {
+    allowed_vm_types: [ :medium, :large ],
+    service_time_distribution: {
+      medium: { distribution: :gaussian,
+                mean:         0.009, # 1 request processed every 9ms
+                sd:           0.001 },
+      large:  { distribution: :gaussian,
+                mean:         0.007, # 1 request processed every 7ms
+                sd:           0.001 } },
+    estimated_workload: 50,
+  },
+  'App Server' => {
+    allowed_vm_types: [ :medium, :large, :huge ],
+    service_time_distribution: {
+      medium: { distribution: :gaussian,
+                mean:         0.015, # 1 request processed every 15ms
+                sd:           0.005 },
+      large:  { distribution: :gaussian,
+                mean:         0.012, # 1 request processed every 12ms
+                sd:           0.003 },
+      huge:   { distribution: :gaussian,
+                mean:         0.009, # 1 request processed every 7ms
+                sd:           0.002 } },
+    estimated_workload: 70,
+  },
+  'Financial Transaction Server' => {
+    allowed_vm_types: [ :large, :huge ],
+    service_time_distribution: {
+      large:  { distribution: :gaussian,
+                mean:         0.015, # 1 request processed every 15ms
+                sd:           0.004 },
+      huge:   { distribution: :gaussian,
+                mean:         0.008, # 1 request processed every 8ms
+                sd:           0.003 } },
+    estimated_workload: 80,
+  }
+END
+
+
+# workflow (or job) types descriptions
+WORKFLOW_TYPES_CHARACTERIZATION = <<END
+workflow_types \
+  1 => {
+    component_sequence: [
+      { name: 'Web Server' },
+      { name: 'App Server' },
+      { name: 'Financial Transaction Server' },
+    ],
+    next_component_selection: :random,
+  },
+  2 => {
+    component_sequence: [
+      { name: 'Web Server' },
+      { name: 'App Server' },
+    ],
+    # next_component_selection: :least_loaded,
+    next_component_selection: :random,
+  }
+END
+
+
+CONSTRAINT_CHARACTERIZATION = <<END
+constraints \
+  'Web Server' => [
+    { data_center: 1, min: 0, max: 300 },
+    { data_center: 2, min: 0, max: 300 },
+    { data_center: 3, min: 0, max: 300 },
+    { data_center: 4, min: 0, max: 300 },
+    { data_center: 5, min: 0, max: 300 },
+  ],
+  'App Server' => [
+    { data_center: 1, min: 0, max: 300 },
+    { data_center: 2, min: 0, max: 300 },
+    { data_center: 3, min: 0, max: 300 },
+    { data_center: 4, min: 0, max: 300 },
+    { data_center: 5, min: 0, max: 300 },
+  ],
+  'Financial Transaction Server' => [
+    { data_center: 1, number: 1 },
+    { data_center: 2, number: 0 },
+    { data_center: 3, number: 0 },
+    { data_center: 4, number: 0 },
+    { data_center: 5, number: 0 },
+  ]
+END
+
+
+REQUEST_GENERATION_CHARACTERIZATION = <<END
+request_generation \
+  command: "<pwd>/generator.R"
+END
+
+
+KPI_CUSTOMIZATION_CHARACTERIZATION = <<END
+kpi_customization \
+  longer_than: [ 2.0, 5.0 ] # count number of requests longer than 2 and 5 seconds respectively
+END
+
+
+EVALUATION_CHARACTERIZATION = <<END
+evaluation \
+  vm_hourly_cost: [
+    { data_center: 1, vm_type: :medium, cost: 0.160 },
+    { data_center: 1, vm_type: :large,  cost: 0.320 },
+    { data_center: 2, vm_type: :medium, cost: 0.184 },
+    { data_center: 2, vm_type: :large,  cost: 0.368 }
+  ],
+  # 500$ penalties if MTTR takes more than 50 msecs
+  penalties: lambda {|kpis,dc_kpis| 500.0 if kpis[:mttr] > 0.050 }
+END
+
+# this is the whole reference configuration
+# (useful for spec'ing configuration.rb)
+REFERENCE_CONFIGURATION =
+  SIMULATION_CHARACTERIZATION +
+  DATA_CENTERS_CHARACTERIZATION +
+  LATENCY_MODELS_CHARACTERIZATION +
+  CUSTOMER_CHARACTERIZATION +
+  SERVICE_COMPONENT_TYPES_CHARACTERIZATION +
+  WORKFLOW_TYPES_CHARACTERIZATION +
+  CONSTRAINT_CHARACTERIZATION +
+  REQUEST_GENERATION_CHARACTERIZATION +
+  KPI_CUSTOMIZATION_CHARACTERIZATION +
+  EVALUATION_CHARACTERIZATION
+
+
+evaluator = Object.new
+evaluator.extend SISFC::Configurable
+evaluator.instance_eval(REFERENCE_CONFIGURATION)
+
+# these are preprocessed portions of the reference configuration
+# (useful for spec'ing everything else)
+DATA_CENTERS            = evaluator.data_centers
+SERVICE_COMPONENT_TYPES = evaluator.service_component_types
+WORKFLOW_TYPES          = evaluator.workflow_types
+EVALUATION              = evaluator.evaluation
+LATENCY_MODELS          = evaluator.latency_models
+
+
+def with_reference_config(opts={})
+  begin
+    # create temporary file with reference configuration
+    tf = Tempfile.open('REFERENCE_CONFIGURATION')
+    tf.write(REFERENCE_CONFIGURATION)
+    tf.close
+
+    # create a configuration object from the reference configuration file
+    conf = SISFC::Configuration.load_from_file(tf.path)
+
+    # apply any change from the opts parameter and validate the modified configuration
+    opts.each do |k,v|
+      conf.send(k, v)
+    end
+    conf.validate
+
+    # pass the configuration object to the block
+    yield conf
+  ensure
+    # delete temporary file
+    tf.delete
+  end
+end