sipp 0.1.0 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e823ae979f2ceef4999a253bf86f204dec06313e
-  data.tar.gz: fd26206453b273c66c0fed4eddfa6d675be7d8a8
+  metadata.gz: a759acbd50e83cfbc4294f476ca21048c42286fb
+  data.tar.gz: 91df79cf3188f78777c1495002445c540e60d031
 SHA512:
-  metadata.gz: f3661ba71eec6117c0056b3e1ffc124ffcdfb64d24e19542bdb66d5564f03113d70720b5eec6303503ff4512e90c6c4c10f0d858a70d9ffd74ce726cceb6e1c8
-  data.tar.gz: 20c4cb082839d425516cd5d21abb955a883a0fc64cf92d61dd01b20e9510e3f49c28fb3e67b380ae1402484e0449ec9990649c8712b6b1842b1885bc850fdc82
+  metadata.gz: e699be1f95b5075a45b4b8b54fc1e1ea1c418c32e88e1a202e9659d4e5e1ec4dfa3bfd00ef803ff79555d858cb1acd831e767249381cae6a3dda4748905e3465
+  data.tar.gz: fbe654d6c318cbc133c7a43d60614a800135d093b62a3524eeaa26747f60e33183e108475925961e5048b8e754683f35a2a8560b38e50a2ec50c26217a0f863f

data/Gemfile

@@ -5,4 +5,4 @@ git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
 # Specify your gem's dependencies in sipp.gemspec
 gemspec
 
-gem 'activesupport', '~> 3.0'
+gem 'activesupport', '~> 4.1'

data/README.md

@@ -33,7 +33,7 @@ Calling `code.validate!` will throw validation errors with exceptions.
 ## TODO
 - add pseudo codes
 - add van codes
-- add i18n helpers
+- add i18n helpers or redo strings into symbols to be i18n-ised
 - add query methods for common checks (like `.diesel?` etc)
 
 

data/lib/sipp/code.rb

@@ -7,7 +7,7 @@ module SIPP
     attr_reader :code
 
     def initialize(code = nil)
-      @code = code.to_s.upcase
+      @code = code.to_s.strip.upcase
 
     end
 
@@ -15,50 +15,95 @@ module SIPP
       validate_code &&
         validate_category &&
         validate_type &&
-        validate_transmission &&
+        validate_transmission_drive &&
         validate_fuel_ac
     end
 
     def valid?
       validate!
-    rescue CodeError, CategoryError, TypeError, TransmissionError, FuelACError
+    rescue CodeError, CategoryError, TypeError, TransmissionDriveError, FuelACError
       false
     end
 
     def category
-      CATEGORY[code[0]] if valid?
+      validate_category
+      CATEGORY[code[0]]
+    rescue CategoryError => e
+      nil
     end
 
     def type
-      TYPE[code[1]] if valid?
+      validate_type
+      TYPE[code[1]]
+    rescue TypeError => e
+      nil
+    end
+
+    def transmission_drive
+      validate_transmission_drive
+      TRANSMISSION_DRIVE[code[2]]
+    rescue TransmissionDriveError => e
+      nil
     end
 
     def transmission
-      TRANSMISSION[code[2]] if valid?
+      validate_transmission_drive
+      TRANSMISSION[code[2]]
+    rescue TransmissionDriveError => e
+      nil
+    end
+
+    def transmission_manual?
+      validate_transmission_drive
+      'Manual' == transmission ? true : false # TODO fix magic string
+    rescue TransmissionDriveError => e
+      nil
+    end
+
+    def transmission_auto?
+      validate_transmission_drive
+      'Auto' == transmission ? true : false # TODO fix magic string
+    rescue TransmissionDriveError => e
+      nil
+    end
+
+    def drive
+      validate_transmission_drive
+      DRIVE[code[2]]
+    rescue TransmissionDriveError => e
+      nil
     end
 
     def fuel_ac
-      FUEL_AC[code[3]] if valid?
+      validate_fuel_ac
+      FUEL_AC[code[3]]
+    rescue FuelACError => e
+      nil
     end
 
     def fuel
-      FUEL[code[3]] if valid?
+      validate_fuel_ac
+      FUEL[code[3]]
+    rescue FuelACError => e
+      nil
     end
 
     def ac
-      AC[code[3]] if valid?
+      validate_fuel_ac
+      AC[code[3]]
+    rescue FuelACError => e
+      nil
     end
 
     def ac?
-      if valid?
-        'Air' == ac ? true : false # TODO fix magic string
-      else
-        nil
-      end
+      validate_fuel_ac
+      'Air' == ac ? true : false # TODO fix magic string
+    rescue FuelACError => e
+      nil
     end
 
     def to_s
-      [category, type, transmission, fuel_ac].join(' - ')
+      [category, type, transmission_drive, fuel_ac].join(' - ') if valid?
     end
 
     private
@@ -87,9 +132,9 @@ module SIPP
       end
     end
 
-    def validate_transmission
-      if @code[2].blank? || !TRANSMISSION.keys.include?(@code[2])
-        raise TransmissionError, :invalid_transmission
+    def validate_transmission_drive
+      if @code[2].blank? || !TRANSMISSION_DRIVE.keys.include?(@code[2])
+        raise TransmissionDriveError, :invalid_transmission_drive
       else
         true
       end

data/lib/sipp/dictionary.rb

@@ -46,7 +46,7 @@ module SIPP
       'K' => 'Commercial Van/Truck',
     }
 
-    TRANSMISSION = {
+    TRANSMISSION_DRIVE = {
       'M' => 'Manual Unspecified Drive',
       'N' => 'Manual 4WD',
       'C' => 'Manual AWD',
@@ -54,6 +54,23 @@ module SIPP
       'B' => 'Auto 4WD',
       'D' => 'Auto AWD',
     }
+    TRANSMISSION = {
+      'M' => 'Manual',
+      'N' => 'Manual',
+      'C' => 'Manual',
+      'A' => 'Auto',
+      'B' => 'Auto',
+      'D' => 'Auto',
+    }
+
+    DRIVE = {
+      'M' => 'Unspecified',
+      'N' => '4WD',
+      'C' => 'AWD',
+      'A' => 'Unspecified',
+      'B' => '4WD',
+      'D' => 'AWD',
+    }
 
     FUEL_AC = {
       'R' => 'Unspecified Fuel/Power With Air',

data/lib/sipp/version.rb

@@ -1,3 +1,3 @@
 module SIPP
-  VERSION = "0.1.0"
+  VERSION = "0.1.3"
 end

data/lib/sipp.rb

@@ -5,11 +5,11 @@ module SIPP
   class CodeError < StandardError; end
   class CategoryError < StandardError; end
   class TypeError < StandardError; end
-  class TransmissionError < StandardError; end
+  class TransmissionDriveError < StandardError; end
   class FuelACError < StandardError; end
   # Your code goes here...
 end
 
-require 'active_support/all'
+require 'active_support/core_ext/object'
 require "sipp/code"
 require "sipp/dictionary"

data/sipp.gemspec

@@ -27,5 +27,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
 
-  spec.add_dependency "activesupport", "~> 3.0"
+  spec.add_dependency "activesupport", "~> 4.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sipp
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.3
 platform: ruby
 authors:
 - Max Buslaev
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-07-30 00:00:00.000000000 Z
+date: 2022-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.1'
 description: Translates car SIPP codes into something meaningful
 email:
 - max@buslaev.net