sip2 0.0.12 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 426aa3286377738536f3308fe3031e27103f6fe6
-  data.tar.gz: 03aa7d489c2ba5089bf5a961dc045c8c6682b8db
+SHA256:
+  metadata.gz: e8f73fce390c230b1c0d95bba4221ebe77368b49a394635d84d8bd8314208ebb
+  data.tar.gz: c1b9beff001b1e3774a57853d2b031c5154fe51b793be2c301968744e61ca08d
 SHA512:
-  metadata.gz: 6acd6b54ecf7e553ce2cbc05257ea2721bcc3b5203166b755316cd4165e02e13003f1ffed164e4896883d3a6900bc45106864cffa753b68c46eceec1837965f6
-  data.tar.gz: 71f3609d27e6a0c6eda9541900b9982034359306cd967820db39cbd4f4411907dbfb465d842d81e712bab5a1301bf8638f6bea81a69cefb991c8428fc5ecfdbc
+  metadata.gz: 44d2323ee3939e99bdb192c5f61ce0be327321e99f5260592f62260ad3145d2681353ef759aff7a3193c09c7b5403e1f08f50fac661ecf22a063ec3ba475cfa8
+  data.tar.gz: 22e1645b0b13fcdff5de58757a9ba052191173c7fd374572fdadfaeba99a66b4b495d3dbb2b98dc717692f2f3c0442c975769c6917aaf7097d4c6f9a600ffeee

data/.travis.yml

@@ -1,10 +1,12 @@
 language: ruby
+sudo: required
+
 rvm:
-  - 2.1.10
-  - 2.2.10
-  - 2.3.7
-  - 2.4.4
-  - 2.5.1
+  - 2.2
+  - 2.3
+  - 2.4
+  - 2.5
+#  - 2.6 waiting for https://github.com/rubocop-hq/rubocop/issues/6412 to land
 
 before_install:
   - gem update bundler
@@ -15,4 +17,6 @@ install:
 
 script:
   - rubocop
+  # Blackhole 127.0.0.2 for testing connection timeouts
+  - sudo iptables -I INPUT -s 127.0.0.2 -j DROP
   - bundle exec rake

data/lib/sip2/client.rb

@@ -3,14 +3,15 @@ module Sip2
   # Sip2 Client
   #
   class Client
-    def initialize(host:, port:, ignore_error_detection: false)
+    def initialize(host:, port:, ignore_error_detection: false, timeout: nil)
       @host = host
       @port = port
       @ignore_error_detection = ignore_error_detection
+      @timeout = timeout || NonBlockingSocket::DEFAULT_TIMEOUT
     end
 
     def connect
-      socket = NonBlockingSocket.connect @host, @port
+      socket = NonBlockingSocket.connect @host, @port, @timeout
       yield Connection.new(socket, @ignore_error_detection) if block_given?
     ensure
       socket.close if socket

data/lib/sip2/connection.rb

@@ -41,6 +41,7 @@ module Sip2
       message = with_checksum with_error_detection message
       response = send_message message
       return if response.nil?
+
       send "handle_#{message_type}_response", response
     end
 
@@ -68,6 +69,7 @@ module Sip2
 
     def sequence_and_checksum_valid?(response)
       return true if @ignore_error_detection
+
       sequence_regex = /^(?<message>.*?AY(?<sequence>[0-9]+)AZ)(?<checksum>[A-F0-9]{4})$/
       match = response.strip.match sequence_regex
       match &&

data/lib/sip2/messages/patron_information.rb

@@ -23,6 +23,7 @@ module Sip2
 
       def handle_patron_information_response(response)
         return unless sequence_and_checksum_valid?(response)
+
         Sip2::PatronInformation.new response
       end
     end

data/lib/sip2/patron_information.rb

@@ -72,6 +72,7 @@ module Sip2
     def transaction_date
       match = raw_response.match(/\A64.{17}(\d{4})(\d{2})(\d{2})(.{4})(\d{2})(\d{2})(\d{2})/)
       return unless match
+
       _, year, month, day, zone, hour, minute, second = match.to_a
       Time.new(
         year.to_i, month.to_i, day.to_i,

data/lib/sip2/version.rb

@@ -1,3 +1,3 @@
 module Sip2
-  VERSION = '0.0.12'.freeze
+  VERSION = '0.1.1'.freeze
 end

data/sip2.gemspec

@@ -17,11 +17,11 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(spec)/}) }
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.1.0'
+  spec.required_ruby_version = '>= 2.2.0'
 
   spec.add_development_dependency 'bundler', '>= 1.11'
   spec.add_development_dependency 'rake', '>= 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'rubocop', '~> 0'
   spec.add_development_dependency 'timecop', '~> 0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sip2
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.1.1
 platform: ruby
 authors:
 - abrom
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-05 00:00:00.000000000 Z
+date: 2018-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -56,14 +56,14 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
@@ -115,7 +115,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.1.0
+      version: 2.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -123,7 +123,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14.1
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: 3M™ Standard Interchange Protocol v2 client implementation in Ruby