single_cov 1.9.1 → 1.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 033c6118fe2eb88114dab333f21c65b789ae0841b52ecfc5d7e96ce086f1c36d
-  data.tar.gz: f6dbb0e79ccd6764efa21f943d1e10e31b84ba7a1bff80f4af7d92dcf3b7ea42
+  metadata.gz: 3ffed2c03e29890449010148c9492563266983dd70d0f32e7a600692fa6b6a57
+  data.tar.gz: a9395fb02ed4dd4f5490cf4faf8a7c8ef3bd8b084081958c3a86fabb3cbbedcf
 SHA512:
-  metadata.gz: 939772cc7264d4ab62255b608b9ef6d493c75c6ed0e96f7e1c1d5f97e967a79bc93624c6449a5cffb5973e527a5ce9dae204e01b336e8ecb22dbea9779fd19d1
-  data.tar.gz: 8d101d81129a40851a00b9f7157d1e1424c0845f3f0185c64fe890b08c3f453dc11dbcd756275768d286a6817e1483205cabf18683428ecbdb884cd4877118d7
+  metadata.gz: dddfdd5778b9e3c34b92db87d4288970a6a0bd27154d0c40572bf5fa581f92806214827974b55c2612b19f1298bd1d5827072006fb1d131bf5feb36ccca33513
+  data.tar.gz: 6b82b17a84a018334c140027bab24ef3ac9c08cb0d52973f87d580006d19b0c7cfd3a80b8331b7d487e38af34c8e51f817066170ddee360378587b0b8af03981

data/lib/single_cov/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SingleCov
-  VERSION = "1.9.1"
+  VERSION = "1.11.0"
 end

data/lib/single_cov.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 module SingleCov
   COVERAGES = []
-  MAX_OUTPUT = 40
+  MAX_OUTPUT = Integer(ENV["SINGLE_COV_MAX_OUTPUT"] || "40")
   RAILS_APP_FOLDERS = ["models", "serializers", "helpers", "controllers", "mailers", "views", "jobs", "channels"]
   UNCOVERED_COMMENT_MARKER = /#.*uncovered/
   PREFIXES_TO_IGNORE = [] # things to not prefix with lib/ etc
@@ -40,7 +40,7 @@ module SingleCov
         # ignore lines that are marked as uncovered via comments
         # TODO: warn when using uncovered but the section is indeed covered
         content = File.readlines("#{root}/#{file}")
-        uncovered.reject! do |line_start, _, _, _|
+        uncovered.reject! do |line_start, _, _, _, _|
           content[line_start - 1].match?(UNCOVERED_COMMENT_MARKER)
         end
         next if uncovered.size == expected_uncovered
@@ -50,7 +50,9 @@ module SingleCov
 
       return true if errors.empty?
 
-      errors[MAX_OUTPUT..-1] = "... coverage output truncated" if errors.size >= MAX_OUTPUT
+      if errors.size >= MAX_OUTPUT
+        errors[MAX_OUTPUT..-1] = "... coverage output truncated (use SINGLE_COV_MAX_OUTPUT=999 to expand)"
+      end
       @error_logger.puts errors
 
       errors.all? { |l| warning?(l) }
@@ -146,18 +148,13 @@ module SingleCov
     def uncovered(coverage)
       return coverage unless coverage.is_a?(Hash) # just lines
 
-      # [nil, 1, 0, 1, 0] -> [3, 5]
-      uncovered_lines = coverage.fetch(:lines)
-        .each_with_index
-        .select { |c, _| c == 0 }
-        .map { |_, i| i + 1 }
-        .compact
-
+      uncovered_lines = indexes(coverage.fetch(:lines), 0).map! { |i| i + 1 }
       uncovered_branches = uncovered_branches(coverage[:branches] || {})
-      uncovered_branches.reject! { |k| uncovered_lines.include?(k[0]) } # remove duplicates
+      uncovered_branches.reject! { |br| uncovered_lines.include?(br[0]) } # ignore branch when whole line is uncovered
 
+      # combine lines and branches while keeping them sorted
       all = uncovered_lines.concat uncovered_branches
-      all.sort_by! { |line_start, char_start, _, _| [line_start, char_start || 0] } # branches are unsorted
+      all.sort_by! { |line_start, char_start, _, _, _| [line_start, char_start || 0] } # branches are unsorted
       all
     end
 
@@ -174,19 +171,21 @@ module SingleCov
       (!defined?(@main_process_pid) || @main_process_pid == Process.pid)
     end
 
+    # {[branch_id] => {[branch_part] => coverage}} --> uncovered location
     def uncovered_branches(coverage)
-      # {[branch_id] => {[branch_part] => coverage}} --> {branch_part -> sum-of-coverage}
-      sum = Hash.new(0)
+      sum = {}
       coverage.each_value do |branch|
-        branch.each do |k, v|
-          sum[k.slice(2, 4)] += v
+        branch.filter_map do |part, c|
+          location = [part[2], part[3] + 1, part[4], part[5] + 1] # locations can be duplicated
+          type = part[0]
+          info = (sum[location] ||= [0, nil])
+          info[0] += c
+          info[1] = type if type == :else # only else is important to track since it often is not in the code
         end
       end
 
-      sum.select! { |_, v| v == 0 } # keep missing coverage
-      found = sum.map { |k, _| [k[0], k[1] + 1, k[2], k[3] + 1] }
-      found.uniq!
-      found
+      # keep location and type of missing coverage
+      sum.filter_map { |k, v| k + [v[1]] if v[0] == 0 }
     end
 
     def default_tests
@@ -197,6 +196,10 @@ module SingleCov
       Dir["#{root}/#{pattern}"].map! { |f| f.sub("#{root}/", '') }
     end
 
+    def indexes(list, find)
+      list.each_with_index.filter_map { |v, i| i if v == find }
+    end
+
     # do not ask for coverage when SimpleCov already does or it conflicts
     def coverage_results
       if defined?(SimpleCov) && (result = SimpleCov.instance_variable_get(:@result))
@@ -327,13 +330,13 @@ module SingleCov
         [
           "#{file} new uncovered lines introduced #{details}",
           red("Lines missing coverage:"),
-          *uncovered.map do |line_start, char_start, line_end, char_end|
+          *uncovered.map do |line_start, char_start, line_end, char_end, type|
             if char_start # branch coverage
               if line_start == line_end
                 "#{file}:#{line_start}:#{char_start}-#{char_end}"
               else # possibly unreachable since branches always seem to be on the same line
                 "#{file}:#{line_start}:#{char_start}-#{line_end}:#{char_end}"
-              end
+              end + (type ? " # #{type}" : "")
             else
               "#{file}:#{line_start}"
             end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: single_cov
 version: !ruby/object:Gem::Version
-  version: 1.9.1
+  version: 1.11.0
 platform: ruby
 authors:
 - Michael Grosser
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-03-15 00:00:00.000000000 Z
+date: 2023-06-03 00:00:00.000000000 Z
 dependencies: []
 description:
 email: michael@grosser.it