sinclair 1.6.3 → 1.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e73aaf0289f39dd23b05bbd256c7bbd98de3d5a2a963bddd096315241ad81d6b
-  data.tar.gz: ed6e16a5b51ef93cc7bd083c6ae304121df91dfc67ac71b8804cc340c63a002a
+  metadata.gz: 7c4239fce273eaf2a9dd2f62219833a2dc035230ba115f1369bc881fac00da9a
+  data.tar.gz: 45b56a8e12244c9adcf3c328d7d794d0036ded1dcf040d21401406294c139f30
 SHA512:
-  metadata.gz: a38a73d5ddca24d0dfacb8c535255a83978f84b0913c940f7eda1e6a5f162fd14c314b063df67d35673c2b83d55fc0d42ed7a8aaa2fbfa7093f0e23e7bef5abc
-  data.tar.gz: 1bb0387bd0cc01250985b5b000fac058e34a39b37b352cf89a953ab36fef069fda576121ff59ef0d95ab3521cce2879e0940085d95d4ccd95feb1e169d06da47
+  metadata.gz: cfb6141258f4d0a62cde59dcfddfa69ad7c875a78c11a080fc2d0b5d6a688fd62fe39c71f3c30229ff01f1c95c12a595c1f35799799c21007f7b518e8f794955
+  data.tar.gz: 99ac196abb1272d7c0224e358a90540eb81e8fca869abd36b371e21157b734779914a29946f5bcb951f3b1d12d6638eeda34591f3eac1a1ede08fbc09ea7426e

data/README.md

@@ -15,7 +15,7 @@ methods
 
 Yard Documentation
 -------------------
-[https://www.rubydoc.info/gems/sinclair/1.6.3](https://www.rubydoc.info/gems/sinclair/1.6.3)
+[https://www.rubydoc.info/gems/sinclair/1.6.4](https://www.rubydoc.info/gems/sinclair/1.6.4)
 
 Installation
 ---------------

data/config/yardstick.yml

@@ -19,6 +19,7 @@ rules:
       - Sinclair::Configurable#config
       - Sinclair::Configurable#reset_config
       - Sinclair::Configurable#configure
+      - Sinclair::Options#==
       - Sinclair::OptionsParser#options
       - Sinclair::OptionsParser#options_object
   ReturnTag:

data/lib/sinclair/options.rb

@@ -45,8 +45,6 @@ class Sinclair
         allowed_options << name.to_sym
       end
 
-      private
-
       # @api private
       # @private
       #
@@ -54,24 +52,10 @@ class Sinclair
       #
       # @return [Set<Symbol>]
       def allowed_options
-        @allowed_options ||= build_allowed_options
+        @allowed_options ||= superclass.try(:allowed_options).dup || Set.new
       end
 
-      # @api private
-      # @private
-      #
-      # Build set of allowed options
-      #
-      # When class is descendent of {Options}
-      # a duplication of it's parents allowed_options is
-      # returned
-      #
-      # @return (see allowed_options)
-      def build_allowed_options
-        superclass.send(:allowed_options).dup
-      rescue NoMethodError
-        Set.new
-      end
+      private
 
       # @api public
       # @!visibility public
@@ -105,6 +89,19 @@ class Sinclair
       end
     end
 
+    # returns if other equals to self
+    #
+    # @param other [Object] object to be compared
+    #
+    # @return [TrueClass,FalseClass]
+    def ==(other)
+      return false unless self.class == other.class
+
+      self.class.allowed_options.all? do |name|
+        public_send(name) == other.public_send(name)
+      end
+    end
+
     private
 
     # @private

data/lib/sinclair/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Sinclair
-  VERSION = '1.6.3'
+  VERSION = '1.6.4'
 end

data/spec/lib/sinclair/options_spec.rb

@@ -197,6 +197,51 @@ describe Sinclair::Options do
     end
   end
 
+  describe '.allowed_options' do
+    let(:klass) { Class.new(described_class) }
+
+    context 'when class has not been changed' do
+      it { expect(klass.allowed_options).to be_a(Set) }
+    end
+
+    context 'when initializing with with options' do
+      let(:expected) do
+        Set.new %i[timeout retries port protocol]
+      end
+
+      before do
+        klass.send(
+          :with_options,
+          :timeout, :retries, port: 443, protocol: 'https'
+        )
+      end
+
+      it do
+        expect(klass.allowed_options)
+          .to eq(expected)
+      end
+
+      context 'when class is descendent' do
+        let(:descendent_class) { Class.new(klass) }
+        let(:expected) do
+          Set.new %i[timeout retries port protocol name]
+        end
+
+        before do
+          descendent_class.send(
+            :with_options,
+            :name
+          )
+        end
+
+        it do
+          expect(descendent_class.allowed_options)
+            .to eq(expected)
+        end
+      end
+    end
+  end
+
   describe '#initialize' do
     let(:klass) { ConnectionOptions }
 
@@ -309,4 +354,28 @@ describe Sinclair::Options do
       it { expect(options.protocol).to eq(false) }
     end
   end
+
+  describe '#==' do
+    let(:klass) { ConnectionOptions }
+
+    context 'with black initialization' do
+      it do
+        expect(klass.new).to eq(klass.new)
+      end
+    end
+
+    context 'when initializing with same values' do
+      let(:first_option) { klass.new(protocol: nil) }
+      let(:second_option) { klass.new(protocol: nil) }
+
+      it { expect(first_option).to eq(second_option) }
+    end
+
+    context 'when initializing with different values' do
+      let(:first_option) { klass.new(protocol: nil) }
+      let(:second_option) { klass.new }
+
+      it { expect(first_option).not_to eq(second_option) }
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sinclair
 version: !ruby/object:Gem::Version
-  version: 1.6.3
+  version: 1.6.4
 platform: ruby
 authors:
 - DarthJee