sinclair 1.3.3 → 1.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46aae0be813637d70c6060f5ac9a14537d19eb2d5e4275a31e864625b396c038
-  data.tar.gz: '08f41f83267f7f017b036e4fd806e336a17932ae4f93eadae0e08dd4341c51cb'
+  metadata.gz: 6e1275a6e3f8459ed0176557d4d9580c7cac9bc537b36dd3a96179d43803035b
+  data.tar.gz: baba86f5fe29bddf70c3d440e0539c4d0aa4a7b892a9548f73dbaf8945d51be7
 SHA512:
-  metadata.gz: 61deac1e3f21b5f238f33fd900ffadacd478b48cdaa3387ac7c272c28edb6d810af1609ec0d76b670861339c9de13600c8c39538c5be0199d5175fe6ed899434
-  data.tar.gz: 3681a6b3f56c9380e6bcc19bde499c0f4afc593075d8e23144ecc3d0168f0c89bf5352f351b1b87930fc2ba937f313a94292498157e75e6e4e7d56b12bd2efac
+  metadata.gz: ca4c580be409552638fb442d63b5036cac1d45134839f00551ea2cdcf1cada5f8736d6e1f2abdda97bd9d850a25d92599791efa15f423496796f30c834db053f
+  data.tar.gz: 604d5a4c072fff368b8bd6d062ab6730880bef1f29d6d197e00780cf7d8e98d3d6d64a34c87c8d93a1a367ec81a9a3ab98860111d5d425599d2777fb831db7dd

data/README.md

@@ -14,7 +14,7 @@ methods
 
 Yard Documentation
 -------------------
-https://www.rubydoc.info/gems/sinclair/1.3.3
+https://www.rubydoc.info/gems/sinclair/1.3.4
 
 Installation
 ---------------
@@ -311,7 +311,7 @@ Configurations are read-only objects that can only be set using
 the `configurable#configure` method
 
 ```ruby
-  class MyConfigurable
+  module MyConfigurable
     extend Sinclair::Configurable
 
     # port is defaulted to 80

data/lib/sinclair/configurable.rb

@@ -52,7 +52,7 @@ class Sinclair
     #
     # @return [ConfigFactory]
     def config_factory
-      @config_factory ||= if superclass.is_a?(Configurable)
+      @config_factory ||= if is_a?(Class) && superclass.is_a?(Configurable)
                             superclass.config_factory.child
                           else
                             ConfigFactory.new
@@ -71,7 +71,7 @@ class Sinclair
     # @see ConfigFactory#add_configs
     #
     # @example Configuring with common {Sinclair::Config} class
-    #   class MyConfigurable
+    #   module MyConfigurable
     #     extend Sinclair::Configurable
     #
     #     # port is defaulted to 80

data/lib/sinclair/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Sinclair
-  VERSION = '1.3.3'
+  VERSION = '1.3.4'
 end

data/spec/lib/sinclair/configurable_spec.rb

@@ -73,6 +73,22 @@ describe Sinclair::Configurable do
       configurable.reset_config
       expect(configurable.config).to be_a(Sinclair::Config)
     end
+
+    context 'when configurable is a module' do
+      subject(:configurable) do
+        Module.new { extend Sinclair::Configurable }
+      end
+
+      it do
+        expect { configurable.send(:configurable_with, :name) }
+          .not_to raise_error
+      end
+
+      it 'adds reader to config' do
+        expect { configurable.send(:configurable_with, :name) }
+          .to add_method(:name).to(configurable.config)
+      end
+    end
   end
 
   describe '#configurable_by' do

data/spec/support/models/my_configurable.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-class MyConfigurable
+module MyConfigurable
   extend Sinclair::Configurable
 
   # port is defaulted to 80

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sinclair
 version: !ruby/object:Gem::Version
-  version: 1.3.3
+  version: 1.3.4
 platform: ruby
 authors:
 - DarthJee