sinclair 1.10.0 → 1.11.0

data/spec/lib/sinclair_spec.rb

@@ -11,86 +11,15 @@ describe Sinclair do
   let(:builder_class) { described_class }
 
   describe '#add_method' do
-    context 'when extending the class' do
-      let(:builder_class) { described_class::DummyBuilder }
+    let(:object) { instance }
 
-      before do
-        builder.init
-        builder.build
-      end
-
-      context 'when describing a method with block' do
-        it 'creates a method with the block' do
-          expect(instance.blocked).to eq(1)
-        end
-      end
-
-      context 'when describing a method with string' do
-        it 'creates a method using the string definition' do
-          expect(instance.defined).to eq(1)
-          expect(instance.defined).to eq(2)
-        end
-      end
-
-      context 'when passing options' do
-        let(:options) { { increment: 2 } }
-
-        it 'parses the options' do
-          expect(instance.defined).to eq(2)
-          expect(instance.defined).to eq(4)
-        end
-      end
-    end
-
-    context 'when using the builder without extending' do
-      context 'when declaring a method with a block' do
-        before do
-          builder.add_method(:blocked) { 1 }
-          builder.add_method(:blocked) { 2 }
-          builder.build
-        end
-
-        it 'respect the order of method addtion' do
-          expect(instance.blocked).to eq(2)
-        end
-      end
-
-      context 'when declaring a method string' do
-        before do
-          builder.add_method(:string, '1')
-          builder.add_method(:string, '2')
-          builder.build
-        end
-
-        it 'respect the order of method addtion' do
-          expect(instance.string).to eq(2)
-        end
-      end
-
-      context 'when declaring block and string' do
-        before do
-          builder.add_method(:value) { 1 }
-          builder.add_method(:value, '2')
-          builder.build
-        end
-
-        it 'respect the order of method addtion' do
-          expect(instance.value).to eq(2)
-        end
-      end
+    it_behaves_like 'A sinclair builder', :instance
+  end
 
-      context 'when declaring string and block' do
-        before do
-          builder.add_method(:value, '1')
-          builder.add_method(:value) { 2 }
-          builder.build
-        end
+  describe '#add_class_method' do
+    let(:object) { dummy_class }
 
-        it 'respect the order of method addtion' do
-          expect(instance.value).to eq(2)
-        end
-      end
-    end
+    it_behaves_like 'A sinclair builder', :class
   end
 
   describe '#eval_and_add_method' do
@@ -149,87 +78,4 @@ describe Sinclair do
       end
     end
   end
-
-  describe '#add_class_method' do
-    context 'when extending the class' do
-      let(:builder_class) { described_class::DummyClassBuilder }
-
-      before do
-        builder.init
-        builder.build
-      end
-
-      context 'when describing a method with block' do
-        it 'creates a method with the block' do
-          expect(dummy_class.blocked).to eq(1)
-        end
-      end
-
-      context 'when describing a method with string' do
-        it 'creates a method using the string definition' do
-          expect(dummy_class.defined).to eq(1)
-          expect(dummy_class.defined).to eq(2)
-        end
-      end
-
-      context 'when passing options' do
-        let(:options) { { increment: 2 } }
-
-        it 'parses the options' do
-          expect(dummy_class.defined).to eq(2)
-          expect(dummy_class.defined).to eq(4)
-        end
-      end
-    end
-
-    context 'when using the builder without extending' do
-      context 'when declaring a method with a block' do
-        before do
-          builder.add_class_method(:blocked) { 1 }
-          builder.add_class_method(:blocked) { 2 }
-          builder.build
-        end
-
-        it 'respect the order of method addtion' do
-          expect(dummy_class.blocked).to eq(2)
-        end
-      end
-
-      context 'when declaring a method string' do
-        before do
-          builder.add_class_method(:string, '1')
-          builder.add_class_method(:string, '2')
-          builder.build
-        end
-
-        it 'respect the order of method addtion' do
-          expect(dummy_class.string).to eq(2)
-        end
-      end
-
-      context 'when declaring block and string' do
-        before do
-          builder.add_class_method(:value) { 1 }
-          builder.add_class_method(:value, '2')
-          builder.build
-        end
-
-        it 'respect the order of method addtion' do
-          expect(dummy_class.value).to eq(2)
-        end
-      end
-
-      context 'when declaring string and block' do
-        before do
-          builder.add_class_method(:value, '1')
-          builder.add_class_method(:value) { 2 }
-          builder.build
-        end
-
-        it 'respect the order of method addtion' do
-          expect(dummy_class.value).to eq(2)
-        end
-      end
-    end
-  end
 end

data/spec/support/models/dummy_builder.rb

@@ -5,7 +5,10 @@ class Sinclair
     def init
       add_method(:blocked) { 1 }
       add_method(:defined, "@value = value + #{options_object&.increment || 1}")
-      add_method(:value, '@value ||= 0')
+      add_method(:value, cached: true) { 0 }
+      add_method(:type_block, type: :block) { 3 }
+      add_method(:type_string, '10', type: :string)
+      add_method(:attr_accessor, :some_attribute, type: :call)
     end
   end
 end

data/spec/support/models/dummy_class_builder.rb

@@ -6,6 +6,9 @@ class Sinclair
       add_class_method(:blocked) { 1 }
       add_class_method(:defined, "@value = value + #{options_object&.increment || 1}")
       add_class_method(:value, '@value ||= 0')
+      add_class_method(:type_block, type: :block) { 3 }
+      add_class_method(:type_string, '10', type: :string)
+      add_class_method(:attr_accessor, :some_attribute, type: :call)
     end
   end
 end

data/spec/support/models/person.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class Person
-  attr_reader :first_name, :last_name
+  attr_accessor :first_name, :last_name
 
   def initialize(first_name, last_name)
     @first_name = first_name

data/spec/support/shared_examples/sinclair.rb

@@ -0,0 +1,112 @@
+# frozen_string_literal: true
+
+RSpec.shared_examples 'A sinclair builder' do |type|
+  let(:method_name) do
+    type == :instance ? :add_method : :add_class_method
+  end
+
+  context 'when extending the builder' do
+    let(:builder_class) do
+      type == :instance ? described_class::DummyBuilder : described_class::DummyClassBuilder
+    end
+
+    before do
+      builder.init
+      builder.build
+    end
+
+    context 'when describing a method with block' do
+      it 'creates a method with the block' do
+        expect(object.blocked).to eq(1)
+      end
+    end
+
+    context 'when describing a method with string' do
+      it 'creates a method using the string definition' do
+        expect(object.defined).to eq(1)
+        expect(object.defined).to eq(2)
+      end
+    end
+
+    context 'when describing a method using a block specific type' do
+      it 'creates a method with the block' do
+        expect(object.type_block).to eq(3)
+      end
+    end
+
+    context 'when describing a method using a string specific type' do
+      it 'creates a method with the string' do
+        expect(object.type_string).to eq(10)
+      end
+    end
+
+    context 'when describing a method using a call specific type for attr_acessor' do
+      let(:value) { Random.rand }
+
+      it 'creates acessors' do
+        expect { object.some_attribute = value }
+          .to change(object, :some_attribute)
+          .from(nil).to(value)
+      end
+    end
+
+    context 'when passing options' do
+      let(:options) { { increment: 2 } }
+
+      it 'parses the options' do
+        expect(object.defined).to eq(2)
+        expect(object.defined).to eq(4)
+      end
+    end
+  end
+
+  context 'when adding methods to a regular builder' do
+    context 'when declaring a method with a block' do
+      before do
+        builder.public_send(method_name, :blocked) { 1 }
+        builder.public_send(method_name, :blocked) { 2 }
+        builder.build
+      end
+
+      it 'respect the order of method addtion' do
+        expect(object.blocked).to eq(2)
+      end
+    end
+
+    context 'when declaring a method string' do
+      before do
+        builder.public_send(method_name, :string, '1')
+        builder.public_send(method_name, :string, '2')
+        builder.build
+      end
+
+      it 'respect the order of method addtion' do
+        expect(object.string).to eq(2)
+      end
+    end
+
+    context 'when declaring block and string' do
+      before do
+        builder.public_send(method_name, :value) { 1 }
+        builder.public_send(method_name, :value, '2')
+        builder.build
+      end
+
+      it 'respect the order of method addtion' do
+        expect(object.value).to eq(2)
+      end
+    end
+
+    context 'when declaring string and block' do
+      before do
+        builder.public_send(method_name, :value, '1')
+        builder.public_send(method_name, :value) { 2 }
+        builder.build
+      end
+
+      it 'respect the order of method addtion' do
+        expect(object.value).to eq(2)
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sinclair
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.11.0
 platform: ruby
 authors:
 - DarthJee
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-02-23 00:00:00.000000000 Z
+date: 2023-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -324,8 +324,11 @@ files:
 - spec/integration/readme/sinclair/env_settable_spec.rb
 - spec/integration/readme/sinclair/matchers_spec.rb
 - spec/integration/readme/sinclair/options_spec.rb
+- spec/integration/readme/sinclair/types_of_definition_spec.rb
 - spec/integration/readme/sinclair_spec.rb
 - spec/integration/yard/my_builder_spec.rb
+- spec/integration/yard/sinclair/add_class_method_spec.rb
+- spec/integration/yard/sinclair/add_method_spec.rb
 - spec/integration/yard/sinclair/comparable_spec.rb
 - spec/integration/yard/sinclair/config_builder_spec.rb
 - spec/integration/yard/sinclair/config_class_spec.rb
@@ -334,6 +337,7 @@ files:
 - spec/integration/yard/sinclair/configurable_spec.rb
 - spec/integration/yard/sinclair/env_settable_spec.rb
 - spec/integration/yard/sinclair/equals_checker_spec.rb
+- spec/integration/yard/sinclair/eval_and_add_method_spec.rb
 - spec/integration/yard/sinclair/input_hash_spec.rb
 - spec/integration/yard/sinclair/matchers/add_class_method_spec.rb
 - spec/integration/yard/sinclair/matchers/add_class_method_to_spec.rb
@@ -365,6 +369,7 @@ files:
 - spec/lib/sinclair/matchers/change_instance_method_on_spec.rb
 - spec/lib/sinclair/matchers/change_instance_method_spec.rb
 - spec/lib/sinclair/matchers_spec.rb
+- spec/lib/sinclair/method_builder/base_spec.rb
 - spec/lib/sinclair/method_builder/block_method_builder_spec.rb
 - spec/lib/sinclair/method_builder/call_method_builder_spec.rb
 - spec/lib/sinclair/method_builder/string_method_builder_spec.rb
@@ -425,6 +430,7 @@ files:
 - spec/support/shared_examples/config_factory.rb
 - spec/support/shared_examples/env_settable.rb
 - spec/support/shared_examples/instance_method_definition.rb
+- spec/support/shared_examples/sinclair.rb
 homepage: https://github.com/darthjee/sinclair
 licenses: []
 metadata: {}