sinclair 1.1.3 → 1.2.0

data/spec/lib/sinclair_spec.rb

@@ -3,19 +3,20 @@
 require 'spec_helper'
 
 describe Sinclair do
-  let(:options) { {} }
-  let(:instance) { dummy_class.new }
-  let(:dummy_class) { Class.new }
+  subject(:builder) { builder_class.new(dummy_class, options) }
+
+  let(:options)       { {} }
+  let(:instance)      { dummy_class.new }
+  let(:dummy_class)   { Class.new }
   let(:builder_class) { described_class }
-  subject { builder_class.new(dummy_class, options) }
 
   describe '#add_method' do
     context 'when extending the class' do
       let(:builder_class) { described_class::DummyBuilder }
 
       before do
-        subject.init
-        subject.build
+        builder.init
+        builder.build
       end
 
       context 'when describing a method with block' do
@@ -33,6 +34,7 @@ describe Sinclair do
 
       context 'when passing options' do
         let(:options) { { increment: 2 } }
+
         it 'parses the options' do
           expect(instance.defined).to eq(2)
           expect(instance.defined).to eq(4)
@@ -43,9 +45,9 @@ describe Sinclair do
     context 'when using the builder without extending' do
       context 'when declaring a method with a block' do
         before do
-          subject.add_method(:blocked) { 1 }
-          subject.add_method(:blocked) { 2 }
-          subject.build
+          builder.add_method(:blocked) { 1 }
+          builder.add_method(:blocked) { 2 }
+          builder.build
         end
 
         it 'respect the order of method addtion' do
@@ -55,9 +57,9 @@ describe Sinclair do
 
       context 'when declaring a method string' do
         before do
-          subject.add_method(:string, '1')
-          subject.add_method(:string, '2')
-          subject.build
+          builder.add_method(:string, '1')
+          builder.add_method(:string, '2')
+          builder.build
         end
 
         it 'respect the order of method addtion' do
@@ -65,29 +67,27 @@ describe Sinclair do
         end
       end
 
-      context 'when declaring a method using string or block' do
-        context 'when declaring the block first' do
-          before do
-            subject.add_method(:value) { 1 }
-            subject.add_method(:value, '2')
-            subject.build
-          end
-
-          it 'respect the order of method addtion' do
-            expect(instance.value).to eq(2)
-          end
+      context 'when declaring block and string' do
+        before do
+          builder.add_method(:value) { 1 }
+          builder.add_method(:value, '2')
+          builder.build
+        end
+
+        it 'respect the order of method addtion' do
+          expect(instance.value).to eq(2)
         end
+      end
 
-        context 'when declaring the string first' do
-          before do
-            subject.add_method(:value, '1')
-            subject.add_method(:value) { 2 }
-            subject.build
-          end
+      context 'when declaring string and block' do
+        before do
+          builder.add_method(:value, '1')
+          builder.add_method(:value) { 2 }
+          builder.build
+        end
 
-          it 'respect the order of method addtion' do
-            expect(instance.value).to eq(2)
-          end
+        it 'respect the order of method addtion' do
+          expect(instance.value).to eq(2)
         end
       end
     end
@@ -96,11 +96,11 @@ describe Sinclair do
   describe '#eval_and_add_method' do
     context 'when defining the method once' do
       before do
-        subject.add_method(:value, '@value ||= 0')
-        subject.eval_and_add_method(:defined) do
+        builder.add_method(:value, '@value ||= 0')
+        builder.eval_and_add_method(:defined) do
           "@value = value + #{options_object.increment || 1}"
         end
-        subject.build
+        builder.build
       end
 
       it 'creates a method using the string definition' do
@@ -120,12 +120,12 @@ describe Sinclair do
 
     context 'when redefining a method already added' do
       before do
-        subject.add_method(:value,   '@value ||= 0')
-        subject.add_method(:defined, '100')
-        subject.eval_and_add_method(:defined) do
+        builder.add_method(:value,   '@value ||= 0')
+        builder.add_method(:defined, '100')
+        builder.eval_and_add_method(:defined) do
           "@value = value + #{options_object.increment || 1}"
         end
-        subject.build
+        builder.build
       end
 
       it 'redefines it' do
@@ -136,12 +136,12 @@ describe Sinclair do
 
     context 'when readding it' do
       before do
-        subject.add_method(:value, '@value ||= 0')
-        subject.eval_and_add_method(:defined) do
+        builder.add_method(:value, '@value ||= 0')
+        builder.eval_and_add_method(:defined) do
           "@value = value + #{options_object.increment || 1}"
         end
-        subject.add_method(:defined, '100')
-        subject.build
+        builder.add_method(:defined, '100')
+        builder.build
       end
 
       it 'redefines it' do

data/spec/spec_helper.rb

@@ -16,7 +16,6 @@ support_files = File.expand_path('spec/support/**/*.rb')
 Dir[support_files].each { |file| require file }
 
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
   config.filter_run_excluding :integration unless ENV['ALL']

data/spec/support/models/default_value.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+class DefaultValue
+  delegate :build, to: :builder
+  attr_reader :klass, :method, :value
+
+  def initialize(klass, method, value)
+    @klass = klass
+    @method = method
+    @value = value
+  end
+
+  private
+
+  def builder
+    @builder ||= Sinclair.new(klass).tap do |b|
+      b.add_method(method) { value }
+    end
+  end
+end

data/spec/support/models/my_builder.rb

@@ -1,20 +1,21 @@
 # frozen_string_literal: true
 
-class DefaultValue
-  delegate :build, to: :builder
-  attr_reader :klass, :method, :value
-
-  def initialize(klass, method, value)
-    @klass = klass
-    @method = method
-    @value = value
+class MyBuilder < Sinclair
+  def add_methods
+    if options_object.rescue_error
+      add_safe_method
+    else
+      add_method(:symbolize) { @variable.to_sym }
+    end
   end
 
-  private
-
-  def builder
-    @builder ||= Sinclair.new(klass).tap do |b|
-      b.add_method(method) { value }
+  def add_safe_method
+    add_method(:symbolize) do
+      begin
+        @variable.to_sym
+      rescue StandardError
+        :default
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sinclair
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.2.0
 platform: ruby
 authors:
 - DarthJee
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-27 00:00:00.000000000 Z
+date: 2019-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -180,13 +180,16 @@ files:
 - scripts/check_readme.sh
 - sinclair.gemspec
 - sinclair.jpg
-- spec/integration/matcher_spec.rb
-- spec/integration/readme/matcher_spec.rb
 - spec/integration/readme/my_class_spec.rb
-- spec/integration/readme_spec.rb
-- spec/integration/yard/matchers/add_method_spec.rb
-- spec/integration/yard/matchers/add_method_to_spec.rb
-- spec/integration/yard/options_parser_spec.rb
+- spec/integration/readme/my_model_spec.rb
+- spec/integration/readme/sinclair/matchers_spec.rb
+- spec/integration/readme/sinclair_spec.rb
+- spec/integration/sinclair/matchers_spec.rb
+- spec/integration/yard/my_builder_spec.rb
+- spec/integration/yard/sinclair/matchers/add_method_spec.rb
+- spec/integration/yard/sinclair/matchers/add_method_to_spec.rb
+- spec/integration/yard/sinclair/method_definition_spec.rb
+- spec/integration/yard/sinclair/options_parser_spec.rb
 - spec/integration/yard/sinclair_spec.rb
 - spec/lib/sinclair/matchers/add_method_spec.rb
 - spec/lib/sinclair/matchers/add_method_to_spec.rb
@@ -196,6 +199,7 @@ files:
 - spec/lib/sinclair_spec.rb
 - spec/spec_helper.rb
 - spec/support/fixture_helpers.rb
+- spec/support/models/default_value.rb
 - spec/support/models/dummy_builder.rb
 - spec/support/models/dummy_options_parser.rb
 - spec/support/models/initial_valuer.rb

data/spec/integration/readme/matcher_spec.rb

@@ -1,27 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe DefaultValue do
-  let(:klass)    { Class.new }
-  let(:method)   { :the_method }
-  let(:value)    { Random.rand(100) }
-  let(:builder)  { described_class.new(klass, method, value) }
-  let(:instance) { klass.new }
-
-  context 'when the builder runs' do
-    it do
-      expect do
-        described_class.new(klass, method, value).build
-      end.to add_method(method).to(instance)
-    end
-  end
-
-  context 'when the builder runs' do
-    it do
-      expect do
-        described_class.new(klass, method, value).build
-      end.to add_method(method).to(klass)
-    end
-  end
-end

data/spec/integration/readme_spec.rb

@@ -1,23 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-describe 'Stand Alone' do
-  let(:instance) { klass.new }
-  let(:klass) { Class.new }
-  let(:builder) { Sinclair.new(klass) }
-
-  before do
-    builder.add_method(:twenty, '10 + 10')
-    builder.add_method(:eighty) { 4 * twenty }
-    builder.build
-  end
-
-  it 'knows how to add string defined methods' do
-    expect("Twenty => #{instance.twenty}").to eq('Twenty => 20')
-  end
-
-  it 'knows how to add block defined methods' do
-    expect("Eighty => #{instance.eighty}").to eq('Eighty => 80')
-  end
-end