sinatra_auth_github 0.1.4 → 0.1.5

data/README.md

@@ -54,5 +54,5 @@ Extension Options
 * `:scopes`       - The OAuth2 scopes you require, [Learn More](http://gist.github.com/419219)
 * `:secret`       - The client secret that GitHub provides
 * `:client_id`    - The client id that GitHub provides
-* `:failure_app`  - A Sinatra::Base class that has a route for `/authenticated`, Useful for overriding the securocat default page.
+* `:failure_app`  - A Sinatra::Base class that has a route for `/unauthenticated`, Useful for overriding the securocat default page.
 * `:callback_url` - The path that GitHub posts back to, defaults to `/auth/github/callback`.

data/lib/sinatra/auth/github.rb

@@ -5,7 +5,7 @@ require 'rest_client'
 module Sinatra
   module Auth
     module Github
-      VERSION = "0.1.2"
+      VERSION = "0.1.5"
 
       # Simple way to serve an image early in the stack and not get blocked by
       # application level before filters
@@ -79,7 +79,7 @@ module Sinatra
         # Returns a parsed JSON response
         #
         # Examples
-        #   github_raw_request("/user")
+        #   github_request("/user")
         #   # => { 'login' => 'atmos', ... }
         def github_request(path)
           JSON.parse(github_raw_request(path))
@@ -101,7 +101,7 @@ module Sinatra
         #
         # name - the organization name
         #
-        # Returns: true if the uesr has access, false otherwise
+        # Returns: true if the user has access, false otherwise
         def github_organization_access?(name)
           orgs = github_request("orgs/#{name}/members")
           orgs.map { |org| org["login"] }.include?(github_user.login)
@@ -113,7 +113,7 @@ module Sinatra
         #
         # team_id - the team's id
         #
-        # Returns: true if the uesr has access, false otherwise
+        # Returns: true if the user has access, false otherwise
         def github_team_access?(team_id)
           members = github_request("teams/#{team_id}/members")
           members.map { |user| user["login"] }.include?(github_user.login)
@@ -164,7 +164,7 @@ module Sinatra
           manager.failure_app           = app.github_options[:failure_app] || BadAuthentication
 
           manager[:github_secret]       = app.github_options[:secret]       || ENV['GITHUB_CLIENT_SECRET']
-          manager[:github_scopes]       = app.github_options[:scopes]       || 'email,offline_access'
+          manager[:github_scopes]       = app.github_options[:scopes]       || ''
           manager[:github_client_id]    = app.github_options[:client_id]    || ENV['GITHUB_CLIENT_ID']
           manager[:github_callback_url] = app.github_options[:callback_url] || '/auth/github/callback'
         end

data/sinatra_auth_github.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "sinatra_auth_github"
-  s.version     = "0.1.4"
+  s.version     = "0.1.5"
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Corey Donohoe"]
   s.email       = ["atmos@atmos.org"]

data/spec/app.rb

@@ -7,8 +7,7 @@ module Example
     set :github_options, {
                             :secret    => ENV['GITHUB_CLIENT_SECRET'],
                             :client_id => ENV['GITHUB_CLIENT_ID'],
-                            :scopes    => 'user,offline_access,repo' # repo is need for org auth :\
-                          }
+                         }
 
     register Sinatra::Auth::Github
 
@@ -24,14 +23,15 @@ module Example
     end
 
     get '/orgs/:id' do
-      github_organization_authenticate!(params['id'])
+      github_public_organization_authenticate!(params['id'])
       "Hello There, #{github_user.name}! You have access to the #{params['id']} organization."
     end
 
-    get '/teams/:id' do
-      github_team_authenticate!(params['id'])
-      "Hello There, #{github_user.name}! You have access to the #{params['id']} team."
-    end
+    # the scopes above need to include repo for team access :(
+    # get '/teams/:id' do
+    #   github_team_authenticate!(params['id'])
+    #   "Hello There, #{github_user.name}! You have access to the #{params['id']} team."
+    # end
 
     get '/logout' do
       logout!

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: sinatra_auth_github
 version: !ruby/object:Gem::Version 
-  hash: 19
+  hash: 17
   prerelease: 
   segments: 
   - 0
   - 1
-  - 4
-  version: 0.1.4
+  - 5
+  version: 0.1.5
 platform: ruby
 authors: 
 - Corey Donohoe
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-09-20 00:00:00 -07:00
+date: 2011-10-27 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency