sinatra-strong-params 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d7e198ec2d712488f1d5ae9e05c578e7a0cf52da
-  data.tar.gz: 6ed634ad02a939f12ddb34af2851e8f248ae8df4
+  metadata.gz: 2a395072291663098a8c4e241b4488bacc8e25f1
+  data.tar.gz: abb9249d19214474b81d7099e67ac6ba833260b9
 SHA512:
-  metadata.gz: b9aa465bc866fababaa1f807f6bc04397a139a531dc3714e3c6ca4847bb533eb1c3f313a90132b3d4fdd4089a15dd7b99a6fc69a18b7b2a4f739064c631dce49
-  data.tar.gz: 929441a2c4be7f6954f985e3ead0f9ae853862d6922f405175b2adab91169aef82e37acc6bc68dee68695881d59db0b65fb3d6ffb3091c8bd0c5101bacb6c333
+  metadata.gz: 4d6a12f59264e4c74e5580049d9ae7217ba9da4f40ca70d2c902fd50a34337729ad11bd6ded8be465c5518872869b60689f5bc7a36c217e5a9a4174d6580845a
+  data.tar.gz: 70e7dc32a003c0f82f59a06d0e078173afb395490d9bcb03d1ce4d6c1a5926b5c8acecab639838625a9d3530a417a8c841031a8fc7f9282dac59745bc433f56f

data/Rakefile

@@ -1,2 +1,13 @@
-require "bundler/gem_tasks"
+# encoding: UTF-8
+# frozen_string_literal: true
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
+namespace :test do
+  desc 'Run the specs'
+  task :spec do
+    RSpec::Core::RakeTask.new('test:spec')
+  end
+end
+
+task :default => 'test:spec'

data/lib/sinatra/strong-params.rb

@@ -1,3 +1,5 @@
+# encoding: UTF-8
+# frozen_string_literal: true
 require 'sinatra/base'
 require 'sinatra/strong-params/version'
 
@@ -23,10 +25,15 @@ module Sinatra
             globals  = settings.globally_allowed_parameters
             passable = (globals | passable).map(&:to_sym) # make sure it's a symbol
 
-            # trim the params down
+            # Select only the allowed parameters.
             @params = @params.select do |param, _value|
               passable.include?(param.to_sym)
             end
+
+            # Copy Sinatra's default proc to allow indifferent access.
+            @params.tap do |params|
+              params.default_proc = @_params.default_proc.dup rescue nil
+            end
           end
         end
       end

data/lib/sinatra/strong-params/version.rb

@@ -1,5 +1,7 @@
+# encoding: UTF-8
+# frozen_string_literal: true
 module Sinatra
   module StrongParams
-    VERSION = '0.0.2'
+    VERSION = '0.0.3'
   end
 end

data/sinatra-strong-params.gemspec

@@ -1,24 +1,28 @@
-# coding: utf-8
-$:.unshift File.expand_path("../lib", __FILE__)
+# encoding: UTF-8
+# frozen_string_literal: true
+$LOAD_PATH.unshift File.expand_path('../lib', __FILE__)
+
 require 'sinatra/strong-params/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "sinatra-strong-params"
+  spec.name          = 'sinatra-strong-params'
   spec.version       = Sinatra::StrongParams::VERSION
-  spec.authors       = ["Evan Lecklider"]
-  spec.email         = ["evan@lecklider.com"]
-  spec.summary       = %q{Some super basic strong parameter filters for Sinatra.}
+  spec.authors       = ['Evan Lecklider']
+  spec.email         = ['evan@lecklider.com']
+  spec.summary       = 'Some super basic strong parameter filters for Sinatra.'
   spec.description   = spec.summary
-  spec.homepage      = ""
-  spec.license       = "MIT"
+  spec.homepage      = 'https://github.com/evanleck/sinatra-strong-params'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
   spec.add_dependency 'sinatra', '>= 1.4.0'
 
-  spec.add_development_dependency "bundler", "~> 1.6"
-  spec.add_development_dependency "rake"
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'rack-test'
 end

data/spec/spec_helper.rb

@@ -0,0 +1,11 @@
+# encoding: UTF-8
+# frozen_string_literal: true
+ENV['RACK_ENV'] = 'test'
+
+require 'rspec'
+require_relative 'test_helper'
+
+RSpec.configure do |config|
+  config.mock_framework = :rspec
+  config.include TestHelper
+end

data/spec/strong-params_spec.rb

@@ -0,0 +1,97 @@
+# encoding: UTF-8
+# frozen_string_literal: true
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+
+require_relative 'spec_helper'
+require 'json'
+require 'sinatra/strong-params'
+
+describe Sinatra::StrongParams do
+  context "using allows filter" do
+    context "with no nested params" do
+      let(:request_params) { { id: 'id', action: 'action', not_allows: 'not_allows' } }
+
+      it 'supports accessing params with string keys' do
+        actual_params = nil
+        mock_app do
+          register Sinatra::StrongParams
+          get '/', allows: [:id, :action] { actual_params = params }
+        end
+
+        get '/', request_params
+        expect(actual_params['id']).to eq request_params[:id]
+        expect(actual_params['action']).to eq request_params[:action]
+        expect(actual_params['not_allows']).to eq nil
+      end
+
+      it 'supports accessing params with symbol keys' do
+        actual_params = nil
+        mock_app do
+          register Sinatra::StrongParams
+          get '/', allows: [:id, :action] { actual_params = params }
+        end
+
+        get '/', request_params
+        expect(actual_params[:id]).to eq request_params[:id]
+        expect(actual_params[:action]).to eq request_params[:action]
+        expect(actual_params[:not_allows]).to eq nil
+      end
+    end
+
+    context "with nested params" do
+      let(:request_params) { { id: [ { in_array: 'in_array'} ], action: { nested_hash: 'nested_hash'} }}
+
+      it 'supports accessing params with string keys' do
+        actual_params = nil
+        mock_app do
+          register Sinatra::StrongParams
+          get '/', allows: [:id, :action] { actual_params = params }
+        end
+
+        get '/', request_params
+        expect(actual_params['id'][0]['in_array']).to eq request_params[:id][0][:in_array]
+        expect(actual_params['action']['nested_hash']).to eq request_params[:action][:nested_hash]
+      end
+
+      it 'supports accessing params with symbol keys' do
+        actual_params = nil
+        mock_app do
+          register Sinatra::StrongParams
+          get '/', allows: [:id, :action] { actual_params = params }
+        end
+
+        get '/', request_params
+        expect(actual_params[:id][0][:in_array]).to eq request_params[:id][0][:in_array]
+        expect(actual_params[:action][:nested_hash]).to eq request_params[:action][:nested_hash]
+      end
+    end
+  end
+
+  context "using needs filter" do
+    it 'supports accessing params with string keys' do
+      actual_params = nil
+      mock_app do
+        register Sinatra::StrongParams
+        get '/', needs: [:id, :action] { actual_params = params }
+      end
+      params = { id: 'id', action: 'action' }
+
+      get '/', params
+      expect(actual_params['id']).to eq params[:id]
+      expect(actual_params['action']).to eq params[:action]
+    end
+
+    it 'supports accessing params with symbol keys' do
+      actual_params = nil
+      mock_app do
+        register Sinatra::StrongParams
+        get '/', needs: [:id, :action] { actual_params = params }
+      end
+      params = { id: 'id', action: 'action' }
+
+      get '/', params
+      expect(actual_params[:id]).to eq params[:id]
+      expect(actual_params[:action]).to eq params[:action]
+    end
+  end
+end

data/spec/test_helper.rb

@@ -0,0 +1,21 @@
+# encoding: UTF-8
+# frozen_string_literal: true
+require 'rack/test'
+
+module TestHelper
+  include Rack::Test::Methods
+
+  def mock_app(&block)
+    @app = Sinatra.new(Sinatra::Base) do
+      class_eval(&block)
+    end
+  end
+
+  def app
+    @app
+  end
+
+  def json
+    JSON.parse(last_response.body, :symbolize_names => true)
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sinatra-strong-params
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Evan Lecklider
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-11 00:00:00.000000000 Z
+date: 2017-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sinatra
@@ -28,16 +28,16 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +52,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rack-test
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Some super basic strong parameter filters for Sinatra.
 email:
 - evan@lecklider.com
@@ -67,7 +95,10 @@ files:
 - lib/sinatra/strong-params.rb
 - lib/sinatra/strong-params/version.rb
 - sinatra-strong-params.gemspec
-homepage: ''
+- spec/spec_helper.rb
+- spec/strong-params_spec.rb
+- spec/test_helper.rb
+homepage: https://github.com/evanleck/sinatra-strong-params
 licenses:
 - MIT
 metadata: {}
@@ -87,8 +118,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: Some super basic strong parameter filters for Sinatra.
-test_files: []
+test_files:
+- spec/spec_helper.rb
+- spec/strong-params_spec.rb
+- spec/test_helper.rb