sinatra-param 0.1.1 → 0.1.2

data/spec/parameter_validations_spec.rb

@@ -0,0 +1,174 @@
+require 'spec_helper'
+
+describe 'Parameter Validations' do
+  describe 'required' do
+    it 'returns 406 on requests without required fields' do
+      get('/validation/required') do |response|
+        response.status.should eq(406)
+        JSON.parse(response.body)['message'].should eq('Invalid parameter, arg')
+      end
+    end
+
+    it 'returns 200 on requests when required field present' do
+      get('/validation/required', arg: 'foo') do |response|
+        response.status.should eq(200)
+      end
+    end
+  end
+
+  describe 'blank' do
+    it 'returns 406 on requests when string is blank' do
+      get('/validation/blank/string', arg: '') do |response|
+        response.status.should eq(406)
+        JSON.parse(response.body)['message'].should eq('Invalid parameter, arg')
+      end
+    end
+
+    it 'returns 406 on requests when array is blank' do
+      get('/validation/blank/array', arg: '') do |response|
+        response.status.should eq(406)
+        JSON.parse(response.body)['message'].should eq('Invalid parameter, arg')
+      end
+    end
+
+    it 'returns 406 on requests when hash is blank' do
+      get('/validation/blank/hash', arg: '') do |response|
+        response.status.should eq(406)
+        JSON.parse(response.body)['message'].should eq('Invalid parameter, arg')
+      end
+    end
+
+    it 'returns 406 on requests when hash is blank' do
+      get('/validation/blank/other', arg: '') do |response|
+        response.status.should eq(406)
+        JSON.parse(response.body)['message'].should eq('Invalid parameter, arg')
+      end
+    end
+
+    it 'returns 200 on request when blank is true' do
+      get('/validation/nonblank/string', arg: '') do |response|
+        response.status.should eq(200)
+      end
+    end
+  end
+
+  describe 'is' do
+    it 'returns 406 on requests when value is other than defined' do
+      get('/validation/is', arg: 'bar') do |response|
+        response.status.should eq(406)
+        JSON.parse(response.body)['message'].should eq('Invalid parameter, arg')
+      end
+    end
+
+    it 'returns 200 on requests with a value is other than defined' do
+      get('/validation/is', arg: 'foo') do |response|
+        response.status.should eq(200)
+      end
+    end
+  end
+
+  describe 'in' do
+    it 'returns 406 on requests with a value not in the set' do
+      get('/validation/in', arg: 'MISC') do |response|
+        response.status.should eq(406)
+        JSON.parse(response.body)['message'].should eq('Invalid parameter, arg')
+      end
+    end
+
+    it 'returns 200 on requests with a value in the set' do
+      get('/validation/in', arg: 'ASC') do |response|
+        response.status.should eq(200)
+      end
+    end
+  end
+
+  describe 'within' do
+    it 'returns 406 on requests with a value outside the range' do
+      get('/validation/within', arg: 20) do |response|
+        response.status.should eq(406)
+        JSON.parse(response.body)['message'].should eq('Invalid parameter, arg')
+      end
+    end
+
+    it 'returns 200 on requests with a value within the range' do
+      get('/validation/within', arg: 5) do |response|
+        response.status.should eq(200)
+      end
+    end
+  end
+
+  describe 'range' do
+    it 'returns 406 on requests with a value outside the range' do
+      get('/validation/range', arg: 20) do |response|
+        response.status.should eq(406)
+        JSON.parse(response.body)['message'].should eq('Invalid parameter, arg')
+      end
+    end
+
+    it 'returns 200 on requests within the range' do
+      get('/validation/range', arg: 10) do |response|
+        response.status.should eq(200)
+      end
+    end
+  end
+
+  describe 'min' do
+    it 'returns 406 on requests with a value smaller than min' do
+      get('/validation/min', arg: 5) do |response|
+        response.status.should eq(406)
+        JSON.parse(response.body)['message'].should eq('Invalid parameter, arg')
+      end
+    end
+
+    it 'returns 200 on requests with a value larger than min' do
+      get('/validation/min', arg: 200) do |response|
+        response.status.should eq(200)
+      end
+    end
+  end
+
+  describe 'max' do
+    it 'returns 406 on requests with a value larger than max' do
+      get('/validation/max', arg: 100) do |response|
+        response.status.should eq(406)
+        JSON.parse(response.body)['message'].should eq('Invalid parameter, arg')
+      end
+    end
+
+    it 'returns 200 on requests with a value smaller than max' do
+      get('/validation/max', arg: 2) do |response|
+        response.status.should eq(200)
+      end
+    end
+  end
+
+  describe 'min_length' do
+    it 'returns 406 on requests with a string shorter than min_length' do
+      get('/validation/min_length', arg: 'hi') do |response|
+        response.status.should eq(406)
+        JSON.parse(response.body)['message'].should eq('Invalid parameter, arg')
+      end
+    end
+
+    it 'returns 200 on requests with a string longer than min_length' do
+      get('/validation/max_length', arg: 'longer') do |response|
+        response.status.should eq(200)
+      end
+    end
+  end
+
+  describe 'max_length' do
+    it 'returns 406 on requests with a string longer than max_length' do
+      get('/validation/max_length', arg: 'reallylongstringlongerthanmax') do |response|
+        response.status.should eq(406)
+        JSON.parse(response.body)['message'].should eq('Invalid parameter, arg')
+      end
+    end
+
+    it 'returns 200 on requests with a string shorter than max_length' do
+      get('/validation/max_length', arg: 'short') do |response|
+        response.status.should eq(200)
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,3 +1,20 @@
-require 'bundler/setup'
+unless ENV['CI']
+  require 'simplecov'
+  SimpleCov.start do
+    add_filter 'spec'
+    add_filter '.bundle'
+  end
+end
+
 require 'sinatra/param'
-require 'example/app'
+
+require 'rspec'
+require 'rack/test'
+
+require 'dummy/app'
+
+def app
+  App
+end
+
+include Rack::Test::Methods

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sinatra-param
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-01 00:00:00.000000000Z
+date: 2013-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sinatra
-  requirement: &70210869854140 !ruby/object:Gem::Requirement
+  requirement: &70339153513320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,21 +21,10 @@ dependencies:
         version: '1.3'
   type: :runtime
   prerelease: false
-  version_requirements: *70210869854140
+  version_requirements: *70339153513320
 - !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: &70210869853020 !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '2.10'
-  type: :development
-  prerelease: false
-  version_requirements: *70210869853020
-- !ruby/object:Gem::Dependency
-  name: rack-test
-  requirement: &70210869852560 !ruby/object:Gem::Requirement
+  name: simplecov
+  requirement: &70339153510080 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,39 +32,72 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70210869852560
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: &70210869852020 !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.9.2
-  type: :development
-  prerelease: false
-  version_requirements: *70210869852020
+  version_requirements: *70339153510080
 description: Parameter Contracts for Sinatra
 email: m@mattt.me
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ./coverage/assets/0.7.1/application.css
+- ./coverage/assets/0.7.1/application.js
+- ./coverage/assets/0.7.1/fancybox/blank.gif
+- ./coverage/assets/0.7.1/fancybox/fancy_close.png
+- ./coverage/assets/0.7.1/fancybox/fancy_loading.png
+- ./coverage/assets/0.7.1/fancybox/fancy_nav_left.png
+- ./coverage/assets/0.7.1/fancybox/fancy_nav_right.png
+- ./coverage/assets/0.7.1/fancybox/fancy_shadow_e.png
+- ./coverage/assets/0.7.1/fancybox/fancy_shadow_n.png
+- ./coverage/assets/0.7.1/fancybox/fancy_shadow_ne.png
+- ./coverage/assets/0.7.1/fancybox/fancy_shadow_nw.png
+- ./coverage/assets/0.7.1/fancybox/fancy_shadow_s.png
+- ./coverage/assets/0.7.1/fancybox/fancy_shadow_se.png
+- ./coverage/assets/0.7.1/fancybox/fancy_shadow_sw.png
+- ./coverage/assets/0.7.1/fancybox/fancy_shadow_w.png
+- ./coverage/assets/0.7.1/fancybox/fancy_title_left.png
+- ./coverage/assets/0.7.1/fancybox/fancy_title_main.png
+- ./coverage/assets/0.7.1/fancybox/fancy_title_over.png
+- ./coverage/assets/0.7.1/fancybox/fancy_title_right.png
+- ./coverage/assets/0.7.1/fancybox/fancybox-x.png
+- ./coverage/assets/0.7.1/fancybox/fancybox-y.png
+- ./coverage/assets/0.7.1/fancybox/fancybox.png
+- ./coverage/assets/0.7.1/favicon_green.png
+- ./coverage/assets/0.7.1/favicon_red.png
+- ./coverage/assets/0.7.1/favicon_yellow.png
+- ./coverage/assets/0.7.1/loading.gif
+- ./coverage/assets/0.7.1/magnify.png
+- ./coverage/assets/0.7.1/smoothness/images/ui-bg_flat_0_aaaaaa_40x100.png
+- ./coverage/assets/0.7.1/smoothness/images/ui-bg_flat_75_ffffff_40x100.png
+- ./coverage/assets/0.7.1/smoothness/images/ui-bg_glass_55_fbf9ee_1x400.png
+- ./coverage/assets/0.7.1/smoothness/images/ui-bg_glass_65_ffffff_1x400.png
+- ./coverage/assets/0.7.1/smoothness/images/ui-bg_glass_75_dadada_1x400.png
+- ./coverage/assets/0.7.1/smoothness/images/ui-bg_glass_75_e6e6e6_1x400.png
+- ./coverage/assets/0.7.1/smoothness/images/ui-bg_glass_95_fef1ec_1x400.png
+- ./coverage/assets/0.7.1/smoothness/images/ui-bg_highlight-soft_75_cccccc_1x100.png
+- ./coverage/assets/0.7.1/smoothness/images/ui-icons_222222_256x240.png
+- ./coverage/assets/0.7.1/smoothness/images/ui-icons_2e83ff_256x240.png
+- ./coverage/assets/0.7.1/smoothness/images/ui-icons_454545_256x240.png
+- ./coverage/assets/0.7.1/smoothness/images/ui-icons_888888_256x240.png
+- ./coverage/assets/0.7.1/smoothness/images/ui-icons_cd0a0a_256x240.png
+- ./coverage/index.html
+- ./example/app.rb
+- ./example/config.ru
+- ./example/Gemfile
+- ./example/Gemfile.lock
+- ./example/Procfile
 - ./Gemfile
 - ./Gemfile.lock
-- ./lib/example/app.rb
-- ./lib/example/config.ru
-- ./lib/example/Gemfile
-- ./lib/example/Gemfile.lock
-- ./lib/example/Procfile
 - ./lib/sinatra/param/version.rb
 - ./lib/sinatra/param.rb
 - ./LICENSE
 - ./Rakefile
 - ./README.md
-- ./sinatra-param-0.1.0.gem
 - ./sinatra-param.gemspec
-- spec/exclude_spec.rb
+- spec/dummy/app.rb
+- spec/parameter_sets_spec.rb
+- spec/parameter_transformations_spec.rb
+- spec/parameter_type_coercion_spec.rb
+- spec/parameter_validations_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/mattt/sinatra-param
 licenses: []
@@ -91,7 +113,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -4354181681426426125
+      hash: 1586099901428040771
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -100,7 +122,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -4354181681426426125
+      hash: 1586099901428040771
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.15
@@ -108,5 +130,9 @@ signing_key:
 specification_version: 3
 summary: sinatra-param
 test_files:
-- spec/exclude_spec.rb
+- spec/dummy/app.rb
+- spec/parameter_sets_spec.rb
+- spec/parameter_transformations_spec.rb
+- spec/parameter_type_coercion_spec.rb
+- spec/parameter_validations_spec.rb
 - spec/spec_helper.rb

data/spec/exclude_spec.rb

@@ -1,36 +0,0 @@
-require 'spec_helper'
-require 'rack/test'
-
-describe 'parameter exclusion' do
-  include Rack::Test::Methods
-  def app; App; end
-
-  it 'returns 406 on requests that contain more than one mutually exclusive parameter' do
-    params = [
-      {a: 1, b: 2},
-      {b: 2, c: 3},
-      {a: 1, b: 2, c: 3}
-    ]
-    params.each do |param|
-      get('/exclude', param) do |response|
-        response.status.should == 406
-        JSON.parse(response.body)['message'].should =~ /mutually exclusive/
-      end
-    end
-  end
-
-  it 'returns successfully for requests that only have one parameter' do
-    params = [
-      {a: 1},
-      {b: 2},
-      {c: 3},
-      {a: 1, c: 3},
-    ]
-    params.each do |param|
-      get('/exclude', param) do |response|
-        response.status.should == 200
-        JSON.parse(response.body)['message'].should =~ /OK/
-      end
-    end
-  end
-end