sinatra-param-validator 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 54d6ed44b4046ecc9fd330aef4e719cbe10d4a953a8d07a80226822f59ed66d7
-  data.tar.gz: e70164b07f23972aeffa920719c6de35baff4576eed46260944daf3a1b5e404b
+  metadata.gz: f474d7b6ff2e2ed3de6f58e3bd0ab0b328cc11886ac36701c5a1557a8713e5be
+  data.tar.gz: 378f0b0bb00df8adca7f951175133833d68ce457066f79423aadb52cab1ba6fb
 SHA512:
-  metadata.gz: d4d54fc8f4d76d1499d9c15adec02e35ff2f7c36bf99f5606d15b60a579e45da1c0905624c12be5e4a01b645670a5f23603191cf87fd6be0fd3541c1f94f6afb
-  data.tar.gz: c1c40e3b72dcb644adaf9437b0b7b67cfec8e33efad17ded176b74f3d6cf942fd76d3e4b7bf47f11442ebbb279d08907678e7600813b0b8da37c13736e0fdef4
+  metadata.gz: 045a26ac9992b92e1dab3c63527b6ebfd2b70c84b554d20a7f38abfa070f0402da47776d663619c0ae1ff95c681a52ccfb7da34fa2f5c10928c28626c77f75a9
+  data.tar.gz: cefd05d4f4babca139755e05d891802e375732bc944d278a8313e14759e87cd58b300c567e236ccf844897233072ce37e79d9c70f27385babd8b35435008a5c3

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 ## [Unreleased]
 
+## [0.4.0] - 2022-06-09
+
+- Allow custom error messages to be used when validation fails
+- Ensure running multiple validations for a single parameter merges the errors correctly
+- Allow validations to run code if successful
+- Allow exceptions to be raised by the parameter block to indicate failure
+- Allow parameters to be passed to validators
+
 ## [0.3.0] - 2022-06-08
 
 - Don't create entries in `params` for parameters that are not passed

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sinatra-param-validator (0.3.0)
+    sinatra-param-validator (0.4.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -86,6 +86,35 @@ All parameters have the following validations available:
 
 * `min` / `max`
 
+## Custom Messages
+
+It is possible to return a custom error message when a validation fails:
+
+```ruby
+param :number, Integer, required: true, message: 'The number is required'
+```
+
+It is also possible to run multiple validations against a single parameter. 
+This can be useful if different failures require different messages. 
+
+```ruby
+param :number, Integer, required: true, message: 'The number is required'
+param :number, Integer, min: 100, message: 'The number is not large enough'
+```
+
+## Validation blocks
+
+It is possible to run code after a validation succeeds, by passing a block to `param`:
+
+```ruby
+param :number, Integer, required: true do
+  # ...
+end
+```
+
+If you wish to indicate a validation failure within a block, raise `Sinatra::ParameterValidator::InvalidParameterError`
+with a message, and it will be passed through as an error for the parameter.
+
 ## Rules
 
 Rules work on multiple parameters:
@@ -126,6 +155,23 @@ get '/user/:id', validate_url_param: :user_id do
 end
 ```
 
+## Validators with parameters
+
+It is possible to define a validator with a parameter.
+To call the validator, you can use the `vi` helper to wrap a validator identifier with arguments:
+
+```ruby
+validator :number do |min|
+  param :id, Integer, min: min
+end
+
+post '/number', validate: vi(:new_user, 10) do
+  # ...
+end
+```
+
+
+
 ## Development
 
 After checking out the repo, run `bundle install` to install dependencies. Then, run `rake spec` to run the tests.

data/lib/sinatra/param_validator/helpers.rb

@@ -13,10 +13,11 @@ module Sinatra
         raise "Filter params failed: #{e}"
       end
 
-      def validate(klass, identifier, args = {})
-        definition = settings.validator_definitions.get(identifier)
+      def validate(klass, identifier)
+        identifier = Identifier.new(identifier) if identifier.is_a? Symbol
+        definition = settings.validator_definitions.get(identifier.identifier)
         validator = klass.new(&definition)
-        validator.run(self, *args)
+        validator.run(self, *identifier.args)
         validator.handle_failure(self) unless validator.success?
       end
     end

data/lib/sinatra/param_validator/identifier.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Sinatra
+  module ParamValidator
+    # Class to hold a validator identifier plus arguments
+    class Identifier
+      attr_reader :identifier, :args
+
+      def initialize(identifier, *args)
+        @identifier = identifier
+        @args = args
+      end
+    end
+  end
+end

data/lib/sinatra/param_validator/invalid_parameter_error.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module Sinatra
+  module ParamValidator
+    # Error raised when validation fails
+    class InvalidParameterError < StandardError
+    end
+  end
+end

data/lib/sinatra/param_validator/parser.rb

@@ -2,6 +2,7 @@
 
 require 'delegate'
 
+require_relative 'invalid_parameter_error'
 require_relative 'parameter'
 require_relative 'rule'
 
@@ -11,18 +12,26 @@ module Sinatra
     class Parser < SimpleDelegator
       attr_reader :errors
 
-      def initialize(definition, context)
+      def initialize(definition, context, *args)
         super(context)
         @context = context
         @errors = {}
 
-        instance_exec({}, &definition)
+        instance_exec(*args, &definition)
       end
 
-      def param(key, type, **args)
+      def add_error(key, error)
+        @errors[key] = @errors.fetch(key, []).concat(Array(error))
+      end
+
+      def param(key, type, message: nil, **args, &block)
         parameter = Parameter.new(@context.params[key], type, **args)
-        @context.params[key] = parameter.coerced if @context.params.key? key
-        @errors[key] = parameter.errors unless parameter.valid?
+        @context.params[key] = parameter.coerced if @context.params.key?(key) && parameter.coerced
+        if parameter.valid?
+          run_block(key, block) if block
+        else
+          add_error key, message || parameter.errors
+        end
       rescue NameError
         raise 'Invalid parameter type'
       end
@@ -36,6 +45,12 @@ module Sinatra
       rescue NameError
         raise 'Invalid rule type'
       end
+
+      def run_block(key, block)
+        @context.instance_exec(&block)
+      rescue InvalidParameterError => e
+        add_error key, e.message
+      end
     end
   end
 end

data/lib/sinatra/param_validator/validation_failed_error.rb

@@ -6,9 +6,9 @@ module Sinatra
     class ValidationFailedError < StandardError
       attr_reader :errors
 
-      def initialize(errors, msg = nil)
+      def initialize(errors)
         @errors = errors
-        super(msg)
+        super("Validation failed: #{errors}")
       end
     end
   end

data/lib/sinatra/param_validator/validator.rb

@@ -15,8 +15,8 @@ module Sinatra
         raise ValidationFailedError, @errors
       end
 
-      def run(context)
-        @errors = Parser.new(@definition, context).errors
+      def run(context, *args)
+        @errors = Parser.new(@definition, context, *args).errors
       end
 
       def success?

data/lib/sinatra/param_validator/version.rb

@@ -2,6 +2,6 @@
 
 module Sinatra
   module ParamValidator
-    VERSION = '0.3.0'
+    VERSION = '0.4.0'
   end
 end

data/lib/sinatra/param_validator.rb

@@ -3,6 +3,7 @@
 require_relative 'param_validator/camelize'
 require_relative 'param_validator/definitions'
 require_relative 'param_validator/helpers'
+require_relative 'param_validator/identifier'
 require_relative 'param_validator/parser'
 require_relative 'param_validator/snake_case'
 require_relative 'param_validator/validator'
@@ -17,6 +18,10 @@ module Sinatra
       settings.validator_definitions.add(identifier, definition)
     end
 
+    def vi(identifier, *args)
+      Identifier.new(identifier, *args)
+    end
+
     class << self
       include SnakeCase
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sinatra-param-validator
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Rick Selby
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-06-08 00:00:00.000000000 Z
+date: 2022-06-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack-test
@@ -142,6 +142,8 @@ files:
 - lib/sinatra/param_validator/camelize.rb
 - lib/sinatra/param_validator/definitions.rb
 - lib/sinatra/param_validator/helpers.rb
+- lib/sinatra/param_validator/identifier.rb
+- lib/sinatra/param_validator/invalid_parameter_error.rb
 - lib/sinatra/param_validator/parameter.rb
 - lib/sinatra/param_validator/parameter/array.rb
 - lib/sinatra/param_validator/parameter/boolean.rb