sinatra-my-params 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 517d1c8ee0d4be39d56aa775659ccb5a158c3f27f2f2e0f27abb6b80b890dbb8
-  data.tar.gz: aa9aca42a85144fbd460016ba3abddc9fbc2d4862fe42da3f8ffda02b65d8a85
+  metadata.gz: a2c387628a7d4582e28e5fe2bdc905abc284cdcf81c76fc8bd2f0c3e23f254e1
+  data.tar.gz: e86107885442e79700caf8f293b591814798296275b5588dbe2120d80df63898
 SHA512:
-  metadata.gz: d34af72735130ba06e1754e03f64b2179b1561ee8325deb1e22516843674fccafcb289f6f9fe902f5979b86cc5823083de996b6a063d904df5301f100f3eda1d
-  data.tar.gz: '09fdd6bdec6704c5edd45d60c24dcca194e6ed7751cd82b1b463a29efdffe3fa8a455b8b3fc2737386477bf50308987198eeac5db7de5eae244d3aded7477762'
+  metadata.gz: 8c544a84df83f1e507dced93487e175f0d3b4044141f47774f59fdd8f12592070f98134a472b524983ddde905af04444da6acf359cbf8a34c14fe5e0d1eb65b5
+  data.tar.gz: b03d81b690692988673bdf9fbf944ca533fa770ff3e4b21f358e371579b6c0ebc6c5688d5729adc243c4e1f522737b256941cee23ee71df6964917b87c6c3a3e

data/Rakefile

@@ -1,8 +1,13 @@
 require "rake/testtask"
+require "rspec/core/rake_task"
 
 Rake::TestTask.new do |t|
   t.libs << "test"
 end
 
-desc "Run tests"
-task :default => :test
+begin
+  RSpec::Core::RakeTask.new(:spec)
+
+  task :default => :spec
+rescue LoadError
+end

data/lib/permit_params.rb

@@ -3,17 +3,20 @@ module PermitParams
     attr_accessor :param, :options
   end
 
+  def permitted_params(params, permitted = {}, strong_validation = false)
+    return params if permitted.empty?
   
-  def permitted_params(params, permitted, strong_validation = false)
     params.select do |k,v| 
       permitted.keys.map(&:to_s).include?(k.to_s) && 
         !v.nil? && 
-        coerce(v, permitted[k.to_sym], strong_validation)
+        !coerce(v, permitted[k.to_sym], strong_validation).nil?
     end
   end
 
   private
 
+  Boolean = :boolean
+
   def coerce(param, type, strong = false, options = {})
     begin
       return nil if param.nil?
@@ -26,17 +29,17 @@ module PermitParams
       return DateTime.parse(param) if type == DateTime
       return Array(param.split(options[:delimiter] || ",")) if type == Array
       return Hash[param.split(options[:delimiter] || ",").map{|c| c.split(options[:separator] || ":")}] if type == Hash
-      if [TrueClass, FalseClass, Boolean].include? type
-        coerced = /^(false|f|no|n|0)$/i === param.to_s ? false : /^(true|t|yes|y|1)$/i === param.to_s ? true : nil
-        raise ArgumentError if coerced.nil?
-        return coerced
-      end
+      return coerce_boolean(param) if [TrueClass, FalseClass, Boolean].include? type
       return nil
     rescue ArgumentError
-      if strong
-        raise InvalidParameterError, "'#{param}' is not a valid #{type}"
-      end
+      raise InvalidParameterError, "'#{param}' is not a valid #{type}" if strong
     end
   end
+
+  def coerce_boolean(param)
+    coerced = /^(false|f|no|n|0)$/i === param.to_s ? false : /^(true|t|yes|y|1)$/i === param.to_s ? true : nil
+    raise ArgumentError if coerced.nil?
+    coerced
+  end
 end
 

data/spec/permit_params_spec.rb

@@ -0,0 +1,70 @@
+require "test/unit"
+require "permit_params"
+require "rspec"
+require "rack/test"
+
+include PermitParams
+
+describe "exceptions" do
+  it "should raise error when at least one param is invalid" do
+    input = { param_1: "a" }
+    expect{
+      permitted_params(input, { param_1: Integer }, true)
+    }.to raise_error(InvalidParameterError, "'a' is not a valid Integer") 
+  end
+
+  it "should return a string when a pemitted is string" do
+    input = { param_1: "a string" }
+    expect(input).to eq permitted_params(input, { param_1: String })
+  end
+
+  it "should return a float when a pemitted is float" do
+    input = { param_1: 10.0 }
+    expect(input).to eq permitted_params(input, { param_1: Float })
+  end
+
+  it "should return a date when a pemitted is date" do
+    input = { param_1: Date.new }
+    expect(input).to eq permitted_params(input, { param_1: Date })
+  end
+
+  it "should return a time when a pemitted is time" do
+    input = { param_1: Time.new }
+    expect(input).to eq permitted_params(input, { param_1: Time })
+  end
+
+  it "should return an integer when a pemitted is integer" do
+    input = { param_1: 1 }
+    expect(input).to eq permitted_params(input, { param_1: Integer })
+  end
+
+  it "should return an integer when a pemitted can be cast into integer" do
+    input = { param_1: "1" }
+    output = { param_1: 1 }
+    expect(input).to eq permitted_params(input, { param_1: Integer })
+  end
+
+  it "should return a false(boolean) when a pemitted is boolean" do
+    input = { param_1: "false" }
+    output = { param_1: "false" }
+    expect(output).to eq permitted_params(input, { param_1: Boolean })
+  end
+
+  it "should return a true(boolean) when a pemitted is boolean" do
+    input = { param_1: "true" }
+    output = { param_1: "true" }
+    expect(output).to eq permitted_params(input, { param_1: Boolean })
+  end
+
+  it "should remove a string when a pemitted is integer" do
+    input = { param_1: "a string" }
+    output = {}
+    expect(output).to eq permitted_params(input, { param_1: Integer })
+  end
+
+  it "should allow all params when no restriction is given" do
+    input = { param_1: "a string" }
+    expect(input).to eq permitted_params(input)
+  end
+end
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sinatra-my-params
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Marco Aviles
@@ -11,7 +11,7 @@ cert_chain: []
 date: 2021-09-19 00:00:00.000000000 Z
 dependencies: []
 description: A simple sinatra params sanitizer
-email: nick@quaran.to
+email: gdmarav374@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -19,7 +19,7 @@ files:
 - Rakefile
 - bin/permit_params
 - lib/permit_params.rb
-- test/test_permit_params.rb
+- spec/permit_params_spec.rb
 homepage: https://github.com/mhero/sinatra-my-params
 licenses: []
 metadata: {}
@@ -43,4 +43,4 @@ signing_key:
 specification_version: 3
 summary: permit_params!
 test_files:
-- test/test_permit_params.rb
+- spec/permit_params_spec.rb

data/test/test_permit_params.rb

@@ -1,35 +0,0 @@
-require "test/unit"
-require "permit_params"
-require "rspec"
-require "rack/test"
-
-class PermitParamsTest < Test::Unit::TestCase
-  include PermitParams
-
-  def test_pemit_string
-    input = { param_1: "a string" }
-    output = { param_1: "a string" }
-    assert_equal output, permitted_params( input, { param_1: String } )
-  end
-
-  def test_permit_integer
-    input = { param_1: 1 }
-    output = { param_1: 1 }
-    assert_equal output, permitted_params( input, { param_1: Integer } )
-  end
-
-  def test_remove_integer
-    input = { param_1: "a string" }
-    output = {}
-    assert_equal output, permitted_params( input, { param_1: Integer } )
-  end
-
-  describe "exceptions" do
-    describe "raise" do
-      it "should raise error when at least one param is invalid" do
-        input = { param_1: "a" }
-        expect(permitted_params( input, { param_1: Integer }, true )).to raise_error InvalidParameterError
-      end
-    end
-  end
-end