sinatra-fix_951 1.0.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 7de5a3271eb11d6cee35247559e34b2e90523a5f
+  data.tar.gz: 51ff29c937fe5828d1d2af2cbbf56d8df4a2d052
+SHA512:
+  metadata.gz: 55bdde9fffde3b2b1bf20d0eed2da96c105a94d505994b54799363aeaa608a9ec7acfda5585328a0b16c335d08573fd4e3a4d5fc78d33cd646a600784e49f976
+  data.tar.gz: 5046102e6ae621b2e70578ff246801c5b2bf566debd87101a699952e6d94831839449c54b7bcfd3bff770c21f64a43b0e375fa32e0b0b2131dd8bd3a7156e386

data/.gitignore

@@ -0,0 +1,13 @@
+# THIS IS COPY / PASTED STRAIGHT OUT OF THE SINATRA GEMFILE:
+# https://github.com/sinatra/sinatra/blob/v1.4.5/.gitignore
+
+# please add general patterns to your global ignore list
+# see https://github.com/github/gitignore#readme
+.DS_STORE
+*.swp
+*.rbc
+*.sass-cache
+/pkg
+/doc/api
+/Gemfile.lock
+*.gem

data/.travis.yml

@@ -0,0 +1,24 @@
+# THIS IS COPY / PASTED STRAIGHT OUT OF THE SINATRA GEMFILE:
+# https://github.com/sinatra/sinatra/blob/v1.4.5/.travis.yml
+---
+rvm:
+  - 1.8.7
+  - 1.9.2
+  - 1.9.3
+  - 2.0.0
+  - 2.1.0
+  - rbx
+  - jruby
+  - jruby-head
+  - ruby-head
+matrix:
+  include:
+    - { rvm: 1.9.3, env: rack=1.4.0  }
+    - { rvm: 1.8.7, env: tilt=master }
+    - { rvm: 1.9.3, env: rack=master }
+    - { rvm: 1.9.3, env: tilt=master }
+  allow_failures:
+    - env: tilt=master
+    - rvm: rbx
+    - rvm: ruby-head
+    - rvm: jruby-head

data/Gemfile

@@ -0,0 +1,82 @@
+# THIS IS COPY / PASTED STRAIGHT OUT OF THE SINATRA GEMFILE:
+# https://github.com/sinatra/sinatra/blob/v1.4.5/Gemfile
+
+# Why use bundler?
+# Well, not all development dependencies install on all rubies. Moreover, `gem
+# install sinatra --development` doesn't work, as it will also try to install
+# development dependencies of our dependencies, and those are not conflict free.
+# So, here we are, `bundle install`.
+#
+# If you have issues with a gem: `bundle install --without-coffee-script`.
+
+RUBY_ENGINE = 'ruby' unless defined? RUBY_ENGINE
+source 'https://rubygems.org' unless ENV['QUICK']
+gemspec
+
+gem 'rake'
+gem 'rack-test', '>= 0.5.6'
+gem 'minitest',  '= 5.5.1'
+
+# Allows stuff like `tilt=1.2.2 bundle install` or `tilt=master ...`.
+# Used by the CI.
+github = "git://github.com/%s.git"
+repos  = {'tilt' => github % "rtomayko/tilt", 'rack' => github % "rack/rack"}
+
+%w[tilt rack].each do |lib|
+  dep = case ENV[lib]
+        when 'stable', nil then nil
+        when /(\d+\.)+\d+/ then "~> " + ENV[lib].sub("#{lib}-", '')
+        else {:git => repos[lib], :branch => dep}
+        end
+  gem lib, dep
+end
+
+if RUBY_ENGINE == 'jruby'
+  gem 'nokogiri', '!= 1.5.0'
+  gem 'jruby-openssl'
+  gem 'trinidad'
+end
+
+if RUBY_ENGINE == "ruby" and RUBY_VERSION > '1.9.2'
+  gem 'less', '~> 2.0'
+  gem 'therubyracer'
+  gem 'redcarpet'
+  gem 'wlang', '>= 2.0.1'
+  gem 'bluecloth'
+  gem 'rdiscount'
+  gem 'RedCloth'
+  gem 'puma'
+  gem 'net-http-server'
+  gem 'yajl-ruby'
+  gem 'nokogiri'
+  gem 'thin'
+  gem 'slim', '~> 1.0'
+  gem 'coffee-script', '>= 2.0'
+  gem 'rdoc'
+  gem 'kramdown'
+  gem 'maruku'
+  gem 'creole'
+  gem 'wikicloth'
+  gem 'markaby'
+  gem 'radius'
+  gem 'asciidoctor'
+  gem 'liquid'
+  gem 'stylus'
+  gem 'rabl'
+  gem 'builder'
+  gem 'erubis'
+  gem 'haml', '>= 3.0'
+  gem 'sass'
+end
+
+gem 'pry'
+
+if RUBY_ENGINE == "rbx"
+  gem 'json'
+  gem 'rubysl'
+  gem 'rubysl-test-unit'
+end
+
+platforms :ruby_18, :jruby do
+  gem 'json' unless RUBY_VERSION > '1.9' # is there a jruby but 1.8 only selector?
+end

data/Rakefile

@@ -0,0 +1,7 @@
+desc 'Run the tests'
+task :test do
+  require File.expand_path('../test', __FILE__)
+end
+
+task :default => :test
+

data/Readme.md

@@ -0,0 +1,55 @@
+[![Build Status](https://secure.travis-ci.org/JoshCheek/sinatra-fix_951.png?branch=master)](https://travis-ci.org/JoshCheek/sinatra-fix_951)
+
+Fix for Sinatra 1.4.5's [issue #951](https://github.com/sinatra/sinatra/issues/951)
+===================================================================================
+
+Fixes a bug that my students have been hitting while working on their projects.
+
+How to know if you hit this
+---------------------------
+
+You will know if you hit this, because you'll get an error message like
+
+```
+NoMethodError: undefined method `join' for #<String:0x007f62c3e6fb90>
+```
+
+Or maybe one like this:
+
+```
+Unexpected error while processing request: undefined method `join' for #<String:0x007fa3d244d1f8>
+```
+
+If you want to understand it better, the issue is [here](https://github.com/sinatra/sinatra/issues/951),
+and I traced its history and explained what happened and why [here](https://github.com/sinatra/sinatra/issues/951#issuecomment-73140540).
+
+If you want to understand why this fixes the issue,
+then you'll need to learn the Ruby Object Model.
+This is a class that [I teach](object-model-2httpsgithubcomjoshcheekruby-object-model),
+come and learn with us at the [Turing School of Software and Design](http://turing.io/)!
+
+Installing
+----------
+
+If you're using Bundler, then add this to your Gemfile:
+
+```ruby
+gem 'sinatra-fix_951', require: 'sinatra/fix_951'
+```
+
+If you aren't using Bundler, then install it from the command-line:
+
+```sh
+$ gem install sinatra-fix_951
+```
+
+And then require it wherever you're currently requiring Sinatra:
+
+```ruby
+require 'sinatra/fix_951'
+```
+
+LICENSE
+-------
+
+MIT, to mirror [Sinatra's license](https://github.com/sinatra/sinatra/blob/master/LICENSE).

data/lib/sinatra/fix_951.rb

@@ -0,0 +1,3 @@
+# fix the Sinatra 1.4.5 bug
+require 'sinatra/show_exceptions'
+Sinatra::ShowExceptions.module_eval { def pretty(*) Array super end }

data/sinatra-fix_951.gemspec

@@ -0,0 +1,14 @@
+Gem::Specification.new do |s|
+  s.name        = 'sinatra-fix_951'
+  s.version     = '1.0.0'
+  s.description = "Fix bug #951 in Sinatra version 1.4.5"
+  s.summary     = "My students at the Turing School of Software and Design have been hitting this bug for three or four months now. Finally decided to just fix it."
+  s.authors     = ["Josh Cheek"]
+  s.email       = "josh.cheek@gmail.com"
+  s.homepage    = "https://github.com/JoshCheek/sinatra-fix_951"
+  s.license     = 'MIT'
+  s.files       = `git ls-files`.split("\n")
+  s.test_files  = ['test.rb']
+
+  s.add_dependency 'sinatra', '= 1.4.5'
+end

data/test.rb

@@ -0,0 +1,57 @@
+# Initially tested with this shell script (syntax is fish, not bash)
+# $ ruby -I . (find test -type f -name '*_test.rb' | awk '{ print "-r" $0 }') -e 'Sinatra::ShowExceptions.module_eval { def pretty(*) Array super end }'
+
+# this needs to support 1.8.7, which doesn't load rubygems by default -- actually, on my Ruby, it doesn't even ship with rubygems!
+require 'rubygems'
+
+# Fake it out to require the new minitest instead of the old minitest
+# The dependency wasn't formally specified, and it depends on ActiveSupport, which mandates the new Minitest,
+# but it was written against the old minitest, so we're just making it think the old one was loaded,
+# while forcing it to actually load the new one, and then faking the interface enough to appease the tests
+gem 'minitest', '~> 5.1'
+$LOADED_FEATURES << `gem which test/unit`.chomp # so it won't try to re-require files that don't exist anymore
+$LOADED_FEATURES << 'test/unit.rb'              # 1.8.7 version of the previous line
+require 'minitest/autorun'                      # the new equivalent
+require 'minitest/unit'                         # the new equivalent
+Test = Minitest
+module Minitest::Unit::Assertions
+  include Minitest::Assertions
+  alias assert_raise    assert_raises
+  alias assert_not_nil  assert
+  attr_writer :assertions
+  def assertions
+    @assertions ||= 0
+  end
+  def assert_nothing_raised(*)
+    yield
+  end
+end
+class Test::Unit::TestCase
+  include Minitest::Unit::Assertions
+  class << self
+    remove_method :inherited # this method will spam us with like a hundred deprecations for using the old interface
+  end
+end
+
+
+# relevant dirs
+sinatra_gemspec = Gem::Specification.find_by_path 'sinatra'
+test_path       = File.join sinatra_gemspec.full_gem_path, 'test'
+
+# fix load path :/
+$LOAD_PATH.unshift sinatra_gemspec.full_gem_path
+
+# load tests
+Dir[File.join test_path, '*_test.rb'].
+  reject { |file| File.basename(file) == 'rdoc_test.rb' }. # rdoc_test is broken b/c assertion matches a regex against its content
+  each   { |file| require file }
+
+# Fix test that fails due to conflation of `respond_to?` in test helper with the one in Kernel
+# Nothing seems to actually depend on this method
+class Test::Unit::TestCase
+  remove_method :respond_to?
+end
+
+# load our code to make the tests pass
+$LOAD_PATH.unshift File.expand_path('../lib', __FILE__)
+require 'sinatra/fix_951'

metadata

@@ -0,0 +1,68 @@
+--- !ruby/object:Gem::Specification
+name: sinatra-fix_951
+version: !ruby/object:Gem::Version
+  version: 1.0.0
+platform: ruby
+authors:
+- Josh Cheek
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2015-03-22 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: sinatra
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.4.5
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.4.5
+description: 'Fix bug #951 in Sinatra version 1.4.5'
+email: josh.cheek@gmail.com
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- ".gitignore"
+- ".travis.yml"
+- Gemfile
+- Rakefile
+- Readme.md
+- lib/sinatra/fix_951.rb
+- sinatra-fix_951.gemspec
+- test.rb
+homepage: https://github.com/JoshCheek/sinatra-fix_951
+licenses:
+- MIT
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.4.1
+signing_key: 
+specification_version: 4
+summary: My students at the Turing School of Software and Design have been hitting
+  this bug for three or four months now. Finally decided to just fix it.
+test_files:
+- test.rb
+has_rdoc: