simplycop 2.5.1 → 2.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 32233ac04e05b8eaa2eacd1a2ed2dc38981c8ef4725b41d073f219b080e0b7ba
-  data.tar.gz: 85951b31a81a50dc644f84db1ab954f302a0962d000eadd3a1174fd060418f13
+  metadata.gz: 36e026ec123305bd1dce6bc595faed54010680db307d41e2117e93b311b97b60
+  data.tar.gz: 1f7ad07a49455a49db38ce0497950617287cea5c492257978a8b6a2522ae1fc5
 SHA512:
-  metadata.gz: bea04e7808dc0a45505501df3bbb446439d794924f165917bf3996e4f708e398879674fc54dadb12e71fb0828b8fbee6c6c8d31727bfdff5ddcd53c974692adc
-  data.tar.gz: 3c9579c9ef3ae908af9172059867142d71800ee005f5da567eb751a1a1ea88ac63d7f59e2502a1b1298b87899108946dc9e95794c44565a85b5a48461540c969
+  metadata.gz: cedf098a9adbfdcb240bd45bbd8bd8ac09d6383b6d621aac6f7a3be968c2b81644886d50034c689cca00b4aafa821275eb040e103678bc14caad864431281742
+  data.tar.gz: 6ada823832266850960170c3ae3847dd9b3c0dd207b8f34e79d0ef1216d16d9fab30444d152f060de7044ab4fac2e54d0e3a2dc271e8415cef67c61e654170da

data/.simplycop_lint.yml

@@ -93,6 +93,9 @@ Lint/DuplicateRequire:
 Lint/DuplicateRescueException:
   Enabled: true
 
+Lint/DuplicateSetElement:
+  Enabled: true
+
 Lint/EachWithObjectArgument:
   Enabled: true
 

data/.simplycop_rspec.yml

@@ -314,10 +314,8 @@ RSpec/SpecFilePathFormat:
 RSpec/SpecFilePathSuffix:
   Enabled: true
 
-# Added in Rubocop RSpec 3.1.0 but no docs available at that point 
-# so avoid enabling until consequences and default config are clearly documented
-# RSpec/StringAsInstanceDoubleConstant:
-#   Enabled: true
+RSpec/StringAsInstanceDoubleConstant:
+  Enabled: true
 
 RSpec/StubbedMock:
   Enabled: false

data/lib/simplycop/custom_cops/constantize.rb

@@ -10,7 +10,7 @@ module CustomCops
   #   #good
   #   FOO_BAR
   #
-  class Constantize < RuboCop::Cop::Cop
+  class Constantize < RuboCop::Cop::Base
     MSG = 'Avoid dynamically creating constants.'
 
     def_node_matcher :constantizing?, '(send ... :constantize)'
@@ -18,7 +18,7 @@ module CustomCops
     def on_send(node)
       return unless constantizing?(node)
 
-      add_offense(node, location: :selector)
+      add_offense(node.loc.selector)
     end
   end
 end

data/lib/simplycop/custom_cops/define_method.rb

@@ -15,7 +15,7 @@ module CustomCops
   #      end
   #   end
   #
-  class DefineMethod < RuboCop::Cop::Cop
+  class DefineMethod < RuboCop::Cop::Base
     MSG = 'Avoid define_method.'
 
     def_node_matcher :defining_method?, '(send _ :define_method ...)'
@@ -23,7 +23,7 @@ module CustomCops
     def on_send(node)
       return unless defining_method?(node)
 
-      add_offense(node, location: :selector)
+      add_offense(node.loc.selector)
     end
   end
 end

data/lib/simplycop/custom_cops/dont_print_all_env.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module CustomCops
-  class DontPrintAllEnv < RuboCop::Cop::Cop
+  class DontPrintAllEnv < RuboCop::Cop::Base
     #  This cop checks if someone accidentally print all environment variables
     #  because some of them may contain secrets.
     #
@@ -30,7 +30,7 @@ module CustomCops
     def on_send(node)
       return unless convert_env_to_hash_or_array?(node) || print_all_env_shell?(node)
 
-      add_offense(node, location: :selector)
+      add_offense(node.loc.selector)
     end
   end
 end

data/lib/simplycop/custom_cops/instance_eval.rb

@@ -21,7 +21,7 @@ module CustomCops
   #     end
   #   end
   #
-  class InstanceEval < RuboCop::Cop::Cop
+  class InstanceEval < RuboCop::Cop::Base
     MSG = 'Avoid instance_eval.'
 
     def_node_matcher :instance_evaling?, '(send _ :instance_eval ...)'
@@ -29,7 +29,7 @@ module CustomCops
     def on_send(node)
       return unless instance_evaling?(node)
 
-      add_offense(node, location: :selector)
+      add_offense(node.loc.selector)
     end
   end
 end

data/lib/simplycop/custom_cops/method_missing.rb

@@ -12,7 +12,7 @@ module CustomCops
   #
   #   not using method missing
   #
-  class MethodMissing < RuboCop::Cop::Cop
+  class MethodMissing < RuboCop::Cop::Base
     MSG = 'Avoid method missing.'
 
     def on_def(node)

data/lib/simplycop/custom_cops/no_foreground_indices.rb

@@ -11,7 +11,7 @@ module CustomCops
   #   #good
   #   index({ reference: 1 }, { background: true })
   #
-  class NoForegroundIndices < RuboCop::Cop::Cop
+  class NoForegroundIndices < RuboCop::Cop::Base
     MSG = 'Do not create indices that lack the background flag.'
 
     def_node_matcher :model_index?, <<~PATTERN
@@ -31,7 +31,7 @@ module CustomCops
 
     def on_send(node)
       model_index?(node) do |_fields, options|
-        add_offense(node, location: :selector) unless background_enabled?(options)
+        add_offense(node.loc.selector) unless background_enabled?(options)
       end
     end
 

data/lib/simplycop/custom_cops/timecop_without_block.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module CustomCops
-  class TimecopWithoutBlock < RuboCop::Cop::Cop
+  class TimecopWithoutBlock < RuboCop::Cop::Base
     MSG = 'Avoid using `Timecop.%<method>s` without providing a block.'
 
     def_node_matcher :timecop_method, '(send (const nil? :Timecop) ${:travel :freeze} ...)'
@@ -10,7 +10,7 @@ module CustomCops
       timecop_method(node) do |method_name|
         return if !method_name || first_child_of_block?(node) || last_child_is_a_block(node)
 
-        add_offense(node, location: :selector, message: format(MSG, method: method_name))
+        add_offense(node.loc.selector, message: format(MSG, method: method_name))
       end
     end
 

data/lib/simplycop/custom_cops/variable_name_shadowing_method.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module CustomCops
-  class VariableNameShadowingMethod < RuboCop::Cop::Cop
+  class VariableNameShadowingMethod < RuboCop::Cop::Base
     # For each source file, Rubocop calls on_new_investigation, then walks the abstract syntax
     # tree calling on_foo methods for each "foo" AST node - e.g on_begin, on_def, on_args,
     # on_int, etc.

data/lib/simplycop/security/check_for_vulnerable_code.rb

@@ -1,5 +1,5 @@
 module Security
-  class CheckForVulnerableCode < RuboCop::Cop::Cop
+  class CheckForVulnerableCode < RuboCop::Cop::Base
     RESULT = {}
 
     def self.read_file
@@ -27,7 +27,7 @@ module Security
       if (info = RESULT[method])
         message = "Rails: Possible vulnerability found, CVE Details - #{info} "
 
-        add_offense(node, location: :selector, message: message)
+        add_offense(node.loc.selector, message: message)
       end
     end
   end

data/lib/simplycop/security/csrf_token_validation.rb

@@ -1,5 +1,5 @@
 module Security
-  class CSRFTokenValidation < RuboCop::Cop::Cop
+  class CSRFTokenValidation < RuboCop::Cop::Base
     MSG = 'Do not disable authenticity token validation'
     def_node_matcher :skip_before_action, '(send _ :skip_before_action _)'
 
@@ -8,7 +8,7 @@ module Security
 
       _, _, parts = *node
       method = parts.node_parts
-      add_offense(node, location: :selector) if found_match(method[0])
+      add_offense(node.loc.selector) if found_match(method[0])
     end
 
     def found_match(method)

data/lib/simplycop/security/reject_all_requests_local.rb

@@ -1,5 +1,5 @@
 module Security
-  class RejectAllRequestsLocal < RuboCop::Cop::Cop
+  class RejectAllRequestsLocal < RuboCop::Cop::Base
     RAILS_ENV = ['integration', 'staging', 'production']
 
     MSG = "RAILS CONFIG: Restrict usage of option 'consider_all_requests_local' on #{RAILS_ENV.join(', ')} envs"
@@ -9,7 +9,7 @@ module Security
       source = node.source
       file_name = node.loc.operator.to_s
 
-      add_offense(node, location: :selector) if found_match(source) && block_listed?(file_name)
+      add_offense(node.loc.selector) if found_match(source) && block_listed?(file_name)
     end
 
     def block_listed?(string)

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '2.5.1'
+  VERSION = '2.7.0'
 end

data/simplycop.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '1.66.1'
+  spec.add_dependency 'rubocop', '1.67.0'
   spec.add_dependency 'rubocop-ast', '1.32.3'
   spec.add_dependency 'rubocop-capybara', '2.21.0'
   spec.add_dependency 'rubocop-factory_bot', '2.26.1'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 2.5.1
+  version: 2.7.0
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-10-07 00:00:00.000000000 Z
+date: 2024-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.66.1
+        version: 1.67.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.66.1
+        version: 1.67.0
 - !ruby/object:Gem::Dependency
   name: rubocop-ast
   requirement: !ruby/object:Gem::Requirement