simplycop 2.34.6 → 2.35.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c1ab29bc46c57e4326c35f9e8ca117336f6f0fa92624676fba2cdec89f55170d
-  data.tar.gz: 87f6ddb8947813f55438735006641ed49773bd87a6802ce7e6061f74102047c8
+  metadata.gz: 0d71b8b66d0c5fc9d53c69ed545282ec0dba28b82f14e68f563c3b33de3c6f03
+  data.tar.gz: d624ef8fca7dd286c91a50196fa4e764f3e093080f8991f53fd72516b3604b78
 SHA512:
-  metadata.gz: 0dc12c7bad78a15542234d734e7d95ec23f10b5b3b38497f9221dc9ba71b55eba2d039e2a2345598c0f9d5965a25f022a6ada949c84f43fab4b523c78c35b996
-  data.tar.gz: ab37bd4125ba3f7804682addf9a0cfa0fa494fc54a9940003c0b9e269fda08850c16ff1547f62b05ed7b89cd40ab72329f45dee8c2c42e369e9d58c00d91d7e4
+  metadata.gz: ac5f0f564f13bedb49b5a0c2e894fc1bb0940aee3c9769bbe2c8039154fcdb4027dc03fac319f18aa626ffebba90ab8ff6fba2f52f9e3babc7f4c9d7b7acda1d
+  data.tar.gz: 485352ee4d14fbd4966214b5af1912a488b36919e7d5d2c814a64398defe7aaa3fe88943d1222b85abc1fc11a81461a4841a19fea704cba3302799a478c14d5d

data/.simplycop_rspec.yml

@@ -243,6 +243,9 @@ RSpec/NoExpectationExample:
 RSpec/NotToNot:
   Enabled: false
 
+RSpec/Output:
+  Enabled: true
+
 RSpec/OverwritingSetup:
   Enabled: true
 

data/lib/simplycop/custom_cops/version_comparison.rb

@@ -9,8 +9,6 @@ module CustomCops
   #
   # If this cop flags a false positive, disable it with an inline rubocop comment.
   class VersionComparison < RuboCop::Cop::Base
-    extend RuboCop::Cop::AutoCorrector
-
     DISABLE_HINT = 'Disable if not a semantic version string.'
     MSG_TO_F = "Avoid `.to_f` on version strings; use `Gem::Version.new()`. #{DISABLE_HINT}"
     MSG_TO_I = "Avoid `.to_i` on version strings; use `Gem::Version.new()`. #{DISABLE_HINT}"
@@ -40,43 +38,26 @@ module CustomCops
       send(matcher, node) do |receiver|
         return unless version_related?(receiver)
 
-        add_offense(node, message: message) { |c| autocorrect_numeric(c, node, receiver) }
+        add_offense(node, message: message)
       end
     end
 
     def check_ordering_comparison(node)
-      ordering_comparison?(node) do |receiver, str_val|
+      ordering_comparison?(node) do |receiver, _str_val|
         return unless version_related?(receiver)
 
-        add_offense(node, message: MSG_STRING) do |c|
-          c.replace(node, build_comparison(receiver.source, node.method_name, "'#{str_val}'"))
-        end
+        add_offense(node, message: MSG_STRING)
       end
     end
 
     def check_reversed_ordering_comparison(node)
-      reversed_ordering_comparison?(node) do |str_val, receiver|
+      reversed_ordering_comparison?(node) do |_str_val, receiver|
         return unless version_related?(receiver)
 
-        add_offense(node, message: MSG_STRING) do |c|
-          c.replace(node, build_comparison(receiver.source, REVERSED_OPERATORS[node.method_name], "'#{str_val}'"))
-        end
-      end
-    end
-
-    def autocorrect_numeric(corrector, node, receiver)
-      parent = node.parent
-      if parent&.send_type? && ORDERING_OPERATORS.include?(parent.method_name)
-        corrector.replace(parent, build_comparison(receiver.source, parent.method_name, parent.arguments.first.source))
-      else
-        corrector.replace(node, "Gem::Version.new(#{receiver.source})")
+        add_offense(node, message: MSG_STRING)
       end
     end
 
-    def build_comparison(lhs, operator, rhs)
-      "Gem::Version.new(#{lhs}) #{operator} Gem::Version.new(#{rhs})"
-    end
-
     def version_related?(node)
       return false unless node
 

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '2.34.6'
+  VERSION = '2.35.0'
 end

data/simplycop.gemspec

@@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'rubocop-performance', '1.26.1'
   spec.add_dependency 'rubocop-rails', '2.34.3'
   spec.add_dependency 'rubocop-rake', '0.7.1'
-  spec.add_dependency 'rubocop-rspec', '3.8.0'
+  spec.add_dependency 'rubocop-rspec', '3.9.0'
   spec.add_dependency 'rubocop-rspec_rails', '2.32.0'
   spec.add_development_dependency 'bundler', '>= 2.2.15'
   spec.add_development_dependency 'rake', '>= 12.3.3'

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 2.34.6
+  version: 2.35.0
 platform: ruby
 authors:
 - Simply Business
 bindir: bin
 cert_chain: []
-date: 2026-01-07 00:00:00.000000000 Z
+date: 2026-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: benchmark
@@ -127,14 +127,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.8.0
+        version: 3.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.8.0
+        version: 3.9.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec_rails
   requirement: !ruby/object:Gem::Requirement