simplycop 2.34.5 → 2.34.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3724c4a4e75c12cb3becba815516b7d11f9d3dd1e4e872dfc5d3d83a6319f1fe
-  data.tar.gz: f5d964bc6bd709bc246eb9223a973c26f5fa04983edaba765390c3cbea9d21fd
+  metadata.gz: dbe92fb20c458fa89e0a5106707cb2f9b6b3850d2a3b4d80b28433979a412d6b
+  data.tar.gz: f98bd6ca357718dd5133ff77f3346c59c2b56a12e53cf52f5b27c9f0284ce658
 SHA512:
-  metadata.gz: f019a16b3fdfa342e2e5b488ae409f5bded12aea92ab64da618ccfdaf8cf8ca5e842cb38ff24af5b4a573d7e8a39aafa3ab1b244d50b3f12e2a5eb42b6eb36c2
-  data.tar.gz: e7d8036de40de681a4e21f12eba7fe6a0e772a95c505adbb5d720d1c659efe4ca1c6ef2fe6e86492d9a61527d520eaf3309e703db679ba54fd8003e9c4d58dce
+  metadata.gz: a96d6c74ff3c75e94155962a96b156885c0913511314676ab89187df75bc370fe73f41806f107b33016e1c0a62e9391ed511c6018f366340491327459445eb0f
+  data.tar.gz: 48ae49c573b9b8007cb72414b621ed01e00a0dd850a7f19b1add758c85dab0f5a0c50ae21e6093df4de95e3784db8193ee57111e640a08eff2707833e654ed44

data/lib/simplycop/custom_cops/version_comparison.rb

@@ -9,8 +9,6 @@ module CustomCops
   #
   # If this cop flags a false positive, disable it with an inline rubocop comment.
   class VersionComparison < RuboCop::Cop::Base
-    extend RuboCop::Cop::AutoCorrector
-
     DISABLE_HINT = 'Disable if not a semantic version string.'
     MSG_TO_F = "Avoid `.to_f` on version strings; use `Gem::Version.new()`. #{DISABLE_HINT}"
     MSG_TO_I = "Avoid `.to_i` on version strings; use `Gem::Version.new()`. #{DISABLE_HINT}"
@@ -40,43 +38,26 @@ module CustomCops
       send(matcher, node) do |receiver|
         return unless version_related?(receiver)
 
-        add_offense(node, message: message) { |c| autocorrect_numeric(c, node, receiver) }
+        add_offense(node, message: message)
       end
     end
 
     def check_ordering_comparison(node)
-      ordering_comparison?(node) do |receiver, str_val|
+      ordering_comparison?(node) do |receiver, _str_val|
         return unless version_related?(receiver)
 
-        add_offense(node, message: MSG_STRING) do |c|
-          c.replace(node, build_comparison(receiver.source, node.method_name, "'#{str_val}'"))
-        end
+        add_offense(node, message: MSG_STRING)
       end
     end
 
     def check_reversed_ordering_comparison(node)
-      reversed_ordering_comparison?(node) do |str_val, receiver|
+      reversed_ordering_comparison?(node) do |_str_val, receiver|
         return unless version_related?(receiver)
 
-        add_offense(node, message: MSG_STRING) do |c|
-          c.replace(node, build_comparison(receiver.source, REVERSED_OPERATORS[node.method_name], "'#{str_val}'"))
-        end
-      end
-    end
-
-    def autocorrect_numeric(corrector, node, receiver)
-      parent = node.parent
-      if parent&.send_type? && ORDERING_OPERATORS.include?(parent.method_name)
-        corrector.replace(parent, build_comparison(receiver.source, parent.method_name, parent.arguments.first.source))
-      else
-        corrector.replace(node, "Gem::Version.new(#{receiver.source})")
+        add_offense(node, message: MSG_STRING)
       end
     end
 
-    def build_comparison(lhs, operator, rhs)
-      "Gem::Version.new(#{lhs}) #{operator} Gem::Version.new(#{rhs})"
-    end
-
     def version_related?(node)
       return false unless node
 

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '2.34.5'
+  VERSION = '2.34.7'
 end

data/simplycop.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'rubocop-capybara', '2.22.1'
   spec.add_dependency 'rubocop-factory_bot', '2.28.0'
   spec.add_dependency 'rubocop-performance', '1.26.1'
-  spec.add_dependency 'rubocop-rails', '2.34.2'
+  spec.add_dependency 'rubocop-rails', '2.34.3'
   spec.add_dependency 'rubocop-rake', '0.7.1'
   spec.add_dependency 'rubocop-rspec', '3.8.0'
   spec.add_dependency 'rubocop-rspec_rails', '2.32.0'

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 2.34.5
+  version: 2.34.7
 platform: ruby
 authors:
 - Simply Business
 bindir: bin
 cert_chain: []
-date: 2026-01-05 00:00:00.000000000 Z
+date: 2026-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: benchmark
@@ -99,14 +99,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.34.2
+        version: 2.34.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.34.2
+        version: 2.34.3
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement