simplycop 1.9.5 → 1.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 150d6575bbca0608cab225346ba2a422c630140658e7a082827fa2e0121c097f
-  data.tar.gz: c37d21fb2b8801f69d10757099275019f6190ec452074e8da6edba8953ff72dc
+  metadata.gz: 04bc5ffd6bb383b44e116cea89ed9210c0cb836ffc45cd02468bb148f7857437
+  data.tar.gz: 12921bf54b6d0d10ff4bd3ff5ebddae025476b55c2f166d49c26b066bb88f225
 SHA512:
-  metadata.gz: 873af54d423288250da14e21b31c3db67cf99375d4d5dea019884a552267e10c83fa189bf0c9f0455aa3987189653ff26e0de959c6c3486863b221b494231920
-  data.tar.gz: fa902b7eeff5705d71d87930bd839135103b8762335ad6f84699855b232827cdd316358a2179b2cf589bd0447e48fa974a48b9ea49a3bd9169369989db3e9940
+  metadata.gz: 88d9b9612dba9b3710c109bd504cf9cb3471cf2dff06a308551fbdea26ed45abbebc7eb16350cbb0197c70f7627b3bbb7a229d0ba58a3cb148e475a141ef19f9
+  data.tar.gz: 227fd10a49bdba38b09fafe61e566a1bd4e6bcdeace81e5079e04156c3b0c2b028ee15a35904054adc68b9f8ea11408f0fdc1eb89dbc77101b486c96b6923d08

data/.github/workflows/ci.yml

@@ -19,10 +19,10 @@ jobs:
 
     strategy:
       matrix:
-        ruby-version: [2.5, 2.6, 2.7, jruby]
+        ruby-version: [2.7, 3.0, 3.1, jruby]
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:

data/.github/workflows/create-github-release.yml

@@ -5,30 +5,14 @@ on:
     branches:
       - "master"
 
+permissions:
+  contents: write
+
 jobs:
-  create-release:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v2
-      - name: Set up Ruby
-        uses: ruby/setup-ruby@v1
-        with:
-          bundler-cache: true
-      - name: Get Gem Version
-        id: get-gem-version
-        run: echo "::set-output name=GEM_VERSION::$(bundle exec ruby -e 'puts Simplycop::VERSION')"
-      - name: Create Release
-        uses: actions/github-script@v5
-        env:
-          GEM_VERSION: ${{ steps.get-gem-version.outputs.GEM_VERSION }}
-        with:
-          result-encoding: string
-          script: |
-            const { GEM_VERSION } = process.env
-            github.rest.repos.createRelease({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              tag_name: GEM_VERSION,
-              generate_release_notes: true,
-            })
+  create-new-release:
+    uses: simplybusiness/github-action-reusable-workflows/.github/workflows/create-github-release.yaml@v1
+    with:
+      gem_version_class: "Simplycop::VERSION"
+    secrets:
+      bnw-registry-user: ${{ secrets.GH_ACTIONS_NEXUS_USER }}
+      bnw-registry-password: ${{ secrets.GH_ACTIONS_NEXUS_PASSWORD }}

data/.github/workflows/dobby-actions.yml

@@ -13,7 +13,7 @@ jobs:
       BUNDLE_WITHOUT: "development:test"
     steps:
       - name: Chekcout action
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           repository: 'simplybusiness/dobby'
           ref: 'v3.0.0'
@@ -22,7 +22,7 @@ jobs:
         with:
           bundler-cache: true
       - name: Bump version
-        uses: simplybusiness/dobby@v3.0.0
+        uses: simplybusiness/dobby@v3.0.1
         env:
           DOBBY_APP_ID: ${{ secrets.DOBBY_APP_ID }}
           DOBBY_PRIVATE_KEY: ${{ secrets.DOBBY_PRIVATE_KEY }}

data/.github/workflows/publish_gem.yml

@@ -11,7 +11,7 @@ jobs:
     name: Build and Publish
     runs-on: ubuntu-18.04
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Set up Ruby 2.6
         uses: actions/setup-ruby@v1
         with:

data/.github/workflows/version_forget_me_not.yml

@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-18.04
 
     steps:
-      - uses: simplybusiness/version-forget-me-not@V2.1.1
+      - uses: simplybusiness/version-forget-me-not@v2.3.0
         env:
           ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           VERSION_FILE_PATH: "lib/simplycop/version.rb"

data/.simplycop.yml

@@ -22,9 +22,6 @@ AllCops:
   ExtraDetails: true
 # Adapted from: https://github.com/simplybusiness/how-we-roll/blob/master/development/RUBYSTYLEGUIDE.markdown
 
-Gemspec/DateAssignment:
-  Enabled: true
-
 Layout/EmptyLineAfterMultilineCondition:
   Enabled: true
 
@@ -316,3 +313,48 @@ Style/WordArray:
 
 Style/ZeroLengthPredicate:
   Enabled: true
+
+Gemspec/DeprecatedAttributeAssignment: # new in 1.30
+  Enabled: true
+
+Lint/ConstantOverwrittenInRescue: # new in 1.31
+  Enabled: true
+
+Lint/EmptyInPattern: # new in 1.16
+  Enabled: true
+
+Lint/IncompatibleIoSelectWithFiberScheduler: # new in 1.21
+  Enabled: true
+
+Naming/BlockForwarding: # new in 1.24
+  Enabled: true
+
+Style/EmptyHeredoc: # new in 1.32
+  Enabled: true
+
+Style/FileRead: # new in 1.24
+  Enabled: true
+
+Style/InPatternThen: # new in 1.16
+  Enabled: true
+
+Style/MagicCommentFormat: # new in 1.35
+  Enabled: true
+
+Style/MapCompactWithConditionalBlock: # new in 1.30
+  Enabled: true
+
+Style/MultilineInPatternThen: # new in 1.16
+  Enabled: true
+
+Style/NestedFileDirname: # new in 1.26
+  Enabled: true
+
+Style/NumberedParameters: # new in 1.22
+  Enabled: true
+
+Style/NumberedParametersLimit: # new in 1.22
+  Enabled: true
+
+Style/ObjectThen: # new in 1.28
+  Enabled: true

data/.simplycop_rails.yml

@@ -61,3 +61,42 @@ Rails/WhereExists:
 # Conflicts with Mongoid
 Rails/WhereNot:
   Enabled: false
+
+Rails/ActionControllerTestCase: # new in 2.14
+  Enabled: true
+
+Rails/AddColumnIndex: # new in 2.11
+  Enabled: true
+
+Rails/DotSeparatedKeys: # new in 2.15
+  Enabled: true
+
+Rails/DuplicateAssociation: # new in 2.14
+  Enabled: true
+
+Rails/DuplicateScope: # new in 2.14
+  Enabled: true
+
+Rails/EagerEvaluationLogMessage: # new in 2.11
+  Enabled: true
+
+Rails/ExpandedDateRange: # new in 2.11
+  Enabled: true
+
+Rails/I18nLazyLookup: # new in 2.14
+  Enabled: true
+
+Rails/MigrationClassName: # new in 2.14
+  Enabled: true
+
+Rails/RedundantTravelBack: # new in 2.12
+  Enabled: true
+
+Rails/ToFormattedS: # new in 2.15
+  Enabled: true
+
+Rails/TransactionExitStatement: # new in 2.14
+  Enabled: true
+
+Rails/UnusedIgnoredColumns: # new in 2.11
+  Enabled: true

data/.simplycop_rspec.yml

@@ -46,3 +46,9 @@ RSpec/ScatteredSetup:
 
 RSpec/StubbedMock:
   Enabled: false
+
+RSpec/SubjectDeclaration: # new in 2.5
+  Enabled: true
+
+RSpec/Rails/AvoidSetupHook: # new in 2.4
+  Enabled: true

data/lib/simplycop/security/check_for_vulnerable_code.rb

@@ -5,7 +5,7 @@ module Security
     def self.read_file
       gem_path = File.expand_path("#{File.dirname(__FILE__)}../../../../")
 
-      file = File.open("#{gem_path}/vuln_db.json", "r").read.strip
+      file = File.read("#{gem_path}/vuln_db.json").strip
       json = JSON.parse(file)
       json["vulnerabilities"]["rails"]
     end

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.9.5'
+  VERSION = '1.12.0'
 end

data/simplycop.gemspec

@@ -17,9 +17,9 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 1.12.1'
-  spec.add_dependency 'rubocop-rails', '~> 2.9.0'
-  spec.add_dependency 'rubocop-rspec', '~> 2.2.0'
+  spec.add_dependency 'rubocop', '~> 1.35.0'
+  spec.add_dependency 'rubocop-rails', '~> 2.15.0'
+  spec.add_dependency 'rubocop-rspec', '~> 2.12.0'
   spec.add_development_dependency 'bundler', '>= 2.2.15'
   spec.add_development_dependency 'rake', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.10'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.9.5
+  version: 1.12.0
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-05-25 00:00:00.000000000 Z
+date: 2022-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,42 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.12.1
+        version: 1.35.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.12.1
+        version: 1.35.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.9.0
+        version: 2.15.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.9.0
+        version: 2.15.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: 2.12.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: 2.12.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement