simplycop 1.7.5 → 1.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b2e77533f1f1e2ab183ee38e0b154de2b531366aa67c112eda000e2a2a6da9dc
-  data.tar.gz: 176e07e981b3747f42b4b275c49fcc4c13193ad1a44dc37c7e85bfce0b79fa8b
+  metadata.gz: 1a29b770b541b2f3a6ef6168c4841716a7252e6177827b53da7ad4a699e3ad2d
+  data.tar.gz: 42d094390b9722d90b9702065b8999ef7e8b1546d5ff4c0b42d8c6f56c664589
 SHA512:
-  metadata.gz: 1158d81c907c57ca389d6638cdc39ee86fb4f0f277f6e071f3a62b42d8e7a5420432a82444ce4897a3f946d859b16ee31fcd4e9da92879a15bc544ac3ed9c323
-  data.tar.gz: f13026040f02ec6b2e199fd2a75e1a57cc3cc975fb2155431d522658ca7c397db8f20e2ab23d46312000dd9cb3cf893741a6dcf2563c5d946a0235854f58b448
+  metadata.gz: feec480c50cc3710054fd3f20d217bdc77b93f7564037fe71c67920c710b71dff8d4c37813d9f318a48410716acbd8cc5bcdd77c9ac30facd93ba8c80b815310
+  data.tar.gz: '0599f55d176c3f02dedb6b2628a5305f65e179a1c721305a042ab3dfeb8d7244638aaffc49010ebf1b02f3dd2c2e57cf112d05c686d1685ac85c53475432c6af'

data/.github/workflows/ci.yml

@@ -6,6 +6,9 @@ on:
 
 env:
   CI: true
+permissions:
+  contents: read
+  statuses: write
 
 jobs:
   build:

data/.github/workflows/dobby-actions.yml

@@ -3,6 +3,8 @@ name: "Dobby action"
 on:
   issue_comment:
     types: [created]
+permissions:
+  contents: read
 jobs:
   pr_commented:
     runs-on: ubuntu-20.04

data/.github/workflows/publish_gem.yml

@@ -3,6 +3,8 @@ name: Publish Ruby Gem
 on:
   push:
     branches: [ master ]
+permissions:
+  contents: read
 
 jobs:
   build:

data/.github/workflows/version_forget_me_not.yml

@@ -6,12 +6,15 @@ on:
     branches:
       - master
     types: [opened, synchronize]
+permissions:
+  contents: read
+  statuses: write
 jobs:
   build:
     runs-on: ubuntu-18.04
 
     steps:
-      - uses: simplybusiness/version-forget-me-not@v2
+      - uses: simplybusiness/version-forget-me-not@v2.1.0
         env:
           ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           VERSION_FILE_PATH: "lib/simplycop/version.rb"

data/lib/simplycop/custom_cops/variable_name_shadowing_method.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module CustomCops
+  class VariableNameShadowingMethod < RuboCop::Cop::Cop
+    # For each source file, Rubocop calls on_new_investigation, then walks the abstract syntax
+    # tree calling on_foo methods for each "foo" AST node - e.g on_begin, on_def, on_args,
+    # on_int, etc.
+
+    # We need to do two passes over the source so that we can find all the method names before
+    # we start looking at the nodes that assign local variables (some methods may be defined
+    # _after_ code that assigns shadowing local variables. We do the first one in
+    # on_new_investigation
+
+    def_node_search :method_names, <<~PATTERN
+      (:def $_ ...)
+    PATTERN
+
+    def on_new_investigation
+      ast = processed_source.ast
+      @declared_method_names = ast ? method_names(processed_source.ast).to_a : []
+    end
+
+    def on_lvasgn(node)
+      if @declared_method_names.include?(node.name)
+        add_offense(
+          node,
+          message: "Shadowing method name - `#{node.name}`."
+        )
+      end
+    end
+  end
+end

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.7.5'
+  VERSION = '1.9.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.7.5
+  version: 1.9.1
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-10-19 00:00:00.000000000 Z
+date: 2021-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -132,6 +132,7 @@ files:
 - lib/simplycop/custom_cops/instance_eval.rb
 - lib/simplycop/custom_cops/method_missing.rb
 - lib/simplycop/custom_cops/timecop_without_block.rb
+- lib/simplycop/custom_cops/variable_name_shadowing_method.rb
 - lib/simplycop/security/check_for_vulnerable_code.rb
 - lib/simplycop/security/csrf_token_validation.rb
 - lib/simplycop/security/reject_all_requests_local.rb
@@ -158,7 +159,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.2.32
 signing_key: 
 specification_version: 4
 summary: Provides a single point of reference for common rubocop rules.