simplycop 1.7.4 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 51da31df3951047a568a81ec7504c1930411afcf0e857b2e65ace63d1f488ac0
-  data.tar.gz: 85d46a288f0d262dda7ba5d45499af3f7e8091ca74a66631eafae6cb1f140a00
+  metadata.gz: 88ed5a7c12b016aa0efc6a92e43929528815b273a23909e4a326f3e1dcff6c66
+  data.tar.gz: 24cb00aab9c999085a80b5b4f9f74da88e4e070708ba9427ae4dcb287b5fd889
 SHA512:
-  metadata.gz: 5557171cf6f61cfb26ea0cefcb6a3cc8d50bd6310fbdd061bae01e3ff50232a0bc2c8c0316737408baec401ac3e6426b4c82f72e07dd2a5804d56a8a50a67253
-  data.tar.gz: 6c4f41690117b681f990ed6dc631a5def48e4881b0040ec2f9446b1931e35f61a426a3d0a7205dc63e2f08eb86a699f56a55b140232e5f071a1e75d6b68459b7
+  metadata.gz: 6ed0a5a152bdbb61bb03f7d30730732446505019b9b2b36107cd302c3960791fe3b841e4ab7d60ea8c2792aa286bacbc8258d91d8e68473df8065ee5ce1d1388
+  data.tar.gz: a7ddf0c5a20dd568d3ce16cb0d11279156b9f7627f0683515ff94b64cb079a941cb4dc8f8623447dcd343c59278819b3dfbc972cb8e2553be9e0ba56ec0c174a

data/lib/simplycop/custom_cops/variable_name_shadowing_method.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module CustomCops
+  class VariableNameShadowingMethod < RuboCop::Cop::Cop
+    # For each source file, Rubocop calls on_new_investigation, then walks the abstract syntax
+    # tree calling on_foo methods for each "foo" AST node - e.g on_begin, on_def, on_args,
+    # on_int, etc.
+
+    # We need to do two passes over the source so that we can find all the method names before
+    # we start looking at the nodes that assign local variables (some methods may be defined
+    # _after_ code that assigns shadowing local variables. We do the first one in
+    # on_new_investigation
+
+    def_node_search :method_names, <<~PATTERN
+      (:def $_ ...)
+    PATTERN
+
+    def on_new_investigation
+      ast = processed_source.ast
+      @declared_method_names = ast ? method_names(processed_source.ast).to_a : []
+    end
+
+    def on_lvasgn(node)
+      if @declared_method_names.include?(node.name)
+        add_offense(
+          node,
+          message: "Shadowing method name - `#{node.name}`."
+        )
+      end
+    end
+  end
+end

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.7.4'
+  VERSION = '1.9.0'
 end

data/simplycop.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'rubocop', '~> 1.12.1'
   spec.add_dependency 'rubocop-rails', '~> 2.9.0'
   spec.add_dependency 'rubocop-rspec', '~> 2.2.0'
-  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'bundler', '>= 2.2.15'
   spec.add_development_dependency 'rake', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.10'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.7.4
+  version: 1.9.0
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-10-18 00:00:00.000000000 Z
+date: 2021-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.2.15
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.2.15
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -132,6 +132,7 @@ files:
 - lib/simplycop/custom_cops/instance_eval.rb
 - lib/simplycop/custom_cops/method_missing.rb
 - lib/simplycop/custom_cops/timecop_without_block.rb
+- lib/simplycop/custom_cops/variable_name_shadowing_method.rb
 - lib/simplycop/security/check_for_vulnerable_code.rb
 - lib/simplycop/security/csrf_token_validation.rb
 - lib/simplycop/security/reject_all_requests_local.rb