simplycop 1.7.3 → 1.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 37f961bf25d8a75b4c034f73b033878fda1f93de9aac8eb0f7d973a70cb6208f
-  data.tar.gz: db170cb142883c29d430f3c0963c8cd5aa8e000ce1c4b5f4651efef7c5945c04
+  metadata.gz: a1826e5017b51de501d8edc54dd6100d4d561855cab74f820e3cc05cfc3e634f
+  data.tar.gz: c893eea27d6d1c111c6534e8eac64a14a152d460c14968fd86749a936efae52a
 SHA512:
-  metadata.gz: fd9db437e6ba9d1b47e5c2a5ff2ff3d63657c274b5898dabc0b7bbb87802221dbf4dc4c883d7c03498ed28ce1c6b89c985ccff6b89d9e4a4155d5d9959f53ba5
-  data.tar.gz: 312b26a63c636df40d7508102ae82181951f0024f70006c71a92615ef5ac349b53779a69459c2f426bec3a537955e53494cac690e4e64d1b0ac48e7ab274b30b
+  metadata.gz: 127c38e256808577ec45d688b603b51ef65cb9e17c70e235b1475a7d302f6965f4a692cc28817c6c08755faa6d8a976a9abde92103faaf6376a857f9a855e055
+  data.tar.gz: a01b1754ebcb30bbaaa1393c084949f8846eccb787073c6b75e57d995ca4a2680854d95482e3e6feceb6ee13c6ae8cecbf7ebaeaad877f8ca455e44ca2db70b2

data/.custom_simplycop.yml

@@ -1,6 +1,7 @@
 require:
   - './lib/simplycop/custom_cops/timecop_without_block.rb'
   - './lib/simplycop/custom_cops/dont_print_all_env.rb'
+  - './lib/simplycop/custom_cops/variable_name_shadowing_method.rb'
 
 AllCops:
   ExtraDetails: true

data/.github/workflows/dobby-actions.yml

@@ -1,4 +1,5 @@
-name: "dobby actions"
+
+name: "Dobby action"
 on:
   issue_comment:
     types: [created]
@@ -6,10 +7,20 @@ jobs:
   pr_commented:
     runs-on: ubuntu-20.04
     if: startsWith(github.event.comment.body, '/dobby')
-
+    env:
+      BUNDLE_WITHOUT: "development:test"
     steps:
-      - name: 'bump version'
-        uses: simplybusiness/dobby@v2.1.0
+      - name: Chekcout action
+        uses: actions/checkout@v2
+        with:
+          repository: 'simplybusiness/dobby'
+          ref: 'v3.0.0'
+      - name: Set up ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
+      - name: Bump version
+        uses: simplybusiness/dobby@v3.0.0
         env:
           DOBBY_APP_ID: ${{ secrets.DOBBY_APP_ID }}
           DOBBY_PRIVATE_KEY: ${{ secrets.DOBBY_PRIVATE_KEY }}

data/lib/simplycop/custom_cops/variable_name_shadowing_method.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module CustomCops
+  class VariableNameShadowingMethod < RuboCop::Cop::Cop
+    # For each source file, Rubocop calls on_new_investigation, then walks the abstract syntax
+    # tree calling on_foo methods for each "foo" AST node - e.g on_begin, on_def, on_args,
+    # on_int, etc.
+
+    # We need to do two passes over the source so that we can find all the method names before
+    # we start looking at the nodes that assign local variables (some methods may be defined
+    # _after_ code that assigns shadowing local variables. We do the first one in
+    # on_new_investigation
+
+    def_node_search :method_names, <<~PATTERN
+      (:def $_ ...)
+    PATTERN
+
+    def on_new_investigation
+      ast = processed_source.ast
+      @declared_method_names = ast ? method_names(processed_source.ast).to_a : []
+    end
+
+    def on_lvasgn(node)
+      if @declared_method_names.include?(node.name)
+        add_offense(
+          node,
+          message: "Shadowing method name - `#{node.name}`."
+        )
+      end
+    end
+  end
+end

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.7.3'
+  VERSION = '1.8.1'
 end

data/simplycop.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'rubocop', '~> 1.12.1'
   spec.add_dependency 'rubocop-rails', '~> 2.9.0'
   spec.add_dependency 'rubocop-rspec', '~> 2.2.0'
-  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'bundler', '>= 2.2.15'
   spec.add_development_dependency 'rake', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.10'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.7.3
+  version: 1.8.1
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-08-26 00:00:00.000000000 Z
+date: 2021-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.2.15
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.2.15
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -132,6 +132,7 @@ files:
 - lib/simplycop/custom_cops/instance_eval.rb
 - lib/simplycop/custom_cops/method_missing.rb
 - lib/simplycop/custom_cops/timecop_without_block.rb
+- lib/simplycop/custom_cops/variable_name_shadowing_method.rb
 - lib/simplycop/security/check_for_vulnerable_code.rb
 - lib/simplycop/security/csrf_token_validation.rb
 - lib/simplycop/security/reject_all_requests_local.rb