simplycop 1.7.1 → 1.7.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1c5e5d71fa2887210ca724ca027750a4d4394d1b3534c5788c80c60b84962bde
-  data.tar.gz: 508cdb5d80beb6e5c0165684ea41ae2e48b9f0754c00f7177d12c33c1e97ae11
+  metadata.gz: b2e77533f1f1e2ab183ee38e0b154de2b531366aa67c112eda000e2a2a6da9dc
+  data.tar.gz: 176e07e981b3747f42b4b275c49fcc4c13193ad1a44dc37c7e85bfce0b79fa8b
 SHA512:
-  metadata.gz: 25ac6ea607cc4815efcbe24d2ffa93e9766eb72863845b4cc08720fc7092da563a902af21b21e73599b0e512901c35c68e94f6096b167c7ef61ba350e2bf140f
-  data.tar.gz: b48e756765a1fa0b9a19a0232cadf9b17d4335de756f1164ad6ecc22f2a87c6922dbb70c5f6e419f17eb48845d56bccc8396ce7f4e20755ea358538e6258ac62
+  metadata.gz: 1158d81c907c57ca389d6638cdc39ee86fb4f0f277f6e071f3a62b42d8e7a5420432a82444ce4897a3f946d859b16ee31fcd4e9da92879a15bc544ac3ed9c323
+  data.tar.gz: f13026040f02ec6b2e199fd2a75e1a57cc3cc975fb2155431d522658ca7c397db8f20e2ab23d46312000dd9cb3cf893741a6dcf2563c5d946a0235854f58b448

data/.github/workflows/dobby-actions.yml

@@ -1,4 +1,5 @@
-name: "dobby actions"
+
+name: "Dobby action"
 on:
   issue_comment:
     types: [created]
@@ -6,10 +7,20 @@ jobs:
   pr_commented:
     runs-on: ubuntu-20.04
     if: startsWith(github.event.comment.body, '/dobby')
-
+    env:
+      BUNDLE_WITHOUT: "development:test"
     steps:
-      - name: 'bump version'
-        uses: simplybusiness/dobby@v2.1.0
+      - name: Chekcout action
+        uses: actions/checkout@v2
+        with:
+          repository: 'simplybusiness/dobby'
+          ref: 'v3.0.0'
+      - name: Set up ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
+      - name: Bump version
+        uses: simplybusiness/dobby@v3.0.0
         env:
           DOBBY_APP_ID: ${{ secrets.DOBBY_APP_ID }}
           DOBBY_PRIVATE_KEY: ${{ secrets.DOBBY_PRIVATE_KEY }}

data/README.md

@@ -2,72 +2,4 @@
 
 Provides standard shared rubocop configuration for Simply Business applications. No more copying `.rubocop.yml`, no more out-of-sync configuration files. Yay!
 
-## Installation
-
-Add this line to your application's Gemfile:
-
-```ruby
-gem 'simplycop', git: 'git@github.com:simplybusiness/simplycop.git'
-
-```
-
-Then install gems by executing:
-
-    $ bundle install
-
-Put following lines at the beginning of your `rubocop.yml` file:
-
-```yaml
-inherit_gem:
-  simplycop: .simplycop.yml
-
-AllCops:
-  Exclude:
-    - 'vendor/**/*'
-```
-
-* If you are implementing this in rails project and have rspec , you probably want the standard rails and rspec cops. you can include this by adding:
-
-```yaml
-inherit_gem:
-  simplycop:
-    - .simplycop.yml
-    - .simplycop_rails.yml
-    - .simplycop_rspec.yml
-```
-
-## Usage
-
-Run Rubocop as you would usually do, i.e.
-
-    $ bundle exec rubocop
-
-or from your continuous integration tool.
-
-## Guidances
-
-* If you are implementing this in a non-rails project, you probably don't want or need the rails cops. In case they cause problems, you can exclude them using:
-```yaml
-Rails:
-  Enabled: false
-```
-* When adding rubocop and simplycop to a legacy project, you might want to initially disable some of the rules.
-
-## Security Cops
-- CheckForVulnerableCode
-
-This cop was built to identify possible Rails vulnerable code.
-Its purpose is to raise an awareness of the finding.
-When an offence was raised, please seek for help and guidance from application security team.
-
-IMPORTANT:
-This cop must be enabled at all times, if you need to disable it please check with AppSec team first.
-
-Example of vulnerable code:
-
-```ruby
-class BooksController < ApplicationController
-  caches_page :show
-end
-```
-Vulnerability Details: https://nvd.nist.gov/vuln/detail/CVE-2020-8159
+See [Full docs](docs/index.md)

data/catalog-info.yaml

@@ -0,0 +1,16 @@
+apiVersion: backstage.io/v1alpha1
+kind: Component
+metadata:
+  name: simplycop
+  description: Simply Business Rubocop rules
+  annotations:
+    github.com/project-slug: "simplybusiness/simplycop"
+    backstage.io/source-location: url:https://github.com/simplybusiness/simplycop/
+spec:
+  type: library
+  lifecycle: production
+  owner: silversmiths
+  dependsOn:
+    - "Component:rake"
+    - "Component:rspec"
+    - "Component:rubocop"

data/docs/index.md

@@ -0,0 +1,73 @@
+# Simplycop
+
+Provides standard shared rubocop configuration for Simply Business applications. No more copying `.rubocop.yml`, no more out-of-sync configuration files. Yay!
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+```ruby
+gem 'simplycop'
+
+```
+
+Then install gems by executing:
+
+    $ bundle install
+
+Put following lines at the beginning of your `rubocop.yml` file:
+
+```yaml
+inherit_gem:
+  simplycop: .simplycop.yml
+
+AllCops:
+  Exclude:
+    - 'vendor/**/*'
+```
+
+* If you are implementing this in rails project and have rspec , you probably want the standard rails and rspec cops. you can include this by adding:
+
+```yaml
+inherit_gem:
+  simplycop:
+    - .simplycop.yml
+    - .simplycop_rails.yml
+    - .simplycop_rspec.yml
+```
+
+## Usage
+
+Run Rubocop as you would usually do, i.e.
+
+    $ bundle exec rubocop
+
+or from your continuous integration tool.
+
+## Guidances
+
+* If you are implementing this in a non-rails project, you probably don't want or need the rails cops. In case they cause problems, you can exclude them using:
+```yaml
+Rails:
+  Enabled: false
+```
+* When adding rubocop and simplycop to a legacy project, you might want to initially disable some of the rules.
+
+## Security Cops
+- CheckForVulnerableCode
+
+This cop was built to identify possible Rails vulnerable code.
+Its purpose is to raise an awareness of the finding.
+When an offence was raised, please seek for help and guidance from application security team.
+
+IMPORTANT:
+This cop must be enabled at all times, if you need to disable it please check with AppSec team first.
+
+Example of vulnerable code:
+
+```ruby
+class BooksController < ApplicationController
+  caches_page :show
+end
+```
+Vulnerability Details: https://nvd.nist.gov/vuln/detail/CVE-2020-8159

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.7.1'
+  VERSION = '1.7.5'
 end

data/mkdocs.yml

@@ -0,0 +1,7 @@
+site_name: 'Simplycop Docs'
+docs_dir: 'doc'
+nav:
+  - Home: index.md
+
+plugins:
+  - techdocs-core

data/simplycop.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'rubocop', '~> 1.12.1'
   spec.add_dependency 'rubocop-rails', '~> 2.9.0'
   spec.add_dependency 'rubocop-rspec', '~> 2.2.0'
-  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'bundler', '>= 2.2.15'
   spec.add_development_dependency 'rake', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.10'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.7.1
+  version: 1.7.5
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-28 00:00:00.000000000 Z
+date: 2021-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.2.15
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.2.15
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -123,6 +123,8 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
+- catalog-info.yaml
+- docs/index.md
 - lib/simplycop.rb
 - lib/simplycop/custom_cops/constantize.rb
 - lib/simplycop/custom_cops/define_method.rb
@@ -134,6 +136,7 @@ files:
 - lib/simplycop/security/csrf_token_validation.rb
 - lib/simplycop/security/reject_all_requests_local.rb
 - lib/simplycop/version.rb
+- mkdocs.yml
 - simplycop.gemspec
 - vuln_db.json
 homepage: https://github.com/simplybusiness/simplycop
@@ -155,7 +158,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.15
+rubygems_version: 3.2.22
 signing_key: 
 specification_version: 4
 summary: Provides a single point of reference for common rubocop rules.