simplycop 1.6.2 → 1.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7d9ba2021e0c37a5b4c42e33e5d6918be07ce760d4a21772c74b7ba7cac7f3d9
-  data.tar.gz: f8d81599f5e25b49dfa4f8d383491601112968dc3dd32476e902448279676fda
+  metadata.gz: 50a0298e4fe2fea10475eb542f24df49cc548add3299ce646df95daca8ac8194
+  data.tar.gz: f7bc5d42576f976f5be0b7d28920861d38553dcc907a41a8d7044df941771661
 SHA512:
-  metadata.gz: 89d7da8eeb61c1b30b27831982dfe7c1dea706f3be27c53276c85662d4c5476c17f6c557d39bba6fe3a9f1492b9e2b8e532765abb19443b765737bcb9d5f4e41
-  data.tar.gz: e8a590e84aeb593730f14d6e88a4fa04bf36f804bd583876d741ee4c6ed920246a22dcad7265a3b0a551e3859203859ad405165507a9f6f0fc0603f12c79f9e0
+  metadata.gz: 88236123a372bef498fc28c6b897b5017fdd4492b05c9fb575720721d9174a6b74828a4ae06be57a4dc3082be26eb15f60d3f850ac581a3beb0c55b40a55c883
+  data.tar.gz: 94ad143b7fa0971802e735be97f98ba6ee2826c2c846bdad91a646f50277a070201a756a5ed70b0a57530c6c9d4ce807bf61c6c8c979e089b00d984bf85ab0bd

data/.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        ruby-version: [2.6.5, 2.7, 3.0]
+        ruby-version: [2.5, 2.6.5, 2.7, 3.0, jruby]
 
     steps:
     - uses: actions/checkout@v2

data/.github/workflows/dobby-actions.yml

@@ -9,7 +9,8 @@ jobs:
 
     steps:
       - name: 'bump version'
-        uses: simplybusiness/dobby@v1.0.0
+        uses: simplybusiness/dobby@v2.1.0
         env:
-          ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          VERSION_FILE_PATH: "lib/simplycop/version.rb"
+          DOBBY_APP_ID: ${{ secrets.DOBBY_APP_ID }}
+          DOBBY_PRIVATE_KEY: ${{ secrets.DOBBY_PRIVATE_KEY }}
+          VERSION_FILE_PATH: lib/simplycop/version.rb

data/.simplycop.yml

@@ -4,6 +4,7 @@ inherit_from:
   - .simplycop_metaprogramming.yml
 
 AllCops:
+  TargetRubyVersion: 2.5
   Exclude:
     - 'db/schema.rb'
     - 'vendor/**/*'
@@ -21,6 +22,9 @@ AllCops:
   ExtraDetails: true
 # Adapted from: https://github.com/simplybusiness/how-we-roll/blob/master/development/RUBYSTYLEGUIDE.markdown
 
+Gemspec/DateAssignment:
+  Enabled: true
+
 Layout/EmptyLineAfterMultilineCondition:
   Enabled: true
 
@@ -94,28 +98,14 @@ Lint/UnexpectedBlockArity:
 Lint/UnmodifiedReduceAccumulator:
   Enabled: true
 
-###### COPS REVIEWED ABOVE THIS LINE ######
-
 Metrics/BlockLength:
   Exclude:
     - spec/**/*.rb
-    -
+
 Metrics/ClassLength:
   Max: 512
-  Enabled: true
-
-Metrics/ModuleLength:
-  Enabled: true
 
-Naming/FileName:
-  Enabled: true
-
-Naming/VariableName:
-  Enabled: true
-  EnforcedStyle: snake_case
-  SupportedStyles:
-    - snake_case
-    - camelCase
+###### COPS REVIEWED ABOVE THIS LINE ######
 
 Style/AccessorGrouping:
   Enabled: true
@@ -184,6 +174,9 @@ Style/GuardClause:
 Style/HashAsLastArrayItem:
   Enabled: true
 
+Style/HashConversion:
+  Enabled: true
+
 Style/HashEachMethods:
   Enabled: false
 
@@ -300,6 +293,9 @@ Style/SpecialGlobalVars:
   Enabled: true
   Severity: warning
 
+Style/StringChars:
+  Enabled: true
+
 Style/StringConcatenation:
   Enabled: true
 

data/catalog-info.yaml

@@ -0,0 +1,17 @@
+apiVersion: backstage.io/v1alpha1
+kind: Component
+metadata:
+  name: simplycop
+  description: Simply Business Rubocop rules
+  annotations:
+    github.com/project-slug: "simplybusiness/simplycop"
+    backstage.io/source-location: url:https://github.com/simplybusiness/simplycop/
+    backstage.io/techdocs-ref: url:https://github.com/simplybusiness/simplycop/
+spec:
+  type: library
+  lifecycle: production
+  owner: silversmiths
+  dependsOn:
+    - "Component:rake"
+    - "Component:rspec"
+    - "Component:rubocop"

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.6.2'
+  VERSION = '1.7.2'
 end

data/simplycop.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.version       = Simplycop::VERSION
   spec.authors       = ['Simply Business']
   spec.email         = ['tech@simplybusiness.co.uk']
-  spec.required_ruby_version = '>= 2.6.0'
+  spec.required_ruby_version = '>= 2.5'
   spec.license       = 'MIT'
   spec.summary       = 'Provides a single point of reference for common rubocop rules.'
   spec.description   = 'Require this gem in your application to use Simply Business common rubocop rules.'
@@ -17,9 +17,9 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 1.9.1'
+  spec.add_dependency 'rubocop', '~> 1.12.1'
   spec.add_dependency 'rubocop-rails', '~> 2.9.0'
-  spec.add_dependency 'rubocop-rspec', '~> 2.1.0'
+  spec.add_dependency 'rubocop-rspec', '~> 2.2.0'
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.10'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.6.2
+  version: 1.7.2
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-10 00:00:00.000000000 Z
+date: 2021-07-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.9.1
+        version: 1.12.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.9.1
+        version: 1.12.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: 2.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: 2.2.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -123,6 +123,7 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
+- catalog-info.yaml
 - lib/simplycop.rb
 - lib/simplycop/custom_cops/constantize.rb
 - lib/simplycop/custom_cops/define_method.rb
@@ -148,14 +149,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.6.0
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.2.15
 signing_key: 
 specification_version: 4
 summary: Provides a single point of reference for common rubocop rules.