simplycop 1.6.1 → 1.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe3df1f4bca5ed0a637df22a031215a0dfd5c28de1ad9bc7f08cfac64ee9138a
-  data.tar.gz: b5a24c2578b8292bbeb4d582715fac8e81ec004681035402de893c50e81c359e
+  metadata.gz: 1c5e5d71fa2887210ca724ca027750a4d4394d1b3534c5788c80c60b84962bde
+  data.tar.gz: 508cdb5d80beb6e5c0165684ea41ae2e48b9f0754c00f7177d12c33c1e97ae11
 SHA512:
-  metadata.gz: a9d0645cbe9e75f438ad37bd75d9feb82021fd4e3eb4a892e4d20abfbc9a73d737db6416f3e149fedfe1dad45e572f8fc6450fc8576890b60b2ddc5068376e17
-  data.tar.gz: a3033de1e1eb0b2ec11b7cc5ceac52f4210c11523e51714814ee147a43febd716ec2ca18876a9e9fb62c52af6bdf2abcba93db766487ec72c07e0b2544ecb87d
+  metadata.gz: 25ac6ea607cc4815efcbe24d2ffa93e9766eb72863845b4cc08720fc7092da563a902af21b21e73599b0e512901c35c68e94f6096b167c7ef61ba350e2bf140f
+  data.tar.gz: b48e756765a1fa0b9a19a0232cadf9b17d4335de756f1164ad6ecc22f2a87c6922dbb70c5f6e419f17eb48845d56bccc8396ce7f4e20755ea358538e6258ac62

data/.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        ruby-version: [2.6.5, 2.7, 3.0]
+        ruby-version: [2.5, 2.6.5, 2.7, 3.0, jruby]
 
     steps:
     - uses: actions/checkout@v2

data/.github/workflows/dobby-actions.yml

@@ -0,0 +1,16 @@
+name: "dobby actions"
+on:
+  issue_comment:
+    types: [created]
+jobs:
+  pr_commented:
+    runs-on: ubuntu-20.04
+    if: startsWith(github.event.comment.body, '/dobby')
+
+    steps:
+      - name: 'bump version'
+        uses: simplybusiness/dobby@v2.1.0
+        env:
+          DOBBY_APP_ID: ${{ secrets.DOBBY_APP_ID }}
+          DOBBY_PRIVATE_KEY: ${{ secrets.DOBBY_PRIVATE_KEY }}
+          VERSION_FILE_PATH: lib/simplycop/version.rb

data/.simplycop.yml

@@ -4,6 +4,7 @@ inherit_from:
   - .simplycop_metaprogramming.yml
 
 AllCops:
+  TargetRubyVersion: 2.5
   Exclude:
     - 'db/schema.rb'
     - 'vendor/**/*'
@@ -21,6 +22,9 @@ AllCops:
   ExtraDetails: true
 # Adapted from: https://github.com/simplybusiness/how-we-roll/blob/master/development/RUBYSTYLEGUIDE.markdown
 
+Gemspec/DateAssignment:
+  Enabled: true
+
 Layout/EmptyLineAfterMultilineCondition:
   Enabled: true
 
@@ -94,28 +98,14 @@ Lint/UnexpectedBlockArity:
 Lint/UnmodifiedReduceAccumulator:
   Enabled: true
 
-###### COPS REVIEWED ABOVE THIS LINE ######
-
 Metrics/BlockLength:
   Exclude:
     - spec/**/*.rb
-    -
+
 Metrics/ClassLength:
   Max: 512
-  Enabled: true
-
-Metrics/ModuleLength:
-  Enabled: true
 
-Naming/FileName:
-  Enabled: true
-
-Naming/VariableName:
-  Enabled: true
-  EnforcedStyle: snake_case
-  SupportedStyles:
-    - snake_case
-    - camelCase
+###### COPS REVIEWED ABOVE THIS LINE ######
 
 Style/AccessorGrouping:
   Enabled: true
@@ -184,6 +174,9 @@ Style/GuardClause:
 Style/HashAsLastArrayItem:
   Enabled: true
 
+Style/HashConversion:
+  Enabled: true
+
 Style/HashEachMethods:
   Enabled: false
 
@@ -300,6 +293,9 @@ Style/SpecialGlobalVars:
   Enabled: true
   Severity: warning
 
+Style/StringChars:
+  Enabled: true
+
 Style/StringConcatenation:
   Enabled: true
 

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.6.1'
+  VERSION = '1.7.1'
 end

data/simplycop.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.version       = Simplycop::VERSION
   spec.authors       = ['Simply Business']
   spec.email         = ['tech@simplybusiness.co.uk']
-  spec.required_ruby_version = '>= 2.6.0'
+  spec.required_ruby_version = '>= 2.5'
   spec.license       = 'MIT'
   spec.summary       = 'Provides a single point of reference for common rubocop rules.'
   spec.description   = 'Require this gem in your application to use Simply Business common rubocop rules.'
@@ -17,9 +17,9 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 1.9.1'
+  spec.add_dependency 'rubocop', '~> 1.12.1'
   spec.add_dependency 'rubocop-rails', '~> 2.9.0'
-  spec.add_dependency 'rubocop-rspec', '~> 2.1.0'
+  spec.add_dependency 'rubocop-rspec', '~> 2.2.0'
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.10'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.6.1
+  version: 1.7.1
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-08 00:00:00.000000000 Z
+date: 2021-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.9.1
+        version: 1.12.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.9.1
+        version: 1.12.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: 2.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: 2.2.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -105,6 +105,7 @@ files:
 - ".custom_simplycop.yml"
 - ".github/dependabot.yml"
 - ".github/workflows/ci.yml"
+- ".github/workflows/dobby-actions.yml"
 - ".github/workflows/publish_gem.yml"
 - ".github/workflows/version_forget_me_not.yml"
 - ".gitignore"
@@ -147,14 +148,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.6.0
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.2.15
 signing_key: 
 specification_version: 4
 summary: Provides a single point of reference for common rubocop rules.