simplycop 1.5.0 → 1.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 076036bcf8a50fab9721ef1a9bc81c58c1b37be20b72b6882fbbcd55505f7071
-  data.tar.gz: f246b21e0afd394b49dbafd4445c90734f6232488d7d1578a4e3b118dff9ef53
+  metadata.gz: 92bb33b36ef3075fabd5fb751db5db4ee51600adbdc590b8087ee3caa7096067
+  data.tar.gz: 9ef66e1eee9f894ca08f5842e057d499c3a876ba4771df484034fc47ef33b886
 SHA512:
-  metadata.gz: a19db9f0d33d7b4a376c3e54d3d08f58dad4c891f1349f5c4edb26e04e16b8b21aadf766fcaaef28d16fb113959d755676fa4e5b3fa7d04dc631b99cfffcb02c
-  data.tar.gz: 723b0bb560e8fb0a229b131abba0ee984bb84f6aeb21500fa3dc9d7d25157a0d457f430ada57a8c3737d24218e95e3873efc317a0140da62624aac2cc295fa6f
+  metadata.gz: e85123bfa60e0fde3362574a9340ac24a1a47deda3285604946f0719b169f286c7076a6097388caea6ea1e8eb0c3e8cd140019d17e3c2440ebae6566b9165987
+  data.tar.gz: 2da2ab60e881de80ae5e4b94c440ad5b794ae4be62307a0b6f8064707f310ce91ec3006ae767bc7db8cf70706d863ac16adae0c624ea2999b4a347076399358f

data/.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        ruby-version: [2.6.5, 2.7]
+        ruby-version: [2.5, 2.6.5, 2.7, 3.0, jruby]
 
     steps:
     - uses: actions/checkout@v2

data/.github/workflows/dobby-actions.yml

@@ -0,0 +1,16 @@
+name: "dobby actions"
+on:
+  issue_comment:
+    types: [created]
+jobs:
+  pr_commented:
+    runs-on: ubuntu-20.04
+    if: startsWith(github.event.comment.body, '/dobby')
+
+    steps:
+      - name: 'bump version'
+        uses: simplybusiness/dobby@v2.0.0
+        env:
+          DOBBY_APP_ID: ${{ secrets.DOBBY_APP_ID }}
+          DOBBY_PRIVATE_KEY: ${{ secrets.DOBBY_PRIVATE_KEY }}
+          VERSION_FILE_PATH: lib/simplycop/version.rb

data/.simplycop.yml

@@ -4,6 +4,7 @@ inherit_from:
   - .simplycop_metaprogramming.yml
 
 AllCops:
+  TargetRubyVersion: 2.5
   Exclude:
     - 'db/schema.rb'
     - 'vendor/**/*'
@@ -39,8 +40,6 @@ Layout/HeredocArgumentClosingParenthesis:
 Layout/SpaceBeforeBrackets:
   Enabled: true
 
-###### COPS REVIEWED ABOVE THIS LINE ######
-
 Lint/AmbiguousAssignment:
   Enabled: true
 
@@ -48,146 +47,55 @@ Lint/AmbiguousBlockAssociation:
   Exclude:
     - spec/**/*
 
-Lint/AmbiguousOperator:
-  Enabled: true
-
-Lint/AmbiguousRegexpLiteral:
-  Enabled: true
-
-Lint/BinaryOperatorWithIdenticalOperands:
-  Enabled: true
-
-Lint/CircularArgumentReference:
-  Enabled: true
-
-Lint/ConstantDefinitionInBlock:
-  Enabled: true
-  Exclude:
-    - spec/**/*.rb
-
-Lint/DeprecatedClassMethods:
-  Enabled: true
-
 Lint/DeprecatedConstants:
   Enabled: true
 
-Lint/DeprecatedOpenSSLConstant:
-  Enabled: true
-
 Lint/DuplicateBranch:
   Enabled: true
 
-Lint/DuplicateElsifCondition:
-  Enabled: true
-
-Lint/DuplicateHashKey:
-  Enabled: false
-
-Lint/DuplicateMethods:
-  Enabled: true
-  Severity: warning
-
 Lint/DuplicateRegexpCharacterClassElement:
   Enabled: true
 
-Lint/DuplicateRequire:
-  Enabled: true
-
-Lint/DuplicateRescueException:
-  Enabled: true
-
 Lint/EmptyBlock:
   Enabled: true
 
 Lint/EmptyClass:
   Enabled: true
 
-Lint/EmptyConditionalBody:
-  Enabled: true
-
-Lint/EmptyFile:
-  Enabled: true
-
-Lint/FloatComparison:
-  Enabled: true
-
-Lint/IdentityComparison:
-  Enabled: true
-
-Lint/ImplicitStringConcatenation:
+Lint/HeredocMethodCallPosition:
   Enabled: true
 
-Lint/IneffectiveAccessModifier:
-  Enabled: false
-
 Lint/LambdaWithoutLiteralBlock:
   Enabled: true
 
-Lint/MissingSuper:
-  Enabled: false
-
-Lint/MixedRegexpCaptureTypes:
-  Enabled: true
-
 Lint/NoReturnInBeginEndBlocks:
   Enabled: true
 
-Lint/OutOfRangeRegexpRef:
+Lint/NumberedParameterAssignment:
   Enabled: true
 
-Lint/RaiseException:
+Lint/OrAssignmentToConstant:
   Enabled: true
 
 Lint/RedundantDirGlobSort:
   Enabled: true
 
-Lint/SelfAssignment:
-  Enabled: true
-
-Lint/StructNewOverride:
+Lint/SymbolConversion:
   Enabled: true
 
 Lint/ToEnumArguments:
   Enabled: true
 
-Lint/TopLevelReturnWithArgument:
-  Enabled: true
-
-Lint/TrailingCommaInAttributeDeclaration:
+Lint/TripleQuotes:
   Enabled: true
 
-Lint/UnderscorePrefixedVariableName:
-  Enabled: true
-  Severity: warning
-
 Lint/UnexpectedBlockArity:
   Enabled: true
 
 Lint/UnmodifiedReduceAccumulator:
   Enabled: true
 
-Lint/UnreachableLoop:
-  Enabled: true
-
-Lint/UnusedBlockArgument:
-  Enabled: true
-  Severity: warning
-
-Lint/UselessAccessModifier:
-  Enabled: false
-
-Lint/UselessAssignment:
-  Enabled: true
-  Severity: warning
-
-Lint/UselessMethodDefinition:
-  Enabled: true
-
-Lint/UselessTimes:
-  Enabled: true
-
-Lint/Void:
-  Enabled: true
+###### COPS REVIEWED ABOVE THIS LINE ######
 
 Metrics/BlockLength:
   Exclude:
@@ -295,6 +203,9 @@ Style/HashTransformValues:
 Style/IfInsideElse:
   Enabled: true
 
+Style/IfWithBooleanLiteralBranches:
+  Enabled: true
+
 Style/KeywordParametersOrder:
   Enabled: true
 

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.5.0'
+  VERSION = '1.6.4'
 end

data/simplycop.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.version       = Simplycop::VERSION
   spec.authors       = ['Simply Business']
   spec.email         = ['tech@simplybusiness.co.uk']
-  spec.required_ruby_version = '>= 2.6.0'
+  spec.required_ruby_version = '>= 2.5'
   spec.license       = 'MIT'
   spec.summary       = 'Provides a single point of reference for common rubocop rules.'
   spec.description   = 'Require this gem in your application to use Simply Business common rubocop rules.'
@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 1.8.1'
+  spec.add_dependency 'rubocop', '~> 1.9.1'
   spec.add_dependency 'rubocop-rails', '~> 2.9.0'
   spec.add_dependency 'rubocop-rspec', '~> 2.1.0'
   spec.add_development_dependency 'bundler'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.6.4
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-28 00:00:00.000000000 Z
+date: 2021-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 1.9.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 1.9.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -105,6 +105,7 @@ files:
 - ".custom_simplycop.yml"
 - ".github/dependabot.yml"
 - ".github/workflows/ci.yml"
+- ".github/workflows/dobby-actions.yml"
 - ".github/workflows/publish_gem.yml"
 - ".github/workflows/version_forget_me_not.yml"
 - ".gitignore"
@@ -147,7 +148,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.6.0
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="