simplycop 1.4.2 → 1.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 88f566a01241a5651bbeee6ab969274e2aaddc7ae5d202a5178e69ddfb777442
-  data.tar.gz: 6d0ae21a2f04e4a78e3abb43ae04fca74109fb84732a67d918d5c511e2465f78
+  metadata.gz: 75d616c33d97fb61c1d48c68af3f054a3a108c96ebcd8ccb9248c77cc1cd432b
+  data.tar.gz: 3044018959ad5d784e29e61cca3843fdb85f1bf972f85ec914e8d0bc652b91ee
 SHA512:
-  metadata.gz: a0c1d3b1ab76fedf742d219b0b8c8c19380634ae2e5b0886ffbe41709e0b6a64184e4f87efae1c20fafacfe3b5b2916574b1bcddca7d47ca7c206093ffa2f5f0
-  data.tar.gz: b64adedc727cfa74c539e8e221016764e89f8ea158fbfa910be89acc4d5fc39d70091e54ac4724612d4018e74a6f52fc2678927876e901e3430696405aa29f03
+  metadata.gz: db4a316359a59a88d10f18af824729a2952effb04916afba0bb4d1de285d88c27de7077eb50b64dced5ad9688a474d95bf580e11a8cd22414bee23f9fc2a562a
+  data.tar.gz: 9bf81c0df533b7cbc8b3e550ecb2306d8d06f611d693181d8f50c9cff68256f39899940ab0f351cc6a21cc74acacab804bfda5a8f8b0fabfd54fe583b4dc5849

data/.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        ruby-version: [2.6.5, 2.7]
+        ruby-version: [2.6.5, 2.7, 3.0]
 
     steps:
     - uses: actions/checkout@v2

data/.github/workflows/dobby-actions.yml

@@ -0,0 +1,16 @@
+name: "dobby actions"
+on:
+  issue_comment:
+    types: [created]
+jobs:
+  pr_commented:
+    runs-on: ubuntu-20.04
+    if: startsWith(github.event.comment.body, '/dobby')
+
+    steps:
+      - name: 'bump version'
+        uses: simplybusiness/dobby@v2.0.0
+        env:
+          DOBBY_APP_ID: ${{ secrets.DOBBY_APP_ID }}
+          DOBBY_PRIVATE_KEY: ${{ secrets.DOBBY_PRIVATE_KEY }}
+          VERSION_FILE_PATH: lib/simplycop/version.rb

data/.simplycop.yml

@@ -21,438 +21,302 @@ AllCops:
   ExtraDetails: true
 # Adapted from: https://github.com/simplybusiness/how-we-roll/blob/master/development/RUBYSTYLEGUIDE.markdown
 
-Naming/VariableName:
+Layout/EmptyLineAfterMultilineCondition:
   Enabled: true
-  EnforcedStyle: snake_case
-  SupportedStyles:
-    - snake_case
-    - camelCase
 
-Naming/FileName:
-  Enabled: true
-
-Layout/TrailingEmptyLines:
+Layout/FirstArrayElementLineBreak:
   Enabled: true
-  Severity: warning
 
-Layout/TrailingWhitespace:
+Layout/FirstMethodArgumentLineBreak:
   Enabled: true
-  Severity: warning
 
-Lint/DuplicateMethods:
+Layout/FirstHashElementLineBreak:
   Enabled: true
-  Severity: warning
 
-Style/SpecialGlobalVars:
+Layout/HeredocArgumentClosingParenthesis:
   Enabled: true
-  Severity: warning
 
-Style/ColonMethodCall:
+Layout/SpaceBeforeBrackets:
   Enabled: true
-  Severity: warning
 
-Style/RedundantReturn:
+Lint/AmbiguousAssignment:
   Enabled: true
-  Severity: warning
 
-Style/NestedParenthesizedCalls:
-  Enabled: true
-
-Layout/MultilineMethodCallIndentation:
-  Enabled: true
-
-Style/RedundantParentheses:
-  Enabled: true
-
-Style/RedundantInterpolation:
-  Enabled: false
+Lint/AmbiguousBlockAssociation:
+  Exclude:
+    - spec/**/*
 
-Layout/AssignmentIndentation:
+Lint/DeprecatedConstants:
   Enabled: true
 
-Style/MutableConstant:
-  Enabled: false
-
-Style/ZeroLengthPredicate:
-  Enabled: true
-
-Style/ConditionalAssignment:
+Lint/DuplicateBranch:
   Enabled: true
 
-Style/NestedModifier:
+Lint/DuplicateRegexpCharacterClassElement:
   Enabled: true
 
-Style/IfInsideElse:
+Lint/EmptyBlock:
   Enabled: true
 
-Lint/IneffectiveAccessModifier:
-  Enabled: false
-
-Lint/ImplicitStringConcatenation:
+Lint/EmptyClass:
   Enabled: true
 
-Lint/UselessAssignment:
+Lint/HeredocMethodCallPosition:
   Enabled: true
-  Severity: warning
 
-Lint/UnusedBlockArgument:
+Lint/LambdaWithoutLiteralBlock:
   Enabled: true
-  Severity: warning
 
-Lint/UnderscorePrefixedVariableName:
+Lint/NoReturnInBeginEndBlocks:
   Enabled: true
-  Severity: warning
-
-Style/Documentation:
-  Enabled: false
 
-Layout/SpaceInsideBlockBraces:
-  Enabled: false
-
-Layout/SpaceInsideArrayLiteralBrackets:
+Lint/NumberedParameterAssignment:
   Enabled: true
 
-Layout/SpaceInsideReferenceBrackets:
+Lint/OrAssignmentToConstant:
   Enabled: true
 
-Layout/SpaceInsideHashLiteralBraces:
-  Enabled: false
-
-Layout/SpaceInsideParens:
+Lint/RedundantDirGlobSort:
   Enabled: true
 
-Layout/SpaceBeforeComma:
+Lint/SymbolConversion:
   Enabled: true
 
-Layout/IndentationConsistency:
+Lint/ToEnumArguments:
   Enabled: true
 
-Layout/CaseIndentation:
+Lint/TripleQuotes:
   Enabled: true
 
-Style/MethodDefParentheses:
+Lint/UnexpectedBlockArity:
   Enabled: true
 
-Style/MultilineTernaryOperator:
+Lint/UnmodifiedReduceAccumulator:
   Enabled: true
 
-Style/NestedTernaryOperator:
-  Enabled: true
+###### COPS REVIEWED ABOVE THIS LINE ######
 
-Style/UnlessElse:
+Metrics/BlockLength:
+  Exclude:
+    - spec/**/*.rb
+    -
+Metrics/ClassLength:
+  Max: 512
   Enabled: true
 
-Style/SymbolArray:
-  EnforcedStyle: brackets
-
-Style/WordArray:
-  EnforcedStyle: brackets
-
-Style/ParenthesesAroundCondition:
+Metrics/ModuleLength:
   Enabled: true
 
-Layout/MultilineBlockLayout:
+Naming/FileName:
   Enabled: true
 
-Layout/InitialIndentation:
+Naming/VariableName:
   Enabled: true
+  EnforcedStyle: snake_case
+  SupportedStyles:
+    - snake_case
+    - camelCase
 
-Style/OptionalArguments:
+Style/AccessorGrouping:
   Enabled: true
 
-Lint/DuplicateHashKey:
+Style/Alias:
   Enabled: false
 
-Lint/CircularArgumentReference:
+Style/ArgumentsForwarding:
   Enabled: true
 
-Lint/AmbiguousOperator:
+Style/ArrayCoercion:
   Enabled: true
 
-Lint/AmbiguousRegexpLiteral:
+Style/BisectedAttrAccessor:
   Enabled: true
 
-Layout/BlockAlignment:
+Style/CaseLikeIf:
   Enabled: true
 
-Layout/DefEndAlignment:
+Style/CollectionCompact:
   Enabled: true
 
-Lint/DeprecatedClassMethods:
+Style/ColonMethodCall:
   Enabled: true
+  Severity: warning
 
-Layout/EndAlignment:
+Style/CombinableLoops:
   Enabled: true
 
-Lint/UselessAccessModifier:
-  Enabled: false
-
-Lint/Void:
+Style/ConditionalAssignment:
   Enabled: true
 
-Style/Alias:
+Style/DocumentDynamicEvalDefinition:
   Enabled: false
 
-Layout/SpaceAroundBlockParameters:
-  Enabled: true
-
-Layout/SpaceAroundEqualsInParameterDefault:
-  Enabled: true
-
-Style/RedundantBegin:
-  Enabled: true
-
-Style/RedundantException:
-  Enabled: true
-
-Layout/EmptyLines:
-  Enabled: true
-
-Style/SelfAssignment:
-  Enabled: true
+Style/Documentation:
+  Enabled: false
 
-Style/LambdaCall:
+Style/EndlessMethod:
   Enabled: true
 
-Metrics/ModuleLength:
+Style/ExplicitBlockArgument:
   Enabled: true
 
-Metrics/BlockLength:
-  Exclude:
-    - spec/**/*.rb
+Style/ExponentialNotation:
+  Enabled: false
 
 Style/For:
   Enabled: true
 
-Layout/ExtraSpacing:
+Style/FormatString:
   Enabled: false
 
-Style/GuardClause:
+Style/FormatStringToken:
   Enabled: false
 
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-Style/StringLiterals:
-  Enabled: false
-
-Metrics/ClassLength:
-  Max: 512
+Style/GlobalStdStream:
   Enabled: true
 
-Layout/LineLength:
-  Enabled: true
-  Max: 120
+Style/GuardClause:
+  Enabled: false
 
-Layout/ArgumentAlignment:
+Style/HashAsLastArrayItem:
   Enabled: true
 
 Style/HashEachMethods:
   Enabled: false
 
-Style/HashTransformKeys:
-  Enabled: true
-
-Style/HashTransformValues:
+Style/HashExcept:
   Enabled: true
 
-Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: true
-
-Layout/SpaceAroundMethodCallOperator:
-  Enabled: true
-
-Lint/DeprecatedOpenSSLConstant:
-  Enabled: true
-
-Lint/DuplicateElsifCondition:
-  Enabled: true
+Style/HashLikeCase:
+  Enabled: false
 
-Lint/MixedRegexpCaptureTypes:
+Style/HashTransformKeys:
   Enabled: true
 
-Lint/RaiseException:
+Style/HashTransformValues:
   Enabled: true
 
-Lint/StructNewOverride:
+Style/IfInsideElse:
   Enabled: true
 
-Style/AccessorGrouping:
+Style/IfWithBooleanLiteralBranches:
   Enabled: true
 
-Style/ArrayCoercion:
+Style/KeywordParametersOrder:
   Enabled: true
 
-Style/BisectedAttrAccessor:
+Style/LambdaCall:
   Enabled: true
 
-Style/CaseLikeIf:
+Style/MethodDefParentheses:
   Enabled: true
 
-Style/ExponentialNotation:
-  Enabled: false
-
-Style/HashAsLastArrayItem:
+Style/MultilineTernaryOperator:
   Enabled: true
 
-Style/HashLikeCase:
+Style/MutableConstant:
   Enabled: false
 
-Style/RedundantAssignment:
+Style/NegatedIfElseCondition:
   Enabled: true
 
-Style/RedundantFetchBlock:
+Style/NestedModifier:
   Enabled: true
 
-Style/RedundantFileExtensionInRequire:
+Style/NestedParenthesizedCalls:
   Enabled: true
 
-Style/RedundantRegexpCharacterClass:
+Style/NestedTernaryOperator:
   Enabled: true
 
-Style/RedundantRegexpEscape:
+Style/NilLambda:
   Enabled: true
 
-Style/SlicingWithRange:
+Style/NumericPredicate:
   Enabled: false
 
-Layout/BeginEndAlignment:
+Style/OptionalArguments:
   Enabled: true
 
-Lint/BinaryOperatorWithIdenticalOperands:
+Style/OptionalBooleanParameter:
   Enabled: true
 
-Lint/ConstantDefinitionInBlock:
+Style/ParenthesesAroundCondition:
   Enabled: true
-  Exclude:
-    - spec/**/*.rb
 
-Lint/DuplicateRequire:
+Style/RedundantArgument:
   Enabled: true
 
-Lint/DuplicateRescueException:
+Style/RedundantAssignment:
   Enabled: true
 
-Lint/EmptyConditionalBody:
+Style/RedundantBegin:
   Enabled: true
 
-Lint/EmptyFile:
+Style/RedundantException:
   Enabled: true
 
-Lint/FloatComparison:
+Style/RedundantFetchBlock:
   Enabled: true
 
-Lint/IdentityComparison:
+Style/RedundantFileExtensionInRequire:
   Enabled: true
 
-Lint/MissingSuper:
+Style/RedundantInterpolation:
   Enabled: false
 
-Lint/OutOfRangeRegexpRef:
-  Enabled: true
-
-Lint/SelfAssignment:
-  Enabled: true
-
-Lint/TopLevelReturnWithArgument:
-  Enabled: true
-
-Lint/TrailingCommaInAttributeDeclaration:
-  Enabled: true
-
-Lint/UnreachableLoop:
-  Enabled: true
-
-Lint/UselessMethodDefinition:
-  Enabled: true
-
-Lint/UselessTimes:
-  Enabled: true
-
-Style/CombinableLoops:
-  Enabled: true
-
-Style/ExplicitBlockArgument:
+Style/RedundantParentheses:
   Enabled: true
 
-Style/GlobalStdStream:
+Style/RedundantRegexpCharacterClass:
   Enabled: true
 
-Style/KeywordParametersOrder:
+Style/RedundantRegexpEscape:
   Enabled: true
 
-Style/OptionalBooleanParameter:
+Style/RedundantReturn:
   Enabled: true
+  Severity: warning
 
 Style/RedundantSelfAssignment:
   Enabled: true
 
-Style/SingleArgumentDig:
-  Enabled: true
-
-Style/SoleNestedConditional:
-  Enabled: true
-
-Style/StringConcatenation:
+Style/SelfAssignment:
   Enabled: true
 
-Lint/DuplicateRegexpCharacterClassElement:
+Style/SingleArgumentDig:
   Enabled: true
 
-Lint/EmptyBlock:
-  Enabled: true
+Style/SlicingWithRange:
+  Enabled: false
 
-Lint/ToEnumArguments:
+Style/SoleNestedConditional:
   Enabled: true
 
-Lint/UnmodifiedReduceAccumulator:
+Style/SpecialGlobalVars:
   Enabled: true
+  Severity: warning
 
-Style/ArgumentsForwarding:
+Style/StringConcatenation:
   Enabled: true
 
-Style/DocumentDynamicEvalDefinition:
+Style/StringLiterals:
   Enabled: false
 
 Style/SwapValues:
   Enabled: true
 
-Lint/AmbiguousBlockAssociation:
-  Exclude:
-    - spec/**/*
-
-Layout/FirstHashElementIndentation:
-  EnforcedStyle: consistent
-
-Style/FormatString:
-  Enabled: false
-
-Style/FormatStringToken:
-  Enabled: false
-
-Style/NumericPredicate:
-  Enabled: false
-
-Lint/NoReturnInBeginEndBlocks:
-  Enabled: true
-
-Style/CollectionCompact:
-  Enabled: true
-
-Style/NegatedIfElseCondition:
-  Enabled: true
-
-Lint/DuplicateBranch:
-  Enabled: true
+Style/SymbolArray:
+  EnforcedStyle: brackets
 
-Lint/EmptyClass:
-  Enabled: true
-  
-Style/NilLambda:
+Style/UnlessElse:
   Enabled: true
 
-Lint/UnexpectedBlockArity:
-  Enabled: true
+Style/WordArray:
+  EnforcedStyle: brackets
 
-Style/RedundantArgument:
+Style/ZeroLengthPredicate:
   Enabled: true

data/.simplycop_metaprogramming.yml

@@ -1,6 +1,3 @@
-AllCops:
-  ExtraDetails: true
-
 require:
   - './lib/simplycop/custom_cops/constantize.rb'
   - './lib/simplycop/custom_cops/define_method.rb'

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.4.2'
+  VERSION = '1.6.3'
 end

data/simplycop.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 1.6.1'
+  spec.add_dependency 'rubocop', '~> 1.9.1'
   spec.add_dependency 'rubocop-rails', '~> 2.9.0'
   spec.add_dependency 'rubocop-rspec', '~> 2.1.0'
   spec.add_development_dependency 'bundler'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.4.2
+  version: 1.6.3
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-27 00:00:00.000000000 Z
+date: 2021-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.1
+        version: 1.9.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.1
+        version: 1.9.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -105,6 +105,7 @@ files:
 - ".custom_simplycop.yml"
 - ".github/dependabot.yml"
 - ".github/workflows/ci.yml"
+- ".github/workflows/dobby-actions.yml"
 - ".github/workflows/publish_gem.yml"
 - ".github/workflows/version_forget_me_not.yml"
 - ".gitignore"
@@ -154,7 +155,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.3
 signing_key: 
 specification_version: 4
 summary: Provides a single point of reference for common rubocop rules.