simplycop 1.3.0 → 1.6.0

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 266e346cb15a66ac2a156e5aa7f9baa95db52601c74759ebf8de088e65d5555a
4
- data.tar.gz: 4c59e192a0733f3311c104868ab9b70a746310c58b1f58515334e9b366127d6a
3
+ metadata.gz: 22367bc02ae870de21a70f32d9b036317dfd0069e735699f7395cad4eb4d6492
4
+ data.tar.gz: 18c794e70eed8134e76888835b9e0421d08381c20aa9689a70bba1447406ffb3
5
5
  SHA512:
6
- metadata.gz: e5c2b709e412069b735d778df516789fce3253a6aa8fc6e691f412639d7b8cde5adaf36ca09a62bb82b326e44480d98358b4c4480d707bda8e4f12c2a1a3269b
7
- data.tar.gz: 8da07133883fda0eefcd34f750dacc2f0d43e3480ddb719a32d943de61ec089b91641c28935ccf3fc498ecc79cbe962c2f88fbc4210b3afc91d62f363e9ee539
6
+ metadata.gz: 178543057d26ba7a9c45dbdba4db0fb5ec4eda788aa7aefc9e699f60d6835ef2943193bde45db66d88c4b4e72b3d7ff434ed8414725444dd7fa99222284f4648
7
+ data.tar.gz: cb04137623d750344484aa83277ff826ec20c4e5d66f08e91b2af45857739dd3416823aafca8c5993525a4a38892c989e404d8f0180fc1ba03357daeaf1acacc
@@ -0,0 +1,18 @@
1
+ version: 2
2
+ updates:
3
+ - package-ecosystem: bundler
4
+ directory: "/"
5
+ schedule:
6
+ interval: daily
7
+ time: "05:00"
8
+ open-pull-requests-limit: 99
9
+ labels:
10
+ - dependencies
11
+ - package-ecosystem: github-actions
12
+ directory: "/"
13
+ schedule:
14
+ interval: daily
15
+ time: "05:00"
16
+ open-pull-requests-limit: 99
17
+ labels:
18
+ - dependencies
@@ -11,7 +11,7 @@ jobs:
11
11
  runs-on: ubuntu-18.04
12
12
 
13
13
  steps:
14
- - uses: simplybusiness/version-forget-me-not@v1
14
+ - uses: simplybusiness/version-forget-me-not@v2
15
15
  env:
16
16
  ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
17
17
  VERSION_FILE_PATH: "lib/simplycop/version.rb"
data/.simplycop.yml CHANGED
@@ -18,436 +18,305 @@ AllCops:
18
18
  DisplayStyleGuide: true
19
19
  UseCache: true
20
20
  MaxFilesInCache: 5000
21
+ ExtraDetails: true
21
22
  # Adapted from: https://github.com/simplybusiness/how-we-roll/blob/master/development/RUBYSTYLEGUIDE.markdown
22
23
 
23
- Naming/VariableName:
24
- Enabled: true
25
- EnforcedStyle: snake_case
26
- SupportedStyles:
27
- - snake_case
28
- - camelCase
29
-
30
- Naming/FileName:
31
- Enabled: true
32
-
33
- Layout/TrailingEmptyLines:
34
- Enabled: true
35
- Severity: warning
36
-
37
- Layout/TrailingWhitespace:
38
- Enabled: true
39
- Severity: warning
40
-
41
- Lint/DuplicateMethods:
42
- Enabled: true
43
- Severity: warning
44
-
45
- Style/SpecialGlobalVars:
24
+ Layout/EmptyLineAfterMultilineCondition:
46
25
  Enabled: true
47
- Severity: warning
48
26
 
49
- Style/ColonMethodCall:
27
+ Layout/FirstArrayElementLineBreak:
50
28
  Enabled: true
51
- Severity: warning
52
29
 
53
- Style/RedundantReturn:
30
+ Layout/FirstMethodArgumentLineBreak:
54
31
  Enabled: true
55
- Severity: warning
56
32
 
57
- Style/NestedParenthesizedCalls:
33
+ Layout/FirstHashElementLineBreak:
58
34
  Enabled: true
59
35
 
60
- Layout/MultilineMethodCallIndentation:
36
+ Layout/HeredocArgumentClosingParenthesis:
61
37
  Enabled: true
62
38
 
63
- Style/RedundantParentheses:
39
+ Layout/SpaceBeforeBrackets:
64
40
  Enabled: true
65
41
 
66
- Style/RedundantInterpolation:
67
- Enabled: false
68
-
69
- Layout/AssignmentIndentation:
42
+ Lint/AmbiguousAssignment:
70
43
  Enabled: true
71
44
 
72
- Style/MutableConstant:
73
- Enabled: false
45
+ Lint/AmbiguousBlockAssociation:
46
+ Exclude:
47
+ - spec/**/*
74
48
 
75
- Style/ZeroLengthPredicate:
49
+ Lint/DeprecatedConstants:
76
50
  Enabled: true
77
51
 
78
- Style/ConditionalAssignment:
52
+ Lint/DuplicateBranch:
79
53
  Enabled: true
80
54
 
81
- Style/NestedModifier:
55
+ Lint/DuplicateRegexpCharacterClassElement:
82
56
  Enabled: true
83
57
 
84
- Style/IfInsideElse:
58
+ Lint/EmptyBlock:
85
59
  Enabled: true
86
60
 
87
- Lint/IneffectiveAccessModifier:
88
- Enabled: false
89
-
90
- Lint/ImplicitStringConcatenation:
61
+ Lint/EmptyClass:
91
62
  Enabled: true
92
63
 
93
- Lint/UselessAssignment:
64
+ Lint/HeredocMethodCallPosition:
94
65
  Enabled: true
95
- Severity: warning
96
66
 
97
- Lint/UnusedBlockArgument:
67
+ Lint/LambdaWithoutLiteralBlock:
98
68
  Enabled: true
99
- Severity: warning
100
69
 
101
- Lint/UnderscorePrefixedVariableName:
70
+ Lint/NoReturnInBeginEndBlocks:
102
71
  Enabled: true
103
- Severity: warning
104
-
105
- Style/Documentation:
106
- Enabled: false
107
-
108
- Layout/SpaceInsideBlockBraces:
109
- Enabled: false
110
72
 
111
- Layout/SpaceInsideArrayLiteralBrackets:
73
+ Lint/NumberedParameterAssignment:
112
74
  Enabled: true
113
75
 
114
- Layout/SpaceInsideReferenceBrackets:
76
+ Lint/OrAssignmentToConstant:
115
77
  Enabled: true
116
78
 
117
- Layout/SpaceInsideHashLiteralBraces:
118
- Enabled: false
119
-
120
- Layout/SpaceInsideParens:
79
+ Lint/RedundantDirGlobSort:
121
80
  Enabled: true
122
81
 
123
- Layout/SpaceBeforeComma:
82
+ Lint/SymbolConversion:
124
83
  Enabled: true
125
84
 
126
- Layout/IndentationConsistency:
85
+ Lint/ToEnumArguments:
127
86
  Enabled: true
128
87
 
129
- Layout/CaseIndentation:
88
+ Lint/TripleQuotes:
130
89
  Enabled: true
131
90
 
132
- Style/MethodDefParentheses:
91
+ Lint/UnexpectedBlockArity:
133
92
  Enabled: true
134
93
 
135
- Style/MultilineTernaryOperator:
94
+ Lint/UnmodifiedReduceAccumulator:
136
95
  Enabled: true
137
96
 
138
- Style/NestedTernaryOperator:
139
- Enabled: true
97
+ ###### COPS REVIEWED ABOVE THIS LINE ######
140
98
 
141
- Style/UnlessElse:
99
+ Metrics/BlockLength:
100
+ Exclude:
101
+ - spec/**/*.rb
102
+ -
103
+ Metrics/ClassLength:
104
+ Max: 512
142
105
  Enabled: true
143
106
 
144
- Style/SymbolArray:
145
- EnforcedStyle: brackets
146
-
147
- Style/WordArray:
148
- EnforcedStyle: brackets
149
-
150
- Style/ParenthesesAroundCondition:
107
+ Metrics/ModuleLength:
151
108
  Enabled: true
152
109
 
153
- Layout/MultilineBlockLayout:
110
+ Naming/FileName:
154
111
  Enabled: true
155
112
 
156
- Layout/InitialIndentation:
113
+ Naming/VariableName:
157
114
  Enabled: true
115
+ EnforcedStyle: snake_case
116
+ SupportedStyles:
117
+ - snake_case
118
+ - camelCase
158
119
 
159
- Style/OptionalArguments:
120
+ Style/AccessorGrouping:
160
121
  Enabled: true
161
122
 
162
- Lint/DuplicateHashKey:
123
+ Style/Alias:
163
124
  Enabled: false
164
125
 
165
- Lint/CircularArgumentReference:
126
+ Style/ArgumentsForwarding:
166
127
  Enabled: true
167
128
 
168
- Lint/AmbiguousOperator:
129
+ Style/ArrayCoercion:
169
130
  Enabled: true
170
131
 
171
- Lint/AmbiguousRegexpLiteral:
132
+ Style/BisectedAttrAccessor:
172
133
  Enabled: true
173
134
 
174
- Layout/BlockAlignment:
135
+ Style/CaseLikeIf:
175
136
  Enabled: true
176
137
 
177
- Layout/DefEndAlignment:
138
+ Style/CollectionCompact:
178
139
  Enabled: true
179
140
 
180
- Lint/DeprecatedClassMethods:
141
+ Style/ColonMethodCall:
181
142
  Enabled: true
143
+ Severity: warning
182
144
 
183
- Layout/EndAlignment:
145
+ Style/CombinableLoops:
184
146
  Enabled: true
185
147
 
186
- Lint/UselessAccessModifier:
187
- Enabled: false
188
-
189
- Lint/Void:
148
+ Style/ConditionalAssignment:
190
149
  Enabled: true
191
150
 
192
- Style/Alias:
151
+ Style/DocumentDynamicEvalDefinition:
193
152
  Enabled: false
194
153
 
195
- Layout/SpaceAroundBlockParameters:
196
- Enabled: true
197
-
198
- Layout/SpaceAroundEqualsInParameterDefault:
199
- Enabled: true
200
-
201
- Style/RedundantBegin:
202
- Enabled: true
203
-
204
- Style/RedundantException:
205
- Enabled: true
154
+ Style/Documentation:
155
+ Enabled: false
206
156
 
207
- Layout/EmptyLines:
157
+ Style/EndlessMethod:
208
158
  Enabled: true
209
159
 
210
- Style/SelfAssignment:
211
- Enabled: true
212
-
213
- Style/LambdaCall:
160
+ Style/ExplicitBlockArgument:
214
161
  Enabled: true
215
162
 
216
- Metrics/ModuleLength:
217
- Enabled: true
163
+ Style/ExponentialNotation:
164
+ Enabled: false
218
165
 
219
166
  Style/For:
220
167
  Enabled: true
221
168
 
222
- Layout/ExtraSpacing:
169
+ Style/FormatString:
223
170
  Enabled: false
224
171
 
225
- Style/GuardClause:
172
+ Style/FormatStringToken:
226
173
  Enabled: false
227
174
 
228
175
  Style/FrozenStringLiteralComment:
229
176
  Enabled: false
230
177
 
231
- Style/StringLiterals:
232
- Enabled: false
233
-
234
- Metrics/ClassLength:
235
- Max: 512
178
+ Style/GlobalStdStream:
236
179
  Enabled: true
237
180
 
238
- Layout/LineLength:
239
- Enabled: true
240
- Max: 120
181
+ Style/GuardClause:
182
+ Enabled: false
241
183
 
242
- Layout/ArgumentAlignment:
184
+ Style/HashAsLastArrayItem:
243
185
  Enabled: true
244
186
 
245
187
  Style/HashEachMethods:
246
188
  Enabled: false
247
189
 
248
- Style/HashTransformKeys:
249
- Enabled: true
250
-
251
- Style/HashTransformValues:
190
+ Style/HashExcept:
252
191
  Enabled: true
253
192
 
254
- Layout/EmptyLinesAroundAttributeAccessor:
255
- Enabled: true
256
-
257
- Layout/SpaceAroundMethodCallOperator:
258
- Enabled: true
259
-
260
- Lint/DeprecatedOpenSSLConstant:
261
- Enabled: true
262
-
263
- Lint/DuplicateElsifCondition:
264
- Enabled: true
193
+ Style/HashLikeCase:
194
+ Enabled: false
265
195
 
266
- Lint/MixedRegexpCaptureTypes:
196
+ Style/HashTransformKeys:
267
197
  Enabled: true
268
198
 
269
- Lint/RaiseException:
199
+ Style/HashTransformValues:
270
200
  Enabled: true
271
201
 
272
- Lint/StructNewOverride:
202
+ Style/IfInsideElse:
273
203
  Enabled: true
274
204
 
275
- Style/AccessorGrouping:
205
+ Style/IfWithBooleanLiteralBranches:
276
206
  Enabled: true
277
207
 
278
- Style/ArrayCoercion:
208
+ Style/KeywordParametersOrder:
279
209
  Enabled: true
280
210
 
281
- Style/BisectedAttrAccessor:
211
+ Style/LambdaCall:
282
212
  Enabled: true
283
213
 
284
- Style/CaseLikeIf:
214
+ Style/MethodDefParentheses:
285
215
  Enabled: true
286
216
 
287
- Style/ExponentialNotation:
288
- Enabled: false
289
-
290
- Style/HashAsLastArrayItem:
217
+ Style/MultilineTernaryOperator:
291
218
  Enabled: true
292
219
 
293
- Style/HashLikeCase:
220
+ Style/MutableConstant:
294
221
  Enabled: false
295
222
 
296
- Style/RedundantAssignment:
223
+ Style/NegatedIfElseCondition:
297
224
  Enabled: true
298
225
 
299
- Style/RedundantFetchBlock:
226
+ Style/NestedModifier:
300
227
  Enabled: true
301
228
 
302
- Style/RedundantFileExtensionInRequire:
229
+ Style/NestedParenthesizedCalls:
303
230
  Enabled: true
304
231
 
305
- Style/RedundantRegexpCharacterClass:
232
+ Style/NestedTernaryOperator:
306
233
  Enabled: true
307
234
 
308
- Style/RedundantRegexpEscape:
235
+ Style/NilLambda:
309
236
  Enabled: true
310
237
 
311
- Style/SlicingWithRange:
238
+ Style/NumericPredicate:
312
239
  Enabled: false
313
240
 
314
- Layout/BeginEndAlignment:
241
+ Style/OptionalArguments:
315
242
  Enabled: true
316
243
 
317
- Lint/BinaryOperatorWithIdenticalOperands:
244
+ Style/OptionalBooleanParameter:
318
245
  Enabled: true
319
246
 
320
- Lint/ConstantDefinitionInBlock:
247
+ Style/ParenthesesAroundCondition:
321
248
  Enabled: true
322
- Exclude:
323
- - spec/**/*.rb
324
249
 
325
- Lint/DuplicateRequire:
250
+ Style/RedundantArgument:
326
251
  Enabled: true
327
252
 
328
- Lint/DuplicateRescueException:
253
+ Style/RedundantAssignment:
329
254
  Enabled: true
330
255
 
331
- Lint/EmptyConditionalBody:
256
+ Style/RedundantBegin:
332
257
  Enabled: true
333
258
 
334
- Lint/EmptyFile:
259
+ Style/RedundantException:
335
260
  Enabled: true
336
261
 
337
- Lint/FloatComparison:
262
+ Style/RedundantFetchBlock:
338
263
  Enabled: true
339
264
 
340
- Lint/IdentityComparison:
265
+ Style/RedundantFileExtensionInRequire:
341
266
  Enabled: true
342
267
 
343
- Lint/MissingSuper:
268
+ Style/RedundantInterpolation:
344
269
  Enabled: false
345
270
 
346
- Lint/OutOfRangeRegexpRef:
347
- Enabled: true
348
-
349
- Lint/SelfAssignment:
350
- Enabled: true
351
-
352
- Lint/TopLevelReturnWithArgument:
353
- Enabled: true
354
-
355
- Lint/TrailingCommaInAttributeDeclaration:
356
- Enabled: true
357
-
358
- Lint/UnreachableLoop:
359
- Enabled: true
360
-
361
- Lint/UselessMethodDefinition:
362
- Enabled: true
363
-
364
- Lint/UselessTimes:
365
- Enabled: true
366
-
367
- Style/CombinableLoops:
368
- Enabled: true
369
-
370
- Style/ExplicitBlockArgument:
271
+ Style/RedundantParentheses:
371
272
  Enabled: true
372
273
 
373
- Style/GlobalStdStream:
274
+ Style/RedundantRegexpCharacterClass:
374
275
  Enabled: true
375
276
 
376
- Style/KeywordParametersOrder:
277
+ Style/RedundantRegexpEscape:
377
278
  Enabled: true
378
279
 
379
- Style/OptionalBooleanParameter:
280
+ Style/RedundantReturn:
380
281
  Enabled: true
282
+ Severity: warning
381
283
 
382
284
  Style/RedundantSelfAssignment:
383
285
  Enabled: true
384
286
 
385
- Style/SingleArgumentDig:
386
- Enabled: true
387
-
388
- Style/SoleNestedConditional:
389
- Enabled: true
390
-
391
- Style/StringConcatenation:
287
+ Style/SelfAssignment:
392
288
  Enabled: true
393
289
 
394
- Lint/DuplicateRegexpCharacterClassElement:
290
+ Style/SingleArgumentDig:
395
291
  Enabled: true
396
292
 
397
- Lint/EmptyBlock:
398
- Enabled: true
293
+ Style/SlicingWithRange:
294
+ Enabled: false
399
295
 
400
- Lint/ToEnumArguments:
296
+ Style/SoleNestedConditional:
401
297
  Enabled: true
402
298
 
403
- Lint/UnmodifiedReduceAccumulator:
299
+ Style/SpecialGlobalVars:
404
300
  Enabled: true
301
+ Severity: warning
405
302
 
406
- Style/ArgumentsForwarding:
303
+ Style/StringConcatenation:
407
304
  Enabled: true
408
305
 
409
- Style/DocumentDynamicEvalDefinition:
306
+ Style/StringLiterals:
410
307
  Enabled: false
411
308
 
412
309
  Style/SwapValues:
413
310
  Enabled: true
414
311
 
415
- Lint/AmbiguousBlockAssociation:
416
- Exclude:
417
- - spec/**/*
418
-
419
- Layout/FirstHashElementIndentation:
420
- EnforcedStyle: consistent
421
-
422
- Style/FormatString:
423
- Enabled: false
424
-
425
- Style/FormatStringToken:
426
- Enabled: false
427
-
428
- Style/NumericPredicate:
429
- Enabled: false
430
-
431
- Lint/NoReturnInBeginEndBlocks:
432
- Enabled: true
433
-
434
- Style/CollectionCompact:
435
- Enabled: true
436
-
437
- Style/NegatedIfElseCondition:
438
- Enabled: true
439
-
440
- Lint/DuplicateBranch:
441
- Enabled: true
312
+ Style/SymbolArray:
313
+ EnforcedStyle: brackets
442
314
 
443
- Lint/EmptyClass:
444
- Enabled: true
445
-
446
- Style/NilLambda:
315
+ Style/UnlessElse:
447
316
  Enabled: true
448
317
 
449
- Lint/UnexpectedBlockArity:
450
- Enabled: true
318
+ Style/WordArray:
319
+ EnforcedStyle: brackets
451
320
 
452
- Style/RedundantArgument:
321
+ Style/ZeroLengthPredicate:
453
322
  Enabled: true
@@ -1,6 +1,3 @@
1
- AllCops:
2
- ExtraDetails: true
3
-
4
1
  require:
5
2
  - './lib/simplycop/custom_cops/constantize.rb'
6
3
  - './lib/simplycop/custom_cops/define_method.rb'
data/.simplycop_rails.yml CHANGED
@@ -1,64 +1,20 @@
1
1
  require:
2
2
  - rubocop-rails
3
3
 
4
- AllCops:
5
- Exclude:
6
- - 'db/schema.rb'
7
- - 'vendor/**/*'
8
-
9
- # Cop names are not displayed in offense messages by default. Change behavior
10
- # by overriding DisplayCopNames, or by giving the -D/--display-cop-names
11
- # option.
12
- DisplayCopNames: true
13
- # Style guide URLs are not displayed in offense messages by default. Change
14
- # behavior by overriding DisplayStyleGuide, or by giving the
15
- # -S/--display-style-guide option.
16
- DisplayStyleGuide: true
17
- UseCache: true
18
- MaxFilesInCache: 5000
19
- # Adapted from: https://github.com/simplybusiness/how-we-roll/blob/master/development/RUBYSTYLEGUIDE.markdown
20
-
21
- Rails:
22
- Enabled: true
23
-
24
- ## Rails Cops
25
- Rails/TimeZone:
26
- Enabled: true
27
- Severity: warning
28
-
29
- Rails/Date:
30
- Enabled: true
31
- Severity: warning
32
-
33
- Rails/Delegate:
34
- Enabled: false
35
-
36
- Rails/Output:
37
- Enabled: true
38
-
39
- Rails/Validation:
40
- Enabled: true
41
-
42
- Rails/FindBy:
43
- Enabled: true
44
-
45
- Rails/ActionFilter:
46
- Enabled: true
47
-
48
- Rails/ReadWriteAttribute:
4
+ Rails/ActiveRecordCallbacksOrder:
49
5
  Enabled: true
50
6
 
51
- Rails/PluralizationGrammar:
7
+ Rails/AfterCommitOverride:
52
8
  Enabled: true
53
9
 
54
- Rails/SkipsModelValidations:
10
+ Rails/AttributeDefaultBlockValue:
55
11
  Enabled: true
56
12
 
57
- Rails/ActiveRecordCallbacksOrder:
13
+ Rails/DefaultScope:
58
14
  Enabled: true
59
15
 
60
- Rails/AfterCommitOverride:
61
- Enabled: true
16
+ Rails/Delegate:
17
+ Enabled: false
62
18
 
63
19
  Rails/FindById:
64
20
  Enabled: true
@@ -75,9 +31,11 @@ Rails/MatchRoute:
75
31
  Rails/NegateInclude:
76
32
  Enabled: true
77
33
 
34
+ # Conflicts with Mongoid
78
35
  Rails/Pluck:
79
36
  Enabled: false
80
37
 
38
+ # Conflicts with Mongoid
81
39
  Rails/PluckInWhere:
82
40
  Enabled: false
83
41
 
@@ -93,17 +51,13 @@ Rails/ShortI18n:
93
51
  Rails/SquishedSQLHeredocs:
94
52
  Enabled: true
95
53
 
54
+ Rails/WhereEquals:
55
+ Enabled: true
56
+
57
+ # Conflicts with Mongoid
96
58
  Rails/WhereExists:
97
59
  Enabled: false
98
60
 
61
+ # Conflicts with Mongoid
99
62
  Rails/WhereNot:
100
63
  Enabled: false
101
-
102
- Rails/WhereEquals:
103
- Enabled: true
104
-
105
- Rails/AttributeDefaultBlockValue:
106
- Enabled: true
107
-
108
- Rails/ArelStar:
109
- Enabled: true
data/.simplycop_rspec.yml CHANGED
@@ -1,234 +1,48 @@
1
1
  require:
2
2
  - rubocop-rspec
3
3
 
4
- RSpec/ContextMethod:
5
- Enabled: false
6
-
7
- RSpec/LeakyConstantDeclaration:
8
- Enabled: false
9
-
10
- RSpec/EmptyLineAfterExample:
11
- Enabled: false
12
-
13
- RSpec/AnyInstance:
14
- Description: Check that instances are not being stubbed globally.
15
- Enabled: true
16
-
17
- RSpec/AroundBlock:
18
- Description: Checks that around blocks actually run the test.
19
- Enabled: true
20
-
21
- RSpec/BeEql:
22
- Description: Check for expectations where `be(...)` can replace `eql(...)`.
23
- Enabled: true
24
-
25
4
  RSpec/BeforeAfterAll:
26
- Description: Check that before/after(:all) isn't being used.
27
5
  Enabled: false
28
6
 
29
7
  RSpec/DescribeClass:
30
- Description: Check that the first argument to the top level describe is a constant.
31
- Enabled: false
32
-
33
- RSpec/DescribedClass:
34
- Description: Checks that tests use `described_class`.
35
- SkipBlocks: false
36
8
  Enabled: false
37
- EnforcedStyle: described_class
38
- SupportedStyles:
39
- - described_class
40
- - explicit
41
9
 
42
10
  RSpec/DescribeMethod:
43
- Description: Checks that the second argument to `describe` specifies a method.
44
- Enabled: false
45
-
46
- RSpec/DescribeSymbol:
47
- Description: Avoid describing symbols.
48
11
  Enabled: false
49
12
 
50
- RSpec/IteratedExpectation:
51
- Description: Check that `all` matcher is used instead of iterating over an array.
52
- Enabled: true
53
-
54
- RSpec/EmptyExampleGroup:
55
- Description: Checks if an example group does not include any tests.
56
- Enabled: true
57
-
58
- RSpec/EmptyLineAfterFinalLet:
59
- Description: Checks if there is an empty line after the last let block.
60
- Enabled: false
61
-
62
- RSpec/EmptyLineAfterSubject:
63
- Description: Checks if there is an empty line after subject block.
13
+ RSpec/DescribedClass:
64
14
  Enabled: false
65
15
 
66
16
  RSpec/ExampleLength:
67
- Description: Checks for long examples.
68
17
  Enabled: false
69
- Max: 5
70
-
71
- RSpec/ExampleWording:
72
- Description: Checks for common mistakes in example descriptions.
73
- Enabled: true
74
- CustomTransform:
75
- be: is
76
- BE: IS
77
- have: has
78
- HAVE: HAS
79
- IgnoredWords: []
80
-
81
- RSpec/ExpectActual:
82
- Description: Checks for `expect(...)` calls containing literal values.
83
- Enabled: true
84
18
 
85
19
  RSpec/ExpectOutput:
86
- Description: Checks for opportunities to use `expect { ... }.to output`.
87
20
  Enabled: false
88
21
 
89
22
  RSpec/FilePath:
90
- Description: Checks that spec file paths are consistent with the test subject.
91
- Enabled: false
92
- CustomTransform:
93
- RuboCop: rubocop
94
- RSpec: rspec
95
- IgnoreMethods: false
96
-
97
- RSpec/Focus:
98
- Description: Checks if examples are focused.
99
- Enabled: false
100
-
101
- RSpec/HookArgument:
102
- Description: Checks the arguments passed to `before`, `around`, and `after`.
103
- Enabled: true
104
- EnforcedStyle: implicit
105
- SupportedStyles:
106
- - implicit
107
- - each
108
- - example
109
-
110
- RSpec/ImplicitExpect:
111
- Description: Check that a consistent implicit expectation style is used.
112
- Enabled: true
113
- EnforcedStyle: is_expected
114
- SupportedStyles:
115
- - is_expected
116
- - should
117
-
118
- RSpec/InstanceSpy:
119
- Description: Checks for `instance_double` used with `have_received`.
120
23
  Enabled: false
121
24
 
122
25
  RSpec/InstanceVariable:
123
- Description: Checks for instance variable usage in specs.
124
- AssignmentOnly: false
125
26
  Enabled: false
126
27
 
127
- RSpec/ItBehavesLike:
128
- Description: Checks that only one `it_behaves_like` style is used.
129
- Enabled: true
130
- EnforcedStyle: it_behaves_like
131
- SupportedStyles:
132
- - it_behaves_like
133
- - it_should_behave_like
134
-
135
- RSpec/LeadingSubject:
136
- Description: Checks for `subject` definitions that come after `let` definitions.
137
- Enabled: true
138
-
139
- RSpec/LetSetup:
140
- Description: Checks unreferenced `let!` calls being used for test setup.
141
- Enabled: true
142
-
143
- RSpec/MessageChain:
144
- Description: Check that chains of messages are not being stubbed.
145
- Enabled: true
146
-
147
- RSpec/MessageExpectation:
148
- Description: Checks for consistent message expectation style.
149
- Enabled: false
150
- EnforcedStyle: allow
151
- SupportedStyles:
152
- - allow
153
- - expect
154
-
155
28
  RSpec/MessageSpies:
156
- Description: Checks that message expectations are set using spies.
157
29
  Enabled: false
158
- EnforcedStyle: have_received
159
- SupportedStyles:
160
- - have_received
161
- - receive
162
-
163
- RSpec/MultipleDescribes:
164
- Description: Checks for multiple top level describes.
165
- Enabled: true
166
30
 
167
31
  RSpec/MultipleExpectations:
168
- Description: Checks if examples contain too many `expect` calls.
169
32
  Enabled: false
170
- Max: 1
171
33
 
172
34
  RSpec/MultipleMemoizedHelpers:
173
35
  Enabled: false
174
36
 
175
- RSpec/NamedSubject:
176
- Description: Checks for explicitly referenced test subjects.
177
- Enabled: true
178
-
179
37
  RSpec/NestedGroups:
180
- Description: Checks for nested example groups.
181
38
  Enabled: true
182
39
  Max: 4
183
40
 
184
41
  RSpec/NotToNot:
185
- Description: Checks for consistent method usage for negating expectations.
186
- EnforcedStyle: not_to
187
- SupportedStyles:
188
- - not_to
189
- - to_not
190
42
  Enabled: false
191
43
 
192
- RSpec/OverwritingSetup:
193
- Enabled: true
194
- Description: Checks if there is a let/subject that overwrites an existing one.
195
-
196
- RSpec/RepeatedDescription:
197
- Enabled: true
198
- Description: Check for repeated description strings in example groups.
199
-
200
- RSpec/RepeatedExample:
201
- Enabled: true
202
- Description: Check for repeated examples within example groups.
203
-
204
- RSpec/SharedContext:
205
- Description: Checks for proper shared_context and shared_examples usage.
206
- Enabled: true
207
-
208
- RSpec/SingleArgumentMessageChain:
209
- Description: Checks that chains of messages contain more than one element.
210
- Enabled: true
211
-
212
- RSpec/ScatteredLet:
213
- Description: Checks for let scattered across the example group.
214
- Enabled: true
215
-
216
44
  RSpec/ScatteredSetup:
217
- Description: Checks for setup scattered across multiple hooks in an example group.
218
- Enabled: false
219
-
220
- RSpec/SubjectStub:
221
- Description: Checks for stubbed test subjects.
222
- Enabled: true
223
-
224
- RSpec/VerifiedDoubles:
225
- Description: Prefer using verifying doubles over normal doubles.
226
45
  Enabled: false
227
- IgnoreSymbolicNames: true
228
-
229
- Metrics/BlockLength:
230
- Exclude:
231
- - 'spec/**/*.rb'
232
46
 
233
47
  RSpec/StubbedMock:
234
48
  Enabled: false
@@ -3,9 +3,6 @@ require:
3
3
  - './lib/simplycop/security/reject_all_requests_local.rb'
4
4
  - './lib/simplycop/security/check_for_vulnerable_code.rb'
5
5
 
6
- AllCops:
7
- ExtraDetails: true
8
-
9
6
  Security/CSRFTokenValidation:
10
7
  Enabled: true
11
8
  Details: >-
@@ -7,5 +7,5 @@
7
7
  #
8
8
 
9
9
  module Simplycop
10
- VERSION = '1.3.0'
10
+ VERSION = '1.6.0'
11
11
  end
data/simplycop.gemspec CHANGED
@@ -17,9 +17,9 @@ Gem::Specification.new do |spec|
17
17
  spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
18
18
  spec.require_paths = ['lib']
19
19
 
20
- spec.add_dependency 'rubocop', '~> 1.6.1'
20
+ spec.add_dependency 'rubocop', '~> 1.9.1'
21
21
  spec.add_dependency 'rubocop-rails', '~> 2.9.0'
22
- spec.add_dependency 'rubocop-rspec', '~> 2.0.1'
22
+ spec.add_dependency 'rubocop-rspec', '~> 2.1.0'
23
23
  spec.add_development_dependency 'bundler'
24
24
  spec.add_development_dependency 'rake', '>= 12.3.3'
25
25
  spec.add_development_dependency 'rspec', '~> 3.10'
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: simplycop
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.3.0
4
+ version: 1.6.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Simply Business
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2020-12-17 00:00:00.000000000 Z
11
+ date: 2021-02-05 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rubocop
@@ -16,14 +16,14 @@ dependencies:
16
16
  requirements:
17
17
  - - "~>"
18
18
  - !ruby/object:Gem::Version
19
- version: 1.6.1
19
+ version: 1.9.1
20
20
  type: :runtime
21
21
  prerelease: false
22
22
  version_requirements: !ruby/object:Gem::Requirement
23
23
  requirements:
24
24
  - - "~>"
25
25
  - !ruby/object:Gem::Version
26
- version: 1.6.1
26
+ version: 1.9.1
27
27
  - !ruby/object:Gem::Dependency
28
28
  name: rubocop-rails
29
29
  requirement: !ruby/object:Gem::Requirement
@@ -44,14 +44,14 @@ dependencies:
44
44
  requirements:
45
45
  - - "~>"
46
46
  - !ruby/object:Gem::Version
47
- version: 2.0.1
47
+ version: 2.1.0
48
48
  type: :runtime
49
49
  prerelease: false
50
50
  version_requirements: !ruby/object:Gem::Requirement
51
51
  requirements:
52
52
  - - "~>"
53
53
  - !ruby/object:Gem::Version
54
- version: 2.0.1
54
+ version: 2.1.0
55
55
  - !ruby/object:Gem::Dependency
56
56
  name: bundler
57
57
  requirement: !ruby/object:Gem::Requirement
@@ -103,6 +103,7 @@ extensions: []
103
103
  extra_rdoc_files: []
104
104
  files:
105
105
  - ".custom_simplycop.yml"
106
+ - ".github/dependabot.yml"
106
107
  - ".github/workflows/ci.yml"
107
108
  - ".github/workflows/publish_gem.yml"
108
109
  - ".github/workflows/version_forget_me_not.yml"
@@ -153,7 +154,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
153
154
  - !ruby/object:Gem::Version
154
155
  version: '0'
155
156
  requirements: []
156
- rubygems_version: 3.1.4
157
+ rubygems_version: 3.2.3
157
158
  signing_key:
158
159
  specification_version: 4
159
160
  summary: Provides a single point of reference for common rubocop rules.