simplycop 1.13.9 → 1.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 32900dbfca72cb4082501a3023183e3d13f10e7d573bae10cab7d13d61308f91
-  data.tar.gz: 8478400ec3951beec7b6a21637d95c18e786e1fc37f10303856de8cf151db235
+  metadata.gz: 7143924d855175161eca111c30270dd5bd86af8524a294d4c0d0e3d49420f59f
+  data.tar.gz: 5826de2aa177b6f04fb18f0b869521e008a32245053c08abbf6132a216a41a1e
 SHA512:
-  metadata.gz: 736365716ad3edc37fccbff8980f5a44bbffb0dfbc28a7f087a1c23c70cfb81d0c4b5a19c9c9e3ed26a1b8ccf4e36e23830b68afb32269e8d1562d4d8f2a9381
-  data.tar.gz: 8e59836e7ca6074ce0bf8bb045c724fd9d98254cc895a8944fe8bf80a9ff10da16633518ff1b3a43ab889d8239d61e17b7204e3e9fcddf7bd84eb80b291a21e9
+  metadata.gz: 408508800d0b5c6c9934f9b44c0d225ff3eda5a980975fff3ca9b7854a8fb87381372fdae64af1551b5b5af2ce31597bb80d074869f7f5ecfb95b9e65adadb82
+  data.tar.gz: e09fc5bba99ef3250b5534ade02b046afe835c6f6db71bbd73bcda393dbab1c52e438d76dc00131726d55387906129e7abda0df6c938c064044f2a25732a62fb

data/.github/workflows/ci.yml

@@ -22,7 +22,7 @@ jobs:
         ruby-version: ['2.7', '3.0', '3.1', '3.2', jruby]
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:

data/.github/workflows/publish_gem.yml

@@ -11,7 +11,7 @@ jobs:
     name: Build and Publish
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up Ruby 3.0
         uses: actions/setup-ruby@v1
         with:

data/.simplycop.yml

@@ -886,6 +886,7 @@ Naming/MethodParameterName:
   Enabled: true
   AllowedNames:
     - as
+    - at
     - ex
     - id
     - ip
@@ -917,6 +918,7 @@ Naming/VariableNumber:
     - rfc822
     - rfc2822
     - rfc3339
+    - s3
     - x86_64
   AllowedPatterns:
     - v\d+

data/.simplycop_rails.yml

@@ -1,56 +1,399 @@
 require:
   - rubocop-rails
 
+# Overridden in Chopin
+Rails/ActionControllerFlashBeforeRender:
+  Enabled: true
+
+Rails/ActionControllerTestCase:
+  Enabled: true
+
+Rails/ActionFilter:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/ActionOrder:
+  Enabled: true
+
+Rails/ActiveRecordAliases:
+  Enabled: true
+
 Rails/ActiveRecordCallbacksOrder:
   Enabled: true
 
+Rails/ActiveRecordOverride:
+  Enabled: true
+
+Rails/ActiveSupportAliases:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/ActiveSupportOnLoad:
+  Enabled: true
+
+Rails/AddColumnIndex:
+  Enabled: true
+
 Rails/AfterCommitOverride:
   Enabled: true
 
+Rails/ApplicationController:
+  Enabled: true
+
+Rails/ApplicationJob:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/ApplicationMailer:
+  Enabled: true
+
+Rails/ApplicationRecord:
+  Enabled: true
+
+Rails/ArelStar:
+  Enabled: true
+
+Rails/AssertNot:
+  Enabled: true
+
 Rails/AttributeDefaultBlockValue:
   Enabled: true
 
+Rails/BelongsTo:
+  Enabled: true
+
+Rails/Blank:
+  Enabled: true
+
+Rails/BulkChangeTable:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/CompactBlank:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/ContentTag:
+  Enabled: true
+
+Rails/CreateTableWithTimestamps:
+  Enabled: true
+
+Rails/DangerousColumnNames:
+  Enabled: true
+
+Rails/Date:
+  Enabled: true
+
 Rails/DefaultScope:
   Enabled: true
 
 Rails/Delegate:
   Enabled: false
 
+Rails/DelegateAllowBlank:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/DeprecatedActiveModelErrorsMethods:
+  Enabled: true
+
+Rails/DotSeparatedKeys:
+  Enabled: true
+
+Rails/DuplicateAssociation:
+  Enabled: true
+
+Rails/DuplicateScope:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/DurationArithmetic:
+  Enabled: true
+
+Rails/DynamicFindBy:
+  Enabled: false
+
+Rails/EagerEvaluationLogMessage:
+  Enabled: true
+
+Rails/EnumHash:
+  Enabled: true
+
+Rails/EnumUniqueness:
+  Enabled: true
+
+Rails/EnvironmentComparison:
+  Enabled: true
+
+Rails/EnvironmentVariableAccess:
+  Enabled: false
+
+Rails/Exit:
+  Enabled: true
+
+Rails/ExpandedDateRange:
+  Enabled: true
+
+Rails/FilePath:
+  Enabled: true
+
+Rails/FindBy:
+  Enabled: true
+
 Rails/FindById:
   Enabled: true
 
+Rails/FindEach:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/FreezeTime:
+  Enabled: true
+
+Rails/HasAndBelongsToMany:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/HasManyOrHasOneDependent:
+  Enabled: true
+
+Rails/HelperInstanceVariable:
+  Enabled: true
+
+Rails/HttpPositionalArguments:
+  Enabled: true
+
+Rails/HttpStatus:
+  Enabled: true
+
+Rails/I18nLazyLookup:
+  Enabled: false
+
+# Overridden in Chopin
+Rails/I18nLocaleAssignment:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/I18nLocaleTexts:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/IgnoredColumnsAssignment:
+  Enabled: true
+
+Rails/IgnoredSkipActionFilterOption:
+  Enabled: true
+
+Rails/IndexBy:
+  Enabled: true
+
+Rails/IndexWith:
+  Enabled: true
+
 Rails/Inquiry:
   Enabled: false
 
+Rails/InverseOf:
+  Enabled: true
+
+Rails/LexicallyScopedActionFilter:
+  Enabled: true
+
+Rails/LinkToBlank:
+  Enabled: true
+
 Rails/MailerName:
   Enabled: true
 
 Rails/MatchRoute:
   Enabled: true
 
+Rails/MigrationClassName:
+  Enabled: true
+
+# Overridden in Chopin
 Rails/NegateInclude:
   Enabled: true
 
+Rails/NotNullColumn:
+  Enabled: true
+
+Rails/OrderById:
+  Enabled: false
+
+Rails/Output:
+  Enabled: false
+
+Rails/OutputSafety:
+  Enabled: false
+
+Rails/Pick:
+  Enabled: true
+
 # Conflicts with Mongoid
 Rails/Pluck:
   Enabled: false
 
+Rails/PluckId:
+  Enabled: false
+
 # Conflicts with Mongoid
 Rails/PluckInWhere:
   Enabled: false
 
+Rails/PluralizationGrammar:
+  Enabled: true
+
+Rails/Presence:
+  Enabled: true
+
+Rails/Present:
+  Enabled: true
+
+Rails/RakeEnvironment:
+  Enabled: true
+
+Rails/ReadWriteAttribute:
+  Enabled: true
+
+Rails/RedundantActiveRecordAllMethod:
+  Enabled: true
+
+Rails/RedundantAllowNil:
+  Enabled: true
+
+Rails/RedundantForeignKey:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/RedundantPresenceValidationOnBelongsTo:
+  Enabled: true
+
+Rails/RedundantReceiverInWithOptions:
+  Enabled: true
+
+Rails/RedundantTravelBack:
+  Enabled: true
+
+Rails/ReflectionClassName:
+  Enabled: true
+
+Rails/RefuteMethods:
+  Enabled: false
+
+# Overridden in Chopin
+Rails/RelativeDateConstant:
+  Enabled: true
+
 Rails/RenderInline:
   Enabled: true
 
 Rails/RenderPlainText:
   Enabled: true
 
+Rails/RequestReferer:
+  Enabled: false
+
+Rails/RequireDependency:
+  Enabled: false
+
+Rails/ResponseParsedBody:
+  Enabled: true
+
+Rails/ReversibleMigration:
+  Enabled: true
+
+Rails/ReversibleMigrationMethodDefinition:
+  Enabled: false
+
+# Overridden in Chopin
+Rails/RootJoinChain:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/RootPathNameMethods:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/RootPublicPath:
+  Enabled: true
+
+Rails/SafeNavigation:
+  Enabled: true
+
+Rails/SafeNavigationWithBlank:
+  Enabled: true
+
+Rails/SaveBang:
+  Enabled: false
+
+Rails/SchemaComment:
+  Enabled: false
+
+Rails/ScopeArgs:
+  Enabled: true
+
+Rails/SelectMap:
+  Enabled: true
+
 Rails/ShortI18n:
   Enabled: true
 
+Rails/SkipsModelValidations:
+  Enabled: true
+
 Rails/SquishedSQLHeredocs:
   Enabled: true
 
+# Overridden in Chopin
+Rails/StripHeredoc:
+  Enabled: true
+
+Rails/TableNameAssignment:
+  Enabled: false
+
+Rails/ThreeStateBooleanColumn:
+  Enabled: false
+
+Rails/TimeZone:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/TimeZoneAssignment:
+  Enabled: true
+
+Rails/ToFormattedS:
+  Enabled: false
+
+Rails/ToSWithArgument:
+  Enabled: false
+
+# Overridden in Chopin
+Rails/TopLevelHashWithIndifferentAccess:
+  Enabled: true
+
+Rails/TransactionExitStatement:
+  Enabled: true
+
+Rails/UniqBeforePluck:
+  Enabled: true
+
+Rails/UniqueValidationWithoutIndex:
+  Enabled: true
+
+Rails/UnknownEnv:
+  Enabled: true
+
+Rails/UnusedIgnoredColumns:
+  Enabled: true
+
+Rails/UnusedRenderContent:
+  Enabled: true
+
+Rails/Validation:
+  Enabled: true
+
 Rails/WhereEquals:
   Enabled: true
 
@@ -58,10 +401,18 @@ Rails/WhereEquals:
 Rails/WhereExists:
   Enabled: false
 
+# Anticipate conflicts with Mongoid, like Rails/WhereExists
+Rails/WhereMissing:
+  Enabled: false
+
 # Conflicts with Mongoid
 Rails/WhereNot:
   Enabled: false
 
+# Anticipate conflicts with Mongoid, like Rails/WhereNot
+Rails/WhereNotWithMultipleConditions:
+  Enabled: false
+
 Rails/ActionControllerTestCase: # new in 2.14
   Enabled: true
 

data/.simplycop_rspec.yml

@@ -96,6 +96,12 @@ RSpec/EmptyLineAfterHook:
 RSpec/EmptyLineAfterSubject:
   Enabled: true
 
+RSpec/EmptyMetadata:
+  Enabled: true
+
+RSpec/Eq:
+  Enabled: true
+
 RSpec/ExampleLength:
   Enabled: false
 
@@ -120,9 +126,6 @@ RSpec/ExpectInHook:
 RSpec/ExpectOutput:
   Enabled: false
 
-RSpec/FilePath:
-  Enabled: false
-
 RSpec/Focus:
   Enabled: true
 
@@ -182,6 +185,9 @@ RSpec/MessageChain:
 RSpec/MessageSpies:
   Enabled: false
 
+RSpec/MetadataStyle:
+  Enabled: true
+
 RSpec/MissingExampleGroupArgument:
   Enabled: true
 
@@ -274,6 +280,12 @@ RSpec/SkipBlockInsideExample:
 RSpec/SortMetadata:
   Enabled: true
 
+RSpec/SpecFilePathSuffix:
+  Enabled: false
+
+RSpec/SpecFilePathFormat:
+  Enabled: false
+
 RSpec/StubbedMock:
   Enabled: false
 
@@ -308,10 +320,10 @@ RSpec/Capybara:
   Include:
     - spec/integration/*.rb
 
-Capybara/CurrentPathExpectation:
+RSpec/Capybara/FeatureMethods:
   Enabled: true
 
-Capybara/FeatureMethods:
+Capybara/CurrentPathExpectation:
   Enabled: true
 
 Capybara/MatchStyle:
@@ -331,6 +343,9 @@ Capybara/SpecificMatcher:
 
 # RSpec/FactoryBot
 
+FactoryBot/AssociationStyle:
+  Enabled: true
+
 FactoryBot/AttributeDefinedStatically:
   Enabled: true
 
@@ -340,12 +355,18 @@ FactoryBot/ConsistentParenthesesStyle:
 FactoryBot/CreateList:
   Enabled: false
 
+FactoryBot/FactoryAssociationWithStrategy:
+  Enabled: true
+
 FactoryBot/FactoryClassName:
   Enabled: true
 
 FactoryBot/FactoryNameStyle:
   Enabled: true
 
+FactoryBot/RedundantFactoryOption:
+  Enabled: true
+
 # Prefer explicit factorybot call
 FactoryBot/SyntaxMethods:
   Enabled: false

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.13.9'
+  VERSION = '1.14.0'
 end

data/simplycop.gemspec

@@ -17,10 +17,10 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '1.56.2'
+  spec.add_dependency 'rubocop', '1.56.3'
   spec.add_dependency 'rubocop-performance', '1.19.0'
-  spec.add_dependency 'rubocop-rails', '2.20.2'
-  spec.add_dependency 'rubocop-rspec', '2.23.2'
+  spec.add_dependency 'rubocop-rails', '2.21.1'
+  spec.add_dependency 'rubocop-rspec', '2.24.0'
   spec.add_development_dependency 'bundler', '>= 2.2.15'
   spec.add_development_dependency 'rake', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.10'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.13.9
+  version: 1.14.0
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-09-08 00:00:00.000000000 Z
+date: 2023-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.56.2
+        version: 1.56.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.56.2
+        version: 1.56.3
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -44,28 +44,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.20.2
+        version: 2.21.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.20.2
+        version: 2.21.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.23.2
+        version: 2.24.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.23.2
+        version: 2.24.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement