simplycop 1.13.9 → 1.14.0

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 32900dbfca72cb4082501a3023183e3d13f10e7d573bae10cab7d13d61308f91
4
- data.tar.gz: 8478400ec3951beec7b6a21637d95c18e786e1fc37f10303856de8cf151db235
3
+ metadata.gz: 7143924d855175161eca111c30270dd5bd86af8524a294d4c0d0e3d49420f59f
4
+ data.tar.gz: 5826de2aa177b6f04fb18f0b869521e008a32245053c08abbf6132a216a41a1e
5
5
  SHA512:
6
- metadata.gz: 736365716ad3edc37fccbff8980f5a44bbffb0dfbc28a7f087a1c23c70cfb81d0c4b5a19c9c9e3ed26a1b8ccf4e36e23830b68afb32269e8d1562d4d8f2a9381
7
- data.tar.gz: 8e59836e7ca6074ce0bf8bb045c724fd9d98254cc895a8944fe8bf80a9ff10da16633518ff1b3a43ab889d8239d61e17b7204e3e9fcddf7bd84eb80b291a21e9
6
+ metadata.gz: 408508800d0b5c6c9934f9b44c0d225ff3eda5a980975fff3ca9b7854a8fb87381372fdae64af1551b5b5af2ce31597bb80d074869f7f5ecfb95b9e65adadb82
7
+ data.tar.gz: e09fc5bba99ef3250b5534ade02b046afe835c6f6db71bbd73bcda393dbab1c52e438d76dc00131726d55387906129e7abda0df6c938c064044f2a25732a62fb
@@ -22,7 +22,7 @@ jobs:
22
22
  ruby-version: ['2.7', '3.0', '3.1', '3.2', jruby]
23
23
 
24
24
  steps:
25
- - uses: actions/checkout@v3
25
+ - uses: actions/checkout@v4
26
26
  - name: Set up Ruby
27
27
  uses: ruby/setup-ruby@v1
28
28
  with:
@@ -11,7 +11,7 @@ jobs:
11
11
  name: Build and Publish
12
12
  runs-on: ubuntu-latest
13
13
  steps:
14
- - uses: actions/checkout@v3
14
+ - uses: actions/checkout@v4
15
15
  - name: Set up Ruby 3.0
16
16
  uses: actions/setup-ruby@v1
17
17
  with:
data/.simplycop.yml CHANGED
@@ -886,6 +886,7 @@ Naming/MethodParameterName:
886
886
  Enabled: true
887
887
  AllowedNames:
888
888
  - as
889
+ - at
889
890
  - ex
890
891
  - id
891
892
  - ip
@@ -917,6 +918,7 @@ Naming/VariableNumber:
917
918
  - rfc822
918
919
  - rfc2822
919
920
  - rfc3339
921
+ - s3
920
922
  - x86_64
921
923
  AllowedPatterns:
922
924
  - v\d+
data/.simplycop_rails.yml CHANGED
@@ -1,56 +1,399 @@
1
1
  require:
2
2
  - rubocop-rails
3
3
 
4
+ # Overridden in Chopin
5
+ Rails/ActionControllerFlashBeforeRender:
6
+ Enabled: true
7
+
8
+ Rails/ActionControllerTestCase:
9
+ Enabled: true
10
+
11
+ Rails/ActionFilter:
12
+ Enabled: true
13
+
14
+ # Overridden in Chopin
15
+ Rails/ActionOrder:
16
+ Enabled: true
17
+
18
+ Rails/ActiveRecordAliases:
19
+ Enabled: true
20
+
4
21
  Rails/ActiveRecordCallbacksOrder:
5
22
  Enabled: true
6
23
 
24
+ Rails/ActiveRecordOverride:
25
+ Enabled: true
26
+
27
+ Rails/ActiveSupportAliases:
28
+ Enabled: true
29
+
30
+ # Overridden in Chopin
31
+ Rails/ActiveSupportOnLoad:
32
+ Enabled: true
33
+
34
+ Rails/AddColumnIndex:
35
+ Enabled: true
36
+
7
37
  Rails/AfterCommitOverride:
8
38
  Enabled: true
9
39
 
40
+ Rails/ApplicationController:
41
+ Enabled: true
42
+
43
+ Rails/ApplicationJob:
44
+ Enabled: true
45
+
46
+ # Overridden in Chopin
47
+ Rails/ApplicationMailer:
48
+ Enabled: true
49
+
50
+ Rails/ApplicationRecord:
51
+ Enabled: true
52
+
53
+ Rails/ArelStar:
54
+ Enabled: true
55
+
56
+ Rails/AssertNot:
57
+ Enabled: true
58
+
10
59
  Rails/AttributeDefaultBlockValue:
11
60
  Enabled: true
12
61
 
62
+ Rails/BelongsTo:
63
+ Enabled: true
64
+
65
+ Rails/Blank:
66
+ Enabled: true
67
+
68
+ Rails/BulkChangeTable:
69
+ Enabled: true
70
+
71
+ # Overridden in Chopin
72
+ Rails/CompactBlank:
73
+ Enabled: true
74
+
75
+ # Overridden in Chopin
76
+ Rails/ContentTag:
77
+ Enabled: true
78
+
79
+ Rails/CreateTableWithTimestamps:
80
+ Enabled: true
81
+
82
+ Rails/DangerousColumnNames:
83
+ Enabled: true
84
+
85
+ Rails/Date:
86
+ Enabled: true
87
+
13
88
  Rails/DefaultScope:
14
89
  Enabled: true
15
90
 
16
91
  Rails/Delegate:
17
92
  Enabled: false
18
93
 
94
+ Rails/DelegateAllowBlank:
95
+ Enabled: true
96
+
97
+ # Overridden in Chopin
98
+ Rails/DeprecatedActiveModelErrorsMethods:
99
+ Enabled: true
100
+
101
+ Rails/DotSeparatedKeys:
102
+ Enabled: true
103
+
104
+ Rails/DuplicateAssociation:
105
+ Enabled: true
106
+
107
+ Rails/DuplicateScope:
108
+ Enabled: true
109
+
110
+ # Overridden in Chopin
111
+ Rails/DurationArithmetic:
112
+ Enabled: true
113
+
114
+ Rails/DynamicFindBy:
115
+ Enabled: false
116
+
117
+ Rails/EagerEvaluationLogMessage:
118
+ Enabled: true
119
+
120
+ Rails/EnumHash:
121
+ Enabled: true
122
+
123
+ Rails/EnumUniqueness:
124
+ Enabled: true
125
+
126
+ Rails/EnvironmentComparison:
127
+ Enabled: true
128
+
129
+ Rails/EnvironmentVariableAccess:
130
+ Enabled: false
131
+
132
+ Rails/Exit:
133
+ Enabled: true
134
+
135
+ Rails/ExpandedDateRange:
136
+ Enabled: true
137
+
138
+ Rails/FilePath:
139
+ Enabled: true
140
+
141
+ Rails/FindBy:
142
+ Enabled: true
143
+
19
144
  Rails/FindById:
20
145
  Enabled: true
21
146
 
147
+ Rails/FindEach:
148
+ Enabled: true
149
+
150
+ # Overridden in Chopin
151
+ Rails/FreezeTime:
152
+ Enabled: true
153
+
154
+ Rails/HasAndBelongsToMany:
155
+ Enabled: true
156
+
157
+ # Overridden in Chopin
158
+ Rails/HasManyOrHasOneDependent:
159
+ Enabled: true
160
+
161
+ Rails/HelperInstanceVariable:
162
+ Enabled: true
163
+
164
+ Rails/HttpPositionalArguments:
165
+ Enabled: true
166
+
167
+ Rails/HttpStatus:
168
+ Enabled: true
169
+
170
+ Rails/I18nLazyLookup:
171
+ Enabled: false
172
+
173
+ # Overridden in Chopin
174
+ Rails/I18nLocaleAssignment:
175
+ Enabled: true
176
+
177
+ # Overridden in Chopin
178
+ Rails/I18nLocaleTexts:
179
+ Enabled: true
180
+
181
+ # Overridden in Chopin
182
+ Rails/IgnoredColumnsAssignment:
183
+ Enabled: true
184
+
185
+ Rails/IgnoredSkipActionFilterOption:
186
+ Enabled: true
187
+
188
+ Rails/IndexBy:
189
+ Enabled: true
190
+
191
+ Rails/IndexWith:
192
+ Enabled: true
193
+
22
194
  Rails/Inquiry:
23
195
  Enabled: false
24
196
 
197
+ Rails/InverseOf:
198
+ Enabled: true
199
+
200
+ Rails/LexicallyScopedActionFilter:
201
+ Enabled: true
202
+
203
+ Rails/LinkToBlank:
204
+ Enabled: true
205
+
25
206
  Rails/MailerName:
26
207
  Enabled: true
27
208
 
28
209
  Rails/MatchRoute:
29
210
  Enabled: true
30
211
 
212
+ Rails/MigrationClassName:
213
+ Enabled: true
214
+
215
+ # Overridden in Chopin
31
216
  Rails/NegateInclude:
32
217
  Enabled: true
33
218
 
219
+ Rails/NotNullColumn:
220
+ Enabled: true
221
+
222
+ Rails/OrderById:
223
+ Enabled: false
224
+
225
+ Rails/Output:
226
+ Enabled: false
227
+
228
+ Rails/OutputSafety:
229
+ Enabled: false
230
+
231
+ Rails/Pick:
232
+ Enabled: true
233
+
34
234
  # Conflicts with Mongoid
35
235
  Rails/Pluck:
36
236
  Enabled: false
37
237
 
238
+ Rails/PluckId:
239
+ Enabled: false
240
+
38
241
  # Conflicts with Mongoid
39
242
  Rails/PluckInWhere:
40
243
  Enabled: false
41
244
 
245
+ Rails/PluralizationGrammar:
246
+ Enabled: true
247
+
248
+ Rails/Presence:
249
+ Enabled: true
250
+
251
+ Rails/Present:
252
+ Enabled: true
253
+
254
+ Rails/RakeEnvironment:
255
+ Enabled: true
256
+
257
+ Rails/ReadWriteAttribute:
258
+ Enabled: true
259
+
260
+ Rails/RedundantActiveRecordAllMethod:
261
+ Enabled: true
262
+
263
+ Rails/RedundantAllowNil:
264
+ Enabled: true
265
+
266
+ Rails/RedundantForeignKey:
267
+ Enabled: true
268
+
269
+ # Overridden in Chopin
270
+ Rails/RedundantPresenceValidationOnBelongsTo:
271
+ Enabled: true
272
+
273
+ Rails/RedundantReceiverInWithOptions:
274
+ Enabled: true
275
+
276
+ Rails/RedundantTravelBack:
277
+ Enabled: true
278
+
279
+ Rails/ReflectionClassName:
280
+ Enabled: true
281
+
282
+ Rails/RefuteMethods:
283
+ Enabled: false
284
+
285
+ # Overridden in Chopin
286
+ Rails/RelativeDateConstant:
287
+ Enabled: true
288
+
42
289
  Rails/RenderInline:
43
290
  Enabled: true
44
291
 
45
292
  Rails/RenderPlainText:
46
293
  Enabled: true
47
294
 
295
+ Rails/RequestReferer:
296
+ Enabled: false
297
+
298
+ Rails/RequireDependency:
299
+ Enabled: false
300
+
301
+ Rails/ResponseParsedBody:
302
+ Enabled: true
303
+
304
+ Rails/ReversibleMigration:
305
+ Enabled: true
306
+
307
+ Rails/ReversibleMigrationMethodDefinition:
308
+ Enabled: false
309
+
310
+ # Overridden in Chopin
311
+ Rails/RootJoinChain:
312
+ Enabled: true
313
+
314
+ # Overridden in Chopin
315
+ Rails/RootPathNameMethods:
316
+ Enabled: true
317
+
318
+ # Overridden in Chopin
319
+ Rails/RootPublicPath:
320
+ Enabled: true
321
+
322
+ Rails/SafeNavigation:
323
+ Enabled: true
324
+
325
+ Rails/SafeNavigationWithBlank:
326
+ Enabled: true
327
+
328
+ Rails/SaveBang:
329
+ Enabled: false
330
+
331
+ Rails/SchemaComment:
332
+ Enabled: false
333
+
334
+ Rails/ScopeArgs:
335
+ Enabled: true
336
+
337
+ Rails/SelectMap:
338
+ Enabled: true
339
+
48
340
  Rails/ShortI18n:
49
341
  Enabled: true
50
342
 
343
+ Rails/SkipsModelValidations:
344
+ Enabled: true
345
+
51
346
  Rails/SquishedSQLHeredocs:
52
347
  Enabled: true
53
348
 
349
+ # Overridden in Chopin
350
+ Rails/StripHeredoc:
351
+ Enabled: true
352
+
353
+ Rails/TableNameAssignment:
354
+ Enabled: false
355
+
356
+ Rails/ThreeStateBooleanColumn:
357
+ Enabled: false
358
+
359
+ Rails/TimeZone:
360
+ Enabled: true
361
+
362
+ # Overridden in Chopin
363
+ Rails/TimeZoneAssignment:
364
+ Enabled: true
365
+
366
+ Rails/ToFormattedS:
367
+ Enabled: false
368
+
369
+ Rails/ToSWithArgument:
370
+ Enabled: false
371
+
372
+ # Overridden in Chopin
373
+ Rails/TopLevelHashWithIndifferentAccess:
374
+ Enabled: true
375
+
376
+ Rails/TransactionExitStatement:
377
+ Enabled: true
378
+
379
+ Rails/UniqBeforePluck:
380
+ Enabled: true
381
+
382
+ Rails/UniqueValidationWithoutIndex:
383
+ Enabled: true
384
+
385
+ Rails/UnknownEnv:
386
+ Enabled: true
387
+
388
+ Rails/UnusedIgnoredColumns:
389
+ Enabled: true
390
+
391
+ Rails/UnusedRenderContent:
392
+ Enabled: true
393
+
394
+ Rails/Validation:
395
+ Enabled: true
396
+
54
397
  Rails/WhereEquals:
55
398
  Enabled: true
56
399
 
@@ -58,10 +401,18 @@ Rails/WhereEquals:
58
401
  Rails/WhereExists:
59
402
  Enabled: false
60
403
 
404
+ # Anticipate conflicts with Mongoid, like Rails/WhereExists
405
+ Rails/WhereMissing:
406
+ Enabled: false
407
+
61
408
  # Conflicts with Mongoid
62
409
  Rails/WhereNot:
63
410
  Enabled: false
64
411
 
412
+ # Anticipate conflicts with Mongoid, like Rails/WhereNot
413
+ Rails/WhereNotWithMultipleConditions:
414
+ Enabled: false
415
+
65
416
  Rails/ActionControllerTestCase: # new in 2.14
66
417
  Enabled: true
67
418
 
data/.simplycop_rspec.yml CHANGED
@@ -96,6 +96,12 @@ RSpec/EmptyLineAfterHook:
96
96
  RSpec/EmptyLineAfterSubject:
97
97
  Enabled: true
98
98
 
99
+ RSpec/EmptyMetadata:
100
+ Enabled: true
101
+
102
+ RSpec/Eq:
103
+ Enabled: true
104
+
99
105
  RSpec/ExampleLength:
100
106
  Enabled: false
101
107
 
@@ -120,9 +126,6 @@ RSpec/ExpectInHook:
120
126
  RSpec/ExpectOutput:
121
127
  Enabled: false
122
128
 
123
- RSpec/FilePath:
124
- Enabled: false
125
-
126
129
  RSpec/Focus:
127
130
  Enabled: true
128
131
 
@@ -182,6 +185,9 @@ RSpec/MessageChain:
182
185
  RSpec/MessageSpies:
183
186
  Enabled: false
184
187
 
188
+ RSpec/MetadataStyle:
189
+ Enabled: true
190
+
185
191
  RSpec/MissingExampleGroupArgument:
186
192
  Enabled: true
187
193
 
@@ -274,6 +280,12 @@ RSpec/SkipBlockInsideExample:
274
280
  RSpec/SortMetadata:
275
281
  Enabled: true
276
282
 
283
+ RSpec/SpecFilePathSuffix:
284
+ Enabled: false
285
+
286
+ RSpec/SpecFilePathFormat:
287
+ Enabled: false
288
+
277
289
  RSpec/StubbedMock:
278
290
  Enabled: false
279
291
 
@@ -308,10 +320,10 @@ RSpec/Capybara:
308
320
  Include:
309
321
  - spec/integration/*.rb
310
322
 
311
- Capybara/CurrentPathExpectation:
323
+ RSpec/Capybara/FeatureMethods:
312
324
  Enabled: true
313
325
 
314
- Capybara/FeatureMethods:
326
+ Capybara/CurrentPathExpectation:
315
327
  Enabled: true
316
328
 
317
329
  Capybara/MatchStyle:
@@ -331,6 +343,9 @@ Capybara/SpecificMatcher:
331
343
 
332
344
  # RSpec/FactoryBot
333
345
 
346
+ FactoryBot/AssociationStyle:
347
+ Enabled: true
348
+
334
349
  FactoryBot/AttributeDefinedStatically:
335
350
  Enabled: true
336
351
 
@@ -340,12 +355,18 @@ FactoryBot/ConsistentParenthesesStyle:
340
355
  FactoryBot/CreateList:
341
356
  Enabled: false
342
357
 
358
+ FactoryBot/FactoryAssociationWithStrategy:
359
+ Enabled: true
360
+
343
361
  FactoryBot/FactoryClassName:
344
362
  Enabled: true
345
363
 
346
364
  FactoryBot/FactoryNameStyle:
347
365
  Enabled: true
348
366
 
367
+ FactoryBot/RedundantFactoryOption:
368
+ Enabled: true
369
+
349
370
  # Prefer explicit factorybot call
350
371
  FactoryBot/SyntaxMethods:
351
372
  Enabled: false
@@ -7,5 +7,5 @@
7
7
  #
8
8
 
9
9
  module Simplycop
10
- VERSION = '1.13.9'
10
+ VERSION = '1.14.0'
11
11
  end
data/simplycop.gemspec CHANGED
@@ -17,10 +17,10 @@ Gem::Specification.new do |spec|
17
17
  spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
18
18
  spec.require_paths = ['lib']
19
19
 
20
- spec.add_dependency 'rubocop', '1.56.2'
20
+ spec.add_dependency 'rubocop', '1.56.3'
21
21
  spec.add_dependency 'rubocop-performance', '1.19.0'
22
- spec.add_dependency 'rubocop-rails', '2.20.2'
23
- spec.add_dependency 'rubocop-rspec', '2.23.2'
22
+ spec.add_dependency 'rubocop-rails', '2.21.1'
23
+ spec.add_dependency 'rubocop-rspec', '2.24.0'
24
24
  spec.add_development_dependency 'bundler', '>= 2.2.15'
25
25
  spec.add_development_dependency 'rake', '>= 12.3.3'
26
26
  spec.add_development_dependency 'rspec', '~> 3.10'
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: simplycop
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.13.9
4
+ version: 1.14.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Simply Business
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2023-09-08 00:00:00.000000000 Z
11
+ date: 2023-09-15 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rubocop
@@ -16,14 +16,14 @@ dependencies:
16
16
  requirements:
17
17
  - - '='
18
18
  - !ruby/object:Gem::Version
19
- version: 1.56.2
19
+ version: 1.56.3
20
20
  type: :runtime
21
21
  prerelease: false
22
22
  version_requirements: !ruby/object:Gem::Requirement
23
23
  requirements:
24
24
  - - '='
25
25
  - !ruby/object:Gem::Version
26
- version: 1.56.2
26
+ version: 1.56.3
27
27
  - !ruby/object:Gem::Dependency
28
28
  name: rubocop-performance
29
29
  requirement: !ruby/object:Gem::Requirement
@@ -44,28 +44,28 @@ dependencies:
44
44
  requirements:
45
45
  - - '='
46
46
  - !ruby/object:Gem::Version
47
- version: 2.20.2
47
+ version: 2.21.1
48
48
  type: :runtime
49
49
  prerelease: false
50
50
  version_requirements: !ruby/object:Gem::Requirement
51
51
  requirements:
52
52
  - - '='
53
53
  - !ruby/object:Gem::Version
54
- version: 2.20.2
54
+ version: 2.21.1
55
55
  - !ruby/object:Gem::Dependency
56
56
  name: rubocop-rspec
57
57
  requirement: !ruby/object:Gem::Requirement
58
58
  requirements:
59
59
  - - '='
60
60
  - !ruby/object:Gem::Version
61
- version: 2.23.2
61
+ version: 2.24.0
62
62
  type: :runtime
63
63
  prerelease: false
64
64
  version_requirements: !ruby/object:Gem::Requirement
65
65
  requirements:
66
66
  - - '='
67
67
  - !ruby/object:Gem::Version
68
- version: 2.23.2
68
+ version: 2.24.0
69
69
  - !ruby/object:Gem::Dependency
70
70
  name: bundler
71
71
  requirement: !ruby/object:Gem::Requirement