simplycop 1.13.5 → 1.13.8

Sign up to get free protection for your applications and to get access to all the features.
data/.simplycop.yml CHANGED
@@ -31,8 +31,8 @@ Bundler/GemFilename:
31
31
  Enabled: true
32
32
 
33
33
  # To discuss: Suggest true but 103 fails on Chopin, 10 on Rater
34
- # Bundler/GemVersion:
35
- # Enabled: true
34
+ Bundler/GemVersion:
35
+ Enabled: false
36
36
 
37
37
  Bundler/InsecureProtocolSource:
38
38
  Enabled: true
@@ -41,16 +41,16 @@ Bundler/OrderedGems:
41
41
  Enabled: true
42
42
 
43
43
  # To discuss: Suggest true but 3 fails on Chopin, 21 on Rater
44
- # Gemspec/DependencyVersion:
45
- # Enabled: true
44
+ Gemspec/DependencyVersion:
45
+ Enabled: false
46
46
 
47
47
  # TODO: 1 autocorrectable in Rater and it would pass
48
- # Gemspec/DeprecatedAttributeAssignment:
49
- # Enabled: true
48
+ Gemspec/DeprecatedAttributeAssignment:
49
+ Enabled: true
50
50
 
51
- # To discuss: Suggest true but 2 fails on Chopin, 10 on Rater
52
- # Gemspec/DevelopmentDependencies:
53
- # Enabled: true
51
+ # 2 fails on Chopin, 10 on Rater, so override if necessary
52
+ Gemspec/DevelopmentDependencies:
53
+ Enabled: false
54
54
 
55
55
  Gemspec/DuplicatedAssignment:
56
56
  Enabled: true
@@ -59,12 +59,12 @@ Gemspec/OrderedDependencies:
59
59
  Enabled: true
60
60
 
61
61
  # TODO: Suggest true but 4 fails on Chopin, 3 on Rater, overridden to false on Chopin
62
- # Gemspec/RequireMFA:
63
- # Enabled: true
62
+ Gemspec/RequireMFA:
63
+ Enabled: false
64
64
 
65
- # TODO: Suggest true but 3 fails on Chopin
66
- # Gemspec/RequiredRubyVersion:
67
- # Enabled: true
65
+ # Will need Chopin override
66
+ Gemspec/RequiredRubyVersion:
67
+ Enabled: true
68
68
 
69
69
  Gemspec/RubyVersionGlobalsUsage:
70
70
  Enabled: true
@@ -94,8 +94,9 @@ Layout/CaseIndentation:
94
94
  Enabled: true
95
95
 
96
96
  # Discussion needed about preferred structure. Dozens of fails on each repo if we stick with default, all but 4 on Chopin are autocorrectable
97
- # Layout/ClassStructure:
98
- # Enabled: true
97
+ # Worth agreeing a style?
98
+ Layout/ClassStructure:
99
+ Enabled: false
99
100
 
100
101
  Layout/ClosingHeredocIndentation:
101
102
  Enabled: true
@@ -124,9 +125,9 @@ Layout/EmptyComment:
124
125
  Layout/EmptyLineAfterGuardClause:
125
126
  Enabled: true
126
127
 
127
- # To discuss. Suggest should be true but 500+ autocorrectable fails on Chopin. None on others
128
- # Layout/EmptyLineAfterMagicComment:
129
- # Enabled: true
128
+ # Needs Chopin override
129
+ Layout/EmptyLineAfterMagicComment:
130
+ Enabled: true
130
131
 
131
132
  Layout/EmptyLineAfterMultilineCondition:
132
133
  Enabled: true
@@ -182,22 +183,18 @@ Layout/FirstArrayElementIndentation:
182
183
  Layout/FirstArrayElementLineBreak:
183
184
  Enabled: true
184
185
 
185
- Layout/FirstMethodArgumentLineBreak:
186
- Enabled: true
187
-
188
186
  Layout/FirstHashElementIndentation:
189
187
  Enabled: true
190
188
 
191
189
  Layout/FirstHashElementLineBreak:
192
190
  Enabled: true
193
191
 
194
- # To discuss - 200+ fails on CoCo, none elsewhere
195
- # Layout/FirstMethodArgumentLineBreak:
196
- # Enabled: true
192
+ Layout/FirstMethodArgumentLineBreak:
193
+ Enabled: true
197
194
 
198
- # To discuss - 100+ fails on Chopin, handful on others
199
- # Layout/FirstMethodParameterLineBreak:
200
- # Enabled: true
195
+ # Needs Chopin override
196
+ Layout/FirstMethodParameterLineBreak:
197
+ Enabled: true
201
198
 
202
199
  Layout/FirstParameterIndentation:
203
200
  Enabled: true
@@ -242,18 +239,19 @@ Layout/LineEndStringConcatenationIndentation:
242
239
  Enabled: true
243
240
 
244
241
  # To discuss: configure line length? At default 120: 6805 fails on Chopin, 3 on Rater, 179 on CoCo
245
- # Layout/LineLength
246
- # Enabled: false
242
+ # Typically overridden/"to-do"-ed
243
+ Layout/LineLength:
244
+ Enabled: true
245
+
247
246
  Layout/MultilineArrayBraceLayout:
248
247
  Enabled: true
249
248
 
250
- # To discuss: 100s of fails on each repo but autocorrectable
251
- # Layout/MultilineArrayLineBreaks:
252
- # Enabled: true
249
+ Layout/MultilineArrayLineBreaks:
250
+ Enabled: true
253
251
 
254
252
  # To discuss: 100s of fails on each repo but autocorrectable
255
- # Layout/MultilineAssignmentLayout:
256
- # Enabled: true
253
+ Layout/MultilineAssignmentLayout:
254
+ Enabled: false
257
255
 
258
256
  Layout/MultilineBlockLayout:
259
257
  Enabled: true
@@ -261,13 +259,13 @@ Layout/MultilineBlockLayout:
261
259
  Layout/MultilineHashBraceLayout:
262
260
  Enabled: true
263
261
 
264
- # To discuss: 100s of fails on each repo but autocorrectable
265
- # Layout/MultilineHashKeyLineBreaks:
266
- # Enabled: true
262
+ # To discuss: 100s of fails on each repo but autocorrectable gp
263
+ Layout/MultilineHashKeyLineBreaks:
264
+ Enabled: false
267
265
 
268
266
  # To discuss: 1000s of fails on each repo but autocorrectable
269
- # Layout/MultilineMethodArgumentLineBreaks:
270
- # Enabled: true
267
+ Layout/MultilineMethodArgumentLineBreaks:
268
+ Enabled: false
271
269
 
272
270
  Layout/MultilineMethodCallBraceLayout:
273
271
  Enabled: true
@@ -279,8 +277,8 @@ Layout/MultilineMethodDefinitionBraceLayout:
279
277
  Enabled: true
280
278
 
281
279
  # To discuss: 100s of fails on each repo but autocorrectable
282
- # Layout/MultilineMethodParameterLineBreaks:
283
- # Enabled: true
280
+ Layout/MultilineMethodParameterLineBreaks:
281
+ Enabled: false
284
282
 
285
283
  Layout/MultilineOperationIndentation:
286
284
  Enabled: true
@@ -289,15 +287,15 @@ Layout/ParameterAlignment:
289
287
  Enabled: true
290
288
 
291
289
  # For discussion: 1000s of fails, all autocorrectable
292
- # Layout/RedundantLineBreak:
293
- # Enabled: true
290
+ Layout/RedundantLineBreak:
291
+ Enabled: false
294
292
 
295
293
  Layout/RescueEnsureAlignment:
296
294
  Enabled: true
297
295
 
298
296
  # For discussion: 1000s of fails, all autocorrectable
299
- # Layout/SingleLineBlockChain:
300
- # Enabled: true
297
+ Layout/SingleLineBlockChain:
298
+ Enabled: false
301
299
 
302
300
  Layout/SpaceAfterColon:
303
301
  Enabled: true
@@ -402,8 +400,8 @@ Lint/AmbiguousRange:
402
400
  Enabled: true
403
401
 
404
402
  # TODO: One fail on rater spec then would pass
405
- # Lint/AmbiguousRegexpLiteral:
406
- # Enabled: true
403
+ Lint/AmbiguousRegexpLiteral:
404
+ Enabled: true
407
405
 
408
406
  Lint/AssignmentInCondition:
409
407
  Enabled: true
@@ -421,8 +419,8 @@ Lint/CircularArgumentReference:
421
419
  Enabled: true
422
420
 
423
421
  # TODO: 6 fails in Rater, otherwise clear
424
- # Lint/ConstantDefinitionInBlock:
425
- # Enabled: true
422
+ Lint/ConstantDefinitionInBlock:
423
+ Enabled: true
426
424
 
427
425
  Lint/ConstantOverwrittenInRescue: # new in 1.31
428
426
  Enabled: true
@@ -481,9 +479,8 @@ Lint/DuplicateRescueException:
481
479
  Lint/EachWithObjectArgument:
482
480
  Enabled: true
483
481
 
484
- # TODO: 19 autocorrectable odd else layouts in Rater
485
- # Lint/ElseLayout:
486
- # Enabled: true
482
+ Lint/ElseLayout:
483
+ Enabled: true
487
484
 
488
485
  Lint/EmptyBlock:
489
486
  Enabled: true
@@ -542,9 +539,9 @@ Lint/ImplicitStringConcatenation:
542
539
  Lint/IncompatibleIoSelectWithFiberScheduler: # new in 1.21
543
540
  Enabled: true
544
541
 
545
- # TODO: two fails on Rater, one on CoCo, otherwise fine to enable
546
- # Lint/IneffectiveAccessModifier:
547
- # Enabled: true
542
+ # TODO: two fails on Rater, one on CoCo, otherwise fine
543
+ Lint/IneffectiveAccessModifier:
544
+ Enabled: true
548
545
 
549
546
  Lint/InheritException:
550
547
  Enabled: true
@@ -568,8 +565,11 @@ Lint/MissingCopEnableDirective:
568
565
  Enabled: true
569
566
 
570
567
  # TODO: Handful of errors on Rater and CoCo
571
- # Lint/MissingSuper:
572
- # Enabled: true
568
+ Lint/MissingSuper:
569
+ Enabled: true
570
+
571
+ Lint/MixedCaseRange:
572
+ Enabled: true
573
573
 
574
574
  Lint/MixedRegexpCaptureTypes:
575
575
  Enabled: true
@@ -599,9 +599,8 @@ Lint/NonDeterministicRequireOrder:
599
599
  Lint/NonLocalExitFromIterator:
600
600
  Enabled: true
601
601
 
602
- # 100s of fails on Rater and Chopin
603
- # Lint/NumberConversion:
604
- # Enabled: true
602
+ Lint/NumberConversion:
603
+ Enabled: false
605
604
 
606
605
  Lint/NumberedParameterAssignment:
607
606
  Enabled: true
@@ -630,17 +629,18 @@ Lint/RaiseException:
630
629
  Lint/RandOne:
631
630
  Enabled: true
632
631
 
633
- # Can't be checked with --only, enable once Rater and Chopin up to date with Simplycop
634
- # Lint/RedundantCopDisableDirective:
635
- # Enabled: true
632
+ Lint/RedundantCopDisableDirective:
633
+ Enabled: true
636
634
 
637
- # Can't be checked with --only, enable once Rater and Chopin up to date with Simplycop
638
- # Lint/RedundantCopEnableDirective:
639
- # Enabled: true
635
+ Lint/RedundantCopEnableDirective:
636
+ Enabled: true
640
637
 
641
638
  Lint/RedundantDirGlobSort:
642
639
  Enabled: true
643
640
 
641
+ Lint/RedundantRegexpQuantifiers:
642
+ Enabled: true
643
+
644
644
  Lint/RedundantRequireStatement:
645
645
  Enabled: true
646
646
 
@@ -708,9 +708,9 @@ Lint/ShadowedArgument:
708
708
  Lint/ShadowedException:
709
709
  Enabled: true
710
710
 
711
- # To discuss: 63 offences on Chopin, none on Rater, CoCo
712
- # Lint/ShadowingOuterLocalVariable:
713
- # Enabled: true
711
+ # Needs Chopin override
712
+ Lint/ShadowingOuterLocalVariable:
713
+ Enabled: true
714
714
 
715
715
  Lint/StructNewOverride:
716
716
  Enabled: true
@@ -782,8 +782,8 @@ Lint/UselessMethodDefinition:
782
782
  Enabled: true
783
783
 
784
784
  # TODO: Single fail on Chopin
785
- # Lint/UselessRescue:
786
- # Enabled: true
785
+ Lint/UselessRescue:
786
+ Enabled: true
787
787
 
788
788
  Lint/UselessRuby2Keywords:
789
789
  Enabled: true
@@ -841,9 +841,9 @@ Metrics/PerceivedComplexity:
841
841
  Migration/DepartmentName:
842
842
  Enabled: true
843
843
 
844
- # Suggest true but causes 17 fails in Chopin, 6 in Rater, 2 in CoCo
845
- # Naming/AccessorMethodName:
846
- # Enabled: true
844
+ # Needs override or fix in Chopin
845
+ Naming/AccessorMethodName:
846
+ Enabled: true
847
847
 
848
848
  Naming/AsciiIdentifiers:
849
849
  Enabled: true
@@ -875,55 +875,64 @@ Naming/HeredocDelimiterNaming:
875
875
  Naming/InclusiveLanguage:
876
876
  Enabled: true
877
877
 
878
- # To discuss: suggest true but 86 fails on Chopin
879
- # Naming/MemoizedInstanceVariableName:
880
- # Enabled: true
878
+ # Need override - 86 fails on Chopin
879
+ Naming/MemoizedInstanceVariableName:
880
+ Enabled: true
881
881
 
882
882
  Naming/MethodName:
883
883
  Enabled: true
884
884
 
885
- # To discuss: suggest true with possible allowed exceptions as below (10 fails on Chopin, exceptions would allow 4,
886
- # as and to are already exceptions in Rater so would remove need to configure there)
887
- # Naming/MethodParameterName:
888
- # Enabled: true
889
- # AllowedNames:
890
- # - as
891
- # - ex
892
- # - n
893
- # - to
885
+ Naming/MethodParameterName:
886
+ Enabled: true
887
+ AllowedNames:
888
+ - as
889
+ - ex
890
+ - id
891
+ - n
892
+ - to
894
893
 
895
894
  # To discuss: suggest true but 52 fails in Chopin, 8 in Coco (consider with Naming/AccessorName)
896
- # Naming/PredicateName:
897
- # Enabled: true
895
+ Naming/PredicateName:
896
+ Enabled: false
898
897
 
899
- # To discuss: Should decide on a style. Default e instead of err causes 47 fails on Chopin, none on Rater, CoCo
900
- # Naming/RescuedExceptionsVariableName:
901
- # Enabled: true
898
+ # Need Chopin override
899
+ Naming/RescuedExceptionsVariableName:
900
+ Enabled: true
902
901
 
903
902
  Naming/VariableName:
904
903
  Enabled: true
905
904
 
906
- # To discuss: suggest enforce snake_case as this seems to be the preferred style
907
- # Default normalcase causes
908
- # Naming/VariableNumber:
909
- # Enabled: true
910
- # EnforcedStyle: snake_case
911
-
905
+ # snake_case: 311 fails on Chopin, normalcase: 1118 fails on Chopin
906
+ # snake_case default on Rater so make default in simplycop
907
+ Naming/VariableNumber:
908
+ Enabled: true
909
+ EnforcedStyle: snake_case
910
+ AllowedIdentifiers:
911
+ - capture3
912
+ - iso8601
913
+ - oauth2
914
+ - rfc1123_date
915
+ - rfc822
916
+ - rfc2822
917
+ - rfc3339
918
+ - x86_64
919
+
912
920
  # Overridden to false in Chopin
913
921
  Security/CompoundHash:
914
922
  Enabled: true
915
923
 
916
- # Should probably be set to true but 13 offences in chopin spec
917
- # Security/Eval:
918
- # Enabled: true
924
+ Security/Eval:
925
+ Enabled: true
926
+ Exclude:
927
+ - 'spec/**/*.rb'
919
928
 
920
929
  # Overridden to false on Chopin
921
930
  Security/IoMethods:
922
931
  Enabled: true
923
932
 
924
- # Should probably be set to true but 18 offences in chopin spec
925
- # Security/JSONLoad:
926
- # Enabled: true
933
+ # Needs override in chopin spec
934
+ Security/JSONLoad:
935
+ Enabled: true
927
936
 
928
937
  Security/MarshalLoad:
929
938
  Enabled: true
@@ -931,9 +940,8 @@ Security/MarshalLoad:
931
940
  Security/Open:
932
941
  Enabled: true
933
942
 
934
- # Two fails on ContinuousCover, others fine
935
- # Security/YAMLLoad:
936
- # Enabled: true
943
+ Security/YAMLLoad:
944
+ Enabled: true
937
945
 
938
946
  Style/AccessModifierDeclarations:
939
947
  Enabled: false
@@ -970,11 +978,11 @@ Style/Attr:
970
978
  Enabled: true
971
979
 
972
980
  # Requires fixes in Chopin and Rater
973
- # Style/AutoResourceCleanup:
974
- # Enabled: true
981
+ Style/AutoResourceCleanup:
982
+ Enabled: true
975
983
 
976
- # Requires discussion
977
- # Style/BarePercentLiterals:
984
+ Style/BarePercentLiterals:
985
+ Enabled: true
978
986
 
979
987
  Style/BeginBlock:
980
988
  Enabled: true
@@ -985,8 +993,11 @@ Style/BisectedAttrAccessor:
985
993
  Style/BlockComments:
986
994
  Enabled: true
987
995
 
988
- # Requires discussion - 1000+ offences in Chopin alone, unless options set
989
- # Style/BlockDelimiters:
996
+ # Enabled by default and used in Rater so made explicit here
997
+ # However, overridden by Chopin to do file and proposal to use semantic style:
998
+ # See #technical-excellence-community discussion 28/02/23
999
+ Style/BlockDelimiters:
1000
+ Enabled: true
990
1001
 
991
1002
  Style/CaseEquality:
992
1003
  Enabled: true
@@ -997,8 +1008,10 @@ Style/CaseLikeIf:
997
1008
  Style/CharacterLiteral:
998
1009
  Enabled: true
999
1010
 
1000
- # Requires discussion
1001
- # Style/ClassAndModuleChildren:
1011
+ Style/ClassAndModuleChildren:
1012
+ Enabled: true
1013
+ Exclude:
1014
+ - spec/**/*.rb
1002
1015
 
1003
1016
  Style/ClassCheck:
1004
1017
  Enabled: true
@@ -1009,9 +1022,9 @@ Style/ClassEqualityComparison:
1009
1022
  Style/ClassMethods:
1010
1023
  Enabled: true
1011
1024
 
1012
- # Requires discussion - multiple fails on Chopin/Rater/CoCo when left at default
1013
- # Style/ClassMethodsDefinitions:
1014
- # Enabled: true
1025
+ # Requires discussion - multiple fails on Chopin/Rater/CoCo when set true with default
1026
+ Style/ClassMethodsDefinitions:
1027
+ Enabled: false
1015
1028
 
1016
1029
  Style/ClassVars:
1017
1030
  Enabled: true
@@ -1019,8 +1032,9 @@ Style/ClassVars:
1019
1032
  Style/CollectionCompact:
1020
1033
  Enabled: true
1021
1034
 
1022
- # Requires discussion - multiple fails on Chopin/Rater/CoCo when left at default
1023
- # Style/CollectionMethods:
1035
+ # Requires discussion - multiple fails on Chopin/Rater/CoCo when set true with default
1036
+ Style/CollectionMethods:
1037
+ Enabled: false
1024
1038
 
1025
1039
  Style/ColonMethodCall:
1026
1040
  Enabled: true
@@ -1052,17 +1066,19 @@ Style/ConditionalAssignment:
1052
1066
  Enabled: true
1053
1067
 
1054
1068
  # Requires discussion - 1000+ offences in Chopin alone, unless options set
1055
- # Style/ConstantVisibility:
1069
+ Style/ConstantVisibility:
1070
+ Enabled: false
1056
1071
 
1057
1072
  # For discussion
1058
- # Style/Copyright:
1073
+ Style/Copyright:
1074
+ Enabled: false
1059
1075
 
1060
1076
  Style/DataInheritance:
1061
1077
  Enabled: true
1062
1078
 
1063
1079
  # Requires discussion - multiple fails on Chopin/Rater/CoCo if true
1064
- # Style/DateTime:
1065
- # Enabled: false
1080
+ Style/DateTime:
1081
+ Enabled: false
1066
1082
 
1067
1083
  Style/DefWithParentheses:
1068
1084
  Enabled: true
@@ -1074,7 +1090,8 @@ Style/DirEmpty:
1074
1090
  Enabled: true
1075
1091
 
1076
1092
  # For discussion - - multiple fails on Chopin/Rater/CoCo
1077
- # Style/DisableCopsWithinSourceCodeDirective:
1093
+ Style/DisableCopsWithinSourceCodeDirective:
1094
+ Enabled: false
1078
1095
 
1079
1096
  Style/DocumentDynamicEvalDefinition:
1080
1097
  Enabled: false
@@ -1083,8 +1100,8 @@ Style/Documentation:
1083
1100
  Enabled: false
1084
1101
 
1085
1102
  # Requires discussion - suggest false as 7000+ offences in Chopin alone
1086
- # Style/DocumentationMethod:
1087
- # Enabled: false
1103
+ Style/DocumentationMethod:
1104
+ Enabled: false
1088
1105
 
1089
1106
  Style/DoubleCopDisableDirective:
1090
1107
  Enabled: true
@@ -1092,9 +1109,9 @@ Style/DoubleCopDisableDirective:
1092
1109
  Style/DoubleNegation:
1093
1110
  Enabled: true
1094
1111
 
1095
- # Suggest true but 100+ fails on Rater, none on Chopin or CoCo
1096
- # Style/EachForSimpleLoop:
1097
- # Enabled: true
1112
+ # Need override in Rater
1113
+ Style/EachForSimpleLoop:
1114
+ Enabled: true
1098
1115
 
1099
1116
  Style/EachWithObject:
1100
1117
  Enabled: true
@@ -1108,7 +1125,7 @@ Style/EmptyCaseCondition:
1108
1125
  Style/EmptyElse:
1109
1126
  Enabled: true
1110
1127
 
1111
- Style/EmptyHeredoc: # new in 1.32
1128
+ Style/EmptyHeredoc:
1112
1129
  Enabled: true
1113
1130
 
1114
1131
  Style/EmptyLambdaParameter:
@@ -1233,28 +1250,28 @@ Style/IfWithSemicolon:
1233
1250
  Enabled: true
1234
1251
 
1235
1252
  # For dicussion - 100s of fails on Chopin, CoCo, Rater
1236
- # Style/ImplicitRuntimeError:
1237
- # Enabled: false
1253
+ Style/ImplicitRuntimeError:
1254
+ Enabled: false
1238
1255
 
1239
1256
  Style/InfiniteLoop:
1240
1257
  Enabled: true
1241
1258
 
1242
- # For discussion - suggest false as 1000s of fails
1243
- # Style/InlineComment:
1244
- # Enabled: false
1259
+ Style/InlineComment:
1260
+ Enabled: false
1245
1261
 
1246
1262
  Style/InverseMethods:
1247
1263
  Enabled: true
1248
1264
 
1249
- # Manageable number of fails on Chopin, CoCo, Rater, suggest true
1250
- # Style/InvertibleUnlessCondition:
1251
- # Enabled: true
1265
+ Style/InvertibleUnlessCondition:
1266
+ Enabled: true
1252
1267
 
1253
1268
  Style/InPatternThen: # new in 1.16
1254
1269
  Enabled: true
1255
1270
 
1256
- # For discussion - multiple fails but most could be solved by excluding spec files
1257
- # Style/IpAddresses:
1271
+ # For discussion - disabled by default but could be enabled
1272
+ # and mostly solved by excluding spec files
1273
+ Style/IpAddresses:
1274
+ Enabled: false
1258
1275
  # Enabled: true
1259
1276
  # Exclude: [*spec.rb]
1260
1277
 
@@ -1284,16 +1301,16 @@ Style/MapToHash:
1284
1301
  Style/MapToSet:
1285
1302
  Enabled: true
1286
1303
 
1287
- # For discussion - 1000s of fails, suggest false
1288
- # Style/MethodCallWithArgsParentheses:
1289
- # Enabled: false
1304
+ # For discussion - 1000s of fails if set true
1305
+ Style/MethodCallWithArgsParentheses:
1306
+ Enabled: false
1290
1307
 
1291
1308
  Style/MethodCallWithoutArgsParentheses:
1292
1309
  Enabled: false
1293
1310
 
1294
- # For discussion - 100s of fails, suggest false
1295
- # Style/MethodCalledOnDoEndBlock:
1296
- # Enabled: false
1311
+ # For discussion - 100s of fails if set true
1312
+ Style/MethodCalledOnDoEndBlock:
1313
+ Enabled: false
1297
1314
 
1298
1315
  Style/MethodDefParentheses:
1299
1316
  Enabled: true
@@ -1305,9 +1322,8 @@ Style/MinMax:
1305
1322
  Style/MinMaxComparison:
1306
1323
  Enabled: true
1307
1324
 
1308
- # For discussion - 100s of fails with default true
1309
- # Style/MissingElse:
1310
- # Enabled: true
1325
+ Style/MissingElse:
1326
+ Enabled: false
1311
1327
 
1312
1328
  Style/MissingRespondToMissing:
1313
1329
  Enabled: true
@@ -1337,8 +1353,8 @@ Style/MultilineMemoization:
1337
1353
  Enabled: true
1338
1354
 
1339
1355
  # For discussion - suggest true, but 100s of fails in Chopin and handful in CoCo
1340
- # Style/MultilineMethodSignature:
1341
- # Enabled: true
1356
+ Style/MultilineMethodSignature:
1357
+ Enabled: false
1342
1358
 
1343
1359
  Style/MultilineTernaryOperator:
1344
1360
  Enabled: true
@@ -1364,7 +1380,7 @@ Style/NegatedUnless:
1364
1380
  Style/NegatedWhile:
1365
1381
  Enabled: true
1366
1382
 
1367
- Style/NestedFileDirname: # new in 1.26
1383
+ Style/NestedFileDirname:
1368
1384
  Enabled: true
1369
1385
 
1370
1386
  Style/NestedModifier:
@@ -1391,10 +1407,10 @@ Style/NonNilCheck:
1391
1407
  Style/Not:
1392
1408
  Enabled: true
1393
1409
 
1394
- Style/NumberedParameters: # new in 1.22
1410
+ Style/NumberedParameters:
1395
1411
  Enabled: true
1396
1412
 
1397
- Style/NumberedParametersLimit: # new in 1.22
1413
+ Style/NumberedParametersLimit:
1398
1414
  Enabled: true
1399
1415
 
1400
1416
  Style/NumericLiteralPrefix:
@@ -1406,7 +1422,7 @@ Style/NumericLiterals:
1406
1422
  Style/NumericPredicate:
1407
1423
  Enabled: false
1408
1424
 
1409
- Style/ObjectThen: # new in 1.28
1425
+ Style/ObjectThen:
1410
1426
  Enabled: true
1411
1427
 
1412
1428
  Style/OneLineConditional:
@@ -1452,7 +1468,7 @@ Style/PreferredHashMethods:
1452
1468
  Style/Proc:
1453
1469
  Enabled: true
1454
1470
 
1455
- # Overridden to false in Chopin
1471
+ # Overridden to false in Chopin and Rater
1456
1472
  Style/QuotedSymbols:
1457
1473
  Enabled: true
1458
1474
 
@@ -1465,6 +1481,9 @@ Style/RandomWithOffset:
1465
1481
  Style/RedundantArgument:
1466
1482
  Enabled: false
1467
1483
 
1484
+ Style/RedundantArrayConstructor:
1485
+ Enabled: true
1486
+
1468
1487
  Style/RedundantAssignment:
1469
1488
  Enabled: true
1470
1489
 
@@ -1483,6 +1502,9 @@ Style/RedundantConditional:
1483
1502
  Style/RedundantConstantBase:
1484
1503
  Enabled: false
1485
1504
 
1505
+ Style/RedundantCurrentDirectoryInPath:
1506
+ Enabled: false
1507
+
1486
1508
  Style/RedundantDoubleSplatHashBraces:
1487
1509
  Enabled: true
1488
1510
 
@@ -1498,6 +1520,9 @@ Style/RedundantFetchBlock:
1498
1520
  Style/RedundantFileExtensionInRequire:
1499
1521
  Enabled: true
1500
1522
 
1523
+ Style/RedundantFilterChain:
1524
+ Enabled: true
1525
+
1501
1526
  Style/RedundantFreeze:
1502
1527
  Enabled: true
1503
1528
 
@@ -1519,9 +1544,15 @@ Style/RedundantParentheses:
1519
1544
  Style/RedundantPercentQ:
1520
1545
  Enabled: true
1521
1546
 
1547
+ Style/RedundantRegexpArgument:
1548
+ Enabled: true
1549
+
1522
1550
  Style/RedundantRegexpCharacterClass:
1523
1551
  Enabled: true
1524
1552
 
1553
+ Style/RedundantRegexpConstructor:
1554
+ Enabled: true
1555
+
1525
1556
  Style/RedundantRegexpEscape:
1526
1557
  Enabled: true
1527
1558
 
@@ -1549,13 +1580,12 @@ Style/RedundantSortBy:
1549
1580
  Style/RedundantStringEscape:
1550
1581
  Enabled: true
1551
1582
 
1552
- # For discussion - CoCo, Rater OK, manageable amount of autocorrectable in Chopin if set true
1553
- # Style/RegexpLiteral:
1554
- # Enabled: true
1583
+ Style/RegexpLiteral:
1584
+ Enabled: true
1555
1585
 
1556
- # For discussion - dozens of fails, suggest false as autocorrect also unsafe
1557
- # Style/RequireOrder:
1558
- # Enabled: false
1586
+ # For discussion - would improve legibility if set true
1587
+ Style/RequireOrder:
1588
+ Enabled: false
1559
1589
 
1560
1590
  Style/RescueModifier:
1561
1591
  Enabled: true
@@ -1563,9 +1593,13 @@ Style/RescueModifier:
1563
1593
  Style/RescueStandardError:
1564
1594
  Enabled: true
1565
1595
 
1566
- # For discussion - suggest false as fails in all three if set true
1567
- # Style/ReturnNil:
1568
- # Enabled: false
1596
+ # For discussion - agreed configuration would be nice
1597
+ Style/ReturnNil:
1598
+ Enabled: false
1599
+
1600
+ # For discussion - as ReturnNil agreed configuration would be nice
1601
+ Style/ReturnNilInPredicateMethodDefinition:
1602
+ Enabled: false
1569
1603
 
1570
1604
  Style/SafeNavigation:
1571
1605
  Enabled: false
@@ -1583,9 +1617,8 @@ Style/SelfAssignment:
1583
1617
  Style/Semicolon:
1584
1618
  Enabled: true
1585
1619
 
1586
- # For discussion - 100s of fails on Chopin, some on CoCo
1587
- # Style/Send:
1588
- # Enabled: true
1620
+ Style/Send:
1621
+ Enabled: false
1589
1622
 
1590
1623
  Style/SignalException:
1591
1624
  Enabled: true
@@ -1614,9 +1647,9 @@ Style/SpecialGlobalVars:
1614
1647
  Style/StabbyLambdaParentheses:
1615
1648
  Enabled: true
1616
1649
 
1617
- # For discussion - 100s of fails across Rater, Chopin, CoCo, so suggest false
1618
- # Style/StaticClass:
1619
- # Enabled: false
1650
+ # Unsafe autocorrect and many fails on multiple repos
1651
+ Style/StaticClass:
1652
+ Enabled: false
1620
1653
 
1621
1654
  # TODO: Small number of autocorrects in Chopin
1622
1655
  Style/StderrPuts:
@@ -1628,9 +1661,8 @@ Style/StringChars:
1628
1661
  Style/StringConcatenation:
1629
1662
  Enabled: true
1630
1663
 
1631
- # For discussion - 10000s of fails in Chopin and Rater so suggest false
1632
- # Style/StringHashKeys:
1633
- # Enabled: false
1664
+ Style/StringHashKeys:
1665
+ Enabled: false
1634
1666
 
1635
1667
  Style/StringLiterals:
1636
1668
  Enabled: false
@@ -1663,8 +1695,8 @@ Style/TernaryParentheses:
1663
1695
  Enabled: true
1664
1696
 
1665
1697
  # For discussion - suggest should be true or at least warn but large number of fails on repos
1666
- # Style/TopLevelMethodDefinition:
1667
- # Enabled: true
1698
+ Style/TopLevelMethodDefinition:
1699
+ Enabled: false
1668
1700
 
1669
1701
  Style/TrailingBodyOnClass:
1670
1702
  Enabled: true
@@ -1675,20 +1707,20 @@ Style/TrailingBodyOnMethodDefinition:
1675
1707
  Style/TrailingBodyOnModule:
1676
1708
  Enabled: true
1677
1709
 
1678
- # For discussion - 100s of fails on Chopin, none on others
1679
- # Style/TrailingCommaInArguments:
1680
- # Enabled: true
1710
+ # Will require Chopin override
1711
+ Style/TrailingCommaInArguments:
1712
+ Enabled: true
1681
1713
 
1682
- # For discussion - 72 fails on Chopin, none on others
1683
- # Style/TrailingCommaInArrayLiteral:
1684
- # Enabled: true
1714
+ # Will require Chopin override
1715
+ Style/TrailingCommaInArrayLiteral:
1716
+ Enabled: true
1685
1717
 
1686
1718
  Style/TrailingCommaInBlockArgs:
1687
1719
  Enabled: true
1688
1720
 
1689
- # For discussion - 100s of fails on Chopin and Coco, none on Rater
1690
- # Style/TrailingCommaInHashLiteral:
1691
- # Enabled: true
1721
+ # Will require Chopin override
1722
+ Style/TrailingCommaInHashLiteral:
1723
+ Enabled: true
1692
1724
 
1693
1725
  Style/TrailingMethodEndStatement:
1694
1726
  Enabled: true
@@ -1720,9 +1752,13 @@ Style/WhileUntilDo:
1720
1752
  Style/WhileUntilModifier:
1721
1753
  Enabled: true
1722
1754
 
1755
+ # Overridden to false in Chopin
1723
1756
  Style/WordArray:
1724
1757
  EnforcedStyle: brackets
1725
1758
 
1759
+ Style/YAMLFileRead:
1760
+ Enabled: true
1761
+
1726
1762
  Style/YodaCondition:
1727
1763
  Enabled: false
1728
1764