simplycop 1.13.11 → 1.14.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 99d0c442230faa659ac1e56a848ac10022fdaddd8a4b1519a121236429765a05
-  data.tar.gz: 973ea1ddc7ee7719bb6a1b71595e574d2e1c9b13e08d47abaa37f7e1c42a8044
+  metadata.gz: 0b059fa7b663eecc5cee85e13a4610a7fb9437e08f653eef24b9c700e2e065a3
+  data.tar.gz: 133bc97ec8492dd63898eb91e468807bedea550f36014645f4a9184d6870605d
 SHA512:
-  metadata.gz: d91e8a11a7d6d7bb0d0eaf376883452b89d01ebd72fc42b5cac91e191dc3fee7bc3fb29a7d96590bf9da6ca308472bf86383a6bf64b5957a7c621ae561a944c6
-  data.tar.gz: b8d3c6add9f548651ade0395e013acbfc122ba1fa6ff7a7e13b6a2324d0c513d63aadbffe798bf22a413853eefad80ce40e9412932244dda63a4659e118372da
+  metadata.gz: 3121c965a81b8b46b4ec772501f77b09509f47e304516f37edd979276178f4350992fbd75188254cc865bda89a23def9d516ef2d7bd6a16a08b764e6d487a779
+  data.tar.gz: dcd0423818e706053ab0bfd21ba8a5503fff1d2940d55190fda6d2b40513761535ace9dccea3bd1efbdac0d7701f5b9b1025da79c5737c92cc01e2011725c91f

data/.github/workflows/ci.yml

@@ -22,7 +22,7 @@ jobs:
         ruby-version: ['2.7', '3.0', '3.1', '3.2', jruby]
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:

data/.github/workflows/publish_gem.yml

@@ -11,7 +11,7 @@ jobs:
     name: Build and Publish
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up Ruby 3.0
         uses: actions/setup-ruby@v1
         with:

data/.simplycop.yml

@@ -886,6 +886,7 @@ Naming/MethodParameterName:
   Enabled: true
   AllowedNames:
     - as
+    - at
     - ex
     - id
     - ip
@@ -917,6 +918,7 @@ Naming/VariableNumber:
     - rfc822
     - rfc2822
     - rfc3339
+    - s3
     - x86_64
   AllowedPatterns:
     - v\d+

data/.simplycop_rails.yml

@@ -1,56 +1,399 @@
 require:
   - rubocop-rails
 
+# Overridden in Chopin
+Rails/ActionControllerFlashBeforeRender:
+  Enabled: true
+
+Rails/ActionControllerTestCase:
+  Enabled: true
+
+Rails/ActionFilter:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/ActionOrder:
+  Enabled: true
+
+Rails/ActiveRecordAliases:
+  Enabled: true
+
 Rails/ActiveRecordCallbacksOrder:
   Enabled: true
 
+Rails/ActiveRecordOverride:
+  Enabled: true
+
+Rails/ActiveSupportAliases:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/ActiveSupportOnLoad:
+  Enabled: true
+
+Rails/AddColumnIndex:
+  Enabled: true
+
 Rails/AfterCommitOverride:
   Enabled: true
 
+Rails/ApplicationController:
+  Enabled: true
+
+Rails/ApplicationJob:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/ApplicationMailer:
+  Enabled: true
+
+Rails/ApplicationRecord:
+  Enabled: true
+
+Rails/ArelStar:
+  Enabled: true
+
+Rails/AssertNot:
+  Enabled: true
+
 Rails/AttributeDefaultBlockValue:
   Enabled: true
 
+Rails/BelongsTo:
+  Enabled: true
+
+Rails/Blank:
+  Enabled: true
+
+Rails/BulkChangeTable:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/CompactBlank:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/ContentTag:
+  Enabled: true
+
+Rails/CreateTableWithTimestamps:
+  Enabled: true
+
+Rails/DangerousColumnNames:
+  Enabled: true
+
+Rails/Date:
+  Enabled: true
+
 Rails/DefaultScope:
   Enabled: true
 
 Rails/Delegate:
   Enabled: false
 
+Rails/DelegateAllowBlank:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/DeprecatedActiveModelErrorsMethods:
+  Enabled: true
+
+Rails/DotSeparatedKeys:
+  Enabled: true
+
+Rails/DuplicateAssociation:
+  Enabled: true
+
+Rails/DuplicateScope:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/DurationArithmetic:
+  Enabled: true
+
+Rails/DynamicFindBy:
+  Enabled: false
+
+Rails/EagerEvaluationLogMessage:
+  Enabled: true
+
+Rails/EnumHash:
+  Enabled: true
+
+Rails/EnumUniqueness:
+  Enabled: true
+
+Rails/EnvironmentComparison:
+  Enabled: true
+
+Rails/EnvironmentVariableAccess:
+  Enabled: false
+
+Rails/Exit:
+  Enabled: true
+
+Rails/ExpandedDateRange:
+  Enabled: true
+
+Rails/FilePath:
+  Enabled: true
+
+Rails/FindBy:
+  Enabled: true
+
 Rails/FindById:
   Enabled: true
 
+Rails/FindEach:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/FreezeTime:
+  Enabled: true
+
+Rails/HasAndBelongsToMany:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/HasManyOrHasOneDependent:
+  Enabled: true
+
+Rails/HelperInstanceVariable:
+  Enabled: true
+
+Rails/HttpPositionalArguments:
+  Enabled: true
+
+Rails/HttpStatus:
+  Enabled: true
+
+Rails/I18nLazyLookup:
+  Enabled: false
+
+# Overridden in Chopin
+Rails/I18nLocaleAssignment:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/I18nLocaleTexts:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/IgnoredColumnsAssignment:
+  Enabled: true
+
+Rails/IgnoredSkipActionFilterOption:
+  Enabled: true
+
+Rails/IndexBy:
+  Enabled: true
+
+Rails/IndexWith:
+  Enabled: true
+
 Rails/Inquiry:
   Enabled: false
 
+Rails/InverseOf:
+  Enabled: true
+
+Rails/LexicallyScopedActionFilter:
+  Enabled: true
+
+Rails/LinkToBlank:
+  Enabled: true
+
 Rails/MailerName:
   Enabled: true
 
 Rails/MatchRoute:
   Enabled: true
 
+Rails/MigrationClassName:
+  Enabled: true
+
+# Overridden in Chopin
 Rails/NegateInclude:
   Enabled: true
 
+Rails/NotNullColumn:
+  Enabled: true
+
+Rails/OrderById:
+  Enabled: false
+
+Rails/Output:
+  Enabled: false
+
+Rails/OutputSafety:
+  Enabled: false
+
+Rails/Pick:
+  Enabled: true
+
 # Conflicts with Mongoid
 Rails/Pluck:
   Enabled: false
 
+Rails/PluckId:
+  Enabled: false
+
 # Conflicts with Mongoid
 Rails/PluckInWhere:
   Enabled: false
 
+Rails/PluralizationGrammar:
+  Enabled: true
+
+Rails/Presence:
+  Enabled: true
+
+Rails/Present:
+  Enabled: true
+
+Rails/RakeEnvironment:
+  Enabled: true
+
+Rails/ReadWriteAttribute:
+  Enabled: true
+
+Rails/RedundantActiveRecordAllMethod:
+  Enabled: true
+
+Rails/RedundantAllowNil:
+  Enabled: true
+
+Rails/RedundantForeignKey:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/RedundantPresenceValidationOnBelongsTo:
+  Enabled: true
+
+Rails/RedundantReceiverInWithOptions:
+  Enabled: true
+
+Rails/RedundantTravelBack:
+  Enabled: true
+
+Rails/ReflectionClassName:
+  Enabled: true
+
+Rails/RefuteMethods:
+  Enabled: false
+
+# Overridden in Chopin
+Rails/RelativeDateConstant:
+  Enabled: true
+
 Rails/RenderInline:
   Enabled: true
 
 Rails/RenderPlainText:
   Enabled: true
 
+Rails/RequestReferer:
+  Enabled: false
+
+Rails/RequireDependency:
+  Enabled: false
+
+Rails/ResponseParsedBody:
+  Enabled: true
+
+Rails/ReversibleMigration:
+  Enabled: true
+
+Rails/ReversibleMigrationMethodDefinition:
+  Enabled: false
+
+# Overridden in Chopin
+Rails/RootJoinChain:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/RootPathnameMethods:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/RootPublicPath:
+  Enabled: true
+
+Rails/SafeNavigation:
+  Enabled: true
+
+Rails/SafeNavigationWithBlank:
+  Enabled: true
+
+Rails/SaveBang:
+  Enabled: false
+
+Rails/SchemaComment:
+  Enabled: false
+
+Rails/ScopeArgs:
+  Enabled: true
+
+Rails/SelectMap:
+  Enabled: true
+
 Rails/ShortI18n:
   Enabled: true
 
+Rails/SkipsModelValidations:
+  Enabled: true
+
 Rails/SquishedSQLHeredocs:
   Enabled: true
 
+# Overridden in Chopin
+Rails/StripHeredoc:
+  Enabled: true
+
+Rails/TableNameAssignment:
+  Enabled: false
+
+Rails/ThreeStateBooleanColumn:
+  Enabled: false
+
+Rails/TimeZone:
+  Enabled: true
+
+# Overridden in Chopin
+Rails/TimeZoneAssignment:
+  Enabled: true
+
+Rails/ToFormattedS:
+  Enabled: false
+
+Rails/ToSWithArgument:
+  Enabled: false
+
+# Overridden in Chopin
+Rails/TopLevelHashWithIndifferentAccess:
+  Enabled: true
+
+Rails/TransactionExitStatement:
+  Enabled: true
+
+Rails/UniqBeforePluck:
+  Enabled: true
+
+Rails/UniqueValidationWithoutIndex:
+  Enabled: true
+
+Rails/UnknownEnv:
+  Enabled: true
+
+Rails/UnusedIgnoredColumns:
+  Enabled: true
+
+Rails/UnusedRenderContent:
+  Enabled: true
+
+Rails/Validation:
+  Enabled: true
+
 Rails/WhereEquals:
   Enabled: true
 
@@ -58,10 +401,18 @@ Rails/WhereEquals:
 Rails/WhereExists:
   Enabled: false
 
+# Anticipate conflicts with Mongoid, like Rails/WhereExists
+Rails/WhereMissing:
+  Enabled: false
+
 # Conflicts with Mongoid
 Rails/WhereNot:
   Enabled: false
 
+# Anticipate conflicts with Mongoid, like Rails/WhereNot
+Rails/WhereNotWithMultipleConditions:
+  Enabled: false
+
 Rails/ActionControllerTestCase: # new in 2.14
   Enabled: true
 

data/.simplycop_rspec.yml

@@ -96,6 +96,12 @@ RSpec/EmptyLineAfterHook:
 RSpec/EmptyLineAfterSubject:
   Enabled: true
 
+RSpec/EmptyMetadata:
+  Enabled: true
+
+RSpec/Eq:
+  Enabled: true
+
 RSpec/ExampleLength:
   Enabled: false
 
@@ -179,6 +185,9 @@ RSpec/MessageChain:
 RSpec/MessageSpies:
   Enabled: false
 
+RSpec/MetadataStyle:
+  Enabled: true
+
 RSpec/MissingExampleGroupArgument:
   Enabled: true
 
@@ -311,10 +320,10 @@ RSpec/Capybara:
   Include:
     - spec/integration/*.rb
 
-Capybara/CurrentPathExpectation:
+RSpec/Capybara/FeatureMethods:
   Enabled: true
 
-Capybara/FeatureMethods:
+Capybara/CurrentPathExpectation:
   Enabled: true
 
 Capybara/MatchStyle:
@@ -334,6 +343,9 @@ Capybara/SpecificMatcher:
 
 # RSpec/FactoryBot
 
+FactoryBot/AssociationStyle:
+  Enabled: true
+
 FactoryBot/AttributeDefinedStatically:
   Enabled: true
 
@@ -343,12 +355,18 @@ FactoryBot/ConsistentParenthesesStyle:
 FactoryBot/CreateList:
   Enabled: false
 
+FactoryBot/FactoryAssociationWithStrategy:
+  Enabled: true
+
 FactoryBot/FactoryClassName:
   Enabled: true
 
 FactoryBot/FactoryNameStyle:
   Enabled: true
 
+FactoryBot/RedundantFactoryOption:
+  Enabled: true
+
 # Prefer explicit factorybot call
 FactoryBot/SyntaxMethods:
   Enabled: false

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.13.11'
+  VERSION = '1.14.1'
 end

data/simplycop.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '1.56.2'
+  spec.add_dependency 'rubocop', '1.56.3'
   spec.add_dependency 'rubocop-performance', '1.19.0'
   spec.add_dependency 'rubocop-rails', '2.21.1'
   spec.add_dependency 'rubocop-rspec', '2.24.0'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.13.11
+  version: 1.14.1
 platform: ruby
 authors:
 - Simply Business
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.56.2
+        version: 1.56.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.56.2
+        version: 1.56.3
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement