simplycop 1.13.1 → 1.13.7

data/.simplycop.yml

@@ -31,8 +31,8 @@ Bundler/GemFilename:
   Enabled: true
 
 # To discuss: Suggest true but 103 fails on Chopin, 10 on Rater
-# Bundler/GemVersion:
-#   Enabled: true
+Bundler/GemVersion:
+  Enabled: false
 
 Bundler/InsecureProtocolSource:
   Enabled: true
@@ -41,16 +41,16 @@ Bundler/OrderedGems:
   Enabled: true
 
 # To discuss: Suggest true but 3 fails on Chopin, 21 on Rater
-# Gemspec/DependencyVersion:
-#   Enabled: true
+Gemspec/DependencyVersion:
+  Enabled: false
 
 # TODO: 1 autocorrectable in Rater and it would pass
-# Gemspec/DeprecatedAttributeAssignment:
-#   Enabled: true
+Gemspec/DeprecatedAttributeAssignment:
+  Enabled: true
 
-# To discuss: Suggest true but 2 fails on Chopin, 10 on Rater
-# Gemspec/DevelopmentDependencies:
-#   Enabled: true
+# 2 fails on Chopin, 10 on Rater, so override if necessary
+Gemspec/DevelopmentDependencies:
+  Enabled: false
 
 Gemspec/DuplicatedAssignment:
   Enabled: true
@@ -59,12 +59,12 @@ Gemspec/OrderedDependencies:
   Enabled: true
 
 # TODO: Suggest true but 4 fails on Chopin, 3 on Rater, overridden to false on Chopin
-# Gemspec/RequireMFA:
-#   Enabled: true
+Gemspec/RequireMFA:
+  Enabled: false
 
-# TODO: Suggest true but 3 fails on Chopin
-# Gemspec/RequiredRubyVersion:
-#   Enabled: true
+# Will need Chopin override
+Gemspec/RequiredRubyVersion:
+  Enabled: true
 
 Gemspec/RubyVersionGlobalsUsage:
   Enabled: true
@@ -94,8 +94,9 @@ Layout/CaseIndentation:
   Enabled: true
 
 # Discussion needed about preferred structure. Dozens of fails on each repo if we stick with default, all but 4 on Chopin are autocorrectable
-# Layout/ClassStructure:
-#   Enabled: true
+# Worth agreeing a style?
+Layout/ClassStructure:
+  Enabled: false
 
 Layout/ClosingHeredocIndentation:
   Enabled: true
@@ -124,9 +125,9 @@ Layout/EmptyComment:
 Layout/EmptyLineAfterGuardClause:
   Enabled: true
 
-# To discuss. Suggest should be true but 500+ autocorrectable fails on Chopin. None on others 
-# Layout/EmptyLineAfterMagicComment:
-#   Enabled: true
+# Needs Chopin override 
+Layout/EmptyLineAfterMagicComment:
+  Enabled: true
 
 Layout/EmptyLineAfterMultilineCondition:
   Enabled: true
@@ -182,22 +183,18 @@ Layout/FirstArrayElementIndentation:
 Layout/FirstArrayElementLineBreak:
   Enabled: true
 
-Layout/FirstMethodArgumentLineBreak:
-  Enabled: true
-
 Layout/FirstHashElementIndentation:
   Enabled: true
 
 Layout/FirstHashElementLineBreak:
   Enabled: true
 
-# To discuss - 200+ fails on CoCo, none elsewhere
-# Layout/FirstMethodArgumentLineBreak:
-#   Enabled: true
+Layout/FirstMethodArgumentLineBreak:
+  Enabled: true
 
-# To discuss - 100+ fails on Chopin, handful on others
-# Layout/FirstMethodParameterLineBreak:
-#   Enabled: true
+# Needs Chopin override
+Layout/FirstMethodParameterLineBreak:
+  Enabled: true
 
 Layout/FirstParameterIndentation:
   Enabled: true
@@ -242,18 +239,19 @@ Layout/LineEndStringConcatenationIndentation:
   Enabled: true
 
 # To discuss: configure line length? At default 120: 6805 fails on Chopin, 3 on Rater, 179 on CoCo
-# Layout/LineLength
-#   Enabled: false
+# Typically overridden/"to-do"-ed
+Layout/LineLength:
+  Enabled: true
+
 Layout/MultilineArrayBraceLayout:
   Enabled: true
   
-# To discuss: 100s of fails on each repo but autocorrectable  
-# Layout/MultilineArrayLineBreaks:
-#   Enabled: true
+Layout/MultilineArrayLineBreaks:
+  Enabled: true
 
 # To discuss: 100s of fails on each repo but autocorrectable  
-# Layout/MultilineAssignmentLayout:
-#   Enabled: true
+Layout/MultilineAssignmentLayout:
+  Enabled: false
   
 Layout/MultilineBlockLayout:
   Enabled: true
@@ -261,13 +259,13 @@ Layout/MultilineBlockLayout:
 Layout/MultilineHashBraceLayout:
   Enabled: true
 
-# To discuss: 100s of fails on each repo but autocorrectable  
-# Layout/MultilineHashKeyLineBreaks:
-#   Enabled: true
+# To discuss: 100s of fails on each repo but autocorrectable  gp 
+Layout/MultilineHashKeyLineBreaks:
+  Enabled: false
 
 # To discuss: 1000s of fails on each repo but autocorrectable  
-# Layout/MultilineMethodArgumentLineBreaks:
-#   Enabled: true
+Layout/MultilineMethodArgumentLineBreaks:
+  Enabled: false
   
 Layout/MultilineMethodCallBraceLayout:
   Enabled: true
@@ -279,8 +277,8 @@ Layout/MultilineMethodDefinitionBraceLayout:
   Enabled: true
 
 # To discuss: 100s of fails on each repo but autocorrectable
-# Layout/MultilineMethodParameterLineBreaks:
-#   Enabled: true
+Layout/MultilineMethodParameterLineBreaks:
+  Enabled: false
   
 Layout/MultilineOperationIndentation:
   Enabled: true
@@ -289,15 +287,15 @@ Layout/ParameterAlignment:
   Enabled: true
 
 # For discussion: 1000s of fails, all autocorrectable
-# Layout/RedundantLineBreak:
-#   Enabled: true
+Layout/RedundantLineBreak:
+  Enabled: false
 
 Layout/RescueEnsureAlignment:
   Enabled: true
 
 # For discussion: 1000s of fails, all autocorrectable
-# Layout/SingleLineBlockChain:
-#   Enabled: true
+Layout/SingleLineBlockChain:
+  Enabled: false
 
 Layout/SpaceAfterColon:
   Enabled: true
@@ -402,8 +400,8 @@ Lint/AmbiguousRange:
   Enabled: true
 
 # TODO: One fail on rater spec then would pass
-# Lint/AmbiguousRegexpLiteral:
-#   Enabled: true
+Lint/AmbiguousRegexpLiteral:
+  Enabled: true
 
 Lint/AssignmentInCondition:
   Enabled: true
@@ -421,8 +419,8 @@ Lint/CircularArgumentReference:
   Enabled: true
 
 # TODO: 6 fails in Rater, otherwise clear
-# Lint/ConstantDefinitionInBlock:
-#   Enabled: true
+Lint/ConstantDefinitionInBlock:
+  Enabled: true
 
 Lint/ConstantOverwrittenInRescue: # new in 1.31
   Enabled: true
@@ -481,9 +479,8 @@ Lint/DuplicateRescueException:
 Lint/EachWithObjectArgument:
   Enabled: true
 
-# TODO: 19 autocorrectable odd else layouts in Rater  
-# Lint/ElseLayout:
-#   Enabled: true
+Lint/ElseLayout:
+  Enabled: true
 
 Lint/EmptyBlock:
   Enabled: true
@@ -542,9 +539,9 @@ Lint/ImplicitStringConcatenation:
 Lint/IncompatibleIoSelectWithFiberScheduler: # new in 1.21
   Enabled: true
 
-# TODO: two fails on Rater, one on CoCo, otherwise fine to enable
-# Lint/IneffectiveAccessModifier:
-#   Enabled: true 
+# TODO: two fails on Rater, one on CoCo, otherwise fine
+Lint/IneffectiveAccessModifier:
+  Enabled: true 
 
 Lint/InheritException:
   Enabled: true 
@@ -568,8 +565,11 @@ Lint/MissingCopEnableDirective:
   Enabled: true
 
 # TODO: Handful of errors on Rater and CoCo
-# Lint/MissingSuper:
-#   Enabled: true
+Lint/MissingSuper:
+  Enabled: true
+
+Lint/MixedCaseRange:
+  Enabled: true
 
 Lint/MixedRegexpCaptureTypes:
   Enabled: true
@@ -599,9 +599,8 @@ Lint/NonDeterministicRequireOrder:
 Lint/NonLocalExitFromIterator:
   Enabled: true 
 
-# 100s of fails on Rater and Chopin
-# Lint/NumberConversion:
-#   Enabled: true 
+Lint/NumberConversion:
+  Enabled: false 
 
 Lint/NumberedParameterAssignment:
   Enabled: true
@@ -630,17 +629,18 @@ Lint/RaiseException:
 Lint/RandOne:
   Enabled: true 
 
-# Can't be checked with --only, enable once Rater and Chopin up to date with Simplycop
-# Lint/RedundantCopDisableDirective:
-#   Enabled: true 
+Lint/RedundantCopDisableDirective:
+  Enabled: true 
 
-# Can't be checked with --only, enable once Rater and Chopin up to date with Simplycop
-# Lint/RedundantCopEnableDirective:
-#   Enabled: true 
+Lint/RedundantCopEnableDirective:
+  Enabled: true 
 
 Lint/RedundantDirGlobSort:
   Enabled: true
 
+Lint/RedundantRegexpQuantifiers:
+  Enabled: true
+
 Lint/RedundantRequireStatement:
   Enabled: true
 
@@ -708,9 +708,9 @@ Lint/ShadowedArgument:
 Lint/ShadowedException:
   Enabled: true
 
-# To discuss: 63 offences on Chopin, none on Rater, CoCo
-# Lint/ShadowingOuterLocalVariable:
-#   Enabled: true
+# Needs Chopin override
+Lint/ShadowingOuterLocalVariable:
+  Enabled: true
 
 Lint/StructNewOverride:
   Enabled: true
@@ -782,8 +782,8 @@ Lint/UselessMethodDefinition:
   Enabled: true
 
 # TODO: Single fail on Chopin
-# Lint/UselessRescue:
-#   Enabled: true
+Lint/UselessRescue:
+  Enabled: true
 
 Lint/UselessRuby2Keywords:
   Enabled: true
@@ -841,9 +841,9 @@ Metrics/PerceivedComplexity:
 Migration/DepartmentName:
   Enabled: true
 
-# Suggest true but causes 17 fails in Chopin, 6 in Rater, 2 in CoCo
-# Naming/AccessorMethodName:
-#   Enabled: true
+# Needs override or fix in Chopin
+Naming/AccessorMethodName:
+  Enabled: true
 
 Naming/AsciiIdentifiers:
   Enabled: true
@@ -875,55 +875,63 @@ Naming/HeredocDelimiterNaming:
 Naming/InclusiveLanguage:
   Enabled: true
 
-# To discuss: suggest true but 86 fails on Chopin
-# Naming/MemoizedInstanceVariableName:
-#   Enabled: true
+# Need override - 86 fails on Chopin
+Naming/MemoizedInstanceVariableName:
+  Enabled: true
 
 Naming/MethodName:
   Enabled: true
 
-# To discuss: suggest true with possible allowed exceptions as below (10 fails on Chopin, exceptions would allow 4, 
-# as and to are already exceptions in Rater so would remove need to configure there)
-# Naming/MethodParameterName:
-#   Enabled: true
-#   AllowedNames:
-#     - as
-#     - ex
-#     - n
-#     - to
+Naming/MethodParameterName:
+  Enabled: true
+  AllowedNames:
+    - as
+    - ex
+    - n
+    - to
 
 # To discuss: suggest true but 52 fails in Chopin, 8 in Coco (consider with Naming/AccessorName)
-# Naming/PredicateName:
-#   Enabled: true
+Naming/PredicateName:
+  Enabled: false
 
-# To discuss: Should decide on a style. Default e instead of err causes 47 fails on Chopin, none on Rater, CoCo
-# Naming/RescuedExceptionsVariableName:
-#   Enabled: true
+# Need Chopin override
+Naming/RescuedExceptionsVariableName:
+  Enabled: true
 
 Naming/VariableName:
   Enabled: true
 
-# To discuss: suggest enforce snake_case as this seems to be the preferred style
-# Default normalcase causes 
-# Naming/VariableNumber:
-#   Enabled: true
-#   EnforcedStyle: snake_case
-
+# snake_case: 311 fails on Chopin, normalcase: 1118 fails on Chopin
+# snake_case default on Rater so make default in simplycop
+Naming/VariableNumber:
+  Enabled: true
+  EnforcedStyle: snake_case
+  AllowedIdentifiers:
+    - capture3
+    - iso8601 
+    - oauth2
+    - rfc1123_date
+    - rfc822
+    - rfc2822
+    - rfc3339
+    - x86_64
+    
 # Overridden to false in Chopin
 Security/CompoundHash:
   Enabled: true
 
-# Should probably be set to true but 13 offences in chopin spec
-# Security/Eval:
-#   Enabled: true
+Security/Eval:
+  Enabled: true
+  Exclude:
+    - 'spec/**/*.rb'
 
 # Overridden to false on Chopin
 Security/IoMethods:
   Enabled: true
 
-# Should probably be set to true but 18 offences in chopin spec
-# Security/JSONLoad:
-#   Enabled: true
+# Needs override in chopin spec
+Security/JSONLoad:
+  Enabled: true
 
 Security/MarshalLoad:
   Enabled: true
@@ -931,9 +939,8 @@ Security/MarshalLoad:
 Security/Open:
   Enabled: true
 
-# Two fails on ContinuousCover, others fine
-# Security/YAMLLoad:
-#   Enabled: true
+Security/YAMLLoad:
+  Enabled: true
 
 Style/AccessModifierDeclarations:
   Enabled: false
@@ -970,11 +977,11 @@ Style/Attr:
   Enabled: true
 
 # Requires fixes in Chopin and Rater
-# Style/AutoResourceCleanup:
-#   Enabled: true 
+Style/AutoResourceCleanup:
+  Enabled: true 
 
-# Requires discussion
-# Style/BarePercentLiterals:
+Style/BarePercentLiterals:
+  Enabled: true
 
 Style/BeginBlock:
   Enabled: true
@@ -985,8 +992,11 @@ Style/BisectedAttrAccessor:
 Style/BlockComments:
   Enabled: true
 
-# Requires discussion - 1000+ offences in Chopin alone, unless options set
-# Style/BlockDelimiters:
+# Enabled by default and used in Rater so made explicit here
+# However, overridden by Chopin to do file and proposal to use semantic style:
+# See #technical-excellence-community discussion 28/02/23
+Style/BlockDelimiters:
+  Enabled: true
 
 Style/CaseEquality:
   Enabled: true
@@ -997,8 +1007,10 @@ Style/CaseLikeIf:
 Style/CharacterLiteral:
   Enabled: true
 
-# Requires discussion
-# Style/ClassAndModuleChildren:
+Style/ClassAndModuleChildren:
+  Enabled: true
+  Exclude:
+    - spec/**/*.rb
 
 Style/ClassCheck:
   Enabled: true
@@ -1009,9 +1021,9 @@ Style/ClassEqualityComparison:
 Style/ClassMethods:
   Enabled: true
 
-# Requires discussion - multiple fails on Chopin/Rater/CoCo when left at default
-# Style/ClassMethodsDefinitions:
-#   Enabled: true
+# Requires discussion - multiple fails on Chopin/Rater/CoCo when set true with default
+Style/ClassMethodsDefinitions:
+  Enabled: false
 
 Style/ClassVars:
   Enabled: true
@@ -1019,8 +1031,9 @@ Style/ClassVars:
 Style/CollectionCompact:
   Enabled: true
 
-# Requires discussion - multiple fails on Chopin/Rater/CoCo when left at default
-# Style/CollectionMethods:
+# Requires discussion - multiple fails on Chopin/Rater/CoCo when set true with default
+Style/CollectionMethods:
+  Enabled: false
 
 Style/ColonMethodCall:
   Enabled: true
@@ -1052,17 +1065,19 @@ Style/ConditionalAssignment:
   Enabled: true
 
 # Requires discussion - 1000+ offences in Chopin alone, unless options set
-# Style/ConstantVisibility:
+Style/ConstantVisibility:
+  Enabled: false
 
 # For discussion
-# Style/Copyright:
+Style/Copyright:
+  Enabled: false
 
 Style/DataInheritance:
   Enabled: true
 
 # Requires discussion - multiple fails on Chopin/Rater/CoCo if true
-# Style/DateTime:
-#   Enabled: false
+Style/DateTime:
+  Enabled: false
 
 Style/DefWithParentheses:
   Enabled: true
@@ -1074,7 +1089,8 @@ Style/DirEmpty:
   Enabled: true
 
 # For discussion - - multiple fails on Chopin/Rater/CoCo
-# Style/DisableCopsWithinSourceCodeDirective:
+Style/DisableCopsWithinSourceCodeDirective:
+  Enabled: false
 
 Style/DocumentDynamicEvalDefinition:
   Enabled: false
@@ -1083,8 +1099,8 @@ Style/Documentation:
   Enabled: false
 
 # Requires discussion - suggest false as 7000+ offences in Chopin alone
-# Style/DocumentationMethod:
-# Enabled: false
+Style/DocumentationMethod:
+  Enabled: false
 
 Style/DoubleCopDisableDirective:
   Enabled: true
@@ -1092,9 +1108,9 @@ Style/DoubleCopDisableDirective:
 Style/DoubleNegation:
   Enabled: true
 
-# Suggest true but 100+ fails on Rater, none on Chopin or CoCo
-# Style/EachForSimpleLoop:
-#   Enabled: true
+# Need override in Rater
+Style/EachForSimpleLoop:
+  Enabled: true
 
 Style/EachWithObject:
   Enabled: true
@@ -1108,7 +1124,7 @@ Style/EmptyCaseCondition:
 Style/EmptyElse:
   Enabled: true
 
-Style/EmptyHeredoc: # new in 1.32
+Style/EmptyHeredoc:
   Enabled: true
 
 Style/EmptyLambdaParameter:
@@ -1233,28 +1249,28 @@ Style/IfWithSemicolon:
   Enabled: true
 
 # For dicussion - 100s of fails on Chopin, CoCo, Rater
-# Style/ImplicitRuntimeError:
-#   Enabled: false
+Style/ImplicitRuntimeError:
+  Enabled: false
 
 Style/InfiniteLoop:
   Enabled: true
 
-# For discussion - suggest false as 1000s of fails
-# Style/InlineComment:
-#   Enabled: false
+Style/InlineComment:
+  Enabled: false
 
 Style/InverseMethods:
   Enabled: true
 
-# Manageable number of fails on Chopin, CoCo, Rater, suggest true
-# Style/InvertibleUnlessCondition:
-#   Enabled: true
+Style/InvertibleUnlessCondition:
+  Enabled: true
 
 Style/InPatternThen: # new in 1.16
   Enabled: true
 
-# For discussion - multiple fails but most could be solved by excluding spec files
-# Style/IpAddresses:
+# For discussion - disabled by default but could be enabled 
+# and mostly solved by excluding spec files
+Style/IpAddresses:
+  Enabled: false
 #   Enabled: true
 #   Exclude: [*spec.rb]
 
@@ -1284,16 +1300,16 @@ Style/MapToHash:
 Style/MapToSet:
   Enabled: true
 
-# For discussion - 1000s of fails, suggest false
-# Style/MethodCallWithArgsParentheses:
-#   Enabled: false
+# For discussion - 1000s of fails if set true 
+Style/MethodCallWithArgsParentheses:
+  Enabled: false
 
 Style/MethodCallWithoutArgsParentheses:
   Enabled: false
 
-# For discussion - 100s of fails, suggest false
-# Style/MethodCalledOnDoEndBlock:
-#   Enabled: false
+# For discussion - 100s of fails if set true
+Style/MethodCalledOnDoEndBlock:
+  Enabled: false
 
 Style/MethodDefParentheses:
   Enabled: true
@@ -1305,9 +1321,8 @@ Style/MinMax:
 Style/MinMaxComparison:
   Enabled: true
 
-# For discussion - 100s of fails with default true
-# Style/MissingElse:
-#   Enabled: true
+Style/MissingElse:
+  Enabled: false
 
 Style/MissingRespondToMissing:
   Enabled: true
@@ -1337,8 +1352,8 @@ Style/MultilineMemoization:
   Enabled: true
 
 # For discussion - suggest true, but 100s of fails in Chopin and handful in CoCo
-# Style/MultilineMethodSignature:
-#   Enabled: true
+Style/MultilineMethodSignature:
+  Enabled: false
 
 Style/MultilineTernaryOperator:
   Enabled: true
@@ -1364,7 +1379,7 @@ Style/NegatedUnless:
 Style/NegatedWhile:
   Enabled: true
 
-Style/NestedFileDirname: # new in 1.26
+Style/NestedFileDirname: 
   Enabled: true
 
 Style/NestedModifier:
@@ -1391,10 +1406,10 @@ Style/NonNilCheck:
 Style/Not:
   Enabled: true
 
-Style/NumberedParameters: # new in 1.22
+Style/NumberedParameters: 
   Enabled: true
 
-Style/NumberedParametersLimit: # new in 1.22
+Style/NumberedParametersLimit: 
   Enabled: true
 
 Style/NumericLiteralPrefix:
@@ -1406,7 +1421,7 @@ Style/NumericLiterals:
 Style/NumericPredicate:
   Enabled: false
 
-Style/ObjectThen: # new in 1.28
+Style/ObjectThen:
   Enabled: true
 
 Style/OneLineConditional:
@@ -1452,7 +1467,7 @@ Style/PreferredHashMethods:
 Style/Proc:
   Enabled: true
 
-# Overridden to false in Chopin
+# Overridden to false in Chopin and Rater
 Style/QuotedSymbols:
   Enabled: true
 
@@ -1465,6 +1480,9 @@ Style/RandomWithOffset:
 Style/RedundantArgument:
   Enabled: false
 
+Style/RedundantArrayConstructor:
+  Enabled: true
+
 Style/RedundantAssignment:
   Enabled: true
 
@@ -1483,6 +1501,9 @@ Style/RedundantConditional:
 Style/RedundantConstantBase:
   Enabled: false
 
+Style/RedundantCurrentDirectoryInPath:
+  Enabled: false
+
 Style/RedundantDoubleSplatHashBraces:
   Enabled: true
 
@@ -1498,6 +1519,9 @@ Style/RedundantFetchBlock:
 Style/RedundantFileExtensionInRequire:
   Enabled: true
 
+Style/RedundantFilterChain:
+  Enabled: true
+
 Style/RedundantFreeze:
   Enabled: true
 
@@ -1519,9 +1543,15 @@ Style/RedundantParentheses:
 Style/RedundantPercentQ:
   Enabled: true
 
+Style/RedundantRegexpArgument:
+  Enabled: true
+
 Style/RedundantRegexpCharacterClass:
   Enabled: true
 
+Style/RedundantRegexpConstructor:
+  Enabled: true
+
 Style/RedundantRegexpEscape:
   Enabled: true
 
@@ -1549,13 +1579,12 @@ Style/RedundantSortBy:
 Style/RedundantStringEscape:
   Enabled: true
 
-# For discussion - CoCo, Rater OK, manageable amount of autocorrectable in Chopin if set true
-# Style/RegexpLiteral:
-#   Enabled: true
+Style/RegexpLiteral:
+  Enabled: true
 
-# For discussion - dozens of fails, suggest false as autocorrect also unsafe
-# Style/RequireOrder:
-#   Enabled: false
+# For discussion - would improve legibility if set true
+Style/RequireOrder:
+  Enabled: false
 
 Style/RescueModifier:
   Enabled: true
@@ -1563,9 +1592,13 @@ Style/RescueModifier:
 Style/RescueStandardError:
   Enabled: true
 
-# For discussion - suggest false as fails in all three if set true
-# Style/ReturnNil:
-#   Enabled: false
+# For discussion - agreed configuration would be nice
+Style/ReturnNil:
+  Enabled: false
+
+# For discussion - as ReturnNil agreed configuration would be nice
+Style/ReturnNilInPredicateMethodDefinition:
+  Enabled: false  
 
 Style/SafeNavigation:
   Enabled: false
@@ -1583,9 +1616,8 @@ Style/SelfAssignment:
 Style/Semicolon:
   Enabled: true
 
-# For discussion - 100s of fails on Chopin, some on CoCo
-# Style/Send:
-#   Enabled: true
+Style/Send:
+  Enabled: false
 
 Style/SignalException:
   Enabled: true
@@ -1614,9 +1646,9 @@ Style/SpecialGlobalVars:
 Style/StabbyLambdaParentheses:
   Enabled: true
 
-# For discussion - 100s of fails across Rater, Chopin, CoCo, so suggest false
-# Style/StaticClass:
-#   Enabled: false
+# Will require Chopin override
+Style/StaticClass:
+  Enabled: true
 
 # TODO: Small number of autocorrects in Chopin
 Style/StderrPuts:
@@ -1628,9 +1660,8 @@ Style/StringChars:
 Style/StringConcatenation:
   Enabled: true
 
-# For discussion - 10000s of fails in Chopin and Rater so suggest false
-# Style/StringHashKeys:
-#   Enabled: false
+Style/StringHashKeys:
+  Enabled: false
 
 Style/StringLiterals:
   Enabled: false
@@ -1663,8 +1694,8 @@ Style/TernaryParentheses:
   Enabled: true
 
 # For discussion - suggest should be true or at least warn but large number of fails on repos
-# Style/TopLevelMethodDefinition:
-#   Enabled: true
+Style/TopLevelMethodDefinition:
+  Enabled: false
 
 Style/TrailingBodyOnClass:
   Enabled: true
@@ -1675,20 +1706,20 @@ Style/TrailingBodyOnMethodDefinition:
 Style/TrailingBodyOnModule:
   Enabled: true
 
-# For discussion - 100s of fails on Chopin, none on others
-# Style/TrailingCommaInArguments:
-#   Enabled: true
+# Will require Chopin override
+Style/TrailingCommaInArguments:
+  Enabled: true
 
-# For discussion - 72 fails on Chopin, none on others
-# Style/TrailingCommaInArrayLiteral:
-#   Enabled: true
+# Will require Chopin override
+Style/TrailingCommaInArrayLiteral:
+  Enabled: true
 
 Style/TrailingCommaInBlockArgs:
   Enabled: true
 
-# For discussion - 100s of fails on Chopin and Coco, none on Rater
-# Style/TrailingCommaInHashLiteral:
-#   Enabled: true
+# Will require Chopin override
+Style/TrailingCommaInHashLiteral:
+  Enabled: true
 
 Style/TrailingMethodEndStatement:
   Enabled: true
@@ -1720,9 +1751,13 @@ Style/WhileUntilDo:
 Style/WhileUntilModifier:
   Enabled: true
 
+# Overridden to false in Chopin
 Style/WordArray:
   EnforcedStyle: brackets
 
+Style/YAMLFileRead:
+  Enabled: true
+
 Style/YodaCondition:
   Enabled: false