simplycop 1.12.23 → 1.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fbc8fea3a5b127fa08a9d250016fd102b9a846290fef76953b2bf15b980f69f2
-  data.tar.gz: ed171ab56435846964f89828447bf366e3a69254b25a85ed973e993e71bda264
+  metadata.gz: 7ae29a50f1ec1a006769ef247d908f9517b9c7e94f1d19ff0667b4533a2bf9b8
+  data.tar.gz: 2f2beda956c1d3a780b67999a4befd42f03f7adb58f12b7b899ef735e650882c
 SHA512:
-  metadata.gz: 43943e46ce61242743dd098df0382c8a19478b85f44bb5508bd6bafe3b9095fbd6479f94c8017f066ea709c657f7aef3031c9ee76e159a5c372df7ee3d3b1e29
-  data.tar.gz: f64ea04d619da3c8bedb46d2496bc4c086ea7e8be55ff2a47f497ec2a7c4bae8f49bb7425842d1c9464f3c091c5037656b4fc5369cfecfd0a65c6649edd5a52e
+  metadata.gz: 3b9e27c39b2d9b260fe973e85dfc683a2fd8ecf892dc741ded7c08e295114bbc7b95e9175a0fa478879a5f2781b06ad3fe281bde679c5b67e2e1ac897b60c3c8
+  data.tar.gz: dcf83bc15f5a8db3180df118b58f125a5e6529f3845d3f3f285fb0adc4bbaff68f0ce02a7166e2ed6c3309b5249f085b18f44f585a3b5f26761ba1fea9ca7a95

data/.simplycop.yml

@@ -58,7 +58,7 @@ Gemspec/DuplicatedAssignment:
 Gemspec/OrderedDependencies:
   Enabled: true
 
-# TODO: Suggest true but 4 fails on Chopin, 3 on Rater 
+# TODO: Suggest true but 4 fails on Chopin, 3 on Rater, overridden to false on Chopin
 # Gemspec/RequireMFA:
 #   Enabled: true
 
@@ -229,12 +229,15 @@ Layout/LeadingCommentSpace:
 Layout/LeadingEmptyLines:
   Enabled: true
 
+# Overridden to false in Chopin
 Layout/LineContinuationLeadingSpace:
   Enabled: true
 
+# Overridden to false in Chopin
 Layout/LineContinuationSpacing:
   Enabled: true
 
+# Overridden to false in Chopin
 Layout/LineEndStringConcatenationIndentation:
   Enabled: true
 
@@ -390,9 +393,11 @@ Lint/AmbiguousBlockAssociation:
 Lint/AmbiguousOperator:
   Enabled: true
 
+# Overridden to false in Chopin
 Lint/AmbiguousOperatorPrecedence:
   Enabled: true
 
+# Overridden to false in Chopin
 Lint/AmbiguousRange:
   Enabled: true
 
@@ -584,6 +589,7 @@ Lint/NextWithoutAccumulator:
 Lint/NoReturnInBeginEndBlocks:
   Enabled: true
 
+# Overridden to false in Chopin
 Lint/NonAtomicFileOperation:
   Enabled: true
 
@@ -665,6 +671,7 @@ Lint/RequireParentheses:
 Lint/RequireRangeParentheses:
   Enabled: true
 
+# Overridden to false in Chopin
 Lint/RequireRelativeSelfPath:
   Enabled: true
 
@@ -790,55 +797,46 @@ Lint/UselessTimes:
 Lint/Void:
   Enabled: true
 
-# To discuss. Suggest enabling with suitable max and progressively lower. 
-# Chopin currently set at 91. Couldn't be lowered much. 671 fails at default of 17.
-# Rater currently set at 83. Looks like it could be lowered to c. 40. 111 fails at default of 17.
-# 54 fails in CoCo
-# Metrics/AbcSize:
-#   Max: tbc
+# METRICS COPS
+
+# Metrics cops are enabled by default with the expectation that many repos will 
+# have to set their own limits or disable. #technical-excellence-community discussion
+# suggested some liked to work from them, and that overriding should be a conscious decision
+
+Metrics/AbcSize:
+  Enabled: true
 
-# To discuss. Keep current exclusion as below but decide on suitable max. Still currently needs many overrides.
-# At default of 25, 269 fails on Chopin, 10584 on Rater, 18 on CoCo.
 Metrics/BlockLength:
+  Enabled: true
   Exclude:
     - spec/**/*.rb
 
 Metrics/BlockNesting:
   Enabled: true
 
-# To discuss: set new max? Chopin has one class - rfq - at 554. Exclude and set lower max for elsewhere?
-# CoCo 8 fails at > 100. Max 225. Rater OK
 Metrics/ClassLength:
-  Max: 512
+  Enabled: true
 
 Metrics/CollectionLiteralLength:
   Enabled: true 
 
-# Chopin 31 fails at > 7. Max 18.
-# Rater 11 at > 7. Max 21
-# CoCo 9 at > 7. Max 13
-# Set at 21 to prevent further growth. Discuss setting lower.
 Metrics/CyclomaticComplexity:
-  Max: 21
+  Enabled: true
 
-# To discuss. Chopin 1541 fails at > 10, max 118; Rater 330, max 25 with exclusions; CoCo 87, max 51
-# Metrics/MethodLength:
-#   Max: tbc
+Metrics/MethodLength:
+  Enabled: true
+  Exclude:
+    - spec/**/*.rb
 
-# To discuss. Chopin 22 fails at > 100, max 1521; Rater 31, max 370; CoCo 2, max 160
-# Metrics/ModuleLength:
-#   Max: tbc
+Metrics/ModuleLength:
+  Enabled: true
 
 Metrics/ParameterLists:
   CountKeywordArgs: false
   Enabled: true
 
-# Chopin 15 fails at > 8. Max 19.
-# Rater 9 at > 8. Max 21
-# CoCo 5 at > 8. Max 13
-# Set at 21 to prevent further growth. Discuss setting lower.
 Metrics/PerceivedComplexity:
-  Max: 21
+  Enabled: true
 
 Migration/DepartmentName:
   Enabled: true
@@ -884,13 +882,15 @@ Naming/InclusiveLanguage:
 Naming/MethodName:
   Enabled: true
 
-# To discuss: suggest true with possible allowed exceptions as below (10 fails on Chopin, exceptions would allow 4)
+# To discuss: suggest true with possible allowed exceptions as below (10 fails on Chopin, exceptions would allow 4, 
+# as and to are already exceptions in Rater so would remove need to configure there)
 # Naming/MethodParameterName:
 #   Enabled: true
 #   AllowedNames:
-#     - e
+#     - as
 #     - ex
 #     - n
+#     - to
 
 # To discuss: suggest true but 52 fails in Chopin, 8 in Coco (consider with Naming/AccessorName)
 # Naming/PredicateName:
@@ -909,6 +909,7 @@ Naming/VariableName:
 #   Enabled: true
 #   EnforcedStyle: snake_case
 
+# Overridden to false in Chopin
 Security/CompoundHash:
   Enabled: true
 
@@ -916,6 +917,7 @@ Security/CompoundHash:
 # Security/Eval:
 #   Enabled: true
 
+# Overridden to false on Chopin
 Security/IoMethods:
   Enabled: true
 
@@ -951,6 +953,7 @@ Style/ArgumentsForwarding:
 Style/ArrayCoercion:
   Enabled: true
 
+# Overridden to false in Chopin
 Style/ArrayIntersect:
   Enabled: true
 
@@ -959,7 +962,9 @@ Style/ArrayJoin:
 
 Style/AsciiComments:
   Enabled: true
-  AllowedChars: [£, ©]
+  AllowedChars: 
+    - £
+    - ©
 
 Style/Attr:
   Enabled: true
@@ -1037,8 +1042,8 @@ Style/CommentedKeyword:
   Enabled: true
 
 # TODO: Single fail on Rater
-# Style/ComparableClamp:
-#   Enabled: true
+Style/ComparableClamp:
+  Enabled: true
 
 Style/ConcatArrayLiterals:
   Enabled: true
@@ -1133,9 +1138,8 @@ Style/EvalWithLocation:
 Style/EvenOdd:
   Enabled: true
 
-# Added in version 1.51, unable to check v Chopin, CoCo, Rater yet
-# Style/ExactRegexpMatch:
-#   Enabled: true
+Style/ExactRegexpMatch:
+  Enabled: true
 
 Style/ExpandPathArguments:
   Enabled: true
@@ -1146,6 +1150,7 @@ Style/ExplicitBlockArgument:
 Style/ExponentialNotation:
   Enabled: false
 
+# Overridden to false in Chopin
 Style/FetchEnvVar:
   Enabled: true
 
@@ -1155,6 +1160,7 @@ Style/FileEmpty:
 Style/FileRead: # new in 1.24
   Enabled: true
 
+# Overridden to false in Chopin
 Style/FileWrite:
   Enabled: true
 
@@ -1197,9 +1203,10 @@ Style/HashExcept:
 Style/HashLikeCase:
   Enabled: false
 
-# For discussion - 11000+ fails on Chopin if true by default
-# Style/HashSyntax:
-#   Enabled: false
+Style/HashSyntax:
+  Enabled: true
+  EnforcedStyle: no_mixed_keys
+  EnforcedShorthandSyntax: consistent
 
 Style/HashTransformKeys:
   Enabled: true
@@ -1269,12 +1276,13 @@ Style/MagicCommentFormat: # new in 1.35
 Style/MapCompactWithConditionalBlock: # new in 1.30
   Enabled: true
 
+# Overridden to false in Chopin
 Style/MapToHash:
   Enabled: true
 
-# TODO: small number of fixes in Chopin
-# Style/MapToSet:
-#   Enabled: true
+# Overridden to false in Chopin
+Style/MapToSet:
+  Enabled: true
 
 # For discussion - 1000s of fails, suggest false
 # Style/MethodCallWithArgsParentheses:
@@ -1293,9 +1301,9 @@ Style/MethodDefParentheses:
 Style/MinMax:
   Enabled: true
 
-# For discussion - multiple fails, suggest true
-# Style/MinMaxComparison:
-#   Enabled: true
+# Overridden to false in Chopin
+Style/MinMaxComparison:
+  Enabled: true
 
 # For discussion - 100s of fails with default true
 # Style/MissingElse:
@@ -1404,15 +1412,15 @@ Style/ObjectThen: # new in 1.28
 Style/OneLineConditional:
   Enabled: true
 
+# Overridden to false in Chopin
 Style/OpenStructUse:
   Enabled: true
 
 Style/OperatorMethodCall:
   Enabled: true
 
-# For discussion - suggest true, but dozens of fails on Chopin and handful on Coco, Rater
-# Style/OptionHash:
-#   Enabled: true
+Style/OptionHash:
+  Enabled: true
 
 Style/OptionalArguments:
   Enabled: true
@@ -1444,6 +1452,7 @@ Style/PreferredHashMethods:
 Style/Proc:
   Enabled: true
 
+# Overridden to false in Chopin
 Style/QuotedSymbols:
   Enabled: true
 
@@ -1526,6 +1535,7 @@ Style/RedundantSelf:
 Style/RedundantSelfAssignment:
   Enabled: true
 
+# Overridden to false in Chopin
 Style/RedundantSelfAssignmentBranch:
   Enabled: true
 
@@ -1535,6 +1545,7 @@ Style/RedundantSort:
 Style/RedundantSortBy:
   Enabled: true
 
+# Overridden to false in Chopin
 Style/RedundantStringEscape:
   Enabled: true
 
@@ -1562,6 +1573,7 @@ Style/SafeNavigation:
 Style/Sample:
   Enabled: true
 
+# Overridden to false in Chopin
 Style/SelectByRegexp:
   Enabled: true
 
@@ -1581,9 +1593,10 @@ Style/SignalException:
 Style/SingleArgumentDig:
   Enabled: true
 
-# TODO: Small number of autocorrectables on Chopin and Rater
-# Style/SingleLineBlockParams:
-#   Enabled: true
+# If this is to be set true, desired param names need to be set for reduce and inject
+# (default is |acc, elem|) and current usage suggests domain relevant names are preferred
+Style/SingleLineBlockParams:
+  Enabled: false
 
 Style/SingleLineMethods:
   Enabled: true
@@ -1689,9 +1702,8 @@ Style/TrivialAccessors:
 Style/UnlessElse:
   Enabled: true
 
-# Single fail on each of Chopin and Rater
-# Style/UnlessLogicalOperators:
-#   Enabled: true
+Style/UnlessLogicalOperators:
+  Enabled: true
 
 Style/UnpackFirst:
   Enabled: true
@@ -1711,13 +1723,11 @@ Style/WhileUntilModifier:
 Style/WordArray:
   EnforcedStyle: brackets
 
-# For discussion - causes no fails but maybe some may like it?
-# Style/YodaCondition:
-#   Enabled: true
+Style/YodaCondition:
+  Enabled: false
 
-# For discussion with above - causes multiple fails
-# Style/YodaExpression:
-#   Enabled: true
+Style/YodaExpression:
+  Enabled: false
 
 Style/ZeroLengthPredicate:
   Enabled: true

data/.simplycop_performance.yml

@@ -0,0 +1,62 @@
+require:
+  - rubocop-performance
+
+Performance/AncestorsInclude:
+  Enabled: true
+
+Performance/BigDecimalWithNumericArgument:
+  Enabled: true
+
+Performance/BlockGivenWithExplicitBlock:
+  Enabled: true
+
+Performance/Casecmp:
+  Enabled: true
+
+Performance/CollectionLiteralInLoop:
+  Enabled: true
+
+Performance/ConcurrentMonotonicTime:
+  Enabled: true
+
+Performance/ConstantRegexp:
+  Enabled: true
+
+Performance/MapCompact: # Filter_map removes [false]
+  Enabled: false
+
+Performance/MethodObjectAsBlock:
+  Enabled: true
+
+Performance/RedundantBlockCall: # Causes conflicting warnings with normal rubocop enabled
+  Enabled: false
+
+Performance/RedundantEqualityComparisonBlock:
+  Enabled: true
+
+Performance/RedundantSortBlock:
+  Enabled: true
+
+Performance/RedundantSplitRegexpArgument:
+  Enabled: true
+
+Performance/RedundantStringChars:
+  Enabled: true
+
+Performance/ReverseFirst:
+  Enabled: true
+
+Performance/SortReverse:
+  Enabled: true
+
+Performance/Squeeze:
+  Enabled: true
+
+Performance/StringIdentifierArgument:
+  Enabled: true
+
+Performance/StringInclude:
+  Enabled: true
+
+Performance/Sum:
+  Enabled: true

data/docs/index.md

@@ -26,12 +26,13 @@ AllCops:
     - 'vendor/**/*'
 ```
 
-* If you are implementing this in rails project and have rspec , you probably want the standard rails and rspec cops. you can include this by adding:
+* If you are implementing this in rails project and have rspec , you probably want the standard rails, rspec, and performance cops. you can include this by adding:
 
 ```yaml
 inherit_gem:
   simplycop:
     - .simplycop.yml
+    - .simplycop_performance.yml
     - .simplycop_rails.yml
     - .simplycop_rspec.yml
 ```

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.12.23'
+  VERSION = '1.13.0'
 end

data/simplycop.gemspec

@@ -18,6 +18,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'rubocop', '~> 1.42'
+  spec.add_dependency 'rubocop-performance', '~> 1.15'
   spec.add_dependency 'rubocop-rails', '~> 2.17'
   spec.add_dependency 'rubocop-rspec', '~> 2.16'
   spec.add_development_dependency 'bundler', '>= 2.2.15'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.12.23
+  version: 1.13.0
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-06-01 00:00:00.000000000 Z
+date: 2023-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.42'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.15'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.15'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -117,6 +131,7 @@ files:
 - ".ruby-version"
 - ".simplycop.yml"
 - ".simplycop_metaprogramming.yml"
+- ".simplycop_performance.yml"
 - ".simplycop_rails.yml"
 - ".simplycop_rspec.yml"
 - ".simplycop_security.yml"