simplycop 1.12.22 → 1.12.24

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4300fe0cef92b1860b5f9778f1841ebd1db3341ef2a752dfc2d5033c4d9e4beb
-  data.tar.gz: 78b46b78d6f1dce94788fde32a06531c037857547d2b1c6ef98e87b700545c93
+  metadata.gz: b1e606f65e8473ad122d343ad2a2c233e81c3aaed4d666575fb245a0b2aa761b
+  data.tar.gz: 2a6dcee6680252df61da89a9fa43d4bbe1ab77cfbf697ae8339c4e68d43b1a53
 SHA512:
-  metadata.gz: 4f19dd0c98414a22df7d38285caeb140b92d80618dad5c462e93939d270090dbf623002d18f43088d9f57ce2b68b199b612d8172329e47442efeef104c70e08e
-  data.tar.gz: aed4ed02ab4fba9da43e3ae962f2f8b55a327f1af0881f98734eae7d3bd2e4d8bf07e183f15aa300b639438bf5228fa1e1145e4c51464214e0790f19622cafb9
+  metadata.gz: 5edbc9322e4f83c7888eb4db682169825d7f530988abb7e5623c829a743b783bedc28ac64f93c0b99c543629de5fd99e7d772feb88e41307abf6d62df4e786ad
+  data.tar.gz: 70a6de5c7df05ce6fd4dc66b4191b7aaf5ceda55591d076326e2aacd6c109339d3a808fe2c464d91124d97af14b09cb1bddb0cc8a417e74877888e3afa51eb08

data/.simplycop.yml

@@ -58,7 +58,7 @@ Gemspec/DuplicatedAssignment:
 Gemspec/OrderedDependencies:
   Enabled: true
 
-# TODO: Suggest true but 4 fails on Chopin, 3 on Rater 
+# TODO: Suggest true but 4 fails on Chopin, 3 on Rater, overridden to false on Chopin
 # Gemspec/RequireMFA:
 #   Enabled: true
 
@@ -229,12 +229,15 @@ Layout/LeadingCommentSpace:
 Layout/LeadingEmptyLines:
   Enabled: true
 
+# Overridden to false in Chopin
 Layout/LineContinuationLeadingSpace:
   Enabled: true
 
+# Overridden to false in Chopin
 Layout/LineContinuationSpacing:
   Enabled: true
 
+# Overridden to false in Chopin
 Layout/LineEndStringConcatenationIndentation:
   Enabled: true
 
@@ -387,101 +390,454 @@ Lint/AmbiguousBlockAssociation:
   Exclude:
     - spec/**/*
 
+Lint/AmbiguousOperator:
+  Enabled: true
+
+# Overridden to false in Chopin
 Lint/AmbiguousOperatorPrecedence:
   Enabled: true
 
+# Overridden to false in Chopin
 Lint/AmbiguousRange:
   Enabled: true
 
+# TODO: One fail on rater spec then would pass
+# Lint/AmbiguousRegexpLiteral:
+#   Enabled: true
+
+Lint/AssignmentInCondition:
+  Enabled: true
+  
+Lint/BigDecimalNew:
+  Enabled: true
+
+Lint/BinaryOperatorWithIdenticalOperands:
+  Enabled: true
+
+Lint/BooleanSymbol:
+  Enabled: true
+
+Lint/CircularArgumentReference:
+  Enabled: true
+
+# TODO: 6 fails in Rater, otherwise clear
+# Lint/ConstantDefinitionInBlock:
+#   Enabled: true
+
 Lint/ConstantOverwrittenInRescue: # new in 1.31
   Enabled: true
 
+# Set to false as 10000s of fails on Rater and Chopin if enabled
+# Rubocop docs suggest enabling only for constants that may cause concern
+# so enable and set these if required
+Lint/ConstantResolution:
+  Enabled: false 
+
+Lint/Debugger:
+  Enabled: true 
+
+Lint/DeprecatedClassMethods:
+  Enabled: true 
+
 Lint/DeprecatedConstants:
   Enabled: true
 
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
+Lint/DisjunctiveAssignmentInConstructor:
+  Enabled: true
+
 Lint/DuplicateBranch:
   Enabled: true
 
+Lint/DuplicateCaseCondition:
+  Enabled: true
+
+Lint/DuplicateElsifCondition:
+  Enabled: true
+
+Lint/DuplicateHashKey:
+  Enabled: true
+
 Lint/DuplicateMagicComment:
   Enabled: true
 
+Lint/DuplicateMatchPattern:
+  Enabled: true
+
 Lint/DuplicateMethods:
   Enabled: true
 
 Lint/DuplicateRegexpCharacterClassElement:
   Enabled: true
 
+Lint/DuplicateRequire:
+  Enabled: true
+
+Lint/DuplicateRescueException:
+  Enabled: true
+
+Lint/EachWithObjectArgument:
+  Enabled: true
+
+# TODO: 19 autocorrectable odd else layouts in Rater  
+# Lint/ElseLayout:
+#   Enabled: true
+
 Lint/EmptyBlock:
   Enabled: true
 
 Lint/EmptyClass:
   Enabled: true
 
+Lint/EmptyConditionalBody:
+  Enabled: true 
+
+Lint/EmptyEnsure:
+  Enabled: true 
+
+Lint/EmptyExpression:
+  Enabled: true 
+
+Lint/EmptyFile:
+  Enabled: true 
+
 Lint/EmptyInPattern: # new in 1.16
+  Enabled: true 
+
+Lint/EmptyInterpolation:
+  Enabled: true 
+
+Lint/EmptyWhen:
   Enabled: true
 
+Lint/ErbNewArguments:
+  Enabled: true 
+
+Lint/FlipFlop:
+  Enabled: true 
+
+Lint/FloatComparison:
+  Enabled: true 
+
+Lint/FloatOutOfRange:
+  Enabled: true 
+
+Lint/FormatParameterMismatch:
+  Enabled: true 
+
+Lint/HashCompareByIdentity:
+  Enabled: true 
+
 Lint/HeredocMethodCallPosition:
   Enabled: true
 
+Lint/IdentityComparison:
+  Enabled: true 
+
+Lint/ImplicitStringConcatenation:
+  Enabled: true 
+
 Lint/IncompatibleIoSelectWithFiberScheduler: # new in 1.21
   Enabled: true
 
+# TODO: two fails on Rater, one on CoCo, otherwise fine to enable
+# Lint/IneffectiveAccessModifier:
+#   Enabled: true 
+
+Lint/InheritException:
+  Enabled: true 
+
+Lint/InterpolationCheck:
+  Enabled: true
+
 Lint/LambdaWithoutLiteralBlock:
   Enabled: true
 
+Lint/LiteralAsCondition:
+  Enabled: true
+
+Lint/LiteralInInterpolation:
+  Enabled: true
+
+Lint/Loop:
+  Enabled: true
+
+Lint/MissingCopEnableDirective:
+  Enabled: true
+
+# TODO: Handful of errors on Rater and CoCo
+# Lint/MissingSuper:
+#   Enabled: true
+
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+
+Lint/MultipleComparison:
+  Enabled: true
+
+Lint/NestedMethodDefinition:
+  Enabled: true
+
+Lint/NestedPercentLiteral:
+  Enabled: true
+
+Lint/NextWithoutAccumulator:
+  Enabled: true
+
 Lint/NoReturnInBeginEndBlocks:
   Enabled: true
 
+# Overridden to false in Chopin
 Lint/NonAtomicFileOperation:
   Enabled: true
 
+Lint/NonDeterministicRequireOrder:
+  Enabled: true 
+
+Lint/NonLocalExitFromIterator:
+  Enabled: true 
+
+# 100s of fails on Rater and Chopin
+# Lint/NumberConversion:
+#   Enabled: true 
+
 Lint/NumberedParameterAssignment:
   Enabled: true
 
 Lint/OrAssignmentToConstant:
   Enabled: true
 
+Lint/OrderedMagicComments:
+  Enabled: true 
+
+Lint/OutOfRangeRegexpRef:
+  Enabled: true 
+
+Lint/ParenthesesAsGroupedExpression:
+  Enabled: true 
+
+Lint/PercentStringArray:
+  Enabled: true 
+
+Lint/PercentSymbolArray:
+  Enabled: true 
+
+Lint/RaiseException:
+  Enabled: true 
+
+Lint/RandOne:
+  Enabled: true 
+
+# Can't be checked with --only, enable once Rater and Chopin up to date with Simplycop
+# Lint/RedundantCopDisableDirective:
+#   Enabled: true 
+
+# Can't be checked with --only, enable once Rater and Chopin up to date with Simplycop
+# Lint/RedundantCopEnableDirective:
+#   Enabled: true 
+
 Lint/RedundantDirGlobSort:
   Enabled: true
 
+Lint/RedundantRequireStatement:
+  Enabled: true
+
+Lint/RedundantSafeNavigation:
+  Enabled: true
+
+Lint/RedundantSplatExpansion:
+  Enabled: true
+
+Lint/RedundantStringCoercion:
+  Enabled: true
+
+Lint/RedundantWithIndex:
+  Enabled: true
+
+Lint/RedundantWithObject:
+  Enabled: true
+
 Lint/RefinementImportMethods:
   Enabled: true
 
+Lint/RegexpAsCondition:
+  Enabled: true
+
+Lint/RequireParentheses:
+  Enabled: true
+
 Lint/RequireRangeParentheses:
   Enabled: true
 
+# Overridden to false in Chopin
 Lint/RequireRelativeSelfPath:
   Enabled: true
 
+Lint/RescueException:
+  Enabled: true
+
+Lint/RescueType:
+  Enabled: true
+
+Lint/ReturnInVoidContext:
+  Enabled: true
+
+Lint/SafeNavigationChain:
+  Enabled: true
+
+Lint/SafeNavigationConsistency:
+  Enabled: true
+
+Lint/SafeNavigationWithEmpty:
+  Enabled: true
+
+Lint/ScriptPermission:
+  Enabled: true
+
+Lint/SelfAssignment:
+  Enabled: true
+
+Lint/SendWithMixinArgument:
+  Enabled: true
+
+Lint/ShadowedArgument:
+  Enabled: true
+
+Lint/ShadowedException:
+  Enabled: true
+
+# To discuss: 63 offences on Chopin, none on Rater, CoCo
+# Lint/ShadowingOuterLocalVariable:
+#   Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+Lint/SuppressedException:
+  Enabled: true
+
 Lint/SymbolConversion:
   Enabled: true
 
+Lint/Syntax:
+  Enabled: true
+
 Lint/ToEnumArguments:
   Enabled: true
 
+Lint/ToJSON:
+  Enabled: true
+
+Lint/TopLevelReturnWithArgument:
+  Enabled: true
+
+Lint/TrailingCommaInAttributeDeclaration:
+  Enabled: true
+
 Lint/TripleQuotes:
   Enabled: true
 
+Lint/UnderscorePrefixedVariableName:
+  Enabled: true
+
 Lint/UnexpectedBlockArity:
   Enabled: true
 
+Lint/UnifiedInteger:
+  Enabled: true
+
 Lint/UnmodifiedReduceAccumulator:
   Enabled: true
 
+Lint/UnreachableCode:
+  Enabled: true
+
+Lint/UnreachableLoop:
+  Enabled: true
+
+Lint/UnusedBlockArgument:
+  Enabled: true
+
+Lint/UnusedMethodArgument:
+  Enabled: true
+
+Lint/UriEscapeUnescape:
+  Enabled: true
+
+Lint/UriRegexp:
+  Enabled: true
+
+Lint/UselessAccessModifier:
+  Enabled: true
+
+Lint/UselessAssignment:
+  Enabled: true
+
+Lint/UselessElseWithoutRescue:
+  Enabled: true
+
+Lint/UselessMethodDefinition:
+  Enabled: true
+
+# TODO: Single fail on Chopin
+# Lint/UselessRescue:
+#   Enabled: true
+
 Lint/UselessRuby2Keywords:
   Enabled: true
 
+Lint/UselessSetterCall:
+  Enabled: true
+
+Lint/UselessTimes:
+  Enabled: true
+
+Lint/Void:
+  Enabled: true
+
+# METRICS COPS
+
+# Metrics cops are enabled by default with the expectation that many repos will 
+# have to set their own limits or disable. #technical-excellence-community discussion
+# suggested some liked to work from them, and that overriding should be a conscious decision
+
+Metrics/AbcSize:
+  Enabled: true
+
 Metrics/BlockLength:
+  Enabled: true
   Exclude:
     - spec/**/*.rb
 
+Metrics/BlockNesting:
+  Enabled: true
+
 Metrics/ClassLength:
-  Max: 512
+  Enabled: true
+
+Metrics/CollectionLiteralLength:
+  Enabled: true 
+
+Metrics/CyclomaticComplexity:
+  Enabled: true
+
+Metrics/MethodLength:
+  Enabled: true
+  Exclude:
+    - spec/**/*.rb
+
+Metrics/ModuleLength:
+  Enabled: true
 
 Metrics/ParameterLists:
   CountKeywordArgs: false
   Enabled: true
 
+Metrics/PerceivedComplexity:
+  Enabled: true
+
 Migration/DepartmentName:
   Enabled: true
 
@@ -526,13 +882,15 @@ Naming/InclusiveLanguage:
 Naming/MethodName:
   Enabled: true
 
-# To discuss: suggest true with possible allowed exceptions as below (10 fails on Chopin, exceptions would allow 4)
+# To discuss: suggest true with possible allowed exceptions as below (10 fails on Chopin, exceptions would allow 4, 
+# as and to are already exceptions in Rater so would remove need to configure there)
 # Naming/MethodParameterName:
 #   Enabled: true
 #   AllowedNames:
-#     - e
+#     - as
 #     - ex
 #     - n
+#     - to
 
 # To discuss: suggest true but 52 fails in Chopin, 8 in Coco (consider with Naming/AccessorName)
 # Naming/PredicateName:
@@ -551,6 +909,7 @@ Naming/VariableName:
 #   Enabled: true
 #   EnforcedStyle: snake_case
 
+# Overridden to false in Chopin
 Security/CompoundHash:
   Enabled: true
 
@@ -558,6 +917,7 @@ Security/CompoundHash:
 # Security/Eval:
 #   Enabled: true
 
+# Overridden to false on Chopin
 Security/IoMethods:
   Enabled: true
 
@@ -593,6 +953,7 @@ Style/ArgumentsForwarding:
 Style/ArrayCoercion:
   Enabled: true
 
+# Overridden to false in Chopin
 Style/ArrayIntersect:
   Enabled: true
 
@@ -601,7 +962,9 @@ Style/ArrayJoin:
 
 Style/AsciiComments:
   Enabled: true
-  AllowedChars: [£, ©]
+  AllowedChars: 
+    - £
+    - ©
 
 Style/Attr:
   Enabled: true
@@ -679,8 +1042,8 @@ Style/CommentedKeyword:
   Enabled: true
 
 # TODO: Single fail on Rater
-# Style/ComparableClamp:
-#   Enabled: true
+Style/ComparableClamp:
+  Enabled: true
 
 Style/ConcatArrayLiterals:
   Enabled: true
@@ -775,9 +1138,8 @@ Style/EvalWithLocation:
 Style/EvenOdd:
   Enabled: true
 
-# Added in version 1.51, unable to check v Chopin, CoCo, Rater yet
-# Style/ExactRegexpMatch:
-#   Enabled: true
+Style/ExactRegexpMatch:
+  Enabled: true
 
 Style/ExpandPathArguments:
   Enabled: true
@@ -788,6 +1150,7 @@ Style/ExplicitBlockArgument:
 Style/ExponentialNotation:
   Enabled: false
 
+# Overridden to false in Chopin
 Style/FetchEnvVar:
   Enabled: true
 
@@ -797,6 +1160,7 @@ Style/FileEmpty:
 Style/FileRead: # new in 1.24
   Enabled: true
 
+# Overridden to false in Chopin
 Style/FileWrite:
   Enabled: true
 
@@ -839,9 +1203,10 @@ Style/HashExcept:
 Style/HashLikeCase:
   Enabled: false
 
-# For discussion - 11000+ fails on Chopin if true by default
-# Style/HashSyntax:
-#   Enabled: false
+Style/HashSyntax:
+  Enabled: true
+  EnforcedStyle: no_mixed_keys
+  EnforcedShorthandSyntax: consistent
 
 Style/HashTransformKeys:
   Enabled: true
@@ -911,12 +1276,13 @@ Style/MagicCommentFormat: # new in 1.35
 Style/MapCompactWithConditionalBlock: # new in 1.30
   Enabled: true
 
+# Overridden to false in Chopin
 Style/MapToHash:
   Enabled: true
 
-# TODO: small number of fixes in Chopin
-# Style/MapToSet:
-#   Enabled: true
+# Overridden to false in Chopin
+Style/MapToSet:
+  Enabled: true
 
 # For discussion - 1000s of fails, suggest false
 # Style/MethodCallWithArgsParentheses:
@@ -935,9 +1301,9 @@ Style/MethodDefParentheses:
 Style/MinMax:
   Enabled: true
 
-# For discussion - multiple fails, suggest true
-# Style/MinMaxComparison:
-#   Enabled: true
+# Overridden to false in Chopin
+Style/MinMaxComparison:
+  Enabled: true
 
 # For discussion - 100s of fails with default true
 # Style/MissingElse:
@@ -1046,15 +1412,15 @@ Style/ObjectThen: # new in 1.28
 Style/OneLineConditional:
   Enabled: true
 
+# Overridden to false in Chopin
 Style/OpenStructUse:
   Enabled: true
 
 Style/OperatorMethodCall:
   Enabled: true
 
-# For discussion - suggest true, but dozens of fails on Chopin and handful on Coco, Rater
-# Style/OptionHash:
-#   Enabled: true
+Style/OptionHash:
+  Enabled: true
 
 Style/OptionalArguments:
   Enabled: true
@@ -1086,6 +1452,7 @@ Style/PreferredHashMethods:
 Style/Proc:
   Enabled: true
 
+# Overridden to false in Chopin
 Style/QuotedSymbols:
   Enabled: true
 
@@ -1168,6 +1535,7 @@ Style/RedundantSelf:
 Style/RedundantSelfAssignment:
   Enabled: true
 
+# Overridden to false in Chopin
 Style/RedundantSelfAssignmentBranch:
   Enabled: true
 
@@ -1177,6 +1545,7 @@ Style/RedundantSort:
 Style/RedundantSortBy:
   Enabled: true
 
+# Overridden to false in Chopin
 Style/RedundantStringEscape:
   Enabled: true
 
@@ -1204,6 +1573,7 @@ Style/SafeNavigation:
 Style/Sample:
   Enabled: true
 
+# Overridden to false in Chopin
 Style/SelectByRegexp:
   Enabled: true
 
@@ -1223,9 +1593,10 @@ Style/SignalException:
 Style/SingleArgumentDig:
   Enabled: true
 
-# TODO: Small number of autocorrectables on Chopin and Rater
-# Style/SingleLineBlockParams:
-#   Enabled: true
+# If this is to be set true, desired param names need to be set for reduce and inject
+# (default is |acc, elem|) and current usage suggests domain relevant names are preferred
+Style/SingleLineBlockParams:
+  Enabled: false
 
 Style/SingleLineMethods:
   Enabled: true
@@ -1331,9 +1702,8 @@ Style/TrivialAccessors:
 Style/UnlessElse:
   Enabled: true
 
-# Single fail on each of Chopin and Rater
-# Style/UnlessLogicalOperators:
-#   Enabled: true
+Style/UnlessLogicalOperators:
+  Enabled: true
 
 Style/UnpackFirst:
   Enabled: true
@@ -1353,13 +1723,11 @@ Style/WhileUntilModifier:
 Style/WordArray:
   EnforcedStyle: brackets
 
-# For discussion - causes no fails but maybe some may like it?
-# Style/YodaCondition:
-#   Enabled: true
+Style/YodaCondition:
+  Enabled: false
 
-# For discussion with above - causes multiple fails
-# Style/YodaExpression:
-#   Enabled: true
+Style/YodaExpression:
+  Enabled: false
 
 Style/ZeroLengthPredicate:
   Enabled: true

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.12.22'
+  VERSION = '1.12.24'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.12.22
+  version: 1.12.24
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-05-30 00:00:00.000000000 Z
+date: 2023-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop