simplycop 1.12.21 → 1.12.23

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 68e568f306249b37bfb255cdd58ec03e209b2f1e0d81be18c8ef015dab756c4d
-  data.tar.gz: 84681f62a6470b474340dc9ab33310721a2caf41ada7245d2ab17c39e37b9038
+  metadata.gz: fbc8fea3a5b127fa08a9d250016fd102b9a846290fef76953b2bf15b980f69f2
+  data.tar.gz: ed171ab56435846964f89828447bf366e3a69254b25a85ed973e993e71bda264
 SHA512:
-  metadata.gz: f139da031074eb065eb31ecf446da61ce67c4fb33e7286dd601e8a236d44cdf3473e048b20f3936f615236e4a7ac866cfdb614bca263236fc17b33b04072898e
-  data.tar.gz: 8a02a4aef2f054cec5b66af68d2a922bf6cd0481c6337c51d3aff1de4ca82bbdfb6b0cd978537d639889475aec737e88f2bae86482bbc39b37d05caf7e402a84
+  metadata.gz: 43943e46ce61242743dd098df0382c8a19478b85f44bb5508bd6bafe3b9095fbd6479f94c8017f066ea709c657f7aef3031c9ee76e159a5c372df7ee3d3b1e29
+  data.tar.gz: f64ea04d619da3c8bedb46d2496bc4c086ea7e8be55ff2a47f497ec2a7c4bae8f49bb7425842d1c9464f3c091c5037656b4fc5369cfecfd0a65c6649edd5a52e

data/.simplycop.yml

@@ -21,8 +21,52 @@ AllCops:
   ExtraDetails: true
 # Adapted from: https://github.com/simplybusiness/how-we-roll/blob/master/development/RUBYSTYLEGUIDE.markdown
 
+Bundler/DuplicatedGem:
+  Enabled: true
+
+Bundler/GemComment:
+  Enabled: false
+
+Bundler/GemFilename:
+  Enabled: true
+
+# To discuss: Suggest true but 103 fails on Chopin, 10 on Rater
+# Bundler/GemVersion:
+#   Enabled: true
+
+Bundler/InsecureProtocolSource:
+  Enabled: true
+
+Bundler/OrderedGems:
+  Enabled: true
+
+# To discuss: Suggest true but 3 fails on Chopin, 21 on Rater
+# Gemspec/DependencyVersion:
+#   Enabled: true
+
+# TODO: 1 autocorrectable in Rater and it would pass
+# Gemspec/DeprecatedAttributeAssignment:
+#   Enabled: true
+
+# To discuss: Suggest true but 2 fails on Chopin, 10 on Rater
+# Gemspec/DevelopmentDependencies:
+#   Enabled: true
+
+Gemspec/DuplicatedAssignment:
+  Enabled: true
+
+Gemspec/OrderedDependencies:
+  Enabled: true
+
+# TODO: Suggest true but 4 fails on Chopin, 3 on Rater 
+# Gemspec/RequireMFA:
+#   Enabled: true
+
+# TODO: Suggest true but 3 fails on Chopin
+# Gemspec/RequiredRubyVersion:
+#   Enabled: true
 
-Gemspec/DeprecatedAttributeAssignment: # new in 1.30
+Gemspec/RubyVersionGlobalsUsage:
   Enabled: true
 
 Layout/AccessModifierIndentation:
@@ -343,113 +387,552 @@ Lint/AmbiguousBlockAssociation:
   Exclude:
     - spec/**/*
 
+Lint/AmbiguousOperator:
+  Enabled: true
+
 Lint/AmbiguousOperatorPrecedence:
   Enabled: true
 
 Lint/AmbiguousRange:
   Enabled: true
 
+# TODO: One fail on rater spec then would pass
+# Lint/AmbiguousRegexpLiteral:
+#   Enabled: true
+
+Lint/AssignmentInCondition:
+  Enabled: true
+  
+Lint/BigDecimalNew:
+  Enabled: true
+
+Lint/BinaryOperatorWithIdenticalOperands:
+  Enabled: true
+
+Lint/BooleanSymbol:
+  Enabled: true
+
+Lint/CircularArgumentReference:
+  Enabled: true
+
+# TODO: 6 fails in Rater, otherwise clear
+# Lint/ConstantDefinitionInBlock:
+#   Enabled: true
+
 Lint/ConstantOverwrittenInRescue: # new in 1.31
   Enabled: true
 
+# Set to false as 10000s of fails on Rater and Chopin if enabled
+# Rubocop docs suggest enabling only for constants that may cause concern
+# so enable and set these if required
+Lint/ConstantResolution:
+  Enabled: false 
+
+Lint/Debugger:
+  Enabled: true 
+
+Lint/DeprecatedClassMethods:
+  Enabled: true 
+
 Lint/DeprecatedConstants:
   Enabled: true
 
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
+Lint/DisjunctiveAssignmentInConstructor:
+  Enabled: true
+
 Lint/DuplicateBranch:
   Enabled: true
 
+Lint/DuplicateCaseCondition:
+  Enabled: true
+
+Lint/DuplicateElsifCondition:
+  Enabled: true
+
+Lint/DuplicateHashKey:
+  Enabled: true
+
 Lint/DuplicateMagicComment:
   Enabled: true
 
+Lint/DuplicateMatchPattern:
+  Enabled: true
+
 Lint/DuplicateMethods:
   Enabled: true
 
 Lint/DuplicateRegexpCharacterClassElement:
   Enabled: true
 
+Lint/DuplicateRequire:
+  Enabled: true
+
+Lint/DuplicateRescueException:
+  Enabled: true
+
+Lint/EachWithObjectArgument:
+  Enabled: true
+
+# TODO: 19 autocorrectable odd else layouts in Rater  
+# Lint/ElseLayout:
+#   Enabled: true
+
 Lint/EmptyBlock:
   Enabled: true
 
 Lint/EmptyClass:
   Enabled: true
 
+Lint/EmptyConditionalBody:
+  Enabled: true 
+
+Lint/EmptyEnsure:
+  Enabled: true 
+
+Lint/EmptyExpression:
+  Enabled: true 
+
+Lint/EmptyFile:
+  Enabled: true 
+
 Lint/EmptyInPattern: # new in 1.16
+  Enabled: true 
+
+Lint/EmptyInterpolation:
+  Enabled: true 
+
+Lint/EmptyWhen:
   Enabled: true
 
+Lint/ErbNewArguments:
+  Enabled: true 
+
+Lint/FlipFlop:
+  Enabled: true 
+
+Lint/FloatComparison:
+  Enabled: true 
+
+Lint/FloatOutOfRange:
+  Enabled: true 
+
+Lint/FormatParameterMismatch:
+  Enabled: true 
+
+Lint/HashCompareByIdentity:
+  Enabled: true 
+
 Lint/HeredocMethodCallPosition:
   Enabled: true
 
+Lint/IdentityComparison:
+  Enabled: true 
+
+Lint/ImplicitStringConcatenation:
+  Enabled: true 
+
 Lint/IncompatibleIoSelectWithFiberScheduler: # new in 1.21
   Enabled: true
 
+# TODO: two fails on Rater, one on CoCo, otherwise fine to enable
+# Lint/IneffectiveAccessModifier:
+#   Enabled: true 
+
+Lint/InheritException:
+  Enabled: true 
+
+Lint/InterpolationCheck:
+  Enabled: true
+
 Lint/LambdaWithoutLiteralBlock:
   Enabled: true
 
+Lint/LiteralAsCondition:
+  Enabled: true
+
+Lint/LiteralInInterpolation:
+  Enabled: true
+
+Lint/Loop:
+  Enabled: true
+
+Lint/MissingCopEnableDirective:
+  Enabled: true
+
+# TODO: Handful of errors on Rater and CoCo
+# Lint/MissingSuper:
+#   Enabled: true
+
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+
+Lint/MultipleComparison:
+  Enabled: true
+
+Lint/NestedMethodDefinition:
+  Enabled: true
+
+Lint/NestedPercentLiteral:
+  Enabled: true
+
+Lint/NextWithoutAccumulator:
+  Enabled: true
+
 Lint/NoReturnInBeginEndBlocks:
   Enabled: true
 
 Lint/NonAtomicFileOperation:
   Enabled: true
 
+Lint/NonDeterministicRequireOrder:
+  Enabled: true 
+
+Lint/NonLocalExitFromIterator:
+  Enabled: true 
+
+# 100s of fails on Rater and Chopin
+# Lint/NumberConversion:
+#   Enabled: true 
+
 Lint/NumberedParameterAssignment:
   Enabled: true
 
 Lint/OrAssignmentToConstant:
   Enabled: true
 
+Lint/OrderedMagicComments:
+  Enabled: true 
+
+Lint/OutOfRangeRegexpRef:
+  Enabled: true 
+
+Lint/ParenthesesAsGroupedExpression:
+  Enabled: true 
+
+Lint/PercentStringArray:
+  Enabled: true 
+
+Lint/PercentSymbolArray:
+  Enabled: true 
+
+Lint/RaiseException:
+  Enabled: true 
+
+Lint/RandOne:
+  Enabled: true 
+
+# Can't be checked with --only, enable once Rater and Chopin up to date with Simplycop
+# Lint/RedundantCopDisableDirective:
+#   Enabled: true 
+
+# Can't be checked with --only, enable once Rater and Chopin up to date with Simplycop
+# Lint/RedundantCopEnableDirective:
+#   Enabled: true 
+
 Lint/RedundantDirGlobSort:
   Enabled: true
 
+Lint/RedundantRequireStatement:
+  Enabled: true
+
+Lint/RedundantSafeNavigation:
+  Enabled: true
+
+Lint/RedundantSplatExpansion:
+  Enabled: true
+
+Lint/RedundantStringCoercion:
+  Enabled: true
+
+Lint/RedundantWithIndex:
+  Enabled: true
+
+Lint/RedundantWithObject:
+  Enabled: true
+
 Lint/RefinementImportMethods:
   Enabled: true
 
+Lint/RegexpAsCondition:
+  Enabled: true
+
+Lint/RequireParentheses:
+  Enabled: true
+
 Lint/RequireRangeParentheses:
   Enabled: true
 
 Lint/RequireRelativeSelfPath:
   Enabled: true
 
+Lint/RescueException:
+  Enabled: true
+
+Lint/RescueType:
+  Enabled: true
+
+Lint/ReturnInVoidContext:
+  Enabled: true
+
+Lint/SafeNavigationChain:
+  Enabled: true
+
+Lint/SafeNavigationConsistency:
+  Enabled: true
+
+Lint/SafeNavigationWithEmpty:
+  Enabled: true
+
+Lint/ScriptPermission:
+  Enabled: true
+
+Lint/SelfAssignment:
+  Enabled: true
+
+Lint/SendWithMixinArgument:
+  Enabled: true
+
+Lint/ShadowedArgument:
+  Enabled: true
+
+Lint/ShadowedException:
+  Enabled: true
+
+# To discuss: 63 offences on Chopin, none on Rater, CoCo
+# Lint/ShadowingOuterLocalVariable:
+#   Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+Lint/SuppressedException:
+  Enabled: true
+
 Lint/SymbolConversion:
   Enabled: true
 
+Lint/Syntax:
+  Enabled: true
+
 Lint/ToEnumArguments:
   Enabled: true
 
+Lint/ToJSON:
+  Enabled: true
+
+Lint/TopLevelReturnWithArgument:
+  Enabled: true
+
+Lint/TrailingCommaInAttributeDeclaration:
+  Enabled: true
+
 Lint/TripleQuotes:
   Enabled: true
 
+Lint/UnderscorePrefixedVariableName:
+  Enabled: true
+
 Lint/UnexpectedBlockArity:
   Enabled: true
 
+Lint/UnifiedInteger:
+  Enabled: true
+
 Lint/UnmodifiedReduceAccumulator:
   Enabled: true
 
+Lint/UnreachableCode:
+  Enabled: true
+
+Lint/UnreachableLoop:
+  Enabled: true
+
+Lint/UnusedBlockArgument:
+  Enabled: true
+
+Lint/UnusedMethodArgument:
+  Enabled: true
+
+Lint/UriEscapeUnescape:
+  Enabled: true
+
+Lint/UriRegexp:
+  Enabled: true
+
+Lint/UselessAccessModifier:
+  Enabled: true
+
+Lint/UselessAssignment:
+  Enabled: true
+
+Lint/UselessElseWithoutRescue:
+  Enabled: true
+
+Lint/UselessMethodDefinition:
+  Enabled: true
+
+# TODO: Single fail on Chopin
+# Lint/UselessRescue:
+#   Enabled: true
+
 Lint/UselessRuby2Keywords:
   Enabled: true
 
+Lint/UselessSetterCall:
+  Enabled: true
+
+Lint/UselessTimes:
+  Enabled: true
+
+Lint/Void:
+  Enabled: true
+
+# To discuss. Suggest enabling with suitable max and progressively lower. 
+# Chopin currently set at 91. Couldn't be lowered much. 671 fails at default of 17.
+# Rater currently set at 83. Looks like it could be lowered to c. 40. 111 fails at default of 17.
+# 54 fails in CoCo
+# Metrics/AbcSize:
+#   Max: tbc
+
+# To discuss. Keep current exclusion as below but decide on suitable max. Still currently needs many overrides.
+# At default of 25, 269 fails on Chopin, 10584 on Rater, 18 on CoCo.
 Metrics/BlockLength:
   Exclude:
     - spec/**/*.rb
 
+Metrics/BlockNesting:
+  Enabled: true
+
+# To discuss: set new max? Chopin has one class - rfq - at 554. Exclude and set lower max for elsewhere?
+# CoCo 8 fails at > 100. Max 225. Rater OK
 Metrics/ClassLength:
   Max: 512
 
+Metrics/CollectionLiteralLength:
+  Enabled: true 
+
+# Chopin 31 fails at > 7. Max 18.
+# Rater 11 at > 7. Max 21
+# CoCo 9 at > 7. Max 13
+# Set at 21 to prevent further growth. Discuss setting lower.
+Metrics/CyclomaticComplexity:
+  Max: 21
+
+# To discuss. Chopin 1541 fails at > 10, max 118; Rater 330, max 25 with exclusions; CoCo 87, max 51
+# Metrics/MethodLength:
+#   Max: tbc
+
+# To discuss. Chopin 22 fails at > 100, max 1521; Rater 31, max 370; CoCo 2, max 160
+# Metrics/ModuleLength:
+#   Max: tbc
+
 Metrics/ParameterLists:
   CountKeywordArgs: false
   Enabled: true
 
-Naming/BlockForwarding: # new in 1.24
+# Chopin 15 fails at > 8. Max 19.
+# Rater 9 at > 8. Max 21
+# CoCo 5 at > 8. Max 13
+# Set at 21 to prevent further growth. Discuss setting lower.
+Metrics/PerceivedComplexity:
+  Max: 21
+
+Migration/DepartmentName:
+  Enabled: true
+
+# Suggest true but causes 17 fails in Chopin, 6 in Rater, 2 in CoCo
+# Naming/AccessorMethodName:
+#   Enabled: true
+
+Naming/AsciiIdentifiers:
+  Enabled: true
+
+Naming/BinaryOperatorParameterName:
+  Enabled: true
+
+Naming/BlockForwarding:
+  Enabled: true
+
+Naming/BlockParameterName:
+  Enabled: true
+
+Naming/ClassAndModuleCamelCase:
+  Enabled: true
+
+Naming/ConstantName:
+  Enabled: true
+
+Naming/FileName:
+  Enabled: true
+
+Naming/HeredocDelimiterCase:
+  Enabled: true
+
+Naming/HeredocDelimiterNaming:
   Enabled: true
 
 Naming/InclusiveLanguage:
   Enabled: true
 
+# To discuss: suggest true but 86 fails on Chopin
+# Naming/MemoizedInstanceVariableName:
+#   Enabled: true
+
+Naming/MethodName:
+  Enabled: true
+
+# To discuss: suggest true with possible allowed exceptions as below (10 fails on Chopin, exceptions would allow 4)
+# Naming/MethodParameterName:
+#   Enabled: true
+#   AllowedNames:
+#     - e
+#     - ex
+#     - n
+
+# To discuss: suggest true but 52 fails in Chopin, 8 in Coco (consider with Naming/AccessorName)
+# Naming/PredicateName:
+#   Enabled: true
+
+# To discuss: Should decide on a style. Default e instead of err causes 47 fails on Chopin, none on Rater, CoCo
+# Naming/RescuedExceptionsVariableName:
+#   Enabled: true
+
+Naming/VariableName:
+  Enabled: true
+
+# To discuss: suggest enforce snake_case as this seems to be the preferred style
+# Default normalcase causes 
+# Naming/VariableNumber:
+#   Enabled: true
+#   EnforcedStyle: snake_case
+
 Security/CompoundHash:
   Enabled: true
 
+# Should probably be set to true but 13 offences in chopin spec
+# Security/Eval:
+#   Enabled: true
+
 Security/IoMethods:
   Enabled: true
 
+# Should probably be set to true but 18 offences in chopin spec
+# Security/JSONLoad:
+#   Enabled: true
+
+Security/MarshalLoad:
+  Enabled: true
+
+Security/Open:
+  Enabled: true
+
+# Two fails on ContinuousCover, others fine
+# Security/YAMLLoad:
+#   Enabled: true
+
 Style/AccessModifierDeclarations:
   Enabled: false
 

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.12.21'
+  VERSION = '1.12.23'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.12.21
+  version: 1.12.23
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-05-23 00:00:00.000000000 Z
+date: 2023-06-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop