simplycop 1.12.20 → 1.12.22

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9d7b1dfbe91cd595f0491440519bdaf520cb4dfe9048ab500e5ed37f9a83eda2
-  data.tar.gz: ed90b05962cb6537ff3370271a67659771232fcce4a35f535231b4bcd67f134e
+  metadata.gz: 4300fe0cef92b1860b5f9778f1841ebd1db3341ef2a752dfc2d5033c4d9e4beb
+  data.tar.gz: 78b46b78d6f1dce94788fde32a06531c037857547d2b1c6ef98e87b700545c93
 SHA512:
-  metadata.gz: 20cf2ce53fc721de021c0be9f0fb63e119504b44599dfe3ce6f0d39afc6d5ba9cb79fcd9b91331dc3cd8852b51f4e998d7ae90206674cacd002cdba62963026b
-  data.tar.gz: 4468e20beee4c4c03a12fc80599f92498a192f84d2842e8e8ce8aa056f1b59091eccdd2ae43905be36c4447c0d31e18af4b81cb74de99927dc6824431ad6864d
+  metadata.gz: 4f19dd0c98414a22df7d38285caeb140b92d80618dad5c462e93939d270090dbf623002d18f43088d9f57ce2b68b199b612d8172329e47442efeef104c70e08e
+  data.tar.gz: aed4ed02ab4fba9da43e3ae962f2f8b55a327f1af0881f98734eae7d3bd2e4d8bf07e183f15aa300b639438bf5228fa1e1145e4c51464214e0790f19622cafb9

data/.simplycop.yml

@@ -21,25 +21,214 @@ AllCops:
   ExtraDetails: true
 # Adapted from: https://github.com/simplybusiness/how-we-roll/blob/master/development/RUBYSTYLEGUIDE.markdown
 
+Bundler/DuplicatedGem:
+  Enabled: true
+
+Bundler/GemComment:
+  Enabled: false
+
+Bundler/GemFilename:
+  Enabled: true
+
+# To discuss: Suggest true but 103 fails on Chopin, 10 on Rater
+# Bundler/GemVersion:
+#   Enabled: true
+
+Bundler/InsecureProtocolSource:
+  Enabled: true
+
+Bundler/OrderedGems:
+  Enabled: true
+
+# To discuss: Suggest true but 3 fails on Chopin, 21 on Rater
+# Gemspec/DependencyVersion:
+#   Enabled: true
+
+# TODO: 1 autocorrectable in Rater and it would pass
+# Gemspec/DeprecatedAttributeAssignment:
+#   Enabled: true
+
+# To discuss: Suggest true but 2 fails on Chopin, 10 on Rater
+# Gemspec/DevelopmentDependencies:
+#   Enabled: true
+
+Gemspec/DuplicatedAssignment:
+  Enabled: true
+
+Gemspec/OrderedDependencies:
+  Enabled: true
+
+# TODO: Suggest true but 4 fails on Chopin, 3 on Rater 
+# Gemspec/RequireMFA:
+#   Enabled: true
+
+# TODO: Suggest true but 3 fails on Chopin
+# Gemspec/RequiredRubyVersion:
+#   Enabled: true
+
+Gemspec/RubyVersionGlobalsUsage:
+  Enabled: true
+
+Layout/AccessModifierIndentation:
+  Enabled: true
+
+Layout/ArgumentAlignment:
+  Enabled: true
+
+Layout/ArrayAlignment:
+  Enabled: true
+
+Layout/AssignmentIndentation:
+  Enabled: true
+
+Layout/BeginEndAlignment:
+  Enabled: true
+
+Layout/BlockAlignment:
+  Enabled: true
+
+Layout/BlockEndNewline:
+  Enabled: true
+
+Layout/CaseIndentation:
+  Enabled: true
+
+# Discussion needed about preferred structure. Dozens of fails on each repo if we stick with default, all but 4 on Chopin are autocorrectable
+# Layout/ClassStructure:
+#   Enabled: true
+
+Layout/ClosingHeredocIndentation:
+  Enabled: true
+
+Layout/ClosingParenthesisIndentation:
+  Enabled: true
+
+Layout/CommentIndentation:
+  Enabled: true
+
+Layout/ConditionPosition:
+  Enabled: true
+
+Layout/DefEndAlignment:
+  Enabled: true
+
+Layout/DotPosition:
+  Enabled: true
+
+Layout/ElseAlignment:
+  Enabled: true
+
+Layout/EmptyComment:
+  Enabled: true
 
-Gemspec/DeprecatedAttributeAssignment: # new in 1.30
+Layout/EmptyLineAfterGuardClause:
   Enabled: true
 
+# To discuss. Suggest should be true but 500+ autocorrectable fails on Chopin. None on others 
+# Layout/EmptyLineAfterMagicComment:
+#   Enabled: true
+
 Layout/EmptyLineAfterMultilineCondition:
   Enabled: true
 
+Layout/EmptyLineBetweenDefs:
+  Enabled: true
+
+Layout/EmptyLines:
+  Enabled: true
+
+Layout/EmptyLinesAroundAccessModifier:
+  Enabled: true
+
+Layout/EmptyLinesAroundArguments:
+  Enabled: true
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
+Layout/EmptyLinesAroundBeginBody:
+  Enabled: true
+
+Layout/EmptyLinesAroundBlockBody:
+  Enabled: true
+
+Layout/EmptyLinesAroundClassBody:
+  Enabled: true  
+
+Layout/EmptyLinesAroundExceptionHandlingKeywords:
+  Enabled: true
+
+Layout/EmptyLinesAroundMethodBody:
+  Enabled: true  
+
+Layout/EmptyLinesAroundModuleBody:
+  Enabled: true
+
+Layout/EndAlignment:
+  Enabled: true
+
+Layout/EndOfLine:
+  Enabled: true
+
+Layout/ExtraSpacing:
+  Enabled: true
+
+Layout/FirstArgumentIndentation:
+  Enabled: true
+
+Layout/FirstArrayElementIndentation:
+  Enabled: true
+
 Layout/FirstArrayElementLineBreak:
   Enabled: true
 
 Layout/FirstMethodArgumentLineBreak:
   Enabled: true
 
+Layout/FirstHashElementIndentation:
+  Enabled: true
+
 Layout/FirstHashElementLineBreak:
   Enabled: true
 
+# To discuss - 200+ fails on CoCo, none elsewhere
+# Layout/FirstMethodArgumentLineBreak:
+#   Enabled: true
+
+# To discuss - 100+ fails on Chopin, handful on others
+# Layout/FirstMethodParameterLineBreak:
+#   Enabled: true
+
+Layout/FirstParameterIndentation:
+  Enabled: true
+
+Layout/HashAlignment:
+  Enabled: true
+
 Layout/HeredocArgumentClosingParenthesis:
   Enabled: true
 
+Layout/HeredocIndentation:
+  Enabled: true
+
+Layout/IndentationConsistency:
+  Enabled: true
+
+Layout/IndentationStyle:
+  Enabled: true
+
+Layout/IndentationWidth:
+  Enabled: true
+
+Layout/InitialIndentation:
+  Enabled: true
+
+Layout/LeadingCommentSpace:
+  Enabled: true
+
+Layout/LeadingEmptyLines:
+  Enabled: true
+
 Layout/LineContinuationLeadingSpace:
   Enabled: true
 
@@ -49,9 +238,148 @@ Layout/LineContinuationSpacing:
 Layout/LineEndStringConcatenationIndentation:
   Enabled: true
 
+# To discuss: configure line length? At default 120: 6805 fails on Chopin, 3 on Rater, 179 on CoCo
+# Layout/LineLength
+#   Enabled: false
+Layout/MultilineArrayBraceLayout:
+  Enabled: true
+  
+# To discuss: 100s of fails on each repo but autocorrectable  
+# Layout/MultilineArrayLineBreaks:
+#   Enabled: true
+
+# To discuss: 100s of fails on each repo but autocorrectable  
+# Layout/MultilineAssignmentLayout:
+#   Enabled: true
+  
+Layout/MultilineBlockLayout:
+  Enabled: true
+  
+Layout/MultilineHashBraceLayout:
+  Enabled: true
+
+# To discuss: 100s of fails on each repo but autocorrectable  
+# Layout/MultilineHashKeyLineBreaks:
+#   Enabled: true
+
+# To discuss: 1000s of fails on each repo but autocorrectable  
+# Layout/MultilineMethodArgumentLineBreaks:
+#   Enabled: true
+  
+Layout/MultilineMethodCallBraceLayout:
+  Enabled: true
+  
+Layout/MultilineMethodCallIndentation:
+  Enabled: true
+  
+Layout/MultilineMethodDefinitionBraceLayout:
+  Enabled: true
+
+# To discuss: 100s of fails on each repo but autocorrectable
+# Layout/MultilineMethodParameterLineBreaks:
+#   Enabled: true
+  
+Layout/MultilineOperationIndentation:
+  Enabled: true
+
+Layout/ParameterAlignment:
+  Enabled: true
+
+# For discussion: 1000s of fails, all autocorrectable
+# Layout/RedundantLineBreak:
+#   Enabled: true
+
+Layout/RescueEnsureAlignment:
+  Enabled: true
+
+# For discussion: 1000s of fails, all autocorrectable
+# Layout/SingleLineBlockChain:
+#   Enabled: true
+
+Layout/SpaceAfterColon:
+  Enabled: true
+
+Layout/SpaceAfterComma:
+  Enabled: true
+
+Layout/SpaceAfterMethodName:
+  Enabled: true
+
+Layout/SpaceAfterNot:
+  Enabled: true
+
+Layout/SpaceAfterSemicolon:
+  Enabled: true
+
+Layout/SpaceAroundBlockParameters:
+  Enabled: true
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Layout/SpaceAroundKeyword:
+  Enabled: true
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Layout/SpaceAroundOperators:
+  Enabled: true
+
+Layout/SpaceBeforeBlockBraces:
+  Enabled: true
+
 Layout/SpaceBeforeBrackets:
   Enabled: true
 
+Layout/SpaceBeforeComma:
+  Enabled: true
+
+Layout/SpaceBeforeComment:
+  Enabled: true
+
+Layout/SpaceBeforeFirstArg:
+  Enabled: true
+
+Layout/SpaceBeforeSemicolon:
+  Enabled: true
+
+Layout/SpaceInLambdaLiteral:
+  Enabled: true
+
+Layout/SpaceInsideArrayLiteralBrackets:
+  Enabled: true
+
+Layout/SpaceInsideArrayPercentLiteral:
+  Enabled: true
+
+Layout/SpaceInsideBlockBraces:
+  Enabled: true
+
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: true
+
+Layout/SpaceInsideParens:
+  Enabled: true
+
+Layout/SpaceInsidePercentLiteralDelimiters:
+  Enabled: true
+
+Layout/SpaceInsideRangeLiteral:
+  Enabled: true
+
+Layout/SpaceInsideReferenceBrackets:
+  Enabled: true
+
+Layout/SpaceInsideStringInterpolation:
+  Enabled: true
+
+Layout/TrailingEmptyLines:
+  Enabled: true
+
+Layout/TrailingWhitespace:
+  Enabled: true
+
 Lint/AmbiguousAssignment:
   Enabled: true
 
@@ -154,18 +482,99 @@ Metrics/ParameterLists:
   CountKeywordArgs: false
   Enabled: true
 
-Naming/BlockForwarding: # new in 1.24
+Migration/DepartmentName:
+  Enabled: true
+
+# Suggest true but causes 17 fails in Chopin, 6 in Rater, 2 in CoCo
+# Naming/AccessorMethodName:
+#   Enabled: true
+
+Naming/AsciiIdentifiers:
+  Enabled: true
+
+Naming/BinaryOperatorParameterName:
+  Enabled: true
+
+Naming/BlockForwarding:
+  Enabled: true
+
+Naming/BlockParameterName:
+  Enabled: true
+
+Naming/ClassAndModuleCamelCase:
+  Enabled: true
+
+Naming/ConstantName:
+  Enabled: true
+
+Naming/FileName:
+  Enabled: true
+
+Naming/HeredocDelimiterCase:
+  Enabled: true
+
+Naming/HeredocDelimiterNaming:
   Enabled: true
 
 Naming/InclusiveLanguage:
   Enabled: true
 
+# To discuss: suggest true but 86 fails on Chopin
+# Naming/MemoizedInstanceVariableName:
+#   Enabled: true
+
+Naming/MethodName:
+  Enabled: true
+
+# To discuss: suggest true with possible allowed exceptions as below (10 fails on Chopin, exceptions would allow 4)
+# Naming/MethodParameterName:
+#   Enabled: true
+#   AllowedNames:
+#     - e
+#     - ex
+#     - n
+
+# To discuss: suggest true but 52 fails in Chopin, 8 in Coco (consider with Naming/AccessorName)
+# Naming/PredicateName:
+#   Enabled: true
+
+# To discuss: Should decide on a style. Default e instead of err causes 47 fails on Chopin, none on Rater, CoCo
+# Naming/RescuedExceptionsVariableName:
+#   Enabled: true
+
+Naming/VariableName:
+  Enabled: true
+
+# To discuss: suggest enforce snake_case as this seems to be the preferred style
+# Default normalcase causes 
+# Naming/VariableNumber:
+#   Enabled: true
+#   EnforcedStyle: snake_case
+
 Security/CompoundHash:
   Enabled: true
 
+# Should probably be set to true but 13 offences in chopin spec
+# Security/Eval:
+#   Enabled: true
+
 Security/IoMethods:
   Enabled: true
 
+# Should probably be set to true but 18 offences in chopin spec
+# Security/JSONLoad:
+#   Enabled: true
+
+Security/MarshalLoad:
+  Enabled: true
+
+Security/Open:
+  Enabled: true
+
+# Two fails on ContinuousCover, others fine
+# Security/YAMLLoad:
+#   Enabled: true
+
 Style/AccessModifierDeclarations:
   Enabled: false
 

data/.simplycop_rspec.yml

@@ -117,6 +117,9 @@ Capybara/SpecificMatcher:
 FactoryBot/ConsistentParenthesesStyle:
   Enabled: true
 
+FactoryBot/CreateList:
+  Enabled: false
+
 FactoryBot/FactoryNameStyle:
   Enabled: true
 

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.12.20'
+  VERSION = '1.12.22'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.12.20
+  version: 1.12.22
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-05-22 00:00:00.000000000 Z
+date: 2023-05-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop